From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 767C5C369AB for ; Mon, 21 Apr 2025 11:36:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E24186B0006; Mon, 21 Apr 2025 07:36:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DAD2A6B0007; Mon, 21 Apr 2025 07:36:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C735D6B0008; Mon, 21 Apr 2025 07:36:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A5D836B0006 for ; Mon, 21 Apr 2025 07:36:33 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0A28EC1FBE for ; Mon, 21 Apr 2025 11:36:34 +0000 (UTC) X-FDA: 83357848308.15.DA2068A Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by imf16.hostedemail.com (Postfix) with ESMTP id 367FA18000E for ; Mon, 21 Apr 2025 11:36:31 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=ilrZ0cu+; dmarc=pass (policy=none) header.from=igalia.com; spf=pass (imf16.hostedemail.com: domain of gavinguo@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=gavinguo@igalia.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745235392; a=rsa-sha256; cv=none; b=IOKlTNAk/mfkGCL5aEPElURtalRJpDP2LxOXopq0eCcD8smy7DKNF4XCi4PkWXdFDfuSDU wFBQdeb6xG9yOMI9nSWyTuxcfgSPCSxOPdLWo4WnVDqRQBK58VQUITGGbaY/+EFF1Rtng/ MBozHRw0AHYIAbS2Xs1iXKBL14y72Ug= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=ilrZ0cu+; dmarc=pass (policy=none) header.from=igalia.com; spf=pass (imf16.hostedemail.com: domain of gavinguo@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=gavinguo@igalia.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745235392; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=0WV+sEZDF9ez+F5UP3x6NyJfVwDmxFkP96tBYKSZl4o=; b=zDZvZmxWjbC3gU0G9be/qjZxLPapoPKTgxdArLYz0dMYE+cgHC0yhQkpfqJK+B5duUUWfK DGo2+UUhjxMbQ+/hVsGzWosrTecL+40bLK0L1JzXOcGq2hEVqlPcUaci9iIEZ1/sv3y/rM SoB1QNgzWCZcpG+FHxnnz05hfiSfUwI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=0WV+sEZDF9ez+F5UP3x6NyJfVwDmxFkP96tBYKSZl4o=; b=ilrZ0cu+qKDNMMbuaROMCgqMxR r4q40+hvDmmeRAoyzpE1QjVDb9kO3y7elxwM1KW2Bcrd4/ZexTI/yDtiNGjfKAh0obakQDZE07DHQ dQag8oiPnB9hdQ6Fu0kJT7qvILWEc+Zj/enHpkGZdE0lSsnIZehNjiYqbFmW6P/zsQdagI8tJ9LeZ f5Gb3XhAvzM//uLqm4wc5+THtZw/InZYxg7+tTtpx68TGVLjDUTcabXfVVPbLJdUT5rAUw7xX/Je4 4334lCd3ZuJvcBaZ10GauUNLbdnFatUUCfRVlJ7swBAvhqPyljwe2OBxp7EUpgmKS/MDpff3td7dR N856rgHg==; Received: from 114-44-233-154.dynamic-ip.hinet.net ([114.44.233.154] helo=gavin-HP-Z840-Workstation..) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1u6pRp-005w62-FG; Mon, 21 Apr 2025 13:36:26 +0200 From: Gavin Guo To: linux-mm@kvack.org, akpm@linux-foundation.org Cc: gshan@redhat.com, david@redhat.com, willy@infradead.org, ziy@nvidia.com, linmiaohe@huawei.com, hughd@google.com, revest@google.com, kernel-dev@igalia.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v3] mm/huge_memory: fix dereferencing invalid pmd migration entry Date: Mon, 21 Apr 2025 19:35:36 +0800 Message-ID: <20250421113536.3682201-1-gavinguo@igalia.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 367FA18000E X-Stat-Signature: gp3f8s45t3ddyhp8nq3p98afakzzuadb X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1745235391-742547 X-HE-Meta: U2FsdGVkX1/KYFyct/s04b5L/ClfbFmgNwDTGFqmtcsx7R6CwzAsIuLyXf6xLv52q2Yu3qmco4eIKb7EPMsiZOhCm+Ci9ijYsaqy7Z70R+X4s1UHcNoP+UFEGcOY0/WC9tgnavrQnT/rJyjK3YG0aPdYI3KsrLr1d3FhN2Px/U2buOMA1b0jLjc+KsoTst4EG9o9r9DUYbCtUxG3RVRvsAuXKCDJicrFDrTfkU3KJqFlLAgzrAsRxliDkUKkOYGh4sJpNNfNaeL/Frki5C/jGLIQw4LgBbvV3vYwaKrAIK6jGzmuqvhSD+XYTFlwNsYP242GMIp+ytCjETIn7RKYAV2ZWtAaSEl59SUPuN5lE9eDrt8BsFkqaVVAXZZNOqsQXAYx+EZhBntkakM53qIP+32/i13ZPEwgPsNH/uI5+cQp/8ekU5W9FOQNOTO8ZGjHK7nUjxw5q8RTzgIqFsAb5NcFNSaUZrAznm5Ljkr+RmoRyJ7Pbt0kZfK2NOC0B7ydA1RUtkyWJPgzQGMzlJpsE6n/dWAPgTwYKlo4M/zOxoviJhp1J9KOS8h+/u/1SfI0yTa+5yP31xvuvo8AmHs+fKEKq4Ru9B/F6VcSDUEioTplKT6U+ZGt2ATcTwXTWOKUTtsypgdY58FPSPgR0XMpu14Ig+FK/7rsahp7aGjtfR4X0NMusl6WAnmvKBEj7maJXEZbmims+xUI1gJAiUtE10UPAvb92EjkkH11GBzVaxNkc7XN4w/2itoehH6NV5M/lNWcbuKRft0ruS4GOayJWX0fwo/hfllbrQ+0kDPqKQg7n3Xl59yiPQaunuVN10c0rohK3/pGY1aMQjbfSTKbjDnHS+9ndIe8CfIlCzI281mscIjlIgVia4oDkGrZfXQYvBD5ij44OdgLGPii7uSiFIxRa6Wm3lSTObHHJxjMN/1DcVay0b+QcBL6VN01PAm220ks/FS5HJ+wAox3o9N ZI0Gohhb f/132wHoWhXowOs3R0K2gtmw0Lx+1gnz2LEtt1xHA7MAmTPaZsFRhur6mYRqjWAa1oTZM0V5CMvwcYM44TJc+5aT8BdAxR63cetXi/ElzLH87qf3GPkaqrEEdkCVfyAGdVaShkfrmW34qg9GPU8dyZo5/nH3pGF4O6Yiy8TqNmbciTyOaxjB4BKzU8MvEXTFdhnBHRq5p6z7uJWNo5tX0i73SXxdUWECHiOVa97SIaKGggGylPjCn64GEDJMcCj3HJ4RVIxCImJ5W7OGSHY/MtLAzgg0nHQd5RqgUw97KFTBZeJYXcQihfeG5AZaU/CIVYUi8AQ0n4YVr5MRMPPY6H+FvTGWQw0xt2OB099tG88KdCXx2fFsL/JITu8IjuzE3CZpnyJO3RlDUQF07ixFjaoNkr6EMQVyNH8/0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: When migrating a THP, concurrent access to the PMD migration entry during a deferred split scan can lead to an invalid address access, as illustrated below. To prevent this invalid access, it is necessary to check the PMD migration entry and return early. In this context, there is no need to use pmd_to_swp_entry and pfn_swap_entry_to_page to verify the equality of the target folio. Since the PMD migration entry is locked, it cannot be served as the target. Mailing list discussion and explanation from Hugh Dickins: "An anon_vma lookup points to a location which may contain the folio of interest, but might instead contain another folio: and weeding out those other folios is precisely what the "folio != pmd_folio((*pmd)" check (and the "risk of replacing the wrong folio" comment a few lines above it) is for." BUG: unable to handle page fault for address: ffffea60001db008 CPU: 0 UID: 0 PID: 2199114 Comm: tee Not tainted 6.14.0+ #4 NONE Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 RIP: 0010:split_huge_pmd_locked+0x3b5/0x2b60 Call Trace: try_to_migrate_one+0x28c/0x3730 rmap_walk_anon+0x4f6/0x770 unmap_folio+0x196/0x1f0 split_huge_page_to_list_to_order+0x9f6/0x1560 deferred_split_scan+0xac5/0x12a0 shrinker_debugfs_scan_write+0x376/0x470 full_proxy_write+0x15c/0x220 vfs_write+0x2fc/0xcb0 ksys_write+0x146/0x250 do_syscall_64+0x6a/0x120 entry_SYSCALL_64_after_hwframe+0x76/0x7e The bug is found by syzkaller on an internal kernel, then confirmed on upstream. Fixes: 84c3fc4e9c56 ("mm: thp: check pmd migration entry in common path") Cc: stable@vger.kernel.org Signed-off-by: Gavin Guo Acked-by: David Hildenbrand Acked-by: Hugh Dickins Acked-by: Zi Yan Reviewed-by: Gavin Shan Link: https://lore.kernel.org/all/20250414072737.1698513-1-gavinguo@igalia.com/ Link: https://lore.kernel.org/all/20250418085802.2973519-1-gavinguo@igalia.com/ --- V1 -> V2: Add explanation from Hugh and correct the wording from page fault to invalid address access. V2 -> V3: Improve the commit message and the nested if condition. mm/huge_memory.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 2a47682d1ab7..47d76d03ce30 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -3075,6 +3075,8 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd, void split_huge_pmd_locked(struct vm_area_struct *vma, unsigned long address, pmd_t *pmd, bool freeze, struct folio *folio) { + bool pmd_migration = is_pmd_migration_entry(*pmd); + VM_WARN_ON_ONCE(folio && !folio_test_pmd_mappable(folio)); VM_WARN_ON_ONCE(!IS_ALIGNED(address, HPAGE_PMD_SIZE)); VM_WARN_ON_ONCE(folio && !folio_test_locked(folio)); @@ -3085,9 +3087,12 @@ void split_huge_pmd_locked(struct vm_area_struct *vma, unsigned long address, * require a folio to check the PMD against. Otherwise, there * is a risk of replacing the wrong folio. */ - if (pmd_trans_huge(*pmd) || pmd_devmap(*pmd) || - is_pmd_migration_entry(*pmd)) { - if (folio && folio != pmd_folio(*pmd)) + if (pmd_trans_huge(*pmd) || pmd_devmap(*pmd) || pmd_migration) { + /* + * Do not apply pmd_folio() to a migration entry; and folio lock + * guarantees that it must be of the wrong folio anyway. + */ + if (folio && (pmd_migration || folio != pmd_folio(*pmd))) return; __split_huge_pmd_locked(vma, pmd, address, freeze); } base-commit: 9d7a0577c9db35c4cc52db90bc415ea248446472 -- 2.43.0