From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3805C369AB for ; Mon, 21 Apr 2025 16:43:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C0BF6B000C; Mon, 21 Apr 2025 12:43:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 871B26B000D; Mon, 21 Apr 2025 12:43:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78A296B000E; Mon, 21 Apr 2025 12:43:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 59E916B000C for ; Mon, 21 Apr 2025 12:43:12 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C06D61208E6 for ; Mon, 21 Apr 2025 16:43:12 +0000 (UTC) X-FDA: 83358621024.12.E97954A Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf25.hostedemail.com (Postfix) with ESMTP id 1966AA000C for ; Mon, 21 Apr 2025 16:43:10 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ecXGgq2l; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of kees@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745253791; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0vLT8UVtMdP+2KZnL+KAguQMIE+qlInB/+bpVxdj6JI=; b=f/TyH+8Ba0H7desb+tbuCKjGLej29AQWUM70D+X5y4bn8UzDQUmw6IWmz3w8cnsIJ+YUpM 1G/NiphEA36bW2ZI1JS4E6sbJFtNBwuwfYpaoRvFgztEBQoCM/P4qmMFUhmFO/Z2rRPQeD n1AsC9j8PN+xtfZLCR9Nqq373YS9ypc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745253791; a=rsa-sha256; cv=none; b=1XPLyoI8QaJ37HLFrBaLM8ncsY1zUCEE0JWlu9tELaH6Ez8+Hdjb/BfV/nU7/RzKHwoAnr YGYXVBVdIBAIp09SGVaCrye5HUcN0/IJ9nsUMjTd3p7hWSLmZaYKXjx1MvGrgwYLF0DTqb jrNZcdf4XJr5fL2EZjMk/meC1jUF4Yg= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ecXGgq2l; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of kees@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=kees@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 7871E43D70; Mon, 21 Apr 2025 16:43:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA3E2C4CEE4; Mon, 21 Apr 2025 16:43:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745253789; bh=nU2NB+tnAZnt1MsC8/QTTW/qtrU+1eXEvM7zijUvmBA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ecXGgq2lx4aAuRbCi5U79Qj0tVT7lYsxum+Siq7PjrHVJOkbtHk9fb3/TfTGfjHdd 3KHPMLY2eZtQHzRJEAvetJIwJOKLQyffRLKZQfFzJKfOelyje1/JPDYHlqTwh9nsZq k5InamI1EivEJyXYRQTy0IwezLCbwd7w2igBDjBrICBsfkZWRqd/0mpldv/Kusglzo qRApxCnUSZdvtLlfCvvAPLIEGYbwRwMJQGh5yOgy3tc82QhgGeIOoRZxbbmjSNv9LC aeF1NNYpNTFhSXxxK1uBbcZ9OHL/bdZ1utxz5f+dtjPUmTLzKwyWd4FSLk31pF+/as /5OOVmtLL9DGQ== Date: Mon, 21 Apr 2025 09:43:06 -0700 From: Kees Cook To: Christoph Hellwig Cc: Masahiro Yamada , Andrew Morton , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Nathan Chancellor , Nicolas Schier , Nick Desaulniers , Bill Wendling , Justin Stitt , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kbuild@vger.kernel.org, llvm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-sparse@vger.kernel.org, luc.vanoostenryck@gmail.com Subject: Re: [PATCH] kbuild: Switch from -Wvla to -Wvla-larger-than=0 Message-ID: <202504210940.8B3E06C4F7@keescook> References: <20250418213235.work.532-kees@kernel.org> <20250421091233.GA21118@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250421091233.GA21118@lst.de> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 1966AA000C X-Rspam-User: X-Stat-Signature: 7jur4jxtqo4m7r5z957c67xcnfcgt4rq X-HE-Tag: 1745253790-919261 X-HE-Meta: U2FsdGVkX18/FFtI1pbW82Ef78ymkOePPmASW79BPXTRk9Jr/ZXHWSWYjJ//P25F299MZxJM2yY5HcKA2CZ7FoRynKQGO82b8e3vHMG1irPBxEoP9jo8vEe3MZjNn43BvSmdiEsN+lV8UJiPYYo0VTRIfMu8tbkdL/udUeZ/WY+9zLbIM3XgxpyR9zS9loGZ9Bocdv47YcV7Zt6YsjxqYFyK+jcC3nPABJmLoNJZy8S+vw41n0k0J3UDl5z/QWYrUxyyKcdB3rf4UZBkI5dk5wptz2B5te0JNFDgWbOtEPkdni2qW2ZVBrAyT2GKp2BvBvTN4lopUIk+aCMiR9A14Faz66IxZYMtjkg0fbXWqiep148zCGK3Uf0ZsJglG6sGn0jTMWI2TNc/Ka6X535DtE6EvwtE6WnjgCpS4+qeXLONnqOeQzZ85of2a/4Z4GGnsn6Fchw3w6cXr1dWhbphQpcajUVNa5iRpbT175FSmspJ6YW9nAA9stDwdUZFFtJLHEa1hrh3zkucLx2N6Cm6X3t0UG1tETQAM3f0xYJAnLopc9rVC7Yk+DvLsqH0XNS1DTGPslhmFkv5bsUI57lna3f3Xtzf1aBLxJq5Bc2qfBNILXgH/EEKasnGnnKW5B41AHxaCB6KZoEk9NCxv5Lyh26Lbc63BUG7lcDh27N8EggdTsh8w/vk1kakShhJ3848sSkFdEIyNTsF59w4L9PqhZP507vIgCCeWeXlfpmg+eilrtjjjheLFYCQs3DeR0QBNkIStJSvbdug0JQmNchB++sXl/w10RPy0wAKEE4wah+P5gS5miol9Gdubw6JF1U0K1XQR4WTIH8NpXKWcLXS0BTfbt/ri0KIaenkEDxqKaIkvmXxNKaHwuLn30P0msPmAkMmSpTCXFB3GKfHW0eDIiaLnGfNskkD9RwrM3mrtvFLch44g11Y/K8nL2Zqi/dp17lS3s7tla6DdpnHCbZ oXz9LVHR iLeeToX8JYnwy9PgruMjsmUx3lqajpGWAk6n42C1Sg1NvnqQy6PVlxI0Uy0X+tIuplFZ1pnYZUog3+i9zbLTNzh6eXOp7WkrQb2CkSozLSjOS/nzGKqxUGrQf1vB1tH9S6L9k0HCpXoZlo/UCxfUQ1irkcqI5Jqd/WYtubu/NusM111C4sZp0wgUeM6Gn0we7XXdHMpqatl7PEK8HpeuraqjSvO3R1DbEabIER8Vfbc3ksDTVY/ge0/oys8QB0i7Wd1KDYiKyYtWtCcLOozV0Hj2fSbkzNxlkxQDXCobtZSLw+C8r31pentOPuhANvzAf7+v51BJguGlqOl4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 21, 2025 at 11:12:33AM +0200, Christoph Hellwig wrote: > Looks good: > > Reviewed-by: Christoph Hellwig > > Note that sparse currently also can't cope with VLAs including the > prototype syntax, which also needs addressing. Hm, it looks like it's been over a year since a commit to the sparse git. Luc, are function prototypes with VLAs likely to be supported by sparse soon? -- Kees Cook