From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C72EDC369D3 for ; Mon, 21 Apr 2025 17:16:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A31F6B000C; Mon, 21 Apr 2025 13:16:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 752C26B000A; Mon, 21 Apr 2025 13:16:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5AFEB6B000C; Mon, 21 Apr 2025 13:16:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 381D16B0007 for ; Mon, 21 Apr 2025 13:16:43 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A7F231609C6 for ; Mon, 21 Apr 2025 17:16:43 +0000 (UTC) X-FDA: 83358705486.18.4E19339 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf23.hostedemail.com (Postfix) with ESMTP id 69DC6140003 for ; Mon, 21 Apr 2025 17:16:41 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=GFK4C4dO; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=FgxNaedK; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=mgVAcMlP; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=A9iTiMQo; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf23.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=pfalcato@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745255801; a=rsa-sha256; cv=none; b=N+7Rjc8GjXu3ASBxp6hYbiCdXRY8X0/r2eCaRw1kQH1xJu8UX9P2wdFiCKqpfCf8knHKlc VMr8yHvY1Yo+TzubkZjQ4fzRaU2SeTOpfTqqXzmD4HSXX1A0sDhtnQNlAzVsbs8rFzH2FV OWuBFju+orbAAbDzmIfzoofJq9cWNIY= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=GFK4C4dO; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=FgxNaedK; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=mgVAcMlP; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=A9iTiMQo; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf23.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=pfalcato@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745255801; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=Y23NAR76LYdmaA7SwNGEZzg9KK15eLbfbFxx8zGRNmo=; b=vp0l2I7TC1S+snOtFOJMQQ9+qh+7Y1bltQP9w2Fmg3xYkjnYQRK9cg9gMPhzj14kQ7wISN 6I0apuFjUaHdB2DhKDJCfKbI1nH9J+m/oqYXC2evH/riDgAAuV9hIp+HKysa3JQ5+v7Il8 0dyPv3KfXG2KLRErTQrGXg7Lln2R4ek= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id ED8D921232; Mon, 21 Apr 2025 17:16:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745255800; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Y23NAR76LYdmaA7SwNGEZzg9KK15eLbfbFxx8zGRNmo=; b=GFK4C4dO0aL+raQatk+zsfEujqBoza3pxSL0Af3zc/7ts3tF3TV/afguA1MTZqGhntdkEo gX+fPEuxiQUznULW1jsV1tOST8C0NgVkxMvg3DiFDR5gw9JPNPx6Ciy28VwGH6HCxJcbXD arlEfp+DKyM2iOozSGhctaylXiE7qng= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745255800; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Y23NAR76LYdmaA7SwNGEZzg9KK15eLbfbFxx8zGRNmo=; b=FgxNaedKf6NbmlJnYpDMRkylzmwi/6JbTVbwoI/ZBXo7Kh0LAMUtj1yX6t3Qu9zlJ536Ss JeYOOXSIyWxuwjCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745255799; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Y23NAR76LYdmaA7SwNGEZzg9KK15eLbfbFxx8zGRNmo=; b=mgVAcMlP36P3lI++IEo4b52pbydOswHZXp9ORuywOACYKeFaJhYKOHeYqnLyomrd/Dk7yy oqRCwQmZ2AsaowG/R6sS7eRw5aLM8t1gKWyFR71rysZCCT+PaK0clRNs4tedv9U4XrTQv3 mY+8Dv2J3Nhh3f1kaMsXH9/EtUSdV+c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745255799; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Y23NAR76LYdmaA7SwNGEZzg9KK15eLbfbFxx8zGRNmo=; b=A9iTiMQom1Ug0IJXRuK30sCrMk++OKKAEyHcsP+ciez9WRFJno5v2A75d11d98GA2sZjBx VqGVlm3tHknHN7CA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9E4F9139D0; Mon, 21 Apr 2025 17:16:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Ev3EH3d9BmiQaQAAD6G6ig (envelope-from ); Mon, 21 Apr 2025 17:16:39 +0000 From: Pedro Falcato Date: Mon, 21 Apr 2025 18:16:28 +0100 Subject: [PATCH] mm: workingset: Simplify lockdep check in update_node MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250421-workingset-simplify-v1-1-de5c40051e0e@suse.de> X-B4-Tracking: v=1; b=H4sIAGt9BmgC/x3MywqAIBBA0V+JWSeoFT1+JVpEjTVUFk70QPz3p OVZ3OuB0REyNIkHhxcx7TZCpQkMc28nFDRGg5a6kLlW4t7dQnZiPAXTdqxkXoFoskqqui+rAWJ 5ODT0/Ne2C+EDAnJG+2UAAAA= X-Change-ID: 20250421-workingset-simplify-eef38019a78c To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Pedro Falcato X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1745255799; l=1320; i=pfalcato@suse.de; s=20250421; h=from:subject:message-id; bh=snlAzbl9cvQfLvpS33+wBGM9L/8iWNZMhpY4UQwnYQ0=; b=UFCMiUg0z5tHElB/Ysb1zx+nz9K8T4URWlRbkxu4cqfbVclGZQhEUIVc1JcVxWowadG8Y6YM+ Z5eBOn2AY1/Dc0Xa6HQivAXD221A21savKH5LZnN5AQDPYFlN6PHU7E X-Developer-Key: i=pfalcato@suse.de; a=ed25519; pk=0R7Lzd6olZ38hoDAKHJC9ZdDsvtBo/kjCOfHfihr/FM= X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 69DC6140003 X-Stat-Signature: ej9xtr3xem58s4s995aiqmt8o7jb4o8d X-Rspam-User: X-HE-Tag: 1745255801-705604 X-HE-Meta: U2FsdGVkX1/ov4/yk0OrBhfmBmuJepzqjJcrQrRlKdlAcf5ZK0f5Lrlvon7QO8JIWkv4Ni8talrLcDi/p+GUiW7AfFKeVLqFCz7JbcUFlV6vcHZJ1DdWTwxUl28zbMoMsoZH75zdrfPl2kxuUyIR8mbSzxl/5Rz77e6/m/dnWmHBhAoLZRmSWDIQz6VY1tOIMOHYFKxLnVfyvG5b84fQL60nbS8WMVz9jGHE1TIU+s44Kbxj+iYE5dTcuRDkUVkA6nOLDw8qWuc/Hs/o24dmMMDZeMXx+d+CFEvbkRsruh+PLU7Z59SBz4nEvQFnBEI38VZb4HqcjhfhhY2WkArjYtC9bbrr4FueNmO3LKc7gMeaRpEV7l1iCn0AnFMrr+HQdWosZ8vxCLNFol/nBMoKGCvAFUB5OxUFShqeX+/gZTAmKdWaLEd39+bNZ1OOrpm8nW79x1uI1IfY1zWKIOPioqsEsvbbzGmDS8rSPP9eEddNNB1bCE9d9weEWuL4CU/jCtLlkiccZ5+bY9OHNyBEhx85euSlFAMmyGbGg6v+UjsbruO3Cy3JvLEVbvQEFXPAk/Y8eybtNxVtOdqlBTS3GshSwY2edUp1ZMst6DmX3ufHX2aK9KVrQwvJDi1KXfyBfe/khG33mf+6epMPTngPcpmgUjSE22GkMqFYWRvHUpG+LmvyBShZzB4wZMBWzN1Lk3A9wLifVSr9uKr77BXDPHWlUidQZitOQxh3o9FNipqDZvk5cdrnHuNcqTYI6IsAdkEsOm5z4f2LizS8c5jFL/ym5l4Rdv41D7Es1ZLiikcdFNYk+WYA6ITTjus0Eedz3VjRiO4f8WuyClAI5bCqBpzOmlJL2IeCLt7xOIXLbqPUaNMrRiWqCEoElOoVW9lNtqeotOaT4QMlpAp0EyovPcwTk2QC+K9yPQc0K3o22MwJmCaxIq/0dvhNthtQtmfWdOR/KKd3fynKyZYtgc5 QaT95ASk u+X6rNts/eSGOqjq+cw9TNHRfpdEUGWfmTFnZ7GhKfWGMz/JbCdeynWKClqaQpW5Ez4Rt4Vuzx8DlAK5p8FPWCJJltcP/SxJ7bAayg/7he1wqg79pthtd8k3mxUSpY7+YlVZYtDz1swczJVGyWl3kAv6iLvu0bKWE4eYCuIJYmMc5E99g+2gTOE7AZElRIl8IGA0Rl5nM1mDo+sOEqzT3Eop2vrdVJEKryXvfHLFrK+RKm/laLAJsBvPOBInTCam7+dBuKaspM0y9Oa6ldowuZiOlK+8952gRnpl+gZOuh2GKFZ/klfwW8weC8XO+EBMQAb5l X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: container_of(node->array, ..., i_pages) just to access i_pages again is an incredibly roundabout way of accessing node->array itself. Simplify it. Signed-off-by: Pedro Falcato --- mm/workingset.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/workingset.c b/mm/workingset.c index 4841ae8af41113797378846f08336cd7c5757bd5..6e7f4cb1b9a7807e9288955f180a5b6cffab1a40 100644 --- a/mm/workingset.c +++ b/mm/workingset.c @@ -612,7 +612,6 @@ struct list_lru shadow_nodes; void workingset_update_node(struct xa_node *node) { - struct address_space *mapping; struct page *page = virt_to_page(node); /* @@ -623,8 +622,7 @@ void workingset_update_node(struct xa_node *node) * already where they should be. The list_empty() test is safe * as node->private_list is protected by the i_pages lock. */ - mapping = container_of(node->array, struct address_space, i_pages); - lockdep_assert_held(&mapping->i_pages.xa_lock); + lockdep_assert_held(&node->array->xa_lock); if (node->count && node->count == node->nr_values) { if (list_empty(&node->private_list)) { --- base-commit: 856ddd6c69a1a1935f32de8411550d997bcbe6f5 change-id: 20250421-workingset-simplify-eef38019a78c Best regards, -- Pedro Falcato