From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9A13C369AB for ; Fri, 18 Apr 2025 22:37:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47EA4280003; Fri, 18 Apr 2025 18:37:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 42C93280002; Fri, 18 Apr 2025 18:37:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CF7F280003; Fri, 18 Apr 2025 18:37:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 109B7280001 for ; Fri, 18 Apr 2025 18:37:12 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D9E7E140F46 for ; Fri, 18 Apr 2025 22:37:12 +0000 (UTC) X-FDA: 83348626704.10.F8F7CC9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id E26C540008 for ; Fri, 18 Apr 2025 22:37:10 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Qztl/Yas"; spf=pass (imf01.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745015831; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GQmQfMpW8va+UTCEXGmkf3H4xjY6QXJiuqlXROT9njk=; b=pSMdfkm0KewJ7Q+BOCp8H6TyNukLaQCif+57BAmfpaQuNUmWNuL76XRS3OiBTu7WxdR/3y zJmuUuTI3O8iij7sOSa7CKhgipjbY5lsxFXEIFkEm6YR941i4uBdJCJYycncuDUIHFWjB0 IUeA/156RLiZGeYuJ5jKVOFsHBOUkNM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Qztl/Yas"; spf=pass (imf01.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745015831; a=rsa-sha256; cv=none; b=vOorfBfypDXGaKqD0bv5OudrMGKyLqK+Y6OxJUH/VALz0pXMOGz9uGo2ERyfop3n7RVulv M+TfzpKUmZpSZ/TznP4XLNvFa7d6qk4fjUvj4KKxB6QEydrb+WZADsoEn426PIlQCztOfn 8GSqMS+kjYdWQeyK6ABUI21/90LO3tc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745015830; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GQmQfMpW8va+UTCEXGmkf3H4xjY6QXJiuqlXROT9njk=; b=Qztl/Yasa1y9xE9NzieJ4zjh43mbEysv3ZPJGEW83wnPz7V6kdWchYcCgaKFV/QhO8hMxg pcVAm0JXoRSa/BTvh1oafg6Rw5Hf7iU+0YdPJWCK6qYMsbhtTv3JiVO7d7jFyQPqQpq7YM dHyHQ0NKQravWFOHqPNu8a4V32/TNx8= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-607-SYG6l-PeNDafTOuSFqMW9Q-1; Fri, 18 Apr 2025 18:37:06 -0400 X-MC-Unique: SYG6l-PeNDafTOuSFqMW9Q-1 X-Mimecast-MFC-AGG-ID: SYG6l-PeNDafTOuSFqMW9Q_1745015825 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 86CB1195608E; Fri, 18 Apr 2025 22:37:05 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (unknown [10.72.112.18]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id EE42F1801770; Fri, 18 Apr 2025 22:37:01 +0000 (UTC) From: Baoquan He To: linux-mm@kvack.org Cc: akpm@linux-foundation.org, urezki@gmail.com, shivankg@amd.com, vishal.moola@gmail.com, linux-kernel@vger.kernel.org, Baoquan He Subject: [PATCH v2 1/5] mm/vmalloc.c: change purge_ndoes as local static variable Date: Sat, 19 Apr 2025 06:36:49 +0800 Message-ID: <20250418223653.243436-2-bhe@redhat.com> In-Reply-To: <20250418223653.243436-1-bhe@redhat.com> References: <20250418223653.243436-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E26C540008 X-Stat-Signature: aa51unjzwumnrz169cu6fwqufxjowroj X-HE-Tag: 1745015830-280939 X-HE-Meta: U2FsdGVkX1/TIrIgM/t8WF6AehYRGP3G6X9vZrbEpmfwAgDLqZjEnE+N+Ry+SJgBddrOFFp6h1dVPq9+V4kFlgRPnqeADd0XCUIwv+WiyY/fvQ4wB+P4j3qH2Wbbp3E/X4zoSgoVfyp/GIqgTSlymUkqZ2UoG1pOoZb+WHHyxH/iidYL+Fzv29OsOfXk9k7aj0+pl5Yvx76+wtUsV5/R1x5rQLAeoMAmnCpaAiYCymGSymFHxZ+7XJFr1Ws3LA44Lpl8/ERmeRP1o0iu5bG3bFTv7sIMd+i1tL/G2qvqxxt3RTYoVQW5HoxwhT/LezfV+PoUU5Qaqb+rHyhU6Uj7ydCA9TTeBDHu50arCSR3f2cExUhKGMNeAUSUqhdBqtH7mSI6eRQgJT09fI5+hzYp64yH3epkKXm0PnTila0KWNzE9t/tUVjqmp3n2db9fjSW3Pp7+nVmLBKtZ8m1GWUqV/JCszE12aU0VWuUPulZr8an0cvVtlevBPUVY6kV80QAdygWf1Rl5aCk4d/5qKMT8Scz1xrCqtyPvxojXeseXcx6KclJM+JCNCScTLi5QX2XRQasv/rdRfnCLVPEaDg0HW1i5+wAtugbILRsqWlZY1FW3SyzckyptymZ586R7gAWWazjAneL/Jrj1Td7fJiUIqLCAuh7g7gwXS+wI8ioe1VUoiXefytCb9l7lzyNNbF+3ovdQluNdpYibWpaqmPaIj/KUcrtPAxvtUSkVOCR1uph8Rv2oogVKOYGlpA7zwV6EFAYnM5jwyTFGju7Bh/qYGHaKIu+QVegEB9jCLUKRRAn8Ea0mO2lEXAGEMqhSsqOvH4QPaGVV7iSjFoFMzNfxkuLWlNbCAR6cm58BPGVrIxOhgcY7x4bHjc6gVrR5SrKJbT0bs/nLKQe9YgXDG6H3Muc4U0CrRSn8Lp11lq8x2W+x4vUQ0waF2QvBB0URSJP8ZzndAURpFO7gWnNQFd askN/ow+ xCakhONqXcVervQa5St3YcCLaKX4IsZhCgpvLh5Q1uov7AQ0mSezQp2Kr9IfI4VAMlbzxkEQ0aDlhXng/YNMSl0666k8UYu/IQM+vkfWEH/R07v6Fa4+1C4hLNvKA2YjAIi85aKbEOHK1t+65khw16S8QhlSjbZ42V0/GqF6APTHwc/WIq4dlsIEIUWo1wbDhCb0QiUa3mMeFOFazSuWRFmbzDI++4KH1agwtBbqwrxwmpj0kipeUDgzyRILSKJ2Civ7f3qLp410+JoOuvH96C6joLBL0h/izY7lx0uMg6k9Cskln9iQRB2NVmR4+598OagjTR8HV6Es4QyCphtuXjLK/SCUD++JU+Spr26kGw+/CgonNyFjHW7zfaqkhaQYBqXQNejDL1XJQyKdTilBk41TP7C1aZfRhVCWK8wheRNtJcNi6sErPl9CdXVxnaw8oqP+mTUfTxB9gHUzHJQ7w/Q5qx0nq83VF4Re/aXy/3AAOAbiYVDGEZunjSA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Static variable 'purge_ndoes' is defined in global scope, while it's only used in function __purge_vmap_area_lazy(). It mainly serves to avoid memory allocation repeatedly, especially when NR_CPUS is big. While a local static variable can also satisfy the demand, and can improve code readibility. Hence move its definition into __purge_vmap_area_lazy(). Signed-off-by: Baoquan He Reviewed-by: Uladzislau Rezki (Sony) Reviewed-by: Vishal Moola (Oracle) Reviewed-by: Shivank Garg --- mm/vmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 3ed720a787ec..38d8d8d60985 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -2111,7 +2111,6 @@ static DEFINE_MUTEX(vmap_purge_lock); /* for per-CPU blocks */ static void purge_fragmented_blocks_allcpus(void); -static cpumask_t purge_nodes; static void reclaim_list_global(struct list_head *head) @@ -2244,6 +2243,7 @@ static bool __purge_vmap_area_lazy(unsigned long start, unsigned long end, { unsigned long nr_purged_areas = 0; unsigned int nr_purge_helpers; + static cpumask_t purge_nodes; unsigned int nr_purge_nodes; struct vmap_node *vn; int i; -- 2.41.0