From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD99CC369CB for ; Fri, 18 Apr 2025 22:37:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6FA20280001; Fri, 18 Apr 2025 18:37:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D9FD280004; Fri, 18 Apr 2025 18:37:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DE99280001; Fri, 18 Apr 2025 18:37:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1C292280002 for ; Fri, 18 Apr 2025 18:37:12 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5B357B5FAD for ; Fri, 18 Apr 2025 22:37:13 +0000 (UTC) X-FDA: 83348626746.18.38C242C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id AA60D100008 for ; Fri, 18 Apr 2025 22:37:10 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WTkzR1tH; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745015831; a=rsa-sha256; cv=none; b=6GPK4mbWLi/FqIOlIB8idM7ZmAsA4F3+fgONnaM3Je5kELESdVsGkOftL8oMAJd6Qhz3+y Hkg5YXDkv2uXvMSbJNuDPK8cQP0v0oyUZ73u5TxoLYrjcyVobRTI+KQOihvqrftz6SAyF7 VoByVIv9/fpTS8Z8Wk+dl4UMRUStZeo= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WTkzR1tH; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745015831; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=sDZHjlZI9MgazOQ8q7tQM1TDSr4RQFST8lgwGFeEG18=; b=XUMePSyVCBcIOIyTO65sVIX8TUPAZuVf2lNPuRV/lTjDGyS25GFW/j/zsgZzrL5IKUHceB QIgZtek+JD04iV7PNzNxAavxkrgrMbRN+pNmgd8a8Mmi/U6QCbQzpxJqZjY/kLObzn8HYk 9qVRImJhduLzOd+xJfrrs2gG/tiJnCQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745015830; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sDZHjlZI9MgazOQ8q7tQM1TDSr4RQFST8lgwGFeEG18=; b=WTkzR1tHtl1G7Qa3yE+LNIePuwQkgIaKqYI0ViTUT8RTjBzBAASHuqRYTiwV7za7NBoCS1 mcQqBwMgG1IeBkHasnS1VDKjS8PPlhKK5p13wXbvWuF/gFIUMX22mSW56UxOBXiFXyoHOT EYO0c9QDuQFjkod6rmOfGIZnJqPjG7k= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-360-EtRH0W7XPjKjGIKaPwZaZA-1; Fri, 18 Apr 2025 18:37:04 -0400 X-MC-Unique: EtRH0W7XPjKjGIKaPwZaZA-1 X-Mimecast-MFC-AGG-ID: EtRH0W7XPjKjGIKaPwZaZA_1745015821 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 609E31800877; Fri, 18 Apr 2025 22:37:01 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (unknown [10.72.112.18]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A335F180177F; Fri, 18 Apr 2025 22:36:56 +0000 (UTC) From: Baoquan He To: linux-mm@kvack.org Cc: akpm@linux-foundation.org, urezki@gmail.com, shivankg@amd.com, vishal.moola@gmail.com, linux-kernel@vger.kernel.org, Baoquan He Subject: [PATCH v2 0/5] mm/vmalloc.c: code cleanup and improvements Date: Sat, 19 Apr 2025 06:36:48 +0800 Message-ID: <20250418223653.243436-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Rspamd-Queue-Id: AA60D100008 X-Stat-Signature: zskexh4mcc44t7pi65wnh548n9n3tnyk X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1745015830-927916 X-HE-Meta: U2FsdGVkX1/nshWGCkSU9fBmofA7wAUTUPEO5LtB3lwrxMPZGzD2sWYdeAr/nYL0hDCSHtKhWFJcIaGFniez9M7gQLwu4DMGcKF5g3ejW7Wldk9SaIyVLFZtSKBv1sHnErh8VAR6P8Oo/2PcHb91UFv0mlX55/297g9YK5xLjLANYqD+iWJxNyRmU26ZoIAu9/uqO06U8utiteZF+mBnNMvyibgP1pACBLaPB1p5ZIU8MqiNXAKezNw/sBLR5qgEIZTuL8oIqfqg0CMm1ach2au3QmB4lD+ccOmH0nRfo4Vv5ZFmpd8ctdR0RDm7lVBeRQwvnP3cYzrKEn6qfJry0MoMTVWlnAn7ZT9NQZpM2R1YsRiWIPBHtildByXMM1LEYjIpZEXvEZ6MaNPEYdaN/WP9t6V/kqmF2cTcJvD47Ok9lOKMkrwSEejXz72IBzHMWVCZfGDmEn6gA7fQunSGVwHERGH7M5ICIazFNcSxgO6i3E/BAOvNt59+08N/cjbxSVx7BPjI2uXqDIJjhF1JErmZSq08TpltFjv85qDSb4Ws1Yutw9V+7CJWTA2dvpU902ZLwfn9lhyeTJOv6SkqraJvJNAz+rb8MbhoxqmcdA+MTUuj23XV5cKBVF5dMRtuz9K6YGd0Z32/brUX0v2wRrOqxNWdJd/a+N+acSopzIO5nw5Smvj35if8n0H3+0CVbb0fyDRjM9ebbdCvaI2roKIm52jSuy9PWSQ+bXVX8+kYEpv8iqEc9LQH9wngqlQNjX1wCKy8L0QSL9ohCdtU7hJAa2XURJyKc/y6BDVKL6YBxxEKyjhuj9oIdq5ukzG+qOPnkGEs28YTadexKW/uWAPaW+gwcx66eyS081/0m3AUPoeFR1vvIFDjuBLLQw/w6//mAcZrcNhVBUeCncv/ruPADxbxBClj7HyS9a0GfzeQX4BWXMq6P8tVnn1kC8D6Wl0+V3Ta1e36GXQDHFM gQ54AWeB fgsCMK9x63U+EUMW0Fq4D8Th1U20teuQQ7fnlUs4p4OR+tYxYY6QEwPrJuYLf37/+A1BYR3j0EzEm+9nJ3Jon5pQDFWLsGwlD5x7WfMeLBske0ESt1d4EslgfjX18/OnpxVDMateonpsnmtI8492TFtybEJZnpKqhW7O0+6CURLnYWnOCzxzT0B6VhY+i7Rn1P2JYWq2Hc/cXXSVtIWVXCS+xeidkAEWpGpQhOPphmbr3FmKn8zwEITyI7tuAmkZzDRn6tKazm3QARoyHcr2xSJ7l6rFLalOXtGG1Anpzv7M8mLRdS25sfbWhWABnsfUZAZ8nADGni2ShgmAZv+GmQX3S2oAI24q1szEF58/e1z+bCAxkkdFQrTwQhQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: These were made from code inspection in mm/vmalloc.c. v1->v2: ======= - In patch 3: - made change to improve code according to Uladzislau's suggestion; - use WRITE_ONCE() to assign the value to vn->pool[i].len finally, according to Shivank's suggestion. In patch 5: - add back the WARN_ON_ONCE() on returned value from va_clip() invocation, and also add back the code comment. These are pointed out by Uladzislau. - Add reviewers' tag from Uladzislau, Shivank and Vishal. And I only add Shivank's tag in patch 1, 2, 4 according to his comment because patch 3 and 5 are changed in v2. Baoquan He (5): mm/vmalloc.c: change purge_ndoes as local static variable mm/vmalloc.c: find the vmap of vmap_nodes in reverse order mm/vmalloc.c: optimize code in decay_va_pool_node() a little bit mm/vmalloc: optimize function vm_unmap_aliases() mm/vmalloc.c: return explicit error value in alloc_vmap_area() mm/vmalloc.c | 61 ++++++++++++++++++++++++---------------------------- 1 file changed, 28 insertions(+), 33 deletions(-) -- 2.41.0