From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D4D1C369AB for ; Fri, 18 Apr 2025 10:25:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 36711680002; Fri, 18 Apr 2025 06:25:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F143680001; Fri, 18 Apr 2025 06:25:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 142C9680002; Fri, 18 Apr 2025 06:25:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E21BA680001 for ; Fri, 18 Apr 2025 06:25:15 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0AA96818CD for ; Fri, 18 Apr 2025 10:25:16 +0000 (UTC) X-FDA: 83346782232.07.D8F5678 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) by imf12.hostedemail.com (Postfix) with ESMTP id 3EB6540005 for ; Fri, 18 Apr 2025 10:25:14 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=black-desk.cn (policy=none); spf=pass (imf12.hostedemail.com: domain of clx814727823@gmail.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=clx814727823@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744971914; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XMi6RjNLnii56OiqqTtBYh/fDGXu3JBH/VNIF3fIEn0=; b=TwiJg0ophY7aQa7Us90FjMtSo2rKn/KqoeMS36Fgzju4CJ+5bXuKJ942LTn2PFfDXOyzJX akian5jHhr1G0fjqSPjc5DcFLGX3tauUIkNeGUbscApJZJgzCDablXi67VTlEDvNbVBpdp 8iiTirHo6gxVAR/WXtPRxe2I2TKw2ec= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=black-desk.cn (policy=none); spf=pass (imf12.hostedemail.com: domain of clx814727823@gmail.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=clx814727823@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744971914; a=rsa-sha256; cv=none; b=P6IjIkfM3w46YzVR+LvJhtFfSme9mUYTPrFL2Sginz5G3p9mymtNvoteNCKH16ktPwJ3VS +kHdR6wlB673NocRE6N1mVtV31bqWP0y+oWxqK31CzZI6hMtYXAAEx8EKhpUAIl87Co7RB ZIa37qej09FiyXO/sBQOj88XZP1sPlQ= Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-4774d68c670so8372331cf.0 for ; Fri, 18 Apr 2025 03:25:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744971913; x=1745576713; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XMi6RjNLnii56OiqqTtBYh/fDGXu3JBH/VNIF3fIEn0=; b=lhorQoMArEhHD83eu0bJX1xEOsNeLsId1RpdjF2M8rxJe/VEVLdLBWWco4DAMnCXsl 4lLqa3dlz4gTtluBSzJhjol7pFfBuTGydL+cnIRZzJbb5oNwxWwo5Raf7OFT5EnPnYfH QlUmZOhWG87PCWgl2BwU+IJ86CCzAuy80KGITQNCvGqkhnX9LgynvjA2qXw0GxtUf2Fi 0/MFN8hf4EG/gMh6kc4mybzDPMRz7GSrO90USt+MsuU9HgilaODMiEYBiA1B3RRRJ2wW xWvGDS9CysLbbzXy6/VFROTKpmd0zaOc+eIBsmmN6OP5nJYgV5xfsRN1KD0Lt8V6J7ql vDFw== X-Forwarded-Encrypted: i=1; AJvYcCUnSmOpkhYBaMcS+URLDMFHfm4qiT33VPDpURtO/UM5vxMEf/5EZ9ScQ/FNT/O/0ilfNfGq+ly2kw==@kvack.org X-Gm-Message-State: AOJu0YxBdudLEU4Qq9qJoFCs0Mrce3qli/g3wXxFdRAJ992/oHokvmeL 7yB2xa8AuNAel+9sUrOf1vu4gYjaxY+RO0eIezS0TUQOx8UpLAkn X-Gm-Gg: ASbGncsY/aARNvQKj7dR6uCdRWO/jqgiCASsM7qPQUesoMWctBaZBHbBkqvw5d5Grm/ OAqjgTIgny3VIK4kcwu74R1Hea6frBOIRuzWsD/iAHQo4IZ/EIjOCC1yGtlglqJqmmOVH9n8Yaj Tta31k2j5JKgaa8nQL4Cm2FBJbHXOF0BX8pdegE3pBZNXv+l2UHGAk8Xa+so8lp9zxkkX9nae3o WXRUj363OwI2hi+lMRQdTdP4Tv77K0wdhp7sPl55AvedjmPk3vw/6u5ytY/f6Q1LIp5Xc/qIqxL XZQadXS3DThCS2iK/1vSzyVq6EaNYXdO/cRzGkzDIknbmufC47EI5tpX9aBMK5yN X-Google-Smtp-Source: AGHT+IEKJZWW+CA0u03L2I1YwGaBuPS3Jq/Tgj4wyFEY1P0tyWIjeS90rjHfjPUoep1kge+Jl0aKkA== X-Received: by 2002:ac8:5807:0:b0:47a:e6e1:c04f with SMTP id d75a77b69052e-47aec4cb1fdmr34086211cf.46.1744971913152; Fri, 18 Apr 2025 03:25:13 -0700 (PDT) Received: from localhost.localdomain (ip170.ip-51-81-44.us. [51.81.44.170]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-47ae9c17673sm9266701cf.13.2025.04.18.03.25.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Apr 2025 03:25:12 -0700 (PDT) From: Chen Linxuan To: bvanassche@acm.org Cc: akpm@linux-foundation.org, alex.williamson@redhat.com, axboe@kernel.dk, changbin.du@intel.com, chenlinxuan@uniontech.com, hch@lst.de, jarkko@kernel.org, jgg@ziepe.ca, justinstitt@google.com, kbusch@kernel.org, kevin.tian@intel.com, kvm@vger.kernel.org, linux-integrity@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-nvme@lists.infradead.org, llvm@lists.linux.dev, masahiroy@kernel.org, morbo@google.com, nathan@kernel.org, nick.desaulniers+lkml@gmail.com, nicolas.schier@linux.dev, peterhuewe@gmx.de, sagi@grimberg.me, shameerali.kolothum.thodi@huawei.com, virtualization@lists.linux.dev, wentao@uniontech.com, yishaih@nvidia.com Subject: Re: [PATCH RFC v2 5/5] lib/Kconfig.debug: introduce CONFIG_NO_AUTO_INLINE Date: Fri, 18 Apr 2025 18:24:53 +0800 Message-ID: <20250418102453.982042-1-me@black-desk.cn> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3EB6540005 X-Stat-Signature: ekb9urxgae6e8tnwbfgsfs4c134a76ti X-HE-Tag: 1744971914-962877 X-HE-Meta: U2FsdGVkX18zmNOoVzTz1HL2vnmQvSrra2y9M0tYagzpobinkNUHj0xbHoD3I18EaF84OIibki3Zc6KbJWHNIb8EIsEtjGjV3yxvCioX1LJvwlityi0bmRB/g9pp8lOWvwdXaEH7n4Noutyd75H5XlR0+PSUWochXmOvVT3a2aSfe7o3AcB2HsQg6OI10hcnVWTbyKjaGYBCKalEcL/Sinm/PlDyRYQC7vWM/awf5ak9sW/JOdBEqm6qwuxIVrpX5i+nyc6u9l3b44PHWzbNIIbFQaDrh4YDwNHohTwPDYs2kLoEQcWaWVlI11SmSXt6fbUn7J4pfMW/WCkE0cAUL90EZmB4UinolNDt81kI9HZI9CSXrzdM2reaEZerAo7wiyOL7HN5ec3zRvxkCUi3b+EFKEVq+JFgVXv5hfhsMxhvwvK1woNtDBDb3fE9BotoF3zXJKnOZ7kAaANHPlZRX6McOCLWintCNXMLKxVkdiyCZdXD/SdjcqtLxL6AxZUIPoli8ygK+/4t6BmQ+uRcoznnMKJJsd9VzxWVLw/AWBpsSGGljxYVbfhSnW1Wh0ATN+IQxEnuezZBkl7y7YiG9dlYa8XRsGvIO0Mm3NUyPOeGRFo5epKXRAp8frDPS87Fp8zP9FzS1NFBQKaf+kFN2zEpks4xAVFEbELK7LRN1mqgUqm8/HkwTknB84q8cVvB8JkN2YGoc3sACxbHiwH67po/Ci4iZdijRKX4XqDn4RDdTTSgLZrbx7PWSDjSlVi1BxKFKxCmQVoSkzTQ5IYvdl+8a7y6GF8hBZ+szTf+clxuFbDd4j6sKOqUYkZutFagi6RL8ivAzpf9s4pj+n30fpihVQYpebvtCrbhdkX4CBO8atw958jTAfxJM8q99uy5+xPbqhmqt/oCNGyarTnEV4jfhOaodOx1YJ4O9hWCny4gI7E3ckpYABZSoIdpyz3ybU0/5rlf+q4t11B3bRh p9M1XP8U JtVzYcLCV865hS1T9lPRCL2WIaTINxIHPaCeIb6Ft5jWV9rVWN4fDlrUn2i/3cZl4N05Z1Xmula4V4IOTfO2Ytdeo/fJN4gQSBUBwFMoE0x0eGcgLFPye5sRBIn6PSuaZHSSUzRT2X85jhjshLAXVM4m3YlY0TfGJOZa+/hW0q0lvm57grK0AO9D8XsSmw3c9v1KS3JdtvZ7b9dFiZ3DeO7H5X8/fIb9lsFfIXIZ8L4Zd7mPPcAhmVYemaV7Z+Ph8LA+6c4obHr42hTOpV9lwmHuh3DDzpUYTEbL6UsUAweAAoAfcjlG6dhvupaE9OLOt8Ch3+ue4jz1aPCHZUdnKzxT2re0z/BhB0A89Pe391KTasMynbYr+1dkDkjG2Yu3ukFjLp9+tLc7XeTPIPMIlIxQzPPgkfqVzAsmmCJLSvDgOA5OXU9TP+av+aa1LZOl8Cp6gzVmyjpbywYjTC2EcQ7HwiYeuWSrm9Opq0UwrMGWkSNMNMA/LMgKN9t8mdMOGoA28MeXnfYSETDVBS+QxDh19wYwugIcDoLSp6keC1YwxheiUkW2e3ZrSdY65KI1QIT165OEuBZj5/Lobpc8pOCLuZZGRDmQ0Rs77H1/F0CCffnI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/17/25 5:04 PM, Bart Van Assche wrote: > On 4/16/25 2:44 AM, Chen Linxuan via B4 Relay wrote: > > 2. Make it depends on X86 and LOONGARCH, > > as I haven't test other architectures > > That sounds weird to me. Shouldn't this option be made architecture- > independent? It should, but I have only tested it on X86 and LOONGARCH. > > > +config NO_AUTO_INLINE > > + bool "Disable compiler auto-inline optimizations (EXPERIMENTAL)" > > + default n > > + depends on CC_IS_GCC && (X86 || LOONGARCH) > > Why "depends on CC_IS_GCC"? Please make sure that both gcc and clang are > supported. I make it depends on CC_IS_GCC because 1. Clang do not have `-fno-inline-small-functions` and `-fno-inline-functions-called-once`. 2. If we wrap those options with cc-option, Clang 18.1.3 fails to compile test_bitmap_const_eval(), with config KASAN and TEST_BITMAP is enabled. Comments above test_bitmap_const_eval() says that: > /* > * FIXME: Clang breaks compile-time evaluations when KASAN and GCOV are enabled. > * To workaround it, GCOV is force-disabled in Makefile for this configuration. > */ It seems there are some issues with Clang's compile-time evaluations. So I think there are some ways to workaround this problem: 1. Make NO_AUTO_INLINE depends on CC_IS_GCC; 2. Make NO_AUTO_INLINE depends on KASAN=n; 3. Disable NO_AUTO_INLINE for TEST_BITMAP like how we handle CC_IS_CLANG && KASAN && GCOV in lib/Makefile: > ifeq ($(CONFIG_CC_IS_CLANG)$(CONFIG_KASAN),yy) > # FIXME: Clang breaks test_bitmap_const_eval when KASAN and GCOV are enabled > GCOV_PROFILE_test_bitmap.o := n > endif Which one do you prefer or do you have any other suggestions? > > Thanks, > > Bart.