* [linux-next:master 3890/4528] drivers/acpi/numa/srat.c:467:13: error: implicit declaration of function 'numa_add_reserved_memblk'
@ 2025-04-17 22:41 kernel test robot
2025-04-17 23:36 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2025-04-17 22:41 UTC (permalink / raw)
To: Yuquan Wang; +Cc: oe-kbuild-all, Andrew Morton, Linux Memory Management List
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: bc8aa6cdadcc00862f2b5720e5de2e17f696a081
commit: 8579eee90756b972a13ef678848c49eabb99f3b6 [3890/4528] mm: numa_memblks: introduce numa_add_reserved_memblk()
config: loongarch-randconfig-001-20250418 (https://download.01.org/0day-ci/archive/20250418/202504180647.e3VdYsTZ-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250418/202504180647.e3VdYsTZ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504180647.e3VdYsTZ-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/acpi/numa/srat.c: In function 'acpi_parse_cfmws':
>> drivers/acpi/numa/srat.c:467:13: error: implicit declaration of function 'numa_add_reserved_memblk' [-Wimplicit-function-declaration]
467 | if (numa_add_reserved_memblk(node, start, end) < 0) {
| ^~~~~~~~~~~~~~~~~~~~~~~~
vim +/numa_add_reserved_memblk +467 drivers/acpi/numa/srat.c
427
428 static int __init acpi_parse_cfmws(union acpi_subtable_headers *header,
429 void *arg, const unsigned long table_end)
430 {
431 struct acpi_cedt_cfmws *cfmws;
432 int *fake_pxm = arg;
433 u64 start, end, align;
434 int node;
435 int err;
436
437 cfmws = (struct acpi_cedt_cfmws *)header;
438 start = cfmws->base_hpa;
439 end = cfmws->base_hpa + cfmws->window_size;
440
441 /* Align memblock size to CFMW regions if possible */
442 align = 1UL << __ffs(start | end);
443 if (align >= SZ_256M) {
444 err = memory_block_advise_max_size(align);
445 if (err)
446 pr_warn("CFMWS: memblock size advise failed (%d)\n", err);
447 } else
448 pr_err("CFMWS: [BIOS BUG] base/size alignment violates spec\n");
449
450 /*
451 * The SRAT may have already described NUMA details for all,
452 * or a portion of, this CFMWS HPA range. Extend the memblks
453 * found for any portion of the window to cover the entire
454 * window.
455 */
456 if (!numa_fill_memblks(start, end))
457 return 0;
458
459 /* No SRAT description. Create a new node. */
460 node = acpi_map_pxm_to_node(*fake_pxm);
461
462 if (node == NUMA_NO_NODE) {
463 pr_err("ACPI NUMA: Too many proximity domains while processing CFMWS.\n");
464 return -EINVAL;
465 }
466
> 467 if (numa_add_reserved_memblk(node, start, end) < 0) {
468 /* CXL driver must handle the NUMA_NO_NODE case */
469 pr_warn("ACPI NUMA: Failed to add memblk for CFMWS node %d [mem %#llx-%#llx]\n",
470 node, start, end);
471 }
472 node_set(node, numa_nodes_parsed);
473
474 /* Set the next available fake_pxm value */
475 (*fake_pxm)++;
476 return 0;
477 }
478
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-17 23:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-17 22:41 [linux-next:master 3890/4528] drivers/acpi/numa/srat.c:467:13: error: implicit declaration of function 'numa_add_reserved_memblk' kernel test robot
2025-04-17 23:36 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox