From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB5ABC369C9 for ; Thu, 17 Apr 2025 19:04:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86AA9280005; Thu, 17 Apr 2025 15:04:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 817C46B0105; Thu, 17 Apr 2025 15:04:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61E3A280005; Thu, 17 Apr 2025 15:04:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 37B2C6B0104 for ; Thu, 17 Apr 2025 15:04:14 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4ECCB160350 for ; Thu, 17 Apr 2025 19:04:15 +0000 (UTC) X-FDA: 83344461270.30.D2D69D0 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) by imf29.hostedemail.com (Postfix) with ESMTP id 3A4DD120011 for ; Thu, 17 Apr 2025 19:04:13 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=gDL2yGAf; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf29.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.47 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744916653; a=rsa-sha256; cv=none; b=XIiCMD2xcXuFlMfDTXtmnw4TQ8FFj3gLEJ/kvv+9XvZKCYcbOeFjOOM6ZdDH2eO4FU4OCS xhidwfTqcbkYbRSQNMfm2APNlLhi6JNYf+/IR5zQvelNH5doufHlVgbQKUQbdunBJE8yWF aCqhIa3XOHAXqX3BLkJ8awDIqY9sSvw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=gDL2yGAf; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf29.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.47 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744916653; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cJI7eEInfWBGFTlEkOfJ7m4/J8g226i7EkrN81AXu4g=; b=xxXqPcHlLeWcibk4z+8wXynABbcVDLYlFHj+Wi0M03N1Yt0ArwLQ98k8kwCI4uw4CxE0Va 61nClP6Q38TN5G0jJroekdFaAv+VO5oY2EqhURnmROCYa0os/7EAyrwY7KWqHgtJNYty0p qiIICwQKEJeFlYyXpTYmgDKSlxtLRfw= Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-6e8f4c50a8fso10801376d6.1 for ; Thu, 17 Apr 2025 12:04:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1744916652; x=1745521452; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=cJI7eEInfWBGFTlEkOfJ7m4/J8g226i7EkrN81AXu4g=; b=gDL2yGAfzQMGFgverNj/HXprAmGrO0a6g6BFwyR2TX+Zr8af76Oo04erCakH6NbgNn LnOctSJ7rSuwnKWHClKfc25INaBwo/tEjvHb/SDXd3GDqC5T8O3/uV5C2Dl1r6BIYny5 m/K1j7H4YNexB8WkeLouJEd/keF/7sA56vic3aILQoY8jJYcoZoHIi81ydY279aLXSDA VD7lAe8ROOp79pvBXZfH2yDWUwiwpNMrk9o11oZvbxm4uGqFCHKrUmi3exwwzb1Hv6IU 3t5Y29Pqix2WE0vDSiZJ94jAD3blhCYk6pMy6jRMi4L36VdbdsTl3EKsEuqDdGeXXktN 3xDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744916652; x=1745521452; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cJI7eEInfWBGFTlEkOfJ7m4/J8g226i7EkrN81AXu4g=; b=Rd9y/lnGfxa3IHIHXYUKq1xJr8jmtPL0sgkC0ZVR50wQo8qOn67Uq/KAQIFpzpYGLy qDTHPhq81STF67hiWAZir1caiJIbrtVCJMHnpvmyKM6eLULo1a3uTz8HjL3wdzMBvB+H EUteLgvyBYZU6G9xDpRiaOd56LRu1+4NDHjwbFhxvWKIOaqA3tq7Nn9Vsba14PdAos/3 R6Qmoulk7d645Xz0AnLsRw83ou0/AUNdQm9O4211CjGcFrn8bH+g3cSIT2g2+jyyeoZX PwezL5bXyw8X83IdOw565M0WSMQ+RzxIjOq/z/upHR9O8xuoQZK4sTPA25DNT3cRZndq /EiA== X-Forwarded-Encrypted: i=1; AJvYcCVXYVn46myjpbORDe0u6c7CFTcJke5rfjjLdJzAWmbuwcrHBdo9qmppwV1t08VdeztlOERUPLSgcg==@kvack.org X-Gm-Message-State: AOJu0YyLdDe716Ae0Cqytmb2PqeFmg8NyTubJt8/BA7ySizUjnDIqMIp 5DEgyo+dfitjS4U5sJZf3aXcsKop+hPzNi0uWV7lK83C99mk/JzAwzIulryB9yM= X-Gm-Gg: ASbGncu3ChThwU0zQAZgcfBPJ2qYKGx0Bp7XgN75ACIyqIHmWbuchO3YINSUWFfoVPK DuSYEz3zsm/kVD01PF982su42uJqogjJJjlMn3ScQ+I0PYvwsDRvEhpVG4feDaRi3vWEbnaUpRY lTGLrqxPBzn9MI165t1gmtnoSDpQuMRiD3QjvpqeP8kbJ6JF79YPolcAMhny5qJH1UjGEOnmnYU prtfPA8+eeogqoO3XR5bqntPpAU9MB5xs9F7GlEMoEYdDW3MEy3cfuD6v1niiPUWHc+Hnxrgg+L PyRyYan8qumTCiq6sxatSWJGZlvE0bUfkXe6LXI= X-Google-Smtp-Source: AGHT+IHo1/OeUWXRZqjMpfiF2mmdicEw+dSXUeYDfk/KKmjmWEdY5WOrK1z4XGfQVAL63dV519TDfw== X-Received: by 2002:a05:6214:2aae:b0:6e8:fee2:aae6 with SMTP id 6a1803df08f44-6f2c46bd7ccmr1552706d6.41.1744916652188; Thu, 17 Apr 2025 12:04:12 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:cbb0:8ad0:a429:60f5]) by smtp.gmail.com with UTF8SMTPSA id 6a1803df08f44-6f2c2af5b28sm2348286d6.10.2025.04.17.12.04.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Apr 2025 12:04:11 -0700 (PDT) Date: Thu, 17 Apr 2025 15:04:04 -0400 From: Johannes Weiner To: Kairui Song Cc: Muchun Song , Muchun Song , mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, akpm@linux-foundation.org, david@fromorbit.com, zhengqi.arch@bytedance.com, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, hamzamahfooz@linux.microsoft.com, apais@linux.microsoft.com, yuzhao@google.com Subject: Re: [PATCH RFC 00/28] Eliminate Dying Memory Cgroup Message-ID: <20250417190404.GA205562@cmpxchg.org> References: <20250415024532.26632-1-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 3A4DD120011 X-Stat-Signature: ckbzf1xxmaj94fawkwbm6uzu5wajfxdo X-Rspam-User: X-HE-Tag: 1744916653-94641 X-HE-Meta: U2FsdGVkX18YXbNNThwaxFvmmqEP+sbODyrPnFn/F5VE1T0oVIAVWEjTYnRKKQyYlcFt4Uh81J0KqOEl4TlmR14iJJiXBrCiTw6j795jy3pHUF+qXU9dnKV4ZlUQqVwHXWpj/QnxSoWHqnN2TDQ02+NUX5TjrEJRdNjmRnbHcXWxCCSV9crj8bUPRuHoI3VxSR/rkpQ14EbQ+u/8MGDT7o3DdpXfGHPKkaVB/UZiCdfiyIKq3fdxHoEASgHqaLS7O6/llmRpO5j9DNtr2F7ItA/pvrmQ2Ot2Z85Fcz5qpA8L/DUFFfYq8fO0JRyfh9+qRYArR5KHzh14SYm5NvnIgQPlY2YHvCzDBHTU8fP7nAPbRhgml0jTRuuHh/Z6X6hKkFgw2iXGSn+WTh+M6R4g2RAHFteyC7pdrh9OGfg0QItExB/fYZ3UECXstLV8o2QfCxsjBVQz8OJCUQBDwOCsNajPj4zSlUlLrN/rJoz1SXuud0m8735r1Wj3lfS+uuqNHh/58GwO2E7k+nNo4PoUzgzerSQiN7Il6omSC0FkNDoRicpklMMoTgJkfuPR7szYJ8vek99j5R3RnMxXNZEMBEXK6FSsCWMej6H3BiB7v4QEIn1T3y4jd4GIbIh4jaybf2wB0Kq1EnfTEBLBAaZOYKWRTqq1E21yf/pIiPyFhNlEBuymAoKdWHiiluBiND/yLiVF+jymhc8qFOryoHo6MZi4lQ/qZ5hnUOObEZ/hwD+UzaLPXge/2df5VlyCmqDD/DtzSSQ6+U3iKlyjPBdut4ToIxzbjteMfSzgcCRKjr3kQW3cZLRGvD0oOHPVV7ckyYvivDPRvToVny7VrbrRe7UIMNp9CE3nJ/LYpji/Kt7N90k+q4LS9uBb2RgPMGZokbiVlXQzjtqH6g3d+G8u+zaqIhRjY/tOEc7O5M9401BwjuOn7OEZKmqEdwru7VOJNhWyuDvPmW0et6rrVlS YvOmkMVM ZzNf45UCf8t9E1pTDU+gA3f7fZaXm1blh3RIiumWfv2In3NSaVVKkKhKy1f67gqWhRZDcEZDyNSGVDkC4IOoYTY8lKLKfzQ0rqxSubksscp080NQMSF4Uh7dLSX7XklVnvzjvmriDOWwtWbgqACYdcCkWiyAHt0t2Kspav7BKSicC3HLwActxqM5EvLZJoFpVd4AgbK2n2BIo52JuyLZ74Rih0lKoMzlJrai4km/bs5C4YrRR8jBwIXaEFryUUCBRTCDXDAyhUcWTqwnKZg1PO/3BmNGBG83LXIGMs2Bs3AH9rpjXrG77mXIp2Kw+s294twlBEChSSZq/KrYTB9wIVTRp4fhlnIPPBWh+LoTlMHxIP5QZWwN2QqgXLFJhTanRnJWOuYSPp3j3Bd6NTxhqycagpIHXlK2UIpHXA2gInaEfoj6Yli0ch6fbhSmYugq9oQD9Ud54cqHZflC4TTespxzL6XF+ATsFg11gSSYgsxsc5Pw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000776, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 18, 2025 at 02:22:12AM +0800, Kairui Song wrote: > On Tue, Apr 15, 2025 at 4:02 PM Muchun Song wrote: > We currently have some workloads running with `nokmem` due to objcg > performance issues. I know there are efforts to improve them, but so > far it's still not painless to have. So I'm a bit worried about > this... That's presumably more about the size and corresponding rate of slab allocations. The objcg path has the same percpu cached charging and uncharging, direct task pointer etc. as the direct memcg path. Not sure the additional objcg->memcg indirection in the slowpath would be noticable among hierarchical page counter atomics... > This is a problem indeed, but isn't reparenting a rather rare > operation? So a slow async worker might be just fine? That could be millions of pages that need updating. rmdir is no fast path, but that's a lot of work compared to flipping objcg->memcg and doing a list_splice(). We used to do this in the past, if you check the git history. That's not a desirable direction to take again, certainly not without hard data showing that objcg is an absolute no go.