From: "Uladzislau Rezki (Sony)" <urezki@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
Baoquan He <bhe@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
Uladzislau Rezki <urezki@gmail.com>,
Oleksiy Avramchenko <oleksiy.avramchenko@sony.com>,
Mateusz Guzik <mjguzik@gmail.com>
Subject: [PATCH 4/4] vmalloc: Align nr_vmalloc_pages and vmap_lazy_nr
Date: Thu, 17 Apr 2025 18:12:16 +0200 [thread overview]
Message-ID: <20250417161216.88318-4-urezki@gmail.com> (raw)
In-Reply-To: <20250417161216.88318-1-urezki@gmail.com>
Currently both atomics share one cache-line:
<snip>
...
ffffffff83eab400 b vmap_lazy_nr
ffffffff83eab408 b nr_vmalloc_pages
...
<snip>
those are global variables and they are only 8 bytes apart.
Since they are modified by different threads this causes a
false sharing. This can lead to a performance drop due to
unnecessary cache invalidations.
After this patch it is aligned to a cache line boundary:
<snip>
...
ffffffff8260a600 d vmap_lazy_nr
ffffffff8260a640 d nr_vmalloc_pages
...
<snip>
Cc: Mateusz Guzik <mjguzik@gmail.com>
Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
---
mm/vmalloc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 77da4613f07ff..54f60d62051da 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -1008,7 +1008,8 @@ static BLOCKING_NOTIFIER_HEAD(vmap_notify_list);
static void drain_vmap_area_work(struct work_struct *work);
static DECLARE_WORK(drain_vmap_work, drain_vmap_area_work);
-static atomic_long_t nr_vmalloc_pages;
+static __cacheline_aligned_in_smp atomic_long_t nr_vmalloc_pages;
+static __cacheline_aligned_in_smp atomic_long_t vmap_lazy_nr;
unsigned long vmalloc_nr_pages(void)
{
@@ -2117,8 +2118,6 @@ static unsigned long lazy_max_pages(void)
return log * (32UL * 1024 * 1024 / PAGE_SIZE);
}
-static atomic_long_t vmap_lazy_nr = ATOMIC_LONG_INIT(0);
-
/*
* Serialize vmap purging. There is no actual critical section protected
* by this lock, but we want to avoid concurrent calls for performance
--
2.39.5
next prev parent reply other threads:[~2025-04-17 16:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 16:12 [PATCH 1/4] lib/test_vmalloc.c: Replace RWSEM to SRCU for setup Uladzislau Rezki (Sony)
2025-04-17 16:12 ` [PATCH 2/4] lib/test_vmalloc.c: Allow built-in execution Uladzislau Rezki (Sony)
2025-04-18 15:01 ` Baoquan He
2025-04-24 13:37 ` Adrian Huang12
2025-06-13 13:59 ` Dev Jain
2025-06-13 14:19 ` Uladzislau Rezki
2025-06-13 14:23 ` Dev Jain
2025-06-13 14:37 ` Uladzislau Rezki
2025-06-14 10:27 ` Dev Jain
2025-06-14 15:35 ` Uladzislau Rezki
2025-04-17 16:12 ` [PATCH 3/4] MAINTAINERS: Add test_vmalloc.c to VMALLOC section Uladzislau Rezki (Sony)
2025-04-18 15:01 ` Baoquan He
2025-04-17 16:12 ` Uladzislau Rezki (Sony) [this message]
2025-04-18 13:26 ` [PATCH 4/4] vmalloc: Align nr_vmalloc_pages and vmap_lazy_nr Baoquan He
2025-04-24 13:38 ` Adrian Huang12
2025-04-18 18:12 ` [PATCH 1/4] lib/test_vmalloc.c: Replace RWSEM to SRCU for setup kernel test robot
2025-04-22 12:59 ` Uladzislau Rezki
2025-04-24 13:35 ` Adrian Huang12
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250417161216.88318-4-urezki@gmail.com \
--to=urezki@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mjguzik@gmail.com \
--cc=oleksiy.avramchenko@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox