From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AA41C369B2 for ; Thu, 17 Apr 2025 14:53:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 133216B0101; Thu, 17 Apr 2025 10:53:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 06D226B0170; Thu, 17 Apr 2025 10:53:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E76A66B02A5; Thu, 17 Apr 2025 10:53:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C981B6B00FE for ; Thu, 17 Apr 2025 10:53:34 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 930C281A57 for ; Thu, 17 Apr 2025 14:53:35 +0000 (UTC) X-FDA: 83343829590.12.B398D85 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) by imf29.hostedemail.com (Postfix) with ESMTP id C20AF120003 for ; Thu, 17 Apr 2025 14:53:33 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=C2uJ7qko; spf=pass (imf29.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.181 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744901613; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=orQzpRsQIpG3P6OtKhgbz4MoOFHOwC//U7SqiKMoiFw=; b=xJSF6H/nduoeqEIqJsYj1PoKRLWXgMNQK679Ax6sKx/AqHR0/tFI/kwtVC234UWxEm+X3+ GE9sZap+f8e+j/6skYOB/A0guXUM1LCgrLdVGbNpddvGgudBIzk0s9uxBlS6fwvSCkf7uP 0hzMGphvfR1ealKjBrkGkE4r/Vs9pqY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=C2uJ7qko; spf=pass (imf29.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.181 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744901613; a=rsa-sha256; cv=none; b=wYuICN7K15/OW5+j4AAqll8ClTK2RUGPi5YNjmFFzL1Jrdhzn59zMlE1U4fzSFZY/nVde/ BedCm5dn2f77nC5jobf72Sq1gOjbgqd17BmOJBGhXzP8hhLJnC3NqceF1smGZ9/C2hIx+J fQU6mE4rjPPnrVyIAQVpt3A+9T3KaJI= Received: by mail-qk1-f181.google.com with SMTP id af79cd13be357-7c55500d08cso83766385a.0 for ; Thu, 17 Apr 2025 07:53:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1744901613; x=1745506413; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=orQzpRsQIpG3P6OtKhgbz4MoOFHOwC//U7SqiKMoiFw=; b=C2uJ7qko6NC+LlSJRN7CpB0A5vzVIKlQFEL9VUj0K4o/Zk1rSAQNHs8Oxbi1VKglm6 pfSs/BSWnO1o/gOOPZ0F3rb5lpC93Nj8ij1BEnEY2aXlk4GKfEio8SPJgQiTPFbrv2iP 1TB3joqtTu6qQhaJ9zVWF0MRTGW6rhNzSsct5JHwEqpfjber56o6elDbJfmRB9Xq9cO4 8jUXlOqBC3ALabG6rzQwqc3tX3AKgKNZW6lFba0yx/DfZznhQCUeNf5+QvkFK0qAljnb SDh+2b000d824gB+ksFWl3ZzuPQde9IY+kMIVY2F7rLsDtSzBe+x4NbMT+XlsrhgJS22 ML0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744901613; x=1745506413; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=orQzpRsQIpG3P6OtKhgbz4MoOFHOwC//U7SqiKMoiFw=; b=b+uQAQSppGlrJMIGW3dBERvyVaqG7j+9EB9XobFv578jCsbHMMcMn7QFuVs9T9Gcz8 tm/4rBVc76Qkd/43kAJ/eVDvqryld1HLUrqU7cCR37NRh+0xoelpq/zpofeblahIMN2Y 5sGJxBUp0sYvYPqinQcntO90lEUho0wUKGshTOXIRxAazs+bU7RFGVUmJ3Rl8Pw81dct jmri2KxRNoLHzKt2zPFhefcYnjWCjusHCzeaS+eyXuiQf/QeFZAsMciaRcKnY34Y2Nj9 Wyjiwis0k3KqSZmejbo/qSxsPOGCYZvKETEVAWngrHUcFbDiVfJOoKO5zGLMFCYpZz7d 6LaQ== X-Forwarded-Encrypted: i=1; AJvYcCU9cL1uxMWV3KDEgK4/M5lO9xCDAvdFn2CfEhLj5TiPVpeg3LF0SGhzE55OlJrEyWKnZEmH4RDlhg==@kvack.org X-Gm-Message-State: AOJu0Yya/w15uRN84aNoyUJLEyxlwd+MKAFQ56yY/V3mmkG/8ETw+DKU Pt9vPruFAj3u2DjNfsy0Q92KHY90kv2Bf86XXhdH1dcFYIeD3oUQqZU/CjouEfQ= X-Gm-Gg: ASbGncuOaIvvjReUslzDy9W/uMaRxqbCI6k+XPPgKkkbuH/cQEtnwzlF2sSbvKRZlXD OVm2R2b1SXcH7h9ZCSOvsp2NhtM8Q6YfLihN9qyyWhaHQbeoUDfknIDnqLF7vUDkTtEIY6OqyVb W+qvDH2doKw13N2F4VxUFbUu+ucsR1ZxlNU77MrUaW2IGiL4J1EoUytdHlNcqSd5KbC3lKx2e2O n1ZYoQLDPVK/astOil8mE4Ho8trG+t0GHLbfzjZ6RI0iNIcRZhFN2WzvP4Cfxk5gYHoI2HG+dOt 3BkbtnKPZo9FCXR6Oy9ALx4JW2MZaEFkpYx5Q44= X-Google-Smtp-Source: AGHT+IEqK9fyjzJURoJ5YbmmoiOfm3vVGT7Kw5UjLLbl7399FqDUAYutZyQtGhwh0u3F71MjRojMPA== X-Received: by 2002:a05:620a:44d3:b0:7c7:747f:89d0 with SMTP id af79cd13be357-7c918febeabmr911311385a.18.1744901612837; Thu, 17 Apr 2025 07:53:32 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:365a:60ff:fe62:ff29]) by smtp.gmail.com with UTF8SMTPSA id af79cd13be357-7c7a8a0dd06sm1184307985a.95.2025.04.17.07.53.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Apr 2025 07:53:32 -0700 (PDT) Date: Thu, 17 Apr 2025 10:53:31 -0400 From: Johannes Weiner To: Muchun Song Cc: mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, david@fromorbit.com, zhengqi.arch@bytedance.com, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, hamzamahfooz@linux.microsoft.com, apais@linux.microsoft.com Subject: Re: [PATCH RFC 04/28] mm: rename unlock_page_lruvec_irq and its variants Message-ID: <20250417145331.GG780688@cmpxchg.org> References: <20250415024532.26632-1-songmuchun@bytedance.com> <20250415024532.26632-5-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250415024532.26632-5-songmuchun@bytedance.com> X-Stat-Signature: qhd1wez8oz1p5tisjtd8efmnp43584cg X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: C20AF120003 X-Rspam-User: X-HE-Tag: 1744901613-727013 X-HE-Meta: U2FsdGVkX1/xH17pwH8t4LDMNBsfJTA2Fb0FHgvKJFy2tY2Wp0AjC2WIUe6ZS6VzYXVPQZMkwoXHz3ADNzNctB8LAX878i5YvaOcdcbnnX5h1P3fnaG5CV+1JjUQnjnXdqfTuqiyV8LgS4o7xkjFlRZBgESe7lt1wHk5j8vkRRJjgI5fWXIl7XfvJELIoUuL9evFZH+r4oWj9X2ExlFAJwtOXgHCTuEO83Ns2AEE/hIofX1oX0YDyVBPXyehKtUnEBp4oIDXSYynas/33wjPw4sQ13zRNHqq5eEYAXRvZmokUBGQceH3TeOTxliAYc0CyLsXYUL0N9wIOMpnD7rVrj4aRU/VV0EwhxgeDpwTz/8ftyVyDN5Sdm4mOR9hINHMmNNVVzxzAVzrSzCNirvfLIQ1fUrAa3Tk/hf7FPD6EBiyvywKb3MwGg/FmPDbo2Ro5Lcj6UJk8Zet+sfEOh5ayTCBspE7N4j8viVpaw0eyz+K9m1/4EiY025Yi/5LqSy0Zi1jcFRvlMClkNFwysZYhgBOMkO0hVWgElVOE7YjTF98n5DVinVxKFht8S8Pca6SFvoFYI6Nq7KF6hrUkyWTE+vWEudhmyoT+z8qgvn7qk9RRM3WE1nw2n25jUSyoOYCKqO2Lvf/1nRMWYVinLTklyRnZvbZHrDmSIpn6l1iJSDetrLaz+SMAZCmz22X81+EPXm3UZhmQ3Ncvx0/zpD+9hGyMkyAjwHwaiic3vmFj14YLmHBWldP/frGeGhoJKNBrAf7ESzrHrqJcdpCV/U+Tc/XQfEJcyAfuIROYSb8kKcm6brHN5fmzVvknrkA8ktluxhhX0UyHfFrtKmDVRxZGJ1FzFPAAEblbOLKN4QtOcncNY1y3vViEdRSQaHTu5US0m6iLz/re1TAcybWYRJHQsYSEnPdy6NRYx2HMO3bpp+d/OV5ubIBjHNsNv5mlXy/6pLP2A0BYeO8L3VrjkI XCxRYK1t JNh0eEVUkVL2bjhjGwcq7JWp4WQiTCck8AcuQFfNoTlz6FMzLywbL05ztmM3aI/GUGfUvJf1R0TPzkPa9BYddAS8G0lGHigNYvSn5my6ZDKGzJbWKkRp+dAwN5JPCOveIuSsdDoqDZqMFihWqlOKU8dsa8J3R5psO0ldQiStxTSk+VDR0vznIfHfLy7xAcRXdLvhwlU6Su9UMO97zNADPwmZzG5f5lu71wrcnqRvpKKh3FsDaeWxT36zlpOnXaQKE6X5eHEUWRZ3rh5ND3r7rdGv/TiRxmjjhL3OiZ6VjndLNHaiPCMT3r3rd9hw0vqkqcKTcc7ylK9L/dgjnAiayWRYfQRUo0CWNh0uYUrlrhbi4sKmuGoR6CFikEKI77+8ggk0mXHgA7jk28ywLNOQ+fuBoZa0JCpuAmzB/9SU/CaPxvka5cdjESXybdgn3Zbpg2FbPIwMj5oN6Keg2aFVOWYTeC+a5QPVpYDojvvmle0J1DZwU+tZzbPFh0G/tPYeYHVrAmfx8Ekrk1qOHUAvanKzJCkfumw4A6xvdqC2aONmdbJHMAwIgF1kk4w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 15, 2025 at 10:45:08AM +0800, Muchun Song wrote: > It is inappropriate to use folio_lruvec_lock() variants in conjunction with > unlock_page_lruvec() variants, as this involves the inconsistent operation of > locking a folio while unlocking a page. To rectify this, the functions > unlock_page_lruvec{_irq, _irqrestore} are renamed to lruvec_unlock{_irq, > _irqrestore}. > > Signed-off-by: Muchun Song > Acked-by: Roman Gushchin Acked-by: Johannes Weiner