From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 034B5C369B2 for ; Thu, 17 Apr 2025 09:57:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DC2F2800A8; Thu, 17 Apr 2025 05:57:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F1722800A3; Thu, 17 Apr 2025 05:57:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26B782800A8; Thu, 17 Apr 2025 05:57:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id ECDA02800A3 for ; Thu, 17 Apr 2025 05:57:44 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E7E9FC162C for ; Thu, 17 Apr 2025 09:57:44 +0000 (UTC) X-FDA: 83343084048.12.758BFCA Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf03.hostedemail.com (Postfix) with ESMTP id 3676920006 for ; Thu, 17 Apr 2025 09:57:43 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nARtGiPz; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of brauner@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744883863; a=rsa-sha256; cv=none; b=xamU9byQYszCALAVHahE2+MOWfz+Th8r45YfiGiFUYinICOYAFJA5WapBH8TrCGce9kl3p NCjAEetilcY+FpDfAkXppKDHjaWW8w6AwlL4pA2nAL0gzn7WADNq+GS7ZeHcSIC7gf+dFk 48I6aRvy8l0pXAGiwQpAYoomvWAv/fg= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nARtGiPz; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of brauner@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744883863; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+QXufE+mhwxryAKZb4Nl4MOmiB34c/IqcNxiEIlf+Hw=; b=7TIXIexIDcokWO/Bw39AjRHUWDF/lT4J3u3cOF7/RdtYCoizsaNsQUDHHdx2Wcz0VVM9re NUVg/2La7WeSpJQYiRyyDImU9cHUefdsZZf9/tVm9ZDrbDH9+Nj3qIWidxwmtbzaRPh56k nnEKjw/hXwDNb5t2qe4OHycDu3e1034= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id CE1B249FC9; Thu, 17 Apr 2025 09:57:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F389BC4CEE7; Thu, 17 Apr 2025 09:57:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744883861; bh=74Syrnslrm4pPY3lc+PPK93eU6Bz87BAgFvR+bR2NiM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nARtGiPz0ghKcu32cNEflVOXhx2Hju91/QffUQjwWmvvob7CZ4uNdGNeEyU9LTfbH 5QNHmjBu2wQH/QHynp7bZyuQxhNcBu27IOMbjWyqB3coeHh/j3CErHUqHne3Ozgxg9 EVnL7vMMdijjp+Cs3yKQ3h9hQ34qvh4CbzpUAWGRV5GnNXuWWPQJbp/+1435t/ZIb2 FTYfDu/kGpdNH2NGdxScJd3/3vVpF0ThiPvfENXapwvdJuB0BFz4+6xFqo5A/4nvMs d5ElTJzF2JDuGtb+rC2aOVgIZs00gCOSpp9lm64HKAYtBbhizx+TO1yqfN9chLqDfu E2KU/j9eWTTzQ== Date: Thu, 17 Apr 2025 11:57:36 +0200 From: Christian Brauner To: Luis Chamberlain Cc: Davidlohr Bueso , Linus Torvalds , jack@suse.cz, tytso@mit.edu, adilger.kernel@dilger.ca, willy@infradead.org, hare@suse.de, djwong@kernel.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH -next 0/7] fs/buffer: split pagecache lookups into atomic or blocking Message-ID: <20250417-annahme-geprobt-bc84bbd12af3@brauner> References: <20250415231635.83960-1-dave@stgolabs.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 3676920006 X-Stat-Signature: fyq3shpy8i5gyikg9migpkhf9ggrjrnd X-Rspam-User: X-HE-Tag: 1744883863-677542 X-HE-Meta: U2FsdGVkX18fnyBxdnxyNwQWBlKH8uJvdddxeOO1sIcZ07QEIFk2WRhh8tIdsMtpZSeAlzQPLcx/h69qYXCLc0dSrskF6j+h5QFoxu+QKcwKKwuJ+Z2DhRSFLzVVev2od08nitF3AfjT6fDBrZyA4ymh4jnHbthN4wbkqvs47a/pHFjjTA9ACvhgLDikH5+Ofgq791YLHGQQ2BDbVyxsqPnPVZs0rzv3mhwxFd0OU645+IkDTp780BGzq1ZeuseBnKkMMzuU/KiIucbN2N4MUYhG/L+12Xx8pl2hht4NqW3dILMxfoYcGoEuc7EWQUHSvLK1yfN0cNfOr09Ya6akk9aw7SwhfjLAwwS9KJjIL1lcfNFC4DFzcdICQT85Wof8ThGIt/tTvDPlEuQEutrPBQk+e/oJ+CeYuflcnG3dDGau4vXdXZYL7hmxY9QTHvwORxcoPu4mIAsr0Oms7su+6XNsOaREw77PXqTHDiQCMOtuwJKKp1B5AdhBccrTaNgorGiq5Hu4oP1PCPopW3LmklMerGAaXtYaD9ql7eH5wK4U676LhU8jIGAobrlKw4EhH/1tZBbCwopltZx+AWCOaZ0mm/8zyvoHlQEhXX8ZzK3O2rOIaRw21oXcFpi5iUVOxPMJqiCkzF8F/b1vFWhBd9wv4uBc76dXHc57hEZkrOfs2lwpk4JGmdbDa9Gmdsti8x3N9MGgt+EThIZv9SRnVydhI5oOB6U+G77oZui4zHpVySPrEpfvFkhwL4RtS2faVMIpTWIxZu/cy27UYPSu004U1Z4sFcwUjffm+ugMe3WIG//ZqOJtEZCN2dPugk9l+qCDjEpfL1GP/zdprNZqMQk5AbYxymMH0LDW/uJ/x2RkE+UPTFMTn/WEJS9/f4mP146V6d1/zvxXNXa2ctVIVmYeiprhb1amyvOv4iaEAtVRsia6ATwBXsUHNmzyQPd/LqKMPRFDkVjP35AkBhJ yLL0GyAX 1oJAjOUAe6T1MRQyaUX1eEQBIPBuJ5N/kxdbvgKrYBL3wXSxBgOmaVINmZgLedq8vNN+IaxPv8izKcKijIiPHyI4I6+3/t6tP/GZn+NYhpazccIBUhRhLO4SFXVF2K7No+shO3uy2gGW2avvGW4pPiIY5G21Dw26jrWdgNAngt7Hp2Tgcb+yG6ok6GQZphFLZVlUomLm1ubQksLmG/4iWr+ms9L4A3U6kYkPZg43kM5gVeTSU/xfHtq27Rqu/vR+ixnVGaQNYp2adhpkTN5AFj8IkcCthwtaoysc3gFdUaxnpMjo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 16, 2025 at 12:27:57PM -0700, Luis Chamberlain wrote: > On Tue, Apr 15, 2025 at 04:16:28PM -0700, Davidlohr Bueso wrote: > > Hello, > > > > This is a respin of the series[0] to address the sleep in atomic scenarios for > > noref migration with large folios, introduced in: > > > > 3c20917120ce61 ("block/bdev: enable large folio support for large logical block sizes") > > > > The main difference is that it removes the first patch and moves the fix (reducing > > the i_private_lock critical region in the migration path) to the final patch, which > > also introduces the new BH_Migrate flag. It also simplifies the locking scheme in > > patch 1 to avoid folio trylocking in the atomic lookup cases. So essentially blocking > > users will take the folio lock and hence wait for migration, and otherwise nonblocking > > callers will bail the lookup if a noref migration is on-going. Blocking callers > > will also benefit from potential performance gains by reducing contention on the > > spinlock for bdev mappings. > > > > It is noteworthy that this series is probably too big for Linus' tree, so there are > > two options: > > > > 1. Revert 3c20917120ce61, add this series + 3c20917120ce61 for next. Or, > > Reverting due to a fix series is odd, I'd advocate this series as a set > of fixes to Linus' tree because clearly folio migration was not complete I agree.