From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D68C2C369BA for ; Wed, 16 Apr 2025 17:01:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A622F28001D; Wed, 16 Apr 2025 13:01:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A116828001B; Wed, 16 Apr 2025 13:01:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B06D28001D; Wed, 16 Apr 2025 13:01:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6A1DC28001B for ; Wed, 16 Apr 2025 13:01:11 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4D17180D30 for ; Wed, 16 Apr 2025 17:00:58 +0000 (UTC) X-FDA: 83340521838.08.788CC2E Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf24.hostedemail.com (Postfix) with ESMTP id B6424180006 for ; Wed, 16 Apr 2025 17:00:56 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WB++JRMq; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf24.hostedemail.com: domain of ebiggers@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=ebiggers@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744822856; a=rsa-sha256; cv=none; b=dm8F+qog8TruW/dNtaFp5eIlYKblwHgokW1ZZEmdB2FNvAyAkWGlZTYK+GWyXIX9kNKdIu rgU/W97mHnG5p59HlnYdxi4xOIgwTxaD2e0Ga5/bsQ/e0VGPbrrLQ/Yu+Sv4DuDTZXdqWf 9GUYJXRvmQm2EMFGzNlqvrcfOmZqbnE= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WB++JRMq; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf24.hostedemail.com: domain of ebiggers@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=ebiggers@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744822856; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3T6rzUzaaP1bVCWysEvfusUnUop6dtH3GRcScqd9jBY=; b=CZd5+0WawFNKVQ0YH07/unsbYuL/Wvwpb3tdCzxO2ky+AAyL9UN6bCsLOLtSZaSWMZ+eya X6+QVGf4AkJ536rdrvxtHU8nQIrAQvtg8HbSJ5Wq5OWiRy7in9ZQ9jjB19kiFxA07IsDxD oZS78lGnovXwGGMLpSTjtb7wiRtCqyU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id A991EA49E26; Wed, 16 Apr 2025 16:55:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BF7AC4CEE2; Wed, 16 Apr 2025 17:00:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744822855; bh=Wt1UAs/njkYHTo3ZOAJNS8WN4itweF/XlxN3NKn2w1M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WB++JRMqFAIuXKKetI+/DacXFbk4x87Zc/6gaMvwvUUYxzGRo5BcqCA60QOLZxAMH wgpxQbubCkHZSq9WBefkOID5QP25YWcJoG0NDwEGmXNYUWHmYqlest1Ud/dg92yi2N ikbcB8cI0zJZIidFx5xOeGP44cGUjiJ/Hv5ONHd5nRg+0Wu+QMWRY27sbSCYbKpB6q pt0eogUwI9cLN68yXSiapVNfTO42tARLHV3OYFXYP1N1y1R2iAGdoJYkuNUhvc820W wYwrQH0Oul65iE89u3k1LEvCe/otREhRuc8JHXMZKLul7yjUGrZir3TcKS+hsAChst xWIv2ulQJnAXQ== Date: Wed, 16 Apr 2025 10:00:53 -0700 From: Eric Biggers To: Caleb Sander Mateos Cc: Andrew Morton , linux-mm@kvack.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scatterlist: inline sg_next() Message-ID: <20250416170053.GA189808@quark.localdomain> References: <20250416160615.3571958-1-csander@purestorage.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250416160615.3571958-1-csander@purestorage.com> X-Rspamd-Queue-Id: B6424180006 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: 3mzzkocxxpjfwfigeanfy795jhcbyoms X-HE-Tag: 1744822856-469852 X-HE-Meta: U2FsdGVkX1+CQPqCVoLLG9gIe6Bk8hF+49EexQ+h/RA1nYTCeM6BdqUxehgGPQ2Z3u48xIQqpy8ZUb5WnLnQImLC8//aePcOpJKMen2n17sndPChQJKpweeOdPsZILcmJKI2EiSm+VaalXvlRkh7qdgQgW91AGC6fVy7Prct50gNqofGrxDnud0+63jHu/utfjkH+e+sM+mOrtUU5zqOthy6i8b8FzZx2pMd1tslSdmwQNFXKYxF3BynE6LW96dqQbU28nzSwJ60XsqZEFeb/P/3y61G0ujl9GGKQdT/un/H+HLp1BD6hlNjpFYkr7jmy0UBq+HyimUR+zfPs8UX+WtPymRTV+bhDSH0WTYVX5H0o3/P1nqfCZHvKRMGd5QNrR0dFKFqiLC14xbbaXZ4Zitf4Cd/7yJopkra1qeXvbVYCRDz5HI5c7BxYWC84emd/zkDduTR//1R46N5udb8UDsrSbMyY453m/69DelzoaHbq3Y0N0LhrMPd6B3slEZSfsodT2rV6kv5hAVezrCwErhlFnBhuOcTtURXXs/6Vn4Fz5ZOR9QIGstoiJcDs1CeQExGfQX3xN2sjCiLFXm5e0rbd6ch8ip9pjHoAiwKhINFd3P4IBG+aQazA4dCy0gX6a5BLLzvsEHZ0w+q017omx4+k+6jhHjiRFoTj0wH0fYddJEPU2K/0IFbqksWG3HOQ8Xsn8mExpfjdv3wLAChyX5C5Q5aO5weCE+i/jFWf/y/dfy7OwKoa6WdegXUN8IYt1XtSN98nb3Nc7Ej4V95hg9aQ5eOwfUs8x8QTEwi5ohIO81Fwx3o3Ae119/PWEe+ZkX6l0XzvTpzZItra8wgMFygMU9ZNrJBV0BlVRbuZYbFJy63+zpodHtzp0ad8p3e+gssIhHFy9VSAYg0tvMUShzXDm+XPgIwvz8rIXrB21ejhiWlo5TaZEg0Cv7h3iWHFgmG3lJekcoYl3Jioyd DUHDAj4Z ZaRCMFdwPfAGWrWQesmHMGnv+3m6qJqvjX+tfTIF7fIc67j6nrD1xMkiLFPaNTTj+gaSkBMQsEDykwJaoBmRMJ32DeoI3VRCjIsO+ETf8WvwFUiBAGyINvxYo5Y4eueJrnQ0oE3G6DrmpJZf9pCtEpdBYg/Vi4w3E3VkDa0nh+qra3y+yO7ZvT643nQgq0oJgyFyOeDv/KR6j5H69lbPFL2OI9gEF14sKffXive5jMb3ETE4DhPtGsS7tg8WP/fxuJ3pO8/xl1by5rTH1CRLcPSlRZU5RrxcauU0Vr8vWImU3BoXzLThdo1YO4bGTii9sGzvAFo8xiTL1v5ChesUwX/ZwsQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.012435, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 16, 2025 at 10:06:13AM -0600, Caleb Sander Mateos wrote: > sg_next() is a short function called frequently in I/O paths. Define it > in the header file so it can be inlined into its callers. > > Signed-off-by: Caleb Sander Mateos Reviewed-by: Eric Biggers I had been thinking about doing this too. Besides the benefits for storage, this will also reduce the overhead in some parts of the crypto subsystem. > Is it a concern that this would break kernel modules built against old headers? > If so, I could update the patch to continue compiling and exporting sg_next() in > scatterlist.c. No, that's not a concern. - Eric