From: Eric Biggers <ebiggers@kernel.org>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scatterlist: inline sg_next()
Date: Wed, 16 Apr 2025 10:00:53 -0700 [thread overview]
Message-ID: <20250416170053.GA189808@quark.localdomain> (raw)
In-Reply-To: <20250416160615.3571958-1-csander@purestorage.com>
On Wed, Apr 16, 2025 at 10:06:13AM -0600, Caleb Sander Mateos wrote:
> sg_next() is a short function called frequently in I/O paths. Define it
> in the header file so it can be inlined into its callers.
>
> Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
Reviewed-by: Eric Biggers <ebiggers@kernel.org>
I had been thinking about doing this too. Besides the benefits for storage,
this will also reduce the overhead in some parts of the crypto subsystem.
> Is it a concern that this would break kernel modules built against old headers?
> If so, I could update the patch to continue compiling and exporting sg_next() in
> scatterlist.c.
No, that's not a concern.
- Eric
next prev parent reply other threads:[~2025-04-16 17:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 16:06 Caleb Sander Mateos
2025-04-16 17:00 ` Eric Biggers [this message]
2025-04-16 22:05 ` Andrew Morton
2025-04-16 22:30 ` Caleb Sander Mateos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250416170053.GA189808@quark.localdomain \
--to=ebiggers@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=csander@purestorage.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox