From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D76CAC369C2 for ; Wed, 16 Apr 2025 22:05:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E74B32800D6; Wed, 16 Apr 2025 18:05:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E24F72800CE; Wed, 16 Apr 2025 18:05:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CEB392800D6; Wed, 16 Apr 2025 18:05:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AFDE92800CE for ; Wed, 16 Apr 2025 18:05:32 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 86CAF80E96 for ; Wed, 16 Apr 2025 22:05:33 +0000 (UTC) X-FDA: 83341289346.29.0704C5C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id D09B2140006 for ; Wed, 16 Apr 2025 22:05:31 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=GII2Qomw; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744841131; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VSZqdx093ZUcUYS8wH+WvBtwoqkQgTCF1ySDVfToz68=; b=UCnhwjxfjcYyF6rLoVahETrAQtD8MD3ekynhsXyVAyo/YwHvCSQCj6+VniZjnvT80LGwbS gMVOJHxTittkfhWVLpb2MZu9FrcWVsNVvbd4TO1tlgXxj4zt6MaXzek+EicS8bbyzqotsK 9BF13PD951JNOg+Wm7URBwHIvSZWSs8= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=GII2Qomw; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744841132; a=rsa-sha256; cv=none; b=ERMoF+E9xYfIUBufnGOR9zjqMVtbNIUXlrw73Xw/XgOC543cAtt12HOPLo4AdLdIPfJPhh 2Fa4FA4x+aUpQW0CJd04Zbhu7+nO7jWCS497WC2dx8Mk9tKHJDXo45bIwMfouWv6XRpr1K b2qzE3OrAnfSETqWGDMAR8lXGi3rHZg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C96775C5496; Wed, 16 Apr 2025 22:03:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5179FC4CEE2; Wed, 16 Apr 2025 22:05:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1744841130; bh=CBe1hrz6X6KL++qECv2jjlzYIuclnyXsaN1QUDJING8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GII2QomwB0GYFNET8NeYCkM8tw5De00en2hglF2dWRDUtuI6WgQH2uvzXiWyDdia8 WnJpEzNh612G6iQ4rLr5ve2BTwdC+ciTRbFYKGryaEb0NAlArpWqMcJwTrqeTTC5qT EAK4YLdPhd9sLI/dRGD+y2OSUYsTjaW56/ZC0uJc= Date: Wed, 16 Apr 2025 15:05:29 -0700 From: Andrew Morton To: Caleb Sander Mateos Cc: linux-mm@kvack.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Biggers Subject: Re: [PATCH] scatterlist: inline sg_next() Message-Id: <20250416150529.1e24677e3798cd783f4adb8f@linux-foundation.org> In-Reply-To: <20250416160615.3571958-1-csander@purestorage.com> References: <20250416160615.3571958-1-csander@purestorage.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: 68smijkfpf4xbaizyxfp1n6infkoid5q X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: D09B2140006 X-Rspam-User: X-HE-Tag: 1744841131-1724 X-HE-Meta: U2FsdGVkX18j7NGI9ois28sr/SwnAKg4iwGaFdxPxvWup5dl79AT6lh+LttT8nVz1lFwnGCckMYOoIkvO0U3nsgYNw+kzML2puD+CDxTMLm9Z8mGSmWs0jLeHzbrPmv+RDDyBV1TdtKKH1smYKKpfoj45fFXXChJv95r/Ixfd8D+LynODTBQTPq8xpwUFKv+PzA5afmKBJRo5cGdOv1RfJdmWaS2lnHE4c+DE5JPC/p7JmASQYDebcxX/vKDWfZ/AAt5/G86Dge8kkzWr9RCh0XvxceJnSWQedK26GIQKPdrv4YcTqKT6gT9Wg0skfLBKOqJrlraRvNi8zy5I8vXHE0nMEwGxJDDwfm+kr0i+1adlaetQCbrqAVgkhDd4UlGnEnvkONlHA9fo3QP5gUEx2TiIf9S4Glc4xj/K/LFAqE/kzFO6JJDSLbrfO6jAxvYDGRPxU5jRE80IiYhysn0ZDY4eJZIfd0SnRwOhJQUgy71+Rr9d+Nl5nTT+54DSG5LmghvBbkfAZHWc6cuk8B0XYfVkW2EGcVYHe25M1p6PswVhI/HzxQdKsaKbtJADaWilFEK0WW7ONwyw1Ifjn4cIKE7eHDoBlOvZtqqBCCyyH7/2P7XGx69D730YDK112EEQrb6hsX+LnfayBLNhJ9lt3qYCwIGrjSRVMQdPqiZLGnrnxOR7cfdEy0bOfrQvlKAX4RXlJA+JADfDuOqeBQ0tzyV9AGcIu8CZ3s/AsMmudqhoDZPZJkYymr8KzSewuyB+YrQ/omjX14PtrhECIr6mkSIctu79/wgtV7UazlPyAsXvFXR6LAZuBhqf5REO6RzzlTY1oF9E4SpQxJ7o3o13U9boqnyUFH/ygO450LeX9Sq5iH6uwyN6cC+Y7+8r+9FMYcRcKgDEOy/Hb/b5k6JjMz2Z/7bE+ijtxYu3bR2utcqmggmx/OYD4XzBX81XDn+447y5dKSGAUyl3fooqP /L015mOS eYoAFuxBHsLhXeQkvV2UiLrEJvVdKG5lRm6c1jnSa/0pYh+EGWqkt+cqyRpAk4f+wNXCPiX0qVbHFBWSSuZR/BE81MKwBqN2FyOhzfjc1WghMLzoBX152Oxi0f4yQSeP6HZCu1abIQRZTir+XQJo4yoAaXAIZKyFQftYNKVyAU32AdFfiF9ocHYyfwiZArYs9R6iC3MrP8zzjQX+qLjwgEVqhkMp1DVJkBSgQnZ/jfmOzwKEO4T50GPa7OhcjCoNLQIGi8QyIhqSLEdJElF7JXCj/ntfwONs9bPEToehnDjrI880dgwwicFlRbU9fKEL6lbToV6qsN2VW0J3SJayRA4PQynpl9Z5AEwUt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000343, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 16 Apr 2025 10:06:13 -0600 Caleb Sander Mateos wrote: > sg_next() is a short function called frequently in I/O paths. Define it > in the header file so it can be inlined into its callers. Does this actually make anything faster? net/ceph/messenger_v2.c has four calls to sg_next(). x86_64 defconfig: x1:/usr/src/25> size net/ceph/messenger_v2.o text data bss dec hex filename 31486 2212 0 33698 83a2 net/ceph/messenger_v2.o after: 31742 2212 0 33954 84a2 net/ceph/messenger_v2.o More text means more cache misses. Possibly the patch slows things down??