From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 993B4C369C7 for ; Wed, 16 Apr 2025 20:26:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47D75280140; Wed, 16 Apr 2025 16:26:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4524028013E; Wed, 16 Apr 2025 16:26:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CB74280140; Wed, 16 Apr 2025 16:26:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0041128013E for ; Wed, 16 Apr 2025 16:26:53 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4580AB1A71 for ; Wed, 16 Apr 2025 20:26:55 +0000 (UTC) X-FDA: 83341040790.26.DD354E7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 088AF80006 for ; Wed, 16 Apr 2025 20:26:52 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LTuMOFXV; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of alex.williamson@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=alex.williamson@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744835213; a=rsa-sha256; cv=none; b=XOayJr46sk0TSViu2eFgVKflQSgqh7E3kSxF2vhdQQlgYApS/KPDLzuaLAVnP7Wqhr4kgP aFHq9ncj/s9cl3FPSl9QuOArGnH1Kb/3Lfcz19DcbT/kICks4UultWLH4SLdeOp8Sf9nbc RxpuHKluS/OGARLGSfl8MHTZTkxGUfs= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LTuMOFXV; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of alex.williamson@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=alex.williamson@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744835213; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d6AVDplNPTi289CSbOZ9ARQJAN0z0vy8/1A9VIws9D4=; b=LJngvkyYFqzqFxYu3KkATyf+mXV+sCV78aHRgX+zXAmSixeghVm9Z0UYLkUPAWkCtEp85U 5GF1MRVDb5Dj7x5xYetpz/pc/+QJJwHqCREJwuYte0GR72kyMQtzx/rpNHT4prxo2e5w9C 5ly7I9AemRy9osoy9wwnbmf13FscLts= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744835212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d6AVDplNPTi289CSbOZ9ARQJAN0z0vy8/1A9VIws9D4=; b=LTuMOFXVp2y/fyLkhE5C/W7nV3vj0wgfRBr1Q6DnkM/0L6r6Jzu3fTw0ICCfWXB9DziUpY dAdbJhmAnqIrL+OqoFHRR92+nBQtwvemwkuE7iNXodZFL+ynZBLj8EELn/C553c0jKl9IO UBYLzlDshiTI1xfnf1VeDxNJdeGrSlE= Received: from mail-io1-f69.google.com (mail-io1-f69.google.com [209.85.166.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-142-hkUL5MzbNamN9V-Fu8hYEw-1; Wed, 16 Apr 2025 16:26:50 -0400 X-MC-Unique: hkUL5MzbNamN9V-Fu8hYEw-1 X-Mimecast-MFC-AGG-ID: hkUL5MzbNamN9V-Fu8hYEw_1744835210 Received: by mail-io1-f69.google.com with SMTP id ca18e2360f4ac-8614a8474f6so733239f.3 for ; Wed, 16 Apr 2025 13:26:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744835210; x=1745440010; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d6AVDplNPTi289CSbOZ9ARQJAN0z0vy8/1A9VIws9D4=; b=UVdeG8z5V12ctERGHIAxVGx2TCrd0YqWdCML56xvsmXOZe/Zl043XVBZwNC363XdmT EJSnoBYuiokfkfyq4OO1/Ba2Ow9GEKzx5w5CAV6wJa98MvMMTrWvS+xmd1aJ8z9EyfYH RSXnDDS/SEaLkQ+wpF4nQGpYT5czZBk9E30obUgpVMKn00TA/r7mmyDb1VBiYk+zlh4P MFMHfxVL4oenmLKzdq35keEDL/u6dyQIMHh8NcMbOqXCq0zqbnY8IphHp0SV7hLKwQR/ HAc8m03yff/EaxLrg7OlnKjckVgeBuo+gjA1bDrUbAnl8mdwWIEY4TYxNGnV6UD/gVHo czrA== X-Forwarded-Encrypted: i=1; AJvYcCUjsscoC2qaWpqFGrVz9UMRMCPgldnTVJSZIjpgMudyTz6FJ7hEpr38IYCGHans7Q03pbaHEMRPSQ==@kvack.org X-Gm-Message-State: AOJu0YwgqoQfWaR//1l5jQJy/6G4CbGJqWir2P/NELZI7HZ5oqCSjgCd XAjNkb3slQivrTXyiDbiXeUwB0KeF8yXJkwm5o2p7fiTbD5/OGCAdbZxOZPDHsj7DcChk0fRDPI MvIIgzl1XWmPxMIM6AeLP/6k7LdkDPCrwB4nZMzEhzTVpFK6x X-Gm-Gg: ASbGncven2ZABOQx5Lgk/OG8FlNNHcPmHWs7fAYoXfWagRWfAzzM/j8ZUrsSU2Y6HBK tGiH5vOt339dCJvbQw18aLmX7Ee6HBMN77Y7EcpxVPRIUOE2dbCnIcG69SpeHz4WaZ18CVMEvsg ITaE+5iF73QiVohwLPvW8kiEVGpMuKVd3Voexy8u35ljinzuxtr5q/3WGndepSHBveAVVhGm5l1 OP3oYtx4By8dLlth+p9FuhDd9XjunPhC2qgBYo1awB/PMhx7qjn1H1KYY30brWp3tleNaJI81qA Lev/1+tT2JYWTs8= X-Received: by 2002:a05:6602:1583:b0:856:2a52:ea02 with SMTP id ca18e2360f4ac-861cc5cfb48mr34534039f.5.1744835209679; Wed, 16 Apr 2025 13:26:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHdbc3yXRCu1SxHof01X2wIaipkMkSkrZJncD3XrTLmdj2ulJ1ktFsxzmI+33GyeGFuM7i9VQ== X-Received: by 2002:a05:6602:1583:b0:856:2a52:ea02 with SMTP id ca18e2360f4ac-861cc5cfb48mr34532239f.5.1744835209342; Wed, 16 Apr 2025 13:26:49 -0700 (PDT) Received: from redhat.com ([38.15.36.11]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-8616522d048sm306863539f.1.2025.04.16.13.26.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 13:26:48 -0700 (PDT) Date: Wed, 16 Apr 2025 14:26:45 -0600 From: Alex Williamson To: Salvatore Bonaccorso Cc: David Howells , Christoph Hellwig , David Hildenbrand , Lorenzo Stoakes , Andrew Morton , Jens Axboe , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , Sasha Levin , Greg Kroah-Hartman , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, regressions@lists.linux.dev, table@vger.kernel.org, Bernd Rinn , Karri =?UTF-8?B?SMOkbcOkbMOkaW5lbg==?= , Milan Broz , Cameron Davidson , Markus Subject: Re: [regression 6.1.y] Regression from 476c1dfefab8 ("mm: Don't pin ZERO_PAGE in pin_user_pages()") with pci-passthrough for both KVM VMs and booting in xen DomU Message-ID: <20250416142645.4392a644.alex.williamson@redhat.com> In-Reply-To: References: X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: UJh2_ObePq4Z_MtIPOb_nAJTSgXVDp6EwwotRzgnQH4_1744835210 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 088AF80006 X-Stat-Signature: 4wf7sxg58abfysw1rqek88i6rks5ro48 X-HE-Tag: 1744835212-578424 X-HE-Meta: U2FsdGVkX19C6Mv98uHhOgY4Evca0OYnl9NUDfL+H34TwC+I/bqJu6Vop6ZVJl/IzRM0gdLXm6TUSgQGSsiSyp93xCEwKPrwJ9H3+rNs7fH1j5RFGlCSVIgCvp0zGd2j4QVGFTl3xHlscNuC2haEL4lls2in1Nh9ZevNxbTK+lR7CrY7fQN03vFQbXSwBlGQApMiVLpTTedemZGubJ2j2HrO3/cYb/YSR7aObNtW+mrcT3Jfs3egiRU3kWu0v6VR+/J2DAMC9Uk6UmAdgVRKxXD14BvmZvIUewDyVwWOYZ0F7NZQRpotfQmDsCxPzdOcB0AAbMLxa0miSDQb44kR+5MadF46M0U7Y6p6mq/315McDMR1wD9ph9WneiTjCD6CYXTRdNfaNLvRiJs0Bwq0vu+hnSp5UnPZow5PQvaSrfQJsZFhfpV3Uufrh/tThayxRinVANAqDKB961Svl3ydeU0x424daKrjtzJumNYmlKR82s3PUjIKuqsI5TchxchtCFe0DqjCixWL10iEFGJuQxVQ+Tq7tWqkFUR6KZn4E8W18kFLp4VqusRjSE+guo8b9kW9v4il/YAkh9OWQeTHO74QEdF9GSfiAEJ75xQXyCgVW921cKIp7uQbe2K2OqHYAYX0p0ut6DPlQf/OFTEe0wNwIQP8aYx2zKPA7GuIWZ3l68NNfOwUVW6Ge3TQ6TWP05bfqhYzdx/kMNmtwDvSNWt0IkCAo4DuuyIgcyttGHwtVfRzw09sRWlfIhxIaK/AwRrXnSmF0/9w5+uVq93g4uAjz0jS/ABE5ne8WXsHrPfTu5LEvniDm+5HOKvrqAbb+BogKikicKmVbj8Im23PlXejeFo4o7feH4iSV7cEpqpt8qBf1oyrpyR5NK/LEqnspM6lWUscApiS1PKehBrdz9lFOV9cVtyRWJ8+YxzaNHi0ZfdKZNasuazB+QXp+L8yaiAW3xMfytoB2llGRL+ jbDaWzIj XOa080wskXLvfIvOfQPhYvkMwcOv4ZcRrWqcBEcCD6AgTNA0bYrmBQXxTAjnvLumoFwEnFQ4ntFWFDAxsFfpnXbkqtrtDpjuRhcGIhn8ULLxbB5u5+z663yv8uMPmqskXHqKC+I1BNpTRsgVAD3jaTPdIbyeZhG8dTeXQSNUXQRNyiB/uvOoLExiqEgQLmzerm/8/2Qv2HDf0pqqtW+rcpeyRLJLWzE7CpPJW1avs61P3JUSg6qPVP9vLS2OWuoIz4WyMOKoXoSk7h5ab8DFLe04Y3Q4NvssyVDcgpxP7eXPd0A042FgxiHzdkkkYJhoalcb1iGYZyN9yEdJlaCfIVW9KNM6185kvUR00URbjNmpLtlQN0XHPUhLb9yfJB/AGD7RstT758jvKElVPm2Cls/hjSxF/k3Eeh2AVlIaTN6YJd2f83yZh8l3hvUDaHc8LXlqva8S+TZoIisEMbRUQVmkskg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 15 Apr 2025 20:59:19 +0200 Salvatore Bonaccorso wrote: > Hi > > [Apologies if this has been reported already but I have not found an > already filled corresponding report] > > After updating from the 6.1.129 based version to 6.1.133, various > users have reported that their VMs do not boot anymore up (both KVM > and under Xen) if pci-passthrough is involved. The reports are at: > > https://bugs.debian.org/1102889 > https://bugs.debian.org/1102914 > https://bugs.debian.org/1103153 > > Milan Broz bisected the issues and found that the commit introducing > the problems can be tracked down to backport of c8070b787519 ("mm: > Don't pin ZERO_PAGE in pin_user_pages()") from 6.5-rc1 which got > backported as 476c1dfefab8 ("mm: Don't pin ZERO_PAGE in > pin_user_pages()") in 6.1.130. See https://bugs.debian.org/1102914#60 > > #regzbot introduced: 476c1dfefab8b98ae9c3e3ad283c2ac10d30c774 > > 476c1dfefab8b98ae9c3e3ad283c2ac10d30c774 is the first bad commit > commit 476c1dfefab8b98ae9c3e3ad283c2ac10d30c774 > Author: David Howells > Date: Fri May 26 22:41:40 2023 +0100 > > mm: Don't pin ZERO_PAGE in pin_user_pages() > > [ Upstream commit c8070b78751955e59b42457b974bea4a4fe00187 ] It's a bad backport, I've debugged and posted the fix for stable here: https://lore.kernel.org/all/20250416202441.3911142-1-alex.williamson@redhat.com/ Thanks, Alex