From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47272C369AB for ; Wed, 16 Apr 2025 02:02:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ABDC16B0026; Tue, 15 Apr 2025 22:02:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A6C646B0027; Tue, 15 Apr 2025 22:02:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90C036B0028; Tue, 15 Apr 2025 22:02:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 723816B0026 for ; Tue, 15 Apr 2025 22:02:16 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CC67B5FD64 for ; Wed, 16 Apr 2025 02:02:17 +0000 (UTC) X-FDA: 83338257114.13.D0948CE Received: from fossa.ash.relay.mailchannels.net (fossa.ash.relay.mailchannels.net [23.83.222.62]) by imf15.hostedemail.com (Postfix) with ESMTP id 6C602A0003 for ; Wed, 16 Apr 2025 02:02:15 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=CQPJelMk; dmarc=none; spf=pass (imf15.hostedemail.com: domain of dave@stgolabs.net designates 23.83.222.62 as permitted sender) smtp.mailfrom=dave@stgolabs.net; arc=pass ("mailchannels.net:s=arc-2022:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1744768935; a=rsa-sha256; cv=pass; b=5rY3CGa7c/dlzJxo8fWLtkv7EUrHuqvaROxa0zWdoIFhgAL0kOVE7Lg36uCDixQ0HzkLLy a5Quo5zS8Yj6YzPwvAoksjkGcMHkEouJvSTC671Rk2UKt9377enZP4gVAVL2mF0P5cfKjr Xee/b9NPVE/eIkYqw4pwcUKwrs+M0Z4= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744768935; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EgFwQezJYypIPTLjbAO7+wgBDKuxG1DACqpgT5oKBE4=; b=chcjx0b8kAdIGr5mm8IPYJIbch6G9NViJwGmkE9q6p1Hq2Ayh6nDI35liyNM0cI4KswGPo LyPlS7qVBNrkhSXvbh3+Nrwgou0wr7fuLjZ+IEUcPNMoyH8FZFFAgDZiU+HhL/wZL1362P R2NT7OX6QyBRBctAdZ6Gy+o73/C8po0= ARC-Authentication-Results: i=2; imf15.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=CQPJelMk; dmarc=none; spf=pass (imf15.hostedemail.com: domain of dave@stgolabs.net designates 23.83.222.62 as permitted sender) smtp.mailfrom=dave@stgolabs.net; arc=pass ("mailchannels.net:s=arc-2022:i=1") X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 8FCA8458B5; Wed, 16 Apr 2025 02:02:13 +0000 (UTC) Received: from pdx1-sub0-mail-a270.dreamhost.com (trex-6.trex.outbound.svc.cluster.local [100.110.51.53]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id E44A645942; Wed, 16 Apr 2025 02:02:12 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1744768933; a=rsa-sha256; cv=none; b=ShPKZgvbJsioWDJ6zr+jN3RuXQx3pXzihIoxXcdZaSyjN9R5n1ACCkvuyN7X1ynEKwIIGY R8GLEc4WHPGi2YxHjgspbU56rRPhzKKeMOhaS3HOIxlSSTIWWXJmDKgW6g8jueiTB+5MOS 0b5be/c6VN4uAVl8LeDqWz9iTfaOK8HP39Wn4J0ZhH10leg8DbSoew4l5g5Xxgfe9b1hhv w+nIn0fb8z9cV6LnelyJ2Sr1Q4CAaxrL7Qn4i3hjNw/0+AmXAnmCZ7M7t6UAp7HmTrGpma ogtNCT/bxQXwq+HYkQZ0VY8t4ro3prNAHPfWKpOvwLo+hIyWNNiXI/xr87ARPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1744768933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EgFwQezJYypIPTLjbAO7+wgBDKuxG1DACqpgT5oKBE4=; b=w1Vi/dc5LKt/pF3kalouhzHVe1gKlaQAefi7r4+A6nPgdr/Vcv+OEFNcFeVZprLl10Ehmk xxG41EPehHgismJsEC2a4EyNj8TaSN46COqL6jgv4uvnxKkTxn3mN4z/Pgb41dnmq19u5E hv1PDrdutvORtuSdzhIxjeXkCivOD17/tQd0BWsgk73Ys9RBPaX+74hfz0bj0RvO93ZwW7 0Fpzja0Vz8YGHS4C8xHLWbJ+IEsUl/7njEELgFasx0YpUETwi63Fk2RDr1I5cvMtmJbA1n v5+O4LWQ3bE8rHAcSqL1Fm/W5NVFSDPCri4/wcG66b68BWgtjhaA8jvKAk+tgQ== ARC-Authentication-Results: i=1; rspamd-5dd7f8b4cd-2pb8p; auth=pass smtp.auth=dreamhost smtp.mailfrom=dave@stgolabs.net X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|dave@stgolabs.net X-MailChannels-Auth-Id: dreamhost X-Spot-Thread: 23261b3b7b19990f_1744768933328_4128009771 X-MC-Loop-Signature: 1744768933328:3434343757 X-MC-Ingress-Time: 1744768933328 Received: from pdx1-sub0-mail-a270.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.110.51.53 (trex/7.0.3); Wed, 16 Apr 2025 02:02:13 +0000 Received: from offworld (ip72-199-50-187.sd.sd.cox.net [72.199.50.187]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dave@stgolabs.net) by pdx1-sub0-mail-a270.dreamhost.com (Postfix) with ESMTPSA id 4Zckmg3Gr7z2c; Tue, 15 Apr 2025 19:02:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stgolabs.net; s=dreamhost; t=1744768932; bh=EgFwQezJYypIPTLjbAO7+wgBDKuxG1DACqpgT5oKBE4=; h=Date:From:To:Cc:Subject:Content-Type; b=CQPJelMkHR9c9PwOQz1qB9oLMoQ0ijerkO/7sTliU3wShQdMiumwtZeUz8qKG4hQH P/+Ba9DrECHulLQADswnJQAn7N7p6JgJOjhObbZsvwzjl1ctJj9h4ZCrzAkqDRFUXu p0S045L32lw1PwuZUJqHayjEwt1ltr9Rp+CEuY1ayAOdHWv190+04JcmqhwNHhuIhK 0/2MpjusbdsgGViBxeOeRKPuszsMvIgUOy21txdcZrW66eV/RDnRe9TOYDbaf6ZziO fxFGoIfQeyeU/EDzaCZ+mmP69qqdonxNJRnFc4V8OBjj/3+x97Y7HdQmSxM8hXxUi1 VFDZD9KTPnAzw== Date: Tue, 15 Apr 2025 19:02:07 -0700 From: Davidlohr Bueso To: Luis Chamberlain Cc: Jan Kara , Christian Brauner , tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, riel@surriel.com, willy@infradead.org, hannes@cmpxchg.org, oliver.sang@intel.com, david@redhat.com, axboe@kernel.dk, hare@suse.de, david@fromorbit.com, djwong@kernel.org, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, syzbot+f3c6fda1297c748a7076@syzkaller.appspotmail.com Subject: Re: [PATCH v2 1/8] migrate: fix skipping metadata buffer heads on migration Message-ID: <20250415232501.iypezdhizhttidpc@offworld> Mail-Followup-To: Luis Chamberlain , Jan Kara , Christian Brauner , tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, riel@surriel.com, willy@infradead.org, hannes@cmpxchg.org, oliver.sang@intel.com, david@redhat.com, axboe@kernel.dk, hare@suse.de, david@fromorbit.com, djwong@kernel.org, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, syzbot+f3c6fda1297c748a7076@syzkaller.appspotmail.com References: <20250410014945.2140781-1-mcgrof@kernel.org> <20250410014945.2140781-2-mcgrof@kernel.org> <20250415-freihalten-tausend-a9791b9c3a03@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20220429 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6C602A0003 X-Stat-Signature: szin7nq9mx7ch9yhqwkg1ccka5y75hfa X-Rspam-User: X-HE-Tag: 1744768935-227212 X-HE-Meta: U2FsdGVkX18NPCN/7CZDd0vfZw85uzZqXbdohOaIccNf5O+4R8wRQA6bV8Cyor8F04Qe6kqm07dt1EtQWFSR3TqZ94cLvuqa6dQvpFSj3sn60OieI7UHCt/PpnYid6Kt0dnPKfTFlFA5g4KAlGHx8ibsA9GjMeai/AKGO2WRXNg/QjBP7f8WIEIVek5I1NiqrCXYGCNiOKvupaPThlJMBKU2FuEAii67LJ2iJnEWSwVcuBp+v+l4PmkjS+HAa12y8lzGmpohztxFreF/q4zeC3xDzJmLMpGmgvFypLnePdyuQ/+eyNnit7Jp+/vPPttQT0SBy88C4dZeEjLHfSYRsPbE7Ch8Tvih6J0u1N3lt5YjzfdjFZ/rz5uE4iAQmgRTCY7fRp+ZsU9pjmStGKvS4nc5AQEKGBXZrNppLvx6MnHXGKUzxKt6YMyl/WWIF9wJ/o1HOq04odcMMctSLoTAXGXbvESbVPDANdfk+IllNND5Y2Xwh59FMv83Gvz7wMYJU4/R5p7240ECF5FkEw/GOSOIUIWNA1IUWvzTWn7PArpOwi7bY7j1svVr7Hrv8GJfT6bNJsDGbymZh/bEU1noHchD8SHf94blMr8aE+i9I4PmQjY7AdbPs1BSXigtwnjK748V8IsyjD6N6XD+Y92vlMGYjmHkoueAKQKXy+ZYh3oMYRplm7/OHgW+GT9ZBOJnTr84iK6TVuG2br6m4mOjOkMgOR6wvyc0zFRz52Xa6udimcDP9UtlvJP0kuaw3oHVrGGIr6qm95pob/TlyGFqq6+7tl8o9Xz7D+9UFoXOifiN3yVcceoHsR/4t5O3rr8H/PyIgeRMg1dwFy9y/B63COnyIn6+BQIyhifbf/2JhM4qALJSCIpbCaEkrat/wFZGyH5YQEnYcUih5SJU8kL8MLn2CH84QS/flznB86P10lp8MJGBf51Xj9q7I3aRq9vMJY/r0haNyeOej+6nJuI YR5Xnpyi uWMGgbRvJx0LjhR2Gkl93FxxcTXa4wh/WK65wUjYHDbmR94g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.006717, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 15 Apr 2025, Luis Chamberlain wrote: >On Tue, Apr 15, 2025 at 06:23:54PM +0200, Jan Kara wrote: >> So I don't like removing that commit because it makes a >> "reproducible with a heavy stress test" problem become a "reproduced by >> real world workloads" problem. > >So how about just patch 2 and 8 in this series, with the spin lock >removal happening on the last patch for Linus tree? fyi I sent out a new series (trimmed some recipients), addressing the concerns laid out in this approach. https://lore.kernel.org/all/20250415231635.83960-1-dave@stgolabs.net/ Similar to adding artificial delays to a vanilla kernel, the only behavior these modifications cause is a quicker triggering of the aforementioned (yet independent) ext4 warning splat/corruption.