From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17FECC369AB for ; Tue, 15 Apr 2025 18:14:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 062456B01A1; Tue, 15 Apr 2025 14:14:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 011BB6B01A2; Tue, 15 Apr 2025 14:14:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D7F8B6B01A3; Tue, 15 Apr 2025 14:14:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B3EE46B01A1 for ; Tue, 15 Apr 2025 14:14:18 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A3E64141840 for ; Tue, 15 Apr 2025 18:14:19 +0000 (UTC) X-FDA: 83337077838.14.D9FC139 Received: from heron.birch.relay.mailchannels.net (heron.birch.relay.mailchannels.net [23.83.209.82]) by imf26.hostedemail.com (Postfix) with ESMTP id 2AF8514000C for ; Tue, 15 Apr 2025 18:14:16 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=G4q6bk1o; spf=pass (imf26.hostedemail.com: domain of dave@stgolabs.net designates 23.83.209.82 as permitted sender) smtp.mailfrom=dave@stgolabs.net; dmarc=none; arc=pass ("mailchannels.net:s=arc-2022:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744740857; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bqPyP70PEWYuCJ6mlcNc67gGfoPR1cUIZVFQBbY62vk=; b=xp5hTUB8TqeO9ZHCJUPT7r5fsktXQGfQJ4vpnRc81wK3h+8I28Bqbh8tRW8W3a4GjYcPzr Ma0uWPsLS9d51dL1Yx+kZqCsq6RdJbGEW3gf06oBnK3pkze27Wk9Hes8tJDs4iCK5NQTsk OU65W+C2N2YLIpHT4er9rHE/0Bt/sjk= ARC-Authentication-Results: i=2; imf26.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=G4q6bk1o; spf=pass (imf26.hostedemail.com: domain of dave@stgolabs.net designates 23.83.209.82 as permitted sender) smtp.mailfrom=dave@stgolabs.net; dmarc=none; arc=pass ("mailchannels.net:s=arc-2022:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1744740857; a=rsa-sha256; cv=pass; b=WSnBE6acplcIimu5CzZWV72yAi0ueYN7I/jqmahGt8vZy3Hjf6ggDGy+TITkYiaslV60TD Gl7KajVcaRjXoVHZCUtzgbrw7fALZjL2N8fhLDB3CXwnxLfM0fmrw4x0aX7t7rAs0mLyT6 AA/bM2aEhy0sLkFaBffkqQBv9Ah/T38= X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id BDA8D8A5406; Tue, 15 Apr 2025 18:14:15 +0000 (UTC) Received: from pdx1-sub0-mail-a279.dreamhost.com (100-110-114-166.trex-nlb.outbound.svc.cluster.local [100.110.114.166]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id A255A8A5D6F; Tue, 15 Apr 2025 18:14:14 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1744740855; a=rsa-sha256; cv=none; b=rkt5r0vZEQJ5SC5pH+p56jwbff5PHkchL641YfF5zY4myfshefBqFCcxyNAnOEVIQppNfx W8xnG6Op3/4JXDstAswcDJCJ/HdhoHyFMgRo2qqQ1JEiC+hwTeNyKm23WISfpKTKWE2gDS lc6EolQr0+wEbctjUNqxCImE8q1hV2yJK5Hb2arnulSVJ7wrtdFesxATmRvIjr4ZJ3dkSJ 8uUz8uFuHQfsWlpTFHuTMyneccJBg/2nZqV16PrkkwcfyFj/i8Sx17Dh21TY/puTtSfePd mNE9XQxsLQ0sVQelYWYh4o2aQFQxuQJje+dfoN94kAbdDGC7V/YN3SiFv9B7/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1744740855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bqPyP70PEWYuCJ6mlcNc67gGfoPR1cUIZVFQBbY62vk=; b=4py5Z77tpQMIkf0HN8tDSaA2mZazeLffSWythqK+dEKT1n+Ea5zoIfUBFyjUwE3IBwM93b dV1hmtAE/JIShWRYDVQfZyyphf77vD8lRKry9yrjjWLtsAd5EeY3rl0ZMBS37QkfiLBTx1 HMAyN7dhi6F5BKmy7Oh4MDy3w0Onq3i0qf5n3umxioe2RNnTlXGHJyuopQYaDPE7SP7GId 7twuseHwyIO0tm0UgJJW8t4ISPSWWfXz+jNlxTs3WsXHMyPDPLEJuTiyKQnhD3231tpwdv o8PoY0OoI++YIhUknkjMWKtLBfCyNCj+DbVHNdwLLVtrOcGbvHEQv9P2SyWZWA== ARC-Authentication-Results: i=1; rspamd-5dd7f8b4cd-9lwvj; auth=pass smtp.auth=dreamhost smtp.mailfrom=dave@stgolabs.net X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|dave@stgolabs.net X-MailChannels-Auth-Id: dreamhost X-Whistle-Ruddy: 20c0a1780448f057_1744740855404_3157517117 X-MC-Loop-Signature: 1744740855404:2507718386 X-MC-Ingress-Time: 1744740855403 Received: from pdx1-sub0-mail-a279.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.110.114.166 (trex/7.0.3); Tue, 15 Apr 2025 18:14:15 +0000 Received: from offworld (ip72-199-50-187.sd.sd.cox.net [72.199.50.187]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dave@stgolabs.net) by pdx1-sub0-mail-a279.dreamhost.com (Postfix) with ESMTPSA id 4ZcXNj26v2zJB; Tue, 15 Apr 2025 11:14:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stgolabs.net; s=dreamhost; t=1744740854; bh=bqPyP70PEWYuCJ6mlcNc67gGfoPR1cUIZVFQBbY62vk=; h=Date:From:To:Cc:Subject:Content-Type; b=G4q6bk1oZJ4IbXrRbZv0DiKjppGGnWDbh0B6C8i1Po1oLU2A4Qe8htuO1ob0chAOy nY56dU4ysVjX/YoK5elTTDcx5cLWSCjDvXQvvr9JbCTJunVrRfZG/kz7QKaqhXzBdA UEnvnGFsO4KsatO1DV9k2HqWUOy/0RHN2aoU6rnNSSNIJR5QvRJC/ScdSpq/qF+55s IHmYRN+vFHi6xWvMSDGRdAxqy9fYAGZaEx0hU9Z/nFCWKcnXM6Rio5tmHdOiNQ+4so 6ddPVbSHhJIZV55t62WCru9PvzJHwyLXS484xEzHSjxiypwFQCuP53pZYvnyVC1NY4 w9HA9WErc7h+w== Date: Tue, 15 Apr 2025 11:14:09 -0700 From: Davidlohr Bueso To: Jan Kara Cc: Luis Chamberlain , brauner@kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, riel@surriel.com, willy@infradead.org, hannes@cmpxchg.org, oliver.sang@intel.com, david@redhat.com, axboe@kernel.dk, hare@suse.de, david@fromorbit.com, djwong@kernel.org, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, syzbot+f3c6fda1297c748a7076@syzkaller.appspotmail.com Subject: Re: [PATCH v2 1/8] migrate: fix skipping metadata buffer heads on migration Message-ID: <20250415181409.eqkichqm4dddq4z4@offworld> Mail-Followup-To: Jan Kara , Luis Chamberlain , brauner@kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, riel@surriel.com, willy@infradead.org, hannes@cmpxchg.org, oliver.sang@intel.com, david@redhat.com, axboe@kernel.dk, hare@suse.de, david@fromorbit.com, djwong@kernel.org, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, syzbot+f3c6fda1297c748a7076@syzkaller.appspotmail.com References: <20250410014945.2140781-1-mcgrof@kernel.org> <20250410014945.2140781-2-mcgrof@kernel.org> <20250415013641.f2ppw6wov4kn4wq2@offworld> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20220429 X-Stat-Signature: yu9rwzrujnfrwgix5d1ns6dskt5hmdtx X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 2AF8514000C X-Rspam-User: X-HE-Tag: 1744740856-260228 X-HE-Meta: U2FsdGVkX19P6XHCTUeyTozwLq4vj4nS4qFNsrkM9Yx5jVLMhxtBoL5b2TxEnAlN/uLkkQZf9cBxIBtE8SSSm0Vo6D4wKlOnelRrLzbvkHKfJbzdFKclvlPBSkXelgj+13UGXKlSVTR/QO06iBF7GHyxmkRo3gnYcZlMr3Yeyazxqm+mtMQyXWu9rdJeinlC+HvW8DbWEGgflGHJInm/UPlYLSY/8N4z6zNc7WVDBEJq8An5PuSHuBoJaTupZzMXxPdcLOE54+z8dK+lTOut2kAi9Rd3ZDpfmtYDu9MudbWblZsz/V8pK9n2C6GpVfkuSnJ3Q6ACD/xRgLaVW/b/XFC6ShGnAt0g1r8WPhpLvbmWULa3UWLLJCYZqkNjdyYpZL7l0De0bMa4iXmau7Xk9Oe2CeyWlO3GafEHvjbtyem+E9ZivAVBniPyIkmf/baq1PeoisstD2KUC/jHx8YElQK2b7IrV/3GOymiMrQ57YdVD7M/kkQLZOi/0PFo3xomrDpfAcKvI23eudhAnfY1R6GLIie9jHu58nrOt4Z/gQfkW1gVFnH+ww1vyzbTsoSQzsLaZAkhT4m1jLpCoNWixhN8dhgs+UHWrWrnx3iDv96fJSnYaooNhssN3CgxWvTHwKVMvIp0wlcPangrKoy7OLrd7VDrrSQtL1jodFdajNv/KVfLK24/GVMyIyQbrqTwZiOZvMTNh5VotOgz126f0FxkdWTOKqDYXA2O52r6H6DOU1vM1m5fUuhSexuULN91JlXy1SEUHzGCYMd/3Vii3V+LpXuw4hdLR+UdTAa2d/YDK3aQkCydl7ookxCfLorvWpzlyL973AJWZAH937NWG7AidzR+o1JG7Imyp7sGD0CVPnfK3IYjo7Mv9kSuN9qnkaCgQ8QTTNIzIisruG4OMV00GLWgb0b/6KgmUSVzsDwMhaYfHThzdmL5eupUBZk+X6SPlrRxYix+tK0OQCr 7Xrua179 MXqjDLaEJYREE0FepUxyc2YJ+froJKgixs/FGKgFaO7qmAcg+kPqfSOlbkNM01FPQ3Mmw3cYWoklU/30iygcD0nQGzRY+r7Vl/30GXtreIPKiSsG3ngbnz4ht/eGTxke8wWN1On6RuuVuRYSFSxA1JHjFytrxGRNZeT/t+4B3vR6bbZmSnGUsM+sY4jj/RDzC8Jy67FGp7FYW8nlvaq5w3Tc0F/juabps7azvgo2p1a8zLnFSCf08g/ZojKpHOWdc88sQwWLFaANRmtbTSkDrvzQpSIUS6Fg62WeJegP6yCoSxu4jZPX9U45ApAzkkXMjjkyU2DUmvpub41DVywl7aEl1gszsc/R7ZCuT/gTtKnmE5TtFFKDiv9llREW/9ZHw/56vLikcqFHf87E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001412, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 15 Apr 2025, Jan Kara wrote: >On Mon 14-04-25 18:36:41, Davidlohr Bueso wrote: >> On Wed, 09 Apr 2025, Luis Chamberlain wrote: >> >> > corruption can still happen even with the spin lock held. A test was >> > done using vanilla Linux and adding a udelay(2000) right before we >> > spin_lock(&bd_mapping->i_private_lock) on __find_get_block_slow() and >> > we can reproduce the same exact filesystem corruption issues as observed >> > without the spinlock with generic/750 [1]. >> >> fyi I was actually able to trigger this on a vanilla 6.15-rc1 kernel, >> not even having to add the artificial delay. > >OK, so this is using generic/750, isn't it? How long did you have to run it >to trigger this? Because I've never seen this tripping... Correct, generic/750. It triggered after 90+ hrs running.