From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FFA9C369AB for ; Tue, 15 Apr 2025 15:41:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 91D5F280058; Tue, 15 Apr 2025 11:41:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8CBAA280024; Tue, 15 Apr 2025 11:41:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BC40280058; Tue, 15 Apr 2025 11:41:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5EB15280024 for ; Tue, 15 Apr 2025 11:41:53 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 37C1C1412B4 for ; Tue, 15 Apr 2025 15:41:53 +0000 (UTC) X-FDA: 83336693706.14.5DFD58E Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf06.hostedemail.com (Postfix) with ESMTP id D373A18000D for ; Tue, 15 Apr 2025 15:41:50 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744731711; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hz+DNPpqhsmr1/UiGHY5qWnERyEjNPS4SzWawxzvnzo=; b=XQTNULXWiJLjIvKhO8QmX1nYHjaewsYeuFf7xgi0iJ6HuGjTm2JBb8cDx8SeaMMIAsD942 H68l21ef7Oezn5Wf69j1+YQaDONWXE2gA3SGZ4icCFFCAuHueP5DW6QiYsOWXL279+Hvt/ UqY4CX5in1BHrE8ueeYLROkmLcKUA6U= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744731711; a=rsa-sha256; cv=none; b=KKj2if4fqIMTZZOTD/LIWGmnxyPcppnILzdi+1Dp3T9WyT6w62hYEnwCGNpwpr4XyxGF4p SOB3jL2AyS9wv0FYHyy8dUvh9A/IwjHUaii/zYWcA6H3y77Sa6tbbyCVoR5Bo4wMq/SLX2 qH7MgQD3MtovQ8hJjYPLUSjWN+PbxpI= Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4ZcSzJ6jVTz6FGWg; Tue, 15 Apr 2025 23:40:28 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 40710140144; Tue, 15 Apr 2025 23:41:47 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 15 Apr 2025 17:41:46 +0200 Date: Tue, 15 Apr 2025 16:41:45 +0100 From: Jonathan Cameron To: Rakie Kim CC: , , , , , , , , , , , , Subject: Re: [PATCH v7 1/3] mm/mempolicy: Fix memory leaks in weighted interleave sysfs Message-ID: <20250415164145.00005b6f@huawei.com> In-Reply-To: <20250408073243.488-2-rakie.kim@sk.com> References: <20250408073243.488-1-rakie.kim@sk.com> <20250408073243.488-2-rakie.kim@sk.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To frapeml500008.china.huawei.com (7.182.85.71) X-Stat-Signature: 1i6kf8qx4brnn7fhbofx98pdt8sanmb1 X-Rspamd-Queue-Id: D373A18000D X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1744731710-489617 X-HE-Meta: U2FsdGVkX18+4wyk9ArazlgcDgmXPb+y7UFswrQSi9TUpjx5yoUw5wf33ed8OjNiyZJ9QRx3a2hIw+emopBIWNGUBbi3/sXaoR60aM6lqOW7bkCJHENUVMRjeZplji0dsx6oAtDGRMRz0RwMzNy7FWFMWIohG/lT6+RV6YSTiB9cVzg0WoAe+um6qvNMYU7ki16WtPUnwpQN62bfFLZ4qmthieYaNpC2Oi4MlXOuEUnxB7jX4Vw5SX8e72vzs6/Uf/uvafUxXKpd1hPTuYu8xS8u90hfhiLATg+HmTK5zB9BtIeIRbeCxgeu9x4RWF5A1GlcMavIq/BM0A7+c+M6Wv4kUNIVJOV/OkL9BNXGisVXgyngXD0qOKbWyv7gdsmb9SbcN5nix+H8MCZWOqjaJ/boxnNeDQQNOJTSkU87a8FlhU7ASAi6dFptConaoVFnzcw0ZMhbBS68l6qYssSa9IdTI0/GeD6daxfu046zmWPQ0NzTACRQbfj2K1MIByl6v513rSbACtVJuv3bJ3oAnnCkfoq2PnH3q7oFoKWfI0+WryvXiQA4OTLQJFXcWEfn029VPs++UWCn+OlXJpMIlALelt6bgM1KpnKA7Qd7VJejpXFTBmrz+5aYBALa8yTj0JKN2wdS71TwppAmiheZEnHM2V5q9NaplpsLk1Dlgcf7itD12lYbcIoUkTIEh7Rnc75am27d7umgYSZ/hHJUnIc079Sa2CMDX2OqviB+BerSEfNq5K5CLQZrp5q0Asx5zl9ePhVR0hqUljNp737aOTfaNPpVuAoMuxPxtI+bsx66SDhbfeLAWT5z0CGmpzF+v6XjCjhUfsSeFQudqOXfYezUBdJ0YJc0M0Afg40oR+2dnrT5tm7lCezqMgiDS2Pn9j7iSvzYLJ+Fb04lyz3Qdv8KHX4cqLQ97nEIqkFifZGVbBBDUsreqk8VBZF+ZF/o5K/p8APs9Vu8EpOtqSK 0o5smMqj 8Hitya08QcmXolU19f3NLxpfKxYp/PqtTACYjJHdrHq5BOvquOBjfo1xg7eDL4kbCbEpJudkPHoF7xWYRCZEO7SbkW0erFOhpn5BhTEgWBCrEtlVO98MDgT7ifuEBv+Umrz4+BHGa9dD5OdVqeLQhJwJ9b1UFeufq38ou6kVuPIR/C20SsUWDVubByktVefOzjMZXf85LYc1bngZwetmqIdRWbvrAtxsm1U4J4T0e6HTZ3Cb1hIxSI19PvWVVMEbqCgoVUjLyS63OVRBooIFFC7H6cZyHqy/uKWaSziRDW2ORbQMXIpDIwlDfhGsGh39Y/BsnIIK1yIfzfLGo6UXekcwGFW0oQR98kS27cjmiA2vKBj4PRqpzqYPe0iqmuF+h+EG+vube8WyBbk8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 8 Apr 2025 16:32:40 +0900 Rakie Kim wrote: > Memory leaks occurred when removing sysfs attributes for weighted > interleave. Improper kobject deallocation led to unreleased memory > when initialization failed or when nodes were removed. > > This patch resolves the issue by replacing unnecessary `kfree()` > calls with proper `kobject_del()` and `kobject_put()` sequences, > ensuring correct teardown and preventing memory leaks. > > By explicitly calling `kobject_del()` before `kobject_put()`, > the release function is now invoked safely, and internal sysfs > state is correctly cleaned up. This guarantees that the memory > associated with the kobject is fully released and avoids > resource leaks, thereby improving system stability. > > Fixes: dce41f5ae253 ("mm/mempolicy: implement the sysfs-based weighted_interleave interface") > Signed-off-by: Rakie Kim > Signed-off-by: Honggyu Kim > Signed-off-by: Yunjeong Mun > Reviewed-by: Gregory Price LGTM Reviewed-by: Jonathan Cameron