From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0510BC369B2 for ; Tue, 15 Apr 2025 00:19:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E609E2800B3; Mon, 14 Apr 2025 20:19:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E0F142800B2; Mon, 14 Apr 2025 20:19:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D28C72800B3; Mon, 14 Apr 2025 20:19:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B48D52800B2 for ; Mon, 14 Apr 2025 20:19:40 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id AF36C1CA5C9 for ; Tue, 15 Apr 2025 00:19:40 +0000 (UTC) X-FDA: 83334369720.27.DFB2267 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf08.hostedemail.com (Postfix) with ESMTP id 4F67B16000C for ; Tue, 15 Apr 2025 00:19:39 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ANLISXgw; spf=pass (imf08.hostedemail.com: domain of sj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744676379; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xe14QJRaeEt1/m+o0CNE8glPHXrn1bJkxj1rw78r6Q0=; b=0QZaq1XAWxwWJtM1XbGyWCwE3/OqJIK7mWlFWOsSzAeEt8lrOkVkcDMwk7U5ayvJHF/dYG pCep8CLoYhiXWMAvO1ax3bCVMK3ynyBM9EkFsOXdS8uFfKAHy57CYKNYdLkhuX5CHGj7pZ 1pFhlpTfgSQosKwd8GRe8VFLI1PZdUg= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ANLISXgw; spf=pass (imf08.hostedemail.com: domain of sj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744676379; a=rsa-sha256; cv=none; b=Zn0bhpsMif4hnjqZjItHbcmj8brEAojFQE/o17NXJkaBJybW/W3sb19kdGUzkyI/H48cGU e/7tt0IGGFp7BFAnGzc+oowUhtQ31mACqKtCBRW39Kn3haabSyJgVCbK5E2fYZ0zxw3TgT UJxq0p/Mjq+zQvhd/gRt6gU1yGAGl0E= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 4D14661127; Tue, 15 Apr 2025 00:19:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0275C4CEE2; Tue, 15 Apr 2025 00:19:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744676378; bh=SOAAWgOv5lC97vDbfrXHcPgGTUP7cEcIHA2HIYurhQ0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ANLISXgwtSCcglkO1DGE7VKYyD/kC4KRqt7dvBx1Yivn2k285++cNRUpHk/9bYQEo kdky2T4TuD/24l+ZjLDU4+Ghvol6o4DsoFrW7KOFXPV2prGA+IMLWyEPxePFkaOMin c0dUC/r6Yw+f8iRRSj13aTLiwDw3XEAMR5SycLzg90/PNpRmTQVu7b+p2/145vGXyc dHJ7YdTCzuvkhHG/lBnTAkpyRt3mSuusv8j18rXd4+xzEh9momDLH9Gjps+KsTTQy7 7C/CBNnAOF2XtUkpzLolBtAX8ssapdpoKblfg3CkGSgUBPrDwoawQaY1aa93qMEsft yh1lQN7V+MiDg== From: SeongJae Park To: Gregory Price Cc: SeongJae Park , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, donettom@linux.ibm.com Subject: Re: [RFC PATCH v4 4/6] migrate: implement migrate_misplaced_folio_batch Date: Mon, 14 Apr 2025 17:19:35 -0700 Message-Id: <20250415001935.120888-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250411221111.493193-5-gourry@gourry.net> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4F67B16000C X-Stat-Signature: 6o9kqnhfzsn9w646sztqiho876kyzpcq X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1744676379-755590 X-HE-Meta: U2FsdGVkX18jWuAk0Tye0YjKj8RiUfSkkLHePBDez1okb0hcCvjV73+LcBBIIYAluupZErpGH88TEmDW5TgQRb6HQPRpNy5dwU9YjusuCYv97jetdnyD5lhhvRutsYloWLpz9E0m8BPPmApnvuKFFllOTqnal0cvdHIZ4MYPYST9Tf3xJkHOdQkWlK0tQou+NwqlPkXfRmpTCeqEG8+xmOuav9vgfZcRXplCJUc/1kkmaXDNwc9B0OhLKipAb2+2y8M6iuCFeFFzwiXqVIJLZegJXU6dxFfwbED0KczqSDEtvdt5/Geqx7noOOJPUvdnF3RuZBvRBuK2i5Sj0JC19w+/zVJaCmMHNUHAWgi2zSSSVrNTgTwc/l+dYHTrRH9a5rwpC97h6Ic1Xhf/WiUQWI3FADJhoo1cNoqnB1DphP608SI+I1QVewXM8noHaB28z/ow38AD4Nno5AvD02LcFg3Lnb48OU7fl4ryAxiiEnonQWI34wkBP6rhYXm5CUGRbYAC1tMwQ3r0dA7lJy9e9tqxY1rWvdbQUl2zeZs119Acz4UtiHkO32oTTu+jFZOoTo+JnmkhYa6a/WS3eL2agyHmEGYpkyGw2aLRlUeHz87WDU+W19a+rd25VUAGQs4IuvmwmekZfGtBNSungNU0AZlhgnDCPEcMbyw+6mvgwjSa4fpBB0OisI9WLoM6yZjeNNaHPZ0nfHJilDaRpwl/xgZz2U580tCqIkGqFyw0gpnNMmBw6fcLnQDDZLZ5Q+RscdkXbsTaZfdYppDKN2pFWkTZLgpp3U+R+6LT83Ohh3PTk5jNoJRUG7CB58sUUKyKibGk5sejjVkdTBpjJDhCx/+yh3ahm5/YApIp99JBDovE7w7pErpofa+t2A8IigUsZa/liit7G1bKp8IO0MojMHadqg/gAfhH1411CU0zEWPDOWRA6mkJWi7VJWYEj7opMkOMLQpSYIl9MYhkLSE TOdg34L4 gBzT8oOu9X6HUyOA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 11 Apr 2025 18:11:09 -0400 Gregory Price wrote: > A common operation in tiering is to migrate multiple pages at once. > The migrate_misplaced_folio function requires one call for each > individual folio. Expose a batch-variant of the same call for use > when doing batch migrations. > > Signed-off-by: Gregory Price > --- > include/linux/migrate.h | 6 ++++++ > mm/migrate.c | 31 +++++++++++++++++++++++++++++++ > 2 files changed, 37 insertions(+) > > diff --git a/include/linux/migrate.h b/include/linux/migrate.h > index 61899ec7a9a3..2df756128316 100644 > --- a/include/linux/migrate.h > +++ b/include/linux/migrate.h > @@ -145,6 +145,7 @@ const struct movable_operations *page_movable_ops(struct page *page) > int migrate_misplaced_folio_prepare(struct folio *folio, > struct vm_area_struct *vma, int node); > int migrate_misplaced_folio(struct folio *folio, int node); > +int migrate_misplaced_folio_batch(struct list_head *foliolist, int node); Nit. s/foliolist/folio_list/ ? The none-inline-definition of the function below calls the parameter folio_list, and I show more treewide usage of folio_list than foliolist. linux$ git grep foliolist | wc -l 4 linux$ git grep folio_list | wc -l 142 I wouldn't argue folio_list is the only one right name, but at least using same name on the declaration and the definition[s] would be nice in terms of consistency. > #else > static inline int migrate_misplaced_folio_prepare(struct folio *folio, > struct vm_area_struct *vma, int node) > @@ -155,6 +156,11 @@ static inline int migrate_misplaced_folio(struct folio *folio, int node) > { > return -EAGAIN; /* can't migrate now */ > } > +static inline int migrate_misplaced_folio_batch(struct list_head *foliolist, Ditto. > + int node) > +{ > + return -EAGAIN; /* can't migrate now */ > +} > #endif /* CONFIG_NUMA_BALANCING */ > > #ifdef CONFIG_MIGRATION > diff --git a/mm/migrate.c b/mm/migrate.c > index 047131f6c839..7e1ba6001596 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -2731,5 +2731,36 @@ int migrate_misplaced_folio(struct folio *folio, int node) > BUG_ON(!list_empty(&migratepages)); > return nr_remaining ? -EAGAIN : 0; > } > + > +/* > + * Batch variant of migrate_misplaced_folio. Attempts to migrate > + * a folio list to the specified destination. > + * > + * Caller is expected to have isolated the folios by calling > + * migrate_misplaced_folio_prepare(), which will result in an > + * elevated reference count on the folio. > + * > + * This function will un-isolate the folios, dereference them, and > + * remove them from the list before returning. > + */ > +int migrate_misplaced_folio_batch(struct list_head *folio_list, int node) > +{ > + pg_data_t *pgdat = NODE_DATA(node); > + unsigned int nr_succeeded; > + int nr_remaining; > + > + nr_remaining = migrate_pages(folio_list, alloc_misplaced_dst_folio, > + NULL, node, MIGRATE_ASYNC, > + MR_NUMA_MISPLACED, &nr_succeeded); > + if (nr_remaining) > + putback_movable_pages(folio_list); > + > + if (nr_succeeded) { > + count_vm_numa_events(NUMA_PAGE_MIGRATE, nr_succeeded); migrate_misplaced_folio() also counts memcg events and call mod_lruvec_state(), but this variant doesn't. Is this an intended difference? If so, could you please clarify the reason? > + mod_node_page_state(pgdat, PGPROMOTE_SUCCESS, nr_succeeded); > + } > + BUG_ON(!list_empty(folio_list)); > + return nr_remaining ? -EAGAIN : 0; > +} I feel some code here is duplicated from a part of migrate_misplaced_folio(). Can we deduplicate those? Maybe migrate_misplaced_folio() could be a wrapper of migrate_mispalced_folio_batch()? Thanks, SJ [...]