From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99399C369A2 for ; Mon, 14 Apr 2025 18:10:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B5ED4280071; Mon, 14 Apr 2025 14:10:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ABD9A28005A; Mon, 14 Apr 2025 14:10:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E9A5280071; Mon, 14 Apr 2025 14:10:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6750928005A for ; Mon, 14 Apr 2025 14:10:18 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6BE54C054A for ; Mon, 14 Apr 2025 18:10:19 +0000 (UTC) X-FDA: 83333438958.06.6086343 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) by imf12.hostedemail.com (Postfix) with ESMTP id 1B67C4001A for ; Mon, 14 Apr 2025 18:10:16 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=v96uBnnR; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf12.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.174 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744654217; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wmxLTZDlUtyhjPG3LKgyqC3m7MkeZf8KO7nU/7lCHDI=; b=o17rvWN2lnba8JANv5+bTWbCIrge5ICNPiJTOwpJX90GUVkg8dnjiZN8PhVn/iWqZ+yb9C 2SdFZSjdZ8ap6//SMV3D/OYxbOH/C/N1qLsnbVFYEKM9hWxFOkAcBA+trtGraZXKNjnV3G R5Yb9DI/0R9s8a6VAUuV07EEZK+DKXw= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=v96uBnnR; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf12.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.174 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744654217; a=rsa-sha256; cv=none; b=3hepqdgPBD1vHAGS60swwxCtW9WUrrvq31JxFDg0X9B5SfJ1riN24rURZOcUKlhZD/Pp4h 3zD5BdWYM3gQl/zcwjAjKo19RTMMsj7k1H83tk0Hgek/F8QlSwyPX9lMg4/JajDs2dFaJ7 7oPO1tetTFUoNSv9HTa6rawklD8jAPA= Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-7c597760323so441838885a.3 for ; Mon, 14 Apr 2025 11:10:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1744654216; x=1745259016; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=wmxLTZDlUtyhjPG3LKgyqC3m7MkeZf8KO7nU/7lCHDI=; b=v96uBnnRr5nZvENQN9ZB8ln9Jx84cq2ArNghDT52YFT5mGqS2mdRol162/TmUXk6eF cwAMjZp0X7SLYIsDYvykY6HNaKVGNEPOWSAjLZr+/hF6++bXPx54w+7eVQvBXhlFQ8Ru D6uzYNuxwcUIwVnB6lqHcMHKJ3toTwk4mAhOSdQXo4JzoR0w0ebKS5LJmS8zXEJ4lQO8 RH4hFX8DLaCTKmG0iQ35shNLbSIC86NRCtXFfKv1y2oc34FuVFxSSws5V4d7S7gdSpOn nFnyYxYhQvIbRlK5SQzYbZEJm1khGjDvnvcQRDbnaJ+euf25DG/eM4ZbQ/DOb4osFw4X JLag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744654216; x=1745259016; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wmxLTZDlUtyhjPG3LKgyqC3m7MkeZf8KO7nU/7lCHDI=; b=Zletix5yim298Fo9/Ph3zGbbMdOLBbMRGwYw+PMEJhkIhvWpjs/cjtBlVShzNpHy1u zgCIfyW6U4aT6Y9OUX0wwNdvlDN5AI/izJ9F3VCPiP823QXF5mVOrxg1rxrEHMKZdAnT HbwgbScrQ9TbRoHZTnIIUDtiORCuKYXEtnPRxObe/9nDaWb2SAcoyfcfSgIdcmqoZUjj ccEC+hHZG51vcxb84firOkHJ3SaJy4kwwMcbdMtz6gxTOVtdtPAtUxdE/YbN2zi/IFkS gNoLMB/e8lVjuQoDU9dESjjCKjaS42HJ0D8ut81VgdzgbGbkFo9VTy0j3wkmEOBl4lg5 KpIw== X-Forwarded-Encrypted: i=1; AJvYcCVHzJtWnozKPcwWs/42P1s/F0tF1LQr/2BVPpEP9cPkP6zpzR/DCfCDTptEm0x6rSRknQJ/x0DAKw==@kvack.org X-Gm-Message-State: AOJu0YwGCUsmiQD6SgSiEaI7HXv5tZyw/qDdl1R+mpi0gRlTGNmFb0cR x9yIMXsPAwarxryOtLCnSoPQaEI8X/odLhQYUyDVDMBWUfbYrVq5ux30mpHYdtQ= X-Gm-Gg: ASbGncvR5dl1t0afIG7Prf63aKXpV6ZtC2vt5sZhl3dDv4qUyMNbuOCxuPN0nhdhm9d JSydCTvKHI3YiLCnIWDkNOF89Xh2jJgVf0r26+Y22SUBN3jdph6aBAar+LjI1hGqt34Zy9zLtDy KIMaYoTtgzdv2k+/ySS5Fxmf/2lYw+q/9u7iajUb66IphRuVx9wf1vUPoD++12HgITBPwSQoTHs FXnKM282HGMY9MOjRRz7MEKJjfab33wuBLiK/rxvP/EJZPPxFeOGS67tS/FfPewe8y+Mbh5Ci8r 8I0SS7yabA0aEwcpzI4S8nCfz2u3dDnJ4Q74KAY= X-Google-Smtp-Source: AGHT+IE+XdJpOVhGEaj+Yv6sX3pIJj3/ALpArX3Fg1kdMboHe1klm4GlgsjQnZuIvjCGUk7JRR/efw== X-Received: by 2002:a05:620a:40c7:b0:7c5:5f19:c64f with SMTP id af79cd13be357-7c7af1182d8mr2068553185a.4.1744654215840; Mon, 14 Apr 2025 11:10:15 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:365a:60ff:fe62:ff29]) by smtp.gmail.com with UTF8SMTPSA id af79cd13be357-7c7a8a0c863sm768502585a.92.2025.04.14.11.10.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Apr 2025 11:10:15 -0700 (PDT) Date: Mon, 14 Apr 2025 14:10:14 -0400 From: Johannes Weiner To: Michal =?iso-8859-1?Q?Koutn=FD?= Cc: Waiman Long , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Tejun Heo , Shuah Khan , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v6 1/2] mm/vmscan: Skip memcg with !usage in shrink_node_memcgs() Message-ID: <20250414181014.GB741145@cmpxchg.org> References: <20250414021249.3232315-1-longman@redhat.com> <20250414021249.3232315-2-longman@redhat.com> <6572da04-d6d6-4f5e-9f17-b22d5a94b9fa@redhat.com> <20250414164721.GA741145@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 1B67C4001A X-Stat-Signature: k46uckngnu3s4j1tikwrxe1oommdcxs3 X-Rspam-User: X-HE-Tag: 1744654216-873727 X-HE-Meta: U2FsdGVkX1+4Oj6fCfA+AIEx1A91b3hj6cxg2sj0o2p3NUOfKQWdCPVedFJaW7XZmo5mDSgpKU6brS2sJdyOJtQULj/Awq7b24V5gEOMjWrDPGKCiRa8NPvkkDB7EBoITXOs4TyNxQHPpFuTf97ZV5dzTqqxlc13xwI+YT+ozLvNx/g+O1PqRpjmRtw6hvelm5tAsgCyOlQt7gZ37MtcKGH4q1c4GRJ4eouc7AtGrFT8lPzoWL2kYWcIDzHfjAy4Bk8Y4rGKpd5kH/LawNEfSF9Kc9R9MC9pYbsTpAvOA1JW1TfexmBgLhg1SubC0ewykWn4nFrDBGzmT8QCuILPnKrG1Q+dHSMtqYdzaI8vLk354enPmXUBtJyAaVlYeFymGrUjXYNKCw9lrPNBWF9IRIXs67AdCOpGqWrPGD55Q6Et3FhfxgQtkEvRegl1Chw82p9hKazrgQ5ZGxLxRzGCTAGTsFMVHYexcYSSYXd6MnqcV4DRojvfQMW/lSe97HpRBcRkOLypZL95eNBZGfhvaYi3amaa75XUhUJXtiG3adlPXu7sqO2iMUsycyHaSyGy6fke0awHXWF/Lg0pLG8Xa0pO/vEp8pJYqSYadmu94NgePT9T1uoKPlduWFwcz1TsiXxnbHzqdGT9eScpOBFbvuemseVo/zdeInMs+iG5dVZcaiyG0M2ubUL5ldmzSxR08lkvJRbRaB8reoyJHAjuKBIW0izUFV9gXBpS3N5THDiNMGSJbyiAImw5plF84xmCroTF8RjY3/B4Tvs7SM6JTC5up9aSJJTOCT5YUakJQt2L9VzRi4+Qu2T8NPA7p+okZB778JNrPn/IH5cihd6yZ3KzFNdIwLD2s7E6ntHc+TOstL89eXwkXkCrFVRYi5UrAUzpRL1JRsN9BTSOVnIMFqQwDOqfzr3ohlPG2kRZb9czFBNVL/oboxg6M5QW1W8l5dutCI6OboruuaVXVbU 5uDfTa1K m1kaBhmUVNWE/ajUOZATXSoSv1IHilDonqWAGvuXu4tf+egu4cK8IgWjQohcyweCswSnx8ywyXgarrTJEvBvX0XCXSYMbwZ1kertd9K5B3zmvide8265mzVlXklcO4ysajMsnEt5uVhvn/7wUbBKHK7Lm5MygkNEqFRQQZZ4oQVrsLhPsoJegRKWNGRjbM4/kvXknAhq/AYa42HwQVkDKO6ea489CJDouFldCzBJN/0oH7Zu+dQCR/eb77b9GWQeYBtYI1fq8gbeadNgeYVZtcKUuZ1BaHrgshwQNj5FOSIPBtaa6ADy/XL1HyvkRY/+jG5e2mb/scDoxrI6PJKIrJ43JUvsy15s8YSMFoV7UrHL76YhlXJ0tQxcR0s32L/djQ/c0dAcc1n4svlX8U5Sey4hS0CkGrcRK3QMIXG0ErB+/Q+6shKh9rX9kpyo1S+STZN7n3oseELqoy4NuYkCuqmJOZZMEdsr7BILMl97Eo6DvrZ5gM3MoIfo4WVeTLUkAPgcEwJEltCTn9uFBeA0RwbNDIzOwsndn4IWd1q/etDTzkMqJVhDp99lng63tjyxFAyBKFEkXOPqET7A/+VLKEcp805pzylAD1AjZAIawyLR0o981LI/aENbejw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.008051, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 14, 2025 at 08:01:42PM +0200, Michal Koutný wrote: > On Mon, Apr 14, 2025 at 12:47:21PM -0400, Johannes Weiner wrote: > > It's not a functional change to the protection semantics or the > > reclaim behavior. > > Yes, that's how I understand it, therefore I'm wondering what does it > change. > > If this is taken: > if (!mem_cgroup_usage(memcg, false)) > continue; > > this would've been taken too: > if (mem_cgroup_below_min(target_memcg, memcg)) > continue; > (unless target_memcg == memcg but that's not interesting for the events > here) D'oh. > > The problem is if we go into low_reclaim and encounter an empty group, > > we'll issue "low-protected group is being reclaimed" events, > > How can this happen when > page_counter_read(&memcg->memory) <= memcg->memory.emin > ? (I.e. in this case 0 <= emin and emin >= 0.) > > > which is kind of absurd (nothing will be reclaimed) and thus confusing > > to users (I didn't even configure any protection!) > > Yes. > > > I suggested, instead of redefining the protection definitions for that > > special case, to bypass all the checks and the scan count calculations > > when we already know the group is empty and none of this applies. > > > > https://lore.kernel.org/linux-mm/20250404181308.GA300138@cmpxchg.org/ > > Is this non-functional change to make shrink_node_memcgs() robust > against possible future redefinitions of mem_cgroup_below_*()? No, this was really just aimed to stop low events on empty groups. But as you rightfully point out, they should not get past the min check in the first place. So something seems missing here.