From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 474A8C369A2 for ; Mon, 14 Apr 2025 16:47:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A46E280066; Mon, 14 Apr 2025 12:47:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05304280029; Mon, 14 Apr 2025 12:47:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E834A280066; Mon, 14 Apr 2025 12:47:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CAF6C280029 for ; Mon, 14 Apr 2025 12:47:29 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D4EAB1A03EF for ; Mon, 14 Apr 2025 16:47:29 +0000 (UTC) X-FDA: 83333230218.03.7C3D784 Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) by imf26.hostedemail.com (Postfix) with ESMTP id 9E75914000F for ; Mon, 14 Apr 2025 16:47:27 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=SInWJz0m; spf=pass (imf26.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.50 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744649247; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gvr1Eg7lK7Y8HhVqNwImZJnjSK1mbZPXBkM7KTJCKgE=; b=K/lL0TE8URWIce2VPUUrfijFBGyxC+uvJLjVNuy2wjpQ+dEsqGqVeCDj2TWw8oOuDTUy7+ hsiHKPGUO63/P/y6LE2EELrGPfwLzR5x1sooVVZIG2EIfe0+Cvxhbru5/7Zf4DkSGXmlL1 mgSVEJZbknTyxX6UmR5rreETDwUj+zs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744649247; a=rsa-sha256; cv=none; b=45fGmzn4nZFx/h1dLRYLXepurKvimT/Kwqv8FOZ+6n9Llp9mKpt61nADnpsdkF/gs6wkmp bmTJlJzv8qs2WWmw1+7OjA8k+IyfmzOOB8/TkvKOppnEULE+zc+QIVSbu3VJw7meP+XDBa E5Tcul/HuixNIysaafhGb9KrGFHR3tw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=SInWJz0m; spf=pass (imf26.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.50 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-qv1-f50.google.com with SMTP id 6a1803df08f44-6ecfc2cb1aaso48767706d6.3 for ; Mon, 14 Apr 2025 09:47:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1744649246; x=1745254046; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=gvr1Eg7lK7Y8HhVqNwImZJnjSK1mbZPXBkM7KTJCKgE=; b=SInWJz0m11EF64zZusrKr6/UVeGNHPxkFnfhJI431Qs/4FiiqcECJ7RIWB2/JEa7JF 4JSkSZ+Z7F26FCWVjPSAbtDn7QsztW/fFj52fLI45/yZLyjRjW3zHwH9Pq94Y6BeEZjT 8FMjAHlaL/2+6T//QBJ/EQgkOfSpx99Mp1jSpwz2GHskQeIDSGcqD/02JLy/ZislGfTG b5+V4/IuBzHYsTt0C44S+T1jNSNOha/Hpw9Ygqkd2eishbu71J6AaCHFT6NGKyTugbS9 o0QVYaBpIC1Y+7+9cHCUf/r0Cqaqcuwub3loWzgt572NohlMo8V5JiF2CJl57MJlVQ+9 0cEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744649246; x=1745254046; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gvr1Eg7lK7Y8HhVqNwImZJnjSK1mbZPXBkM7KTJCKgE=; b=JFB65+n4qAEN4ti11BaT9v3oOUmpp0C6NXllpPUfXBjkh2/7MVAIMuGbh4Ml7v6/pz Zn5IwfJNCQ9XV93Filb+ob4+A7PW76fnATgbkwsA/f6hlf2e42rZ2Y1DHsQCRyb3lZle eIljBbWJBjUQnUKleyVe9R4aLsqte0ADEVK27DEIPKs1NGljH3fcROeUZKGil+nXxIAB sQZfGLSQnXNg7IrqQvLO87MUvSOlLGutGD08rlLAjmij4wHotScsQErI7M3IHUcxh5di AypwRzE/Z4WDYyTG1lNcm+c4q1x1nK2T1PaPZ+1nrBhPKaAN0PDJyt13zzK0gn2rfkGd Q0iA== X-Forwarded-Encrypted: i=1; AJvYcCXGtb8ZD3/5gDHavkwhd9kCTLMey5R0glXiWfICT8TAxWREOvXXIn47SK6tfABEu92H3Uvnx77Dmw==@kvack.org X-Gm-Message-State: AOJu0YyKpr53YvBv/pXVlryJDAf62GwjQ6pjyubhDRJG2uFVXyTiHQMT SBQpcrHU+kdN4AmlboQeXdWXEhLo3L8vvWjrAgoXRZ96JN+dMZMCenSYLcbqWT8= X-Gm-Gg: ASbGnctTqDMOcoci4jd90yt96zHL90SxuE3ToicUqureVx8JS/jZ37+NrlehNBqiKFW 3blTIRadg4bC6ai8iBE2Tg7Bf7ZBdtdKBhxXIYUiW/29bsn6V43i0L38bhZr5DP4w+dq0MF6zSx dgo8xDMADJnBc9/qQuTZqafn7/Fu+K4jpCy8AbmYF2JV+7z8dkjVYRnpkfSjWru0Idrct/On5ko DdioPv+ESTwtbSKJb5EZ1wUMon3r9edehx3ygL8GrdGt0/MzMvMS3gBc04jNNcyx/XnPA+tpmsQ ovkyiIS5bq0dcKMYHZW2dCEpASdbDlInWZwsucbFddQeSyD0lA== X-Google-Smtp-Source: AGHT+IGyn19E6PStgkF0prqcjwzNPkKDdnhAlejJTPbm0jkoKGh1Or323otXTafl0CJ+s0xtuj6ZeQ== X-Received: by 2002:ad4:5e8c:0:b0:6e8:f445:3578 with SMTP id 6a1803df08f44-6f230cc177emr218119656d6.2.1744649246264; Mon, 14 Apr 2025 09:47:26 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:365a:60ff:fe62:ff29]) by smtp.gmail.com with UTF8SMTPSA id 6a1803df08f44-6f0dea106cesm85684596d6.103.2025.04.14.09.47.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Apr 2025 09:47:25 -0700 (PDT) Date: Mon, 14 Apr 2025 12:47:21 -0400 From: Johannes Weiner To: Michal =?iso-8859-1?Q?Koutn=FD?= Cc: Waiman Long , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Tejun Heo , Shuah Khan , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v6 1/2] mm/vmscan: Skip memcg with !usage in shrink_node_memcgs() Message-ID: <20250414164721.GA741145@cmpxchg.org> References: <20250414021249.3232315-1-longman@redhat.com> <20250414021249.3232315-2-longman@redhat.com> <6572da04-d6d6-4f5e-9f17-b22d5a94b9fa@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 9E75914000F X-Stat-Signature: ag5njs6uejw3fd6mj7ek99my5am85ung X-HE-Tag: 1744649247-197236 X-HE-Meta: U2FsdGVkX18r0ZZfH7XbLCrhbUM1du5HCuKlK0bPea5zUKvWp2QcGfFw9exkZau+CYQXZFFLBtaDCcVgbPZQ7nV3xs8zMdb9R02SRgofWz/dnL42etbCdbc0+4Z3GLJ1GkIK3/YrZna7xjPxcgXYLzPRO5YTZsYYKH+oksUCb74dCJPv+gbUjPPvqn1kdN/DE/xTezG5CP1069L0Ni2lG/JUQpSxdOy9eHdKf9GRT3inENHE5I7sz9axw59xqZ9J6Y5ciOWQAG6ecb47GKj3NK7RbrZ/Al4duVWN/t9t5lGZTxHZWDXKG2aCJJWU15rsMrrTaJ4RfGU/DnsbWzm8zYZhxvTGKellXzIcn+gbMPWYHDIZ77CFS9Y1ORZu5IUhytvHHzIE5KO1eHhsZzr7ZGaKE4tlAXowJT0dS1ut8iUpU/EFKEbkq4PLx1ZT/+smLBnZl2gOA1Bhx2A3a/OVtgzA3XvKictlvBINeqUWjOIEZqFTbuJX+yhgRu2q3fUeFHSCkXzVNSynHWagoO8fUZiNMIKRRZAU+eaobbUqCQnlZCKBk9WGasnEBQh2RuC+FDjv32TCUM2duqfb3TvRL4u8h/nALZWdrVdgGU+6gJNix+p10Q4Oa/gpL4tWhcwyNaDI967qPAVzNbxltwS4MUmBndVGXnvHUHU4gCrok66/XeisXIVEpXMVRwxI1lP2+yMdVRXUaISLS+sCwjbXedgmcVdQmefKE6mDjKBpGOTOCfhCSssfuy6kmVeyBUWVmvAbdUDtpssjDTT8mQcekiPxKnsazaCeg2mVJMbds3PFzmknKajLe7nn1Tebg8A0eAOwZ9c/zyUo4NgAPK50rKauI2uwzLjX/fqJQah4PlmiYuRFjoxxNu4ttxi8kJal80UMKLegFSM8lzfpAj3rXXMjhmo8fgt1Us8rTG3PZWi9rloiJq3sXHNzp9YchucFOKV5NsbmmXWGdddBVU6 NJEJPPIu 16XMeFYrZlCApX3+fqI4hp2uKPj8hpgHTevkZWElSSvU5RRFYxN/NWLwqfapO0D6IpfFRN8fI59YeIYhhROJfsnWj5WGVeKB5neyOkMpRRFitGur3DMfPGoZ3uAchZv6fOcp6YT4BCeWdbyFPJEI851aChdddm0cUK4NfWXGCOZCcuWBPRhpHQOcgwgiMTKLeO05NOVD1h3exAj67AnCkKLPUaGZT4Mmek3vE53pdBzuAHCO63VgQJSZ2ESHSaHgY5GNBLe0I8mYi8lUzWP3OnhYT4WPYeLwpq9AzOyJk+N6RaxREar/nTln0BaRZFdZC6hRUGBUXFdz0baqFLn7TMeCAZNEjW4BTIQgstpVs5ahqvyJbYotpq7wgdC5zd7Auzj4kgOHJ6iHhloi/rGmqcvPeYFoos9hdINIa2HFoZLTXZ2657tpWoq71HinN4XLwOld0P3yS9o8ktVETS0bDMWNEOMcD0yPpCdL+vEqpeoC8bZs+EblqPqyMLA1R2+Sjw07njgkpoJdQgazzKKsilxxaCsbRK2qqM3LDcVMmQO51nV6HTiFoFZmqRGCCwfkyUM2KbxHW6akJmfJ5JKqJL6vNcxNNZZSqdt3US5YzVhGAkSkFy9PA9H1Z+4zcoysSECsyKj0n0KQQw1g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 14, 2025 at 03:55:39PM +0200, Michal Koutný wrote: > On Mon, Apr 14, 2025 at 09:15:57AM -0400, Waiman Long wrote: > > I did see some low event in the no usage case because of the ">=" comparison > > used in mem_cgroup_below_min(). > > Do you refer to A/B/E or A/B/F from the test? > It's OK to see some events if there was non-zero usage initially. > > Nevertheless, which situation this patch changes that is not handled by > mem_cgroup_below_min() already? It's not a functional change to the protection semantics or the reclaim behavior. The problem is if we go into low_reclaim and encounter an empty group, we'll issue "low-protected group is being reclaimed" events, which is kind of absurd (nothing will be reclaimed) and thus confusing to users (I didn't even configure any protection!) I suggested, instead of redefining the protection definitions for that special case, to bypass all the checks and the scan count calculations when we already know the group is empty and none of this applies. https://lore.kernel.org/linux-mm/20250404181308.GA300138@cmpxchg.org/