From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 748FFC369B2 for ; Mon, 14 Apr 2025 21:51:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B208C280092; Mon, 14 Apr 2025 17:51:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD0B1280080; Mon, 14 Apr 2025 17:51:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BF5D280092; Mon, 14 Apr 2025 17:51:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7CDFA280080 for ; Mon, 14 Apr 2025 17:51:23 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2176DC0754 for ; Mon, 14 Apr 2025 21:51:24 +0000 (UTC) X-FDA: 83333996088.17.5A418DC Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf28.hostedemail.com (Postfix) with ESMTP id 6BE13C0002 for ; Mon, 14 Apr 2025 21:51:22 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=sRNrxXLS; dmarc=none; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744667482; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wgd3Fk2pZaJL/XSUMxdG7jSkSwtgXetdkR4rK/SieK4=; b=3o0XG1GycVLnMoIjIJIgvmTZo6wQxmzdtLMSA0BqIiJany08Ekcif3RGtk8JEtAT61w0rP h9Gygqf7Qnx4FU3xrCpE8cuE3HFMDVCM8KcQLzUVPWfpcAgNIbTC5xoBlNmes9Zp35pkz/ scOPXI55ij92hFxS5SW+gnu3et+y9uM= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=sRNrxXLS; dmarc=none; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744667482; a=rsa-sha256; cv=none; b=R3g8fnhW6AoYuTIDgbMbHjjRUHPYHT96ivlEIPbjjtAvQdFUoxlU+ZZ16Pd//1E7z9rWfb yqxLjF7AHKR69Zx3JPrCnkKAOxGEY4b7gO9aIMnVYWO5tDGZAkNUU8GJLR4qQV3KUFRDnK VfDevHELj7IE9TDfEgWuBoGr20WfqaY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 3D97049D47; Mon, 14 Apr 2025 21:51:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6296C4CEE2; Mon, 14 Apr 2025 21:51:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1744667481; bh=0xMzsyY2JXDLInkHTH9D+2BI0tk5b90cP0/D78/nU2c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sRNrxXLSwHIVS5DpItwK4Yly0b9rEFBhYEDMCyhqiOkOYgkZ4jPeCrLQ/12An3uWF O0pAOkXF7tBSkDX5tdLkQqvXGxk/k9UYzCNnLLJqAOtQi1KGW1NJ23ZWQgyGFOtRFc L/Wgq9FtX9tAwlu057zJAMynqIgzW72i9kj7phJA= Date: Mon, 14 Apr 2025 14:51:20 -0700 From: Andrew Morton To: Andreas Gruenbacher Cc: cgroups@vger.kernel.org, Jan Kara , Tetsuo Handa , Rafael Aquini , gfs2@lists.linux.dev, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] writeback: Fix false warning in inode_to_wb() Message-Id: <20250414145120.6051e4f77024660b43b72c8a@linux-foundation.org> In-Reply-To: <20250412163914.3773459-3-agruenba@redhat.com> References: <20250412163914.3773459-1-agruenba@redhat.com> <20250412163914.3773459-3-agruenba@redhat.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 6BE13C0002 X-Stat-Signature: dxy5m59y5rf7o71htamni53bxaasr5qn X-Rspam-User: X-HE-Tag: 1744667482-924252 X-HE-Meta: U2FsdGVkX19+UZIJ78VtaXwmp8UAC9rQcoAzdFaaQvR0ejQAg0JzvwLWhY2Au2SVptOJNjtuCNKKMLzbl2k9FnCOfmWsHMKiAhtFIieTcnXZi7Y8F7OKHoPe1A8Y0gS1BVYGbtKjbaErsdt8zkfa7gBbib2ajcncEyBg66UAmhrFd/g8IY+ZgxA84a834Zxb25lxY2Bx9Bi5h8MMyqv+b06mRP5xrL8bjC5cXAsPD5UjzA3v7SiA108ViDbj2VRxJ6Ozd1M9xHaqoKEf+OJCQZFJ3o6CALHj3jP9Mrki7p2RnZpbc7kmVayRe6+TVB097Gp6brZ8s8+8yNs7nwCeX/T52QsHi7lsFROmm0H5PAAaMVjEEyC+14p5ENhaO6qrVRdqDhFfkUXLJrwAAwrhcvvh8XyCtzjSzv4iUWUX63xTpQ2x2nvmuzxE0yuzlDSQcmq1/sFsjXVxGSK/coFmwtNbLd3UIODZI7LyBx1VfSlv94IUW5KXZaseBlhxKuD6Jh+900seWfe9xrx/53dvFN96VtCd9jMqh82wvrCOCOFcVY5JJslp4BD4RYjj0HntvdF6qjzJqO5cExK8yhRXgLxso9qIYRF04rfxfwNw1zv4Kj25M2qprurkXBAVaMSGn5g5gqiBhLCnyoBz6/s2+XvkykTXLJqXtxNqYmKEyz9hN836AaWNAlnXNHzsP99N1/q2277oSXWP0sz0QEn/ctXN97tGcFEC4P7zoy4s5NmeQAZSmXcVvX/UrhQohJJR9g7GwUWt8OVVDqhs+M5sGoiJ5rOD1QqfKCetb9O6cWa/rearPMhPx6XrgKdCS58VRAx542tLqF3axhIHEONFINrw2wUydtTATCBODHquiQxonHmJhKWN+Z6rXY138t1HZiXpAb846EbPZihjrlMaOyNKHdBV/FMlHHHxCmCS6oZ53/AL3uwKcawlcmiBdInRKxCBu0Kf6BXY3SLDqBX gS4FjTFC x34eYE28MohXiVeAPWPS3RvVq94ecykIfJzgz5i9uRvkJwxftE2RcGqXeOGzJ2o/lyb+oSDWLSuzTDmrCvAni+EVQXq5preISej5NGqcwT9RcV3y+Xf3fC9sdE6sAEcvRRDE7GNfPhoWo87xU20VDc73S2WCrZyAwn5t/AQLnFDXjBJH1LpU2EITFAPQ50VbU9/ST0WhpiNYLtIcY5Al4amnF7+nScj1WiAROqgaedv02OsADOJWn4rDP6LcE49smnLa0jZqr8YpztAUjD5BtVMoqgmi+/kxQU0fIId10I/NIoHXpiV8Uh1hcXccxxPpnmJjOlbB0WIHkEP2V5/1v8ObCHA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 12 Apr 2025 18:39:12 +0200 Andreas Gruenbacher wrote: > inode_to_wb() is used also for filesystems that don't support cgroup > writeback. For these filesystems inode->i_wb is stable during the > lifetime of the inode (it points to bdi->wb) and there's no need to hold > locks protecting the inode->i_wb dereference. Improve the warning in > inode_to_wb() to not trigger for these filesystems. > > Signed-off-by: Jan Kara > Reviewed-by: Andreas Gruenbacher Yoo were on the patch delivery path so there should be a signed-off-by:Andreas somewhere. I made that change to the mm.git copy of this patch.