From: Andrew Morton <akpm@linux-foundation.org>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: cgroups@vger.kernel.org, Jan Kara <jack@suse.cz>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Rafael Aquini <aquini@redhat.com>,
gfs2@lists.linux.dev, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] writeback: Fix false warning in inode_to_wb()
Date: Mon, 14 Apr 2025 14:51:20 -0700 [thread overview]
Message-ID: <20250414145120.6051e4f77024660b43b72c8a@linux-foundation.org> (raw)
In-Reply-To: <20250412163914.3773459-3-agruenba@redhat.com>
On Sat, 12 Apr 2025 18:39:12 +0200 Andreas Gruenbacher <agruenba@redhat.com> wrote:
> inode_to_wb() is used also for filesystems that don't support cgroup
> writeback. For these filesystems inode->i_wb is stable during the
> lifetime of the inode (it points to bdi->wb) and there's no need to hold
> locks protecting the inode->i_wb dereference. Improve the warning in
> inode_to_wb() to not trigger for these filesystems.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
> Reviewed-by: Andreas Gruenbacher <agruenba@redhat.com>
Yoo were on the patch delivery path so there should be a
signed-off-by:Andreas somewhere. I made that change to the mm.git copy
of this patch.
next prev parent reply other threads:[~2025-04-14 21:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-12 16:39 [PATCH v3 0/2] Fix false warning in inode_to_wb Andreas Gruenbacher
2025-04-12 16:39 ` [PATCH v3 1/2] gfs2: replace sd_aspace with sd_inode Andreas Gruenbacher
2025-04-12 16:39 ` [PATCH v3 2/2] writeback: Fix false warning in inode_to_wb() Andreas Gruenbacher
2025-04-14 13:55 ` Jan Kara
2025-04-14 21:47 ` Andrew Morton
2025-04-14 23:18 ` Andreas Gruenbacher
2025-04-14 21:51 ` Andrew Morton [this message]
2025-04-14 23:22 ` Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250414145120.6051e4f77024660b43b72c8a@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=agruenba@redhat.com \
--cc=aquini@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=gfs2@lists.linux.dev \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox