From: Gregory Price <gourry@gourry.net>
To: linux-mm@kvack.org
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com, akpm@linux-foundation.org,
mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, hannes@cmpxchg.org,
mhocko@kernel.org, roman.gushchin@linux.dev,
shakeel.butt@linux.dev, donettom@linux.ibm.com
Subject: [RFC PATCH v4 1/6] migrate: Allow migrate_misplaced_folio_prepare() to accept a NULL VMA.
Date: Fri, 11 Apr 2025 18:11:06 -0400 [thread overview]
Message-ID: <20250411221111.493193-2-gourry@gourry.net> (raw)
In-Reply-To: <20250411221111.493193-1-gourry@gourry.net>
migrate_misplaced_folio_prepare() may be called on a folio without
a VMA, and so it must be made to accept a NULL VMA.
Suggested-by: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Gregory Price <gourry@gourry.net>
---
mm/migrate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/migrate.c b/mm/migrate.c
index f3ee6d8d5e2e..047131f6c839 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -2654,7 +2654,7 @@ int migrate_misplaced_folio_prepare(struct folio *folio,
* See folio_maybe_mapped_shared() on possible imprecision
* when we cannot easily detect if a folio is shared.
*/
- if ((vma->vm_flags & VM_EXEC) && folio_maybe_mapped_shared(folio))
+ if (vma && (vma->vm_flags & VM_EXEC) && folio_maybe_mapped_shared(folio))
return -EACCES;
/*
--
2.49.0
next prev parent reply other threads:[~2025-04-11 22:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 22:11 [RFC PATCH v4 0/6] Promotion of Unmapped Page Cache Folios Gregory Price
2025-04-11 22:11 ` Gregory Price [this message]
2025-04-15 0:12 ` [RFC PATCH v4 1/6] migrate: Allow migrate_misplaced_folio_prepare() to accept a NULL VMA SeongJae Park
2025-04-11 22:11 ` [RFC PATCH v4 2/6] memory: allow non-fault migration in numa_migrate_check path Gregory Price
2025-04-11 22:11 ` [RFC PATCH v4 3/6] vmstat: add page-cache numa hints Gregory Price
2025-04-11 22:11 ` [RFC PATCH v4 4/6] migrate: implement migrate_misplaced_folio_batch Gregory Price
2025-04-15 0:19 ` SeongJae Park
2025-04-11 22:11 ` [RFC PATCH v4 5/6] migrate,sysfs: add pagecache promotion Gregory Price
2025-04-15 0:41 ` SeongJae Park
2025-04-11 22:11 ` [RFC PATCH v4 6/6] mm/swap.c: Enable promotion of unmapped MGLRU page cache pages Gregory Price
2025-04-11 23:49 ` [RFC PATCH v4 0/6] Promotion of Unmapped Page Cache Folios Matthew Wilcox
2025-04-12 0:09 ` Gregory Price
2025-04-12 0:35 ` Matthew Wilcox
2025-04-12 0:44 ` Gregory Price
2025-04-12 11:52 ` Ritesh Harjani
2025-04-12 14:35 ` Gregory Price
2025-04-13 5:23 ` Donet Tom
2025-04-13 12:48 ` Matthew Wilcox
2025-04-15 0:45 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250411221111.493193-2-gourry@gourry.net \
--to=gourry@gourry.net \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=donettom@linux.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=juri.lelli@redhat.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox