From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1767EC369A2 for ; Fri, 11 Apr 2025 22:29:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D55E680032; Fri, 11 Apr 2025 18:29:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 28612680024; Fri, 11 Apr 2025 18:29:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 173D0680032; Fri, 11 Apr 2025 18:29:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EEA9E680024 for ; Fri, 11 Apr 2025 18:28:59 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1FB8BAD5DC for ; Fri, 11 Apr 2025 22:29:00 +0000 (UTC) X-FDA: 83323204440.24.EC982F4 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf08.hostedemail.com (Postfix) with ESMTP id 74ED8160003 for ; Fri, 11 Apr 2025 22:28:58 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="qR61Q5/H"; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744410538; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YWLEMloXy02Qv7/Mm76FplTip1CGy1amLFNg5a2b7OM=; b=QW8QeIuInBk953WgBv9c0Au0WFtytE+zQslY+EpyOhW4WGyCiO+lllMqbO1T1PMEM67ka+ v6zGoVKyEaMunqG/4qsLjAjzFxJyocK+4fo7d865YuwtMzj4/q4DcvFVEYSdGvTBzkLAfc RXGXg1VCCFcb28dty1EgQI89lUKj8MI= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="qR61Q5/H"; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744410538; a=rsa-sha256; cv=none; b=bQ79QFwr5SyCwmMePUNLqqDTOKgGo0ppHfQk5ChfaspmrBbQiBin2MY6ily81apUlrwGJs 8QTAXCUyofxqVoVVHCZa0SRikiMYWIWrgTxiS2bXYBNcmHwd0+lcakUSgOy0DggvBLIXjD eXN7coV5VUWZ6x+ADxzrKPzwYV8cL4w= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id F285B61137; Fri, 11 Apr 2025 22:28:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA0CAC4CEE2; Fri, 11 Apr 2025 22:28:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1744410537; bh=q0dosBq62p8nJI13NCPBgpG7xr4NCIfSVpSNWnjWU1k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qR61Q5/HTr1CGOIXBKrDgK0weL86YiOWk9RAqh9a9n0ZIQiTubhlELGmLwxgtXg9X 5HY+GuiUSbm3fqv7YTa9aYrBaLihP9XHN44/GMmG0sXeqOfMzaAH4YChPvI2se3hot +c/tdqFnRk/IPbetbqMuvMwdW9IpNzJuUgJcbgbs= Date: Fri, 11 Apr 2025 15:28:56 -0700 From: Andrew Morton To: Waiman Long Cc: Michal =?ISO-8859-1?Q?Koutn=FD?= , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Tejun Heo , Shuah Khan , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v4 1/2] mm/vmscan: Skip memcg with !usage in shrink_node_memcgs() Message-Id: <20250411152856.41a12ac2b3eb1005a86168e6@linux-foundation.org> In-Reply-To: <6d81d576-7e94-4523-af9a-d43298ea64ba@redhat.com> References: <20250407014159.1291785-1-longman@redhat.com> <20250407014159.1291785-2-longman@redhat.com> <6d81d576-7e94-4523-af9a-d43298ea64ba@redhat.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 74ED8160003 X-Stat-Signature: 8eh8mi61oc6bsgczqrpzqqeudi5us4su X-HE-Tag: 1744410538-202091 X-HE-Meta: U2FsdGVkX19P49HVzythgP4fMWHhzWXcRKeM3lXprZcAHxdNDkUs1RWsZimVtfyV5IRagegsG2nnwZdGWOnP+VjV4BisVZv+XHMc/vmlb3IW6SS2mF7oI2lLkTbe9LOLV5gruiv/phic/UcAtHY9K/9UAh0aza9SPpCaAlorFTqOqxVmhg4dUENK8s0RTsXI8gW21PvC7xFCY0lYSRtFmh4SHtmHiQyjBXybYry7qsNt/D5sg93hLDqUHdLr4DYXWeWf3vEwVqYAOdFVO1HOPPlttU6LlmHWkylU4ErOp/bMyPgUKs3Y9atCyZFlUOhKPWXe2MTp/ntM2EfTFu203YCm279arq1KXjeY6dLHiepjiMngytIqlKhf3cp5Km3ECcipSrrY6QTYh+qdmJTk8eJ12kfRX1JGtsVUgrbi1P8RcSJbIdwaiawntrgkTDOEej7lxCPNGnkK/TBL5o090pNZmTTGtvqOXZYwlPYjn2EQc23sd0+8Gay6XsiFG1m4Y0BNRcWMzM0wWdhVC6k1MilTb5YFhU5B9zGxJtqlgygdeuluDejlOGHr9jYtNqoAl7Gn0cHnSjN6TjzidWmX15YRxNUJUt8ZvyL2o9cwSuXSXRccSMZfzwT0lmIwHxAemJIVIxaMXaihIWeuL6y93kNW65cdeKZDRmso1uS5pcvjJID6boAJqckCgjorO7gkBWR9DyT2/tIbC3qWx+Gm8jN5I5qtTzB+Nn5JlNSiJNohsbTEMXxjrWBDmFYvCjlnC1Cahz1T9D7u8vnGGrtkmLQgpDjKTqRQC7t7Y2o6ikbu+AtnUH7yiywD16mCRvVztYGfYes+x5hKJELek6+BMZsFSQQNxY/44jWaqECKN0mEHX7EsV3giwJ3jlqQgvNLHpOUQlapUAlKyEi7C/g5Wvwr2Ee4o7HWi9Eqc4h+7SQBWbk7VDgJqmV6NhEN1wPZYQ0XR/hn8grqfZsXFOK OJEjyIL2 qNPgZyC9S8jFE90+eD6/JNduOg43XyCte+cbMOevwjNgw6ealcPrVFmh7H0wBLvYCI9mKOFSyrvl6AZIsURIs/OYGQT1sha64kf6DimoUihXaux9pZQZgwRpc4NC/wSMYtdTvwLxyRU4YDqFwB786qlsDCntAY8wltzL/AMyqh0O+PRbj8gwijLihBVjdGANaKz4L5uO8MDHWkC3SnOPhqpUnGFSOiwxKh00c4dO0jPs7oAlm5zmc2JhYTm4OqHg6eAuxxmh7HB86AiPI4+RbdPaYoP51Sdo0nLpfVELtDwNRRMrcIWV4QQ6xIQkWYnlKKRLV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 11 Apr 2025 17:08:33 -0400 Waiman Long wrote: > > - * A/B/F memory.current = 0 > > + * A/B/C memory.current ~= 29M, memory.events:low > 0 > > + * A/B/D memory.current ~= 21M, memory.events:low > 0 > > + * A/B/E memory.current ~= 0, memory.events:low not specified (==0 w/out memory_recursiveprot) > > + * A/B/F memory.current = 0, memory.events:low == 0 > > * (for origin of the numbers, see model in memcg_protection.m.) > > Sorry for the late reply. I think it is a good idea to update the header > as well. This function is actually used by both test_memcg_low and > test_memcg.min. So I will use low/min instead. It appears that quite a few updates are expected for this series, so I'll drop v4 from mm.git.