From: Kevin Brodsky <kevin.brodsky@arm.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org,
Kevin Brodsky <kevin.brodsky@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mark Brown <broonie@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
David Hildenbrand <david@redhat.com>,
Ira Weiny <ira.weiny@intel.com>, Jann Horn <jannh@google.com>,
Jeff Xu <jeffxu@chromium.org>, Joey Gouly <joey.gouly@arm.com>,
Kees Cook <kees@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Andy Lutomirski <luto@kernel.org>, Marc Zyngier <maz@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Pierre Langlois <pierre.langlois@arm.com>,
Quentin Perret <qperret@google.com>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
"Mike Rapoport (IBM)" <rppt@kernel.org>,
Ryan Roberts <ryan.roberts@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Will Deacon <will@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Qi Zheng <zhengqi.arch@bytedance.com>,
linux-arm-kernel@lists.infradead.org, x86@kernel.org
Subject: [RFC PATCH v4 14/18] arm64: kpkeys: Support KPKEYS_LVL_PGTABLES
Date: Fri, 11 Apr 2025 10:16:27 +0100 [thread overview]
Message-ID: <20250411091631.954228-15-kevin.brodsky@arm.com> (raw)
In-Reply-To: <20250411091631.954228-1-kevin.brodsky@arm.com>
Enable RW access to KPKEYS_PKEY_PGTABLES (used to map page table
pages) if switching to KPKEYS_LVL_PGTABLES, otherwise only grant RO
access.
Signed-off-by: Kevin Brodsky <kevin.brodsky@arm.com>
---
arch/arm64/include/asm/kpkeys.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/include/asm/kpkeys.h b/arch/arm64/include/asm/kpkeys.h
index 79ae33388088..64d6e22740ec 100644
--- a/arch/arm64/include/asm/kpkeys.h
+++ b/arch/arm64/include/asm/kpkeys.h
@@ -12,7 +12,8 @@
* Equivalent to por_set_kpkeys_level(0, KPKEYS_LVL_DEFAULT), but can also be
* used in assembly.
*/
-#define POR_EL1_INIT POR_ELx_PERM_PREP(KPKEYS_PKEY_DEFAULT, POE_RWX)
+#define POR_EL1_INIT (POR_ELx_PERM_PREP(KPKEYS_PKEY_DEFAULT, POE_RWX) | \
+ POR_ELx_PERM_PREP(KPKEYS_PKEY_PGTABLES, POE_R))
#ifndef __ASSEMBLY__
@@ -26,6 +27,8 @@ static inline bool arch_kpkeys_enabled(void)
static inline u64 por_set_kpkeys_level(u64 por, int level)
{
por = por_elx_set_pkey_perms(por, KPKEYS_PKEY_DEFAULT, POE_RWX);
+ por = por_elx_set_pkey_perms(por, KPKEYS_PKEY_PGTABLES,
+ level == KPKEYS_LVL_PGTABLES ? POE_RW : POE_R);
return por;
}
--
2.47.0
next prev parent reply other threads:[~2025-04-11 9:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 9:16 [RFC PATCH v4 00/18] pkeys-based page table hardening Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 01/18] mm: Introduce kpkeys Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 02/18] set_memory: Introduce set_memory_pkey() stub Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 03/18] arm64: mm: Enable overlays for all EL1 indirect permissions Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 04/18] arm64: Introduce por_elx_set_pkey_perms() helper Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 05/18] arm64: Implement asm/kpkeys.h using POE Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 06/18] arm64: set_memory: Implement set_memory_pkey() Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 07/18] arm64: Reset POR_EL1 on exception entry Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 08/18] arm64: Context-switch POR_EL1 Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 09/18] arm64: Enable kpkeys Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 10/18] mm: Introduce kernel_pgtables_set_pkey() Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 11/18] mm: Introduce kpkeys_hardened_pgtables Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 12/18] mm: Allow __pagetable_ctor() to fail Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 13/18] mm: Map page tables with privileged pkey Kevin Brodsky
2025-04-11 9:16 ` Kevin Brodsky [this message]
2025-04-11 9:16 ` [RFC PATCH v4 15/18] arm64: mm: Guard page table writes with kpkeys Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 16/18] arm64: Enable kpkeys_hardened_pgtables support Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 17/18] mm: Add basic tests for kpkeys_hardened_pgtables Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 18/18] arm64: mm: Batch kpkeys level switches Kevin Brodsky
2025-04-11 9:21 ` [RFC PATCH v4 00/18] pkeys-based page table hardening Ingo Molnar
2025-04-11 12:37 ` Kevin Brodsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250411091631.954228-15-kevin.brodsky@arm.com \
--to=kevin.brodsky@arm.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=ira.weiny@intel.com \
--cc=jannh@google.com \
--cc=jeffxu@chromium.org \
--cc=joey.gouly@arm.com \
--cc=kees@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=maz@kernel.org \
--cc=peterz@infradead.org \
--cc=pierre.langlois@arm.com \
--cc=qperret@google.com \
--cc=rick.p.edgecombe@intel.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox