From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EA75C3601E for ; Thu, 10 Apr 2025 20:31:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE2C628012D; Thu, 10 Apr 2025 16:31:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D42D6280103; Thu, 10 Apr 2025 16:31:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B980128012D; Thu, 10 Apr 2025 16:31:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 95C13280103 for ; Thu, 10 Apr 2025 16:31:28 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3A2FC161439 for ; Thu, 10 Apr 2025 20:31:29 +0000 (UTC) X-FDA: 83319279498.12.055F76F Received: from dwarf.ash.relay.mailchannels.net (dwarf.ash.relay.mailchannels.net [23.83.222.53]) by imf23.hostedemail.com (Postfix) with ESMTP id 8E5B214000C for ; Thu, 10 Apr 2025 20:31:26 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=II+ZVnSc; spf=pass (imf23.hostedemail.com: domain of dave@stgolabs.net designates 23.83.222.53 as permitted sender) smtp.mailfrom=dave@stgolabs.net; dmarc=none; arc=pass ("mailchannels.net:s=arc-2022:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744317087; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tQZ8B5y7ZJWu0aZUk8aDu9a2SdfysDdPA1yijiczGzA=; b=mmXV0d9bz81fgRO1x1q8e54+JYLpIOjd+p3fL7wgfn4uZN3zzYmSFUfDAcPGt206U6HxfM 5gNOcH3sSvh+Corr+UQVGa0RmpnqwNCs0oQDqgqyhqxvMLrWQ7YWCCkL/ETF707vxc8Z0l YUA1g5tC7e+26HZGV8sdDpVPTgXEA0E= ARC-Authentication-Results: i=2; imf23.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=II+ZVnSc; spf=pass (imf23.hostedemail.com: domain of dave@stgolabs.net designates 23.83.222.53 as permitted sender) smtp.mailfrom=dave@stgolabs.net; dmarc=none; arc=pass ("mailchannels.net:s=arc-2022:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1744317087; a=rsa-sha256; cv=pass; b=LtCIc0kYziJ2S+sHG1gjVMpYlKRrzrtukhYXWec7bVYK4m45NO0A0ptgg9qSBTAW27gTqe vA1hQXdkOQ174FwbusrTzmwBV22OoFQBQb5SpV5eh+5TsT3zX69ybIyIhaTLDO2V/BM/6I Z/RjyuPe0S6ywfNBCno4u7RPAKkNMLo= X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 979D58A469F; Thu, 10 Apr 2025 20:31:24 +0000 (UTC) Received: from pdx1-sub0-mail-a232.dreamhost.com (trex-8.trex.outbound.svc.cluster.local [100.103.0.193]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id F05198A4698; Thu, 10 Apr 2025 20:31:23 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1744317084; a=rsa-sha256; cv=none; b=NK9FyxfrkX46m+OwSQWB04JhwZFgK5We+dhrJWmHu5XJfjUmlCELTMpXpx/LX2MlnCB3Uf b4f3AmTC0u1Obo16B8iZv5A7lSLxS4rYhr4MEteRyBvR/zMYYXrDz5fL6wo2eoUthQg6z2 MM/06vmrt/OeImADWO4CbKoBBzi3FKDNccELYVH4NSD8ce3hcGhoQx2GGmngr4elBovZpV UH2jlBLaU9YdwjPB3t0VLXmHxMIwNwrxm3AvTmqyv3FeSjJ+2Uf4w2tTarOK1uTct96Py1 3HgeZG1Wy97kRQivMvBTbYjLpU8T46qMH0n5u8tBySRvl70bzvIS5ydhwWmICQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1744317084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tQZ8B5y7ZJWu0aZUk8aDu9a2SdfysDdPA1yijiczGzA=; b=zSmZZaWGvXMvS4XwQr0DNaJqZamdOez2xAhCdRytIcvHdu2HgLhoATD4LHjObF76yGut2a SiBcfnz/uMO28sMp23FoYsyTHRH25pgsfQjk7882CoXBxCLhiJnAXzYPesNj+qVWAVDxmL 0XeAhq/VzSDrV6mdqhGECbd1MVy+zWkC1HJwnZFWFLyr25DkykBPt1AcV5k8N61Lve7TE6 poP2LmzE1H4kCvqlYF4dZRL/d9gTw7ZLXchQJI6nS+g3HO7RB5Yf2PbQM5sUPFsh4NUG8f 1nWeGuNdy64+jX1wJB7dAQpnpv0L6mK4XYyIaHfhe87lCpFPIYf1L6UsUp53Bg== ARC-Authentication-Results: i=1; rspamd-7d787bdb4f-84nt4; auth=pass smtp.auth=dreamhost smtp.mailfrom=dave@stgolabs.net X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|dave@stgolabs.net X-MailChannels-Auth-Id: dreamhost X-Tangy-Ski: 2acc207811187dc1_1744317084423_3382911955 X-MC-Loop-Signature: 1744317084423:1269916336 X-MC-Ingress-Time: 1744317084423 Received: from pdx1-sub0-mail-a232.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.103.0.193 (trex/7.0.3); Thu, 10 Apr 2025 20:31:24 +0000 Received: from offworld (unknown [104.36.30.209]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dave@stgolabs.net) by pdx1-sub0-mail-a232.dreamhost.com (Postfix) with ESMTPSA id 4ZYWgG1nPZz72; Thu, 10 Apr 2025 13:31:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stgolabs.net; s=dreamhost; t=1744317083; bh=tQZ8B5y7ZJWu0aZUk8aDu9a2SdfysDdPA1yijiczGzA=; h=Date:From:To:Cc:Subject:Content-Type; b=II+ZVnScC4NBCWODwGng6NjrSEDK6pIrJruNXkXm5TLzVcX693mnzTxr6DNgySNua JRVNn2sH/PsIt9lV6NcaLamhIAwVMNp91YaD0YgefmycxcI6Ijqqp4ZQasNhuAtUgQ labTyNqRMpc64/X4sy3rnxndaxlXI4a3r2IEcBK8xo1vTxw/T9G02MLvnjcdkHP6hL CzlBJuhsbb+fZFnA2ANmMl6csrlsfdbaBBEBr9H4WhZxd9nr0zDfiUwzXr6BN9sa3o uAuNzioJvp4/K2ZuheBZdmFZ3+tNaXmOVNLAWNLSHbp9dyOmopM2oOsruTW7Onx2t7 QXLicnLP34M9g== Date: Thu, 10 Apr 2025 13:31:17 -0700 From: Davidlohr Bueso To: nifan.cxl@gmail.com Cc: willy@infradead.org, mcgrof@kernel.org, a.manzanares@samsung.com, akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, will@kernel.org, aneesh.kumar@kernel.org, hca@linux.ibm.com, gor@linux.ibm.com, linux-s390@vger.kernel.org, ziy@nvidia.com, Fan Ni Subject: Re: [PATCH] mm: Introduce free_folio_and_swap_cache() to replace free_page_and_swap_cache() Message-ID: <20250410203117.2ctv3cobdgawp7ma@offworld> Mail-Followup-To: nifan.cxl@gmail.com, willy@infradead.org, mcgrof@kernel.org, a.manzanares@samsung.com, akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, will@kernel.org, aneesh.kumar@kernel.org, hca@linux.ibm.com, gor@linux.ibm.com, linux-s390@vger.kernel.org, ziy@nvidia.com, Fan Ni References: <20250410180254.164118-1-nifan.cxl@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20250410180254.164118-1-nifan.cxl@gmail.com> User-Agent: NeoMutt/20220429 X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8E5B214000C X-Stat-Signature: b9hp1jrzmf8hzjdaffceahyyxzo33kex X-HE-Tag: 1744317086-759739 X-HE-Meta: U2FsdGVkX1+obXYLPuDioC8VzZx0/yjCYKiTRPjEyGiNEYwzHYoXgHsfLXrmdI7V9Rn1UCc/lVCOAheCjhKeLJOhGwCDisqAd+igPSMsWtp/967/vrQg1Z/Fk1Xiq5OnwJgXg4Bfgw48zLc9dYMF/M7wbo5MJPlxUmjsWbMwJ8Z8OCKwJqhC9zCB2XJoDwbkTGbrXTmb3+UM5KKmc0o/wULZ4jWxsXJeieuqN7SwqHiHkAcjFWZealOKfP9GEzcwha2HNW7D/vcw6axafjRm7R9mPLjF1N9ubtsUfaG+qpc7tIy9kbJUWpQcZBmuwZOekCnxEqsG4K5rKi2dLWi6po8u48OG32M3PtC29/hCCNzc4k/O0/TgXkt8BwZvnPq/LDpA53EqlsFhZdAh8v4kwpVBVYhBvnm8Y3nKgXTRkm7DrNXoJ2hZRIXNUnxk01kfV2uMKiDXv6RkcQe6kqbF5vpXe5me4dfzOXvNpKj+Ky0WI2vpvhrY6xRLENWSz319PLaQ4shW8XQwcImux1AqQnDzSLkytyhxj86v23+39QreapUB3IbKv/kRXU3UFl09Rfmo/1Ss3g9q7OnrOIW2a+c3uWLFgyXh8rrZKN+LutyKK6oaWOJpRgzRKy9fJFxpuSmq2NPjhWsPqwjiFstmrGmLhyJGGEgn9R1DUKBO56jhdxs13duW+dNGiLPNltWiJIr4QN1MoDiC9Z/EmNGHeE/7Zx9iNwTIvAYXB0zEy+4c46L9N/i+x0FqP0LMELGhKtu+70KlD1jQyd3w0NtrH9qBgpNqY9CDhj42OOppiMPYn4GQcRVwMR7XKqMltQ78cjm9MO0rkSk9PO8AJ/jkZkXXJQtB+XTSr2hQ6wt/zuCq/FK+07NdLkrZtVRqhjguRJFb28f5TkvK8704qawP6BZyvmSaCC7Qv5BorXpNLtiqE9rf17nL7utX+slg4nJNJro8abXHJg5ASzat9Uc pdKqE30g I8DycjEpQNw9V5WPKBIWBppkDx2Kdc/qybG5RekkG20+3GOu6SBFst7bQds8xW/xPn0wgIrYVHq6XBr4k0MzLa4g9LagC+0pnGe2gWOrI/gY85Fng1q59+Ng8uaoxDZjTMaiSYTVzuz7pD4yWFTHmuzT3Jt6Su7SnguRv90HdQ49oBq8F/jGi6hKQb7WCstsiVBJDTdVDO3x2WL3S+HgcoDiXySQmb1M4PiWeGpCoQiY/rBTpe3oqHRY9C4x6SFKEplG3JVJltoACnbziaKVVjzwbd1DwMu3O5P3Q4koqGQZCLLgP/FyugISL4GdwgbdoWxpRDzdLPt3fdUKdSGM3KY2+zZy4oNBa7OnziSS0MBKV7zaextE7jUICEEPju6eIOwTRyo5DUtU2YnKhPAsUpGQVjj7wQTS2efqdQDgpAK1SkGPpI+C/cbmCC6+i/usgB+00MXxzx2PMJIWtnDPSaEyIBX4JY8++VKan57vmipVDMwgPKZpPAf2We3+R2S6dUJRRSv/5nv1SybWWL/KjzyoItjiD9ivgM5Inf3RG3FgAl2mqwlJkUL5OslTXHtI1q9xJIrTNZTx/6YH6nIY5uTELRDw0r9denFWoGLw4CHetJb8j9eYRfc+y/3l9cCQNbAF1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000546, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 10 Apr 2025, nifan.cxl@gmail.com wrote: >From: Fan Ni > >The function free_page_and_swap_cache() takes a struct page pointer as >input parameter, but it will immediately convert it to folio and all >operations following within use folio instead of page. It makes more >sense to pass in folio directly. > >Introduce free_folio_and_swap_cache(), which takes folio as input to >replace free_page_and_swap_cache(). And apply it to all occurrences >where free_page_and_swap_cache() was used. > >Signed-off-by: Fan Ni With the already pointed out issues, this looks good. Acked-by: Davidlohr Bueso