From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C59D7C369A2 for ; Thu, 10 Apr 2025 17:32:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E40C6B0317; Thu, 10 Apr 2025 13:32:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 03D436B035E; Thu, 10 Apr 2025 13:32:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF8316B035F; Thu, 10 Apr 2025 13:32:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BB31C6B035D for ; Thu, 10 Apr 2025 13:32:46 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C383914111B for ; Thu, 10 Apr 2025 17:32:47 +0000 (UTC) X-FDA: 83318829174.23.76A3934 Received: from crane.ash.relay.mailchannels.net (crane.ash.relay.mailchannels.net [23.83.222.43]) by imf30.hostedemail.com (Postfix) with ESMTP id 74DE380006 for ; Thu, 10 Apr 2025 17:32:45 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=YvqM+2ss; dmarc=none; arc=pass ("mailchannels.net:s=arc-2022:i=1"); spf=pass (imf30.hostedemail.com: domain of dave@stgolabs.net designates 23.83.222.43 as permitted sender) smtp.mailfrom=dave@stgolabs.net ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1744306365; a=rsa-sha256; cv=pass; b=LlkvP3Pj6tHUWhlbHZgs/8Oud8mOZ6lsHxPTeZE0pyUgmWGNLPP4clKEl94L1aQCGmnrCB vMuwYLcCJF/I+Co+Jlx+bcqEUT2Bm6UUXzBxl8NPzbSufES6yhmooEmZZqIW8wExn1LOW1 ePaCgSx6iQwS1RN+vGfYv5WbhOCIhuI= ARC-Authentication-Results: i=2; imf30.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=YvqM+2ss; dmarc=none; arc=pass ("mailchannels.net:s=arc-2022:i=1"); spf=pass (imf30.hostedemail.com: domain of dave@stgolabs.net designates 23.83.222.43 as permitted sender) smtp.mailfrom=dave@stgolabs.net ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744306365; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lcTCH9aiGqJzfggr32r0X1UsU9A+is5S7inOOX9o5eY=; b=kRuaTijzLHwwihlNfeEeUStvP5FGw3T17CPNHJKWaOXOoFPALP0sZ2kh07NYNEXGy5TUuV Ycf5bMo2BrDG2aqMTqF0VuJqHpnTkestjoa9K6NTDlTkXHJtLCMl70uWy73T/GD8TWCCPB kp4SjDXl+SMWixV4TDj/h/X8fYBIK0s= X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 001E5784B8A; Thu, 10 Apr 2025 17:32:44 +0000 (UTC) Received: from pdx1-sub0-mail-a250.dreamhost.com (100-97-35-35.trex-nlb.outbound.svc.cluster.local [100.97.35.35]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 52B0A784AF6; Thu, 10 Apr 2025 17:32:43 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1744306363; a=rsa-sha256; cv=none; b=JyJXISEdm9FUw7mVqhtX17IyBuYOI/dQDUg7iyD6GlrD/it6ZUa8jlRxA2+j/XSq2NWOkp 84eJ3m1vtX0i9aEKeJmde1NXIUHatHPRaG0QODtMurIttyJ7x+jQQriaDlO4Jw5m3r3S3n hj2gexh6Qb7zbLBnkf9x+RfR/SkyhHSF/FtZR/HzbwZVc4m/VwUCMF8dLXLCw1L0093iRW LM+17rWbvYStxVJSFfPkOGY38Z7/YStyyBZs0PU2rPIXtLF+7UZ3lYzJ4ZUjoxNzRi9780 2xIQPt2zQo36/q945tQk4JcnAt+KDUP/aNbdpfKhnIS3gVOiQ+O0NdlmxnJ0WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1744306363; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lcTCH9aiGqJzfggr32r0X1UsU9A+is5S7inOOX9o5eY=; b=PMhbia2QBPQApxDJNPfGgWOyvFMWl4dm1HCCjQQ9tEQSD0Ib2R2HBdxDsHrfu6tw1ognqR eCFnf2ByBIF8cbssGJ9MzOTkyo10oW0Cvr+12nAJF0fGZZ3tgb4jKxeol0giulu2bdz+Ww lXcwrwg/Y9u9gdVorjhfrVGrb6hSRdq3Aysx/8YoK6Eyrt0d9f5l6IuysbeoMsQKGpJBx+ gtDvRA+Hd8s7id29zlee23luC6JRTR8mQA+wKfl+NR1oji97NZoAx4JgP2UDe+4irnMR7R n8RHw9lusAllFHgPJCwyxlEG4prN1WY8G++HeMnrC8OiFtG464vWQCHRxueQ2w== ARC-Authentication-Results: i=1; rspamd-75b96967bb-8k868; auth=pass smtp.auth=dreamhost smtp.mailfrom=dave@stgolabs.net X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|dave@stgolabs.net X-MailChannels-Auth-Id: dreamhost X-Thoughtful-Unite: 098cfac60da347e1_1744306363722_3962588475 X-MC-Loop-Signature: 1744306363722:357417711 X-MC-Ingress-Time: 1744306363722 Received: from pdx1-sub0-mail-a250.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.97.35.35 (trex/7.0.3); Thu, 10 Apr 2025 17:32:43 +0000 Received: from offworld (ip72-199-50-187.sd.sd.cox.net [72.199.50.187]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dave@stgolabs.net) by pdx1-sub0-mail-a250.dreamhost.com (Postfix) with ESMTPSA id 4ZYRj527cGz70; Thu, 10 Apr 2025 10:32:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stgolabs.net; s=dreamhost; t=1744306363; bh=lcTCH9aiGqJzfggr32r0X1UsU9A+is5S7inOOX9o5eY=; h=Date:From:To:Cc:Subject:Content-Type; b=YvqM+2ssz/SACKKaTcst695zmgpo4d92CYxgxgRhGnlHnE66hdYGQsBFuR1N9dCHH 60KirkvbYxy20O/R61o4CELwzAIT4CTTrW7BaeFC17tONX5F6ZWhv4yLcJ2irUmWGE QdQR9HH7yI0Bt1xP7xww5IsPrk/mKUre3ypL4KxcnwvVmIvvvAN+ppwecFbSgIZwUM AymsvQV5EGLU0VQHPgDnPYsUbl9dRYimh4JGLkAmQXGKJ3yCF9RgbY7eDu+9a1xIN4 PrH7Vo1+s6CJuiYavdFT9hcInXBJY+cH1YRVUFlf1OsAxrnMpg2YYcY588YpEaJBeW v/t+PukR3IWBQ== Date: Thu, 10 Apr 2025 10:32:36 -0700 From: Davidlohr Bueso To: Jan Kara Cc: Luis Chamberlain , brauner@kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, riel@surriel.com, willy@infradead.org, hannes@cmpxchg.org, oliver.sang@intel.com, david@redhat.com, axboe@kernel.dk, hare@suse.de, david@fromorbit.com, djwong@kernel.org, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com Subject: Re: [PATCH v2 6/8] fs/ext4: use sleeping version of __find_get_block() Message-ID: <20250410173236.jk5cksfw5zege5n7@offworld> Mail-Followup-To: Jan Kara , Luis Chamberlain , brauner@kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, riel@surriel.com, willy@infradead.org, hannes@cmpxchg.org, oliver.sang@intel.com, david@redhat.com, axboe@kernel.dk, hare@suse.de, david@fromorbit.com, djwong@kernel.org, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com References: <20250410014945.2140781-1-mcgrof@kernel.org> <20250410014945.2140781-7-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20220429 X-Rspamd-Queue-Id: 74DE380006 X-Stat-Signature: ros54qabhykh1um1mz5oc69poezhisut X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1744306365-480873 X-HE-Meta: U2FsdGVkX1+kmBwObPnD81H6lPGWpvTKvMSmGq23BiXG+kOzIXjhLz1Ra66mSVWy99c1dC1RRkj1dQTBvCkRLdkEYgfR6rDxt+ChWfnEhdOSnDur9V9LcGo1HbUz1zRe7T2O9bpnzKs4mjdVnSegcuD6BfK1/1zzvZTeMcBOhQFBCPGKZlcyGt6AKCUdMXfKxCD9KeYeHp+54GYHKd1P/XhlmtVaMZ3VzZyWUnRbSewnDCU+LogBOPsBKEC7US8dfjkadNoIZDAvgbjtzqJ8C4kBNy5Ngjlrvbj7qJioWwxeJpatPf3CPUJ8Ah0OrxaFXMq1mtmqtWitaJGR7aSNsCXzKn71WylV7OJSRFXl68XIyQxYPPkWCCE9Zm574soXkMr23Jj/C/UkHcOGxIjI42dFz27t1kr9Ydiu/zbDQA4f8EljaA653Tr0CFaWBJJ1ViiGvyIAMfjF+yJMI6ntAv285FDy8Hec+Q/PANBH7rxk3IKDsSpSyBtWvisowp4WqsEskJAlTN6ec3H0kzMr08RdEELqgCghn+4Xicoq5SC7Kjd/YOK5bKIFBCUa9hbXbzvEAMiG77RaUbuQy2ZG2hlfe6AlQUfvraRd5p0MBX29AKOyYD+wZT723x0TrlKl1GIEL6oiwjcxfGQ8BwTO2DS+XUL6N41EL5xaRgfMdaBK9eekeGJVdilSwKMuNIbqHIUSqpvTVH1EAQ9sCYOTlDcCnqFksCsC7dlzFL+aPCJLUxCvpgRDh3XqCw7iZL1+xGxLuvC5ZsfeUUybGRYo6kvBWP7C+rR7n06GcqnJeUFCuRzpWEHAV1r20BIydNvJFTGrfoPTHHhxIvXukm1/dQq1stmSr4EX2tVycikfZT6Jf6cmTgZfePy04ySv66fPXP5wSk+DEMSsXylulf1yDmsr6ZyQtQSUdQrIImqghuSU0FAhAg9mEmsGv9ATVLJpeDkcNhgJyyCEkhfGdp8 pfc7J9nT lrUjJIGD+sEB02iasnuLa3O3ZQ0oWjr29Xb5IH96aA3BspflOcmfxk5xNq4EURkbyVpXp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000016, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 10 Apr 2025, Jan Kara wrote: >> @@ -860,6 +860,8 @@ struct buffer_head *ext4_getblk(handle_t *handle, struct inode *inode, >> return sb_find_get_block(inode->i_sb, map.m_pblk); >> >> /* >> + * Potential TODO: use sb_find_get_block_nonatomic() instead. >> + * > >Yes, please. Since we are behind nowait check, we are fine with blocking... Yes, I will send a follow up that replaces that getblk_unmovable() with sb_find_get_block_nonatomic().