From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EE13C369A2 for ; Thu, 10 Apr 2025 17:30:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C19326B0345; Thu, 10 Apr 2025 13:30:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC6896B0346; Thu, 10 Apr 2025 13:30:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A67BD6B0347; Thu, 10 Apr 2025 13:30:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 86E826B0345 for ; Thu, 10 Apr 2025 13:30:38 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3D72114111B for ; Thu, 10 Apr 2025 17:30:39 +0000 (UTC) X-FDA: 83318823798.10.F7C4DBA Received: from cyan.elm.relay.mailchannels.net (cyan.elm.relay.mailchannels.net [23.83.212.47]) by imf02.hostedemail.com (Postfix) with ESMTP id 9C6DB8000B for ; Thu, 10 Apr 2025 17:30:36 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=UUqUSk7O; arc=pass ("mailchannels.net:s=arc-2022:i=1"); spf=pass (imf02.hostedemail.com: domain of dave@stgolabs.net designates 23.83.212.47 as permitted sender) smtp.mailfrom=dave@stgolabs.net; dmarc=none ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744306236; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t+oYNTEtBazT/u3SGm75P4mURykaPqZ2OKAXDYWbnK8=; b=aq0X9XoJ/RCTCwWf6waZt5zZsWVlGbJFF2H9DZvM3vk+m+E79o1sttccN7Dc7TPqqFDf4G J+C+Ld+lVm2tZvZ1jRhnL0wbWr+iRfBJXiS6fAXcGe0VZ7/kooIGaSo47UCslZ6yHtHRUa PUjSy6XAD/US3NnKD9+G18/JKm4wDJY= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1744306236; a=rsa-sha256; cv=pass; b=d2zHp2K8FQGAezg1iAtLtPvstJL+eDOewg1P+bXKWy7KmzKwLlYylAkgasf/0wU77e8R/x iVnqgC7wegbe+/wlWWeVwdg6QzZXMLPSsU86k87eq8FvQqW75T0lA2VJZUVpNVR00lZ0VO NTuvJ3euD5JU6szNI0ngZv3qTl+r3+c= ARC-Authentication-Results: i=2; imf02.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=UUqUSk7O; arc=pass ("mailchannels.net:s=arc-2022:i=1"); spf=pass (imf02.hostedemail.com: domain of dave@stgolabs.net designates 23.83.212.47 as permitted sender) smtp.mailfrom=dave@stgolabs.net; dmarc=none X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id EADE8183A43; Thu, 10 Apr 2025 17:30:34 +0000 (UTC) Received: from pdx1-sub0-mail-a250.dreamhost.com (100-97-44-91.trex-nlb.outbound.svc.cluster.local [100.97.44.91]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 628C91833A0; Thu, 10 Apr 2025 17:30:34 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1744306234; a=rsa-sha256; cv=none; b=Lm6I/Hb4iU7NDmuUwx5azvSi8cdQxTRmxGQP3eXZrbVMpBlOgLEFA/nsu9M14hpciulNAn Lvw01q6tMhj3RTrYGdThy1pg+VZWmO7oCM7DaAoQ9i4jrWO2WE2Os4eRSxT4szm7K6u8aO XlvvmV6lvTuPPz9dzOXHAbe9teRRT7j9PKiPDow5HZtF/4AGbY0yMQAypEVRscLVUcIxrG EjrEDqz2FHV6Ylg73qko53YW58DgdBcdN4JBvzLakV/n7rINk5TFWHOi3RAgb/bcy7FPXN zjDnwkfYRpy2OSZ4xmPxGlsM+mfolWJBlHOH74hJfhrvWe4E4SOEbMJmgfcf7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1744306234; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t+oYNTEtBazT/u3SGm75P4mURykaPqZ2OKAXDYWbnK8=; b=OZG4s0/FK+9IkHyZnUy+qgUH/wZyjaVygxj6jcxTfGl2x1J33Nl9l0HFSsRPy3XB9J4JxJ jjhKoe0DTpOz3i4ozIHz/NJIR1vvfQJXef11S24KfmCVqCR9qbI8PNnGRr+j+VoPsXJWkk BYb16icIKIsDXzoy1xEXgAksZ9Wlpph9JqhDW7uCFNKck+9lJ0ygAPZdSo006lmymz07x3 fZGSZL1Tr7JuFKOCXhe6HUil2yveoIrZZPlhw1YgHAgUTtN86y1a0Y4hh1+2lxyIEkSOcK UyQTkY1DZ2ECpJYpQnLqx83WejBmuSAeAiFftvtsu2UjRRic+O4WTq+w3qOvuw== ARC-Authentication-Results: i=1; rspamd-75b96967bb-96crn; auth=pass smtp.auth=dreamhost smtp.mailfrom=dave@stgolabs.net X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|dave@stgolabs.net X-MailChannels-Auth-Id: dreamhost X-Bubble-Macabre: 37d8ce8e175e33a6_1744306234805_3271725725 X-MC-Loop-Signature: 1744306234805:3416749709 X-MC-Ingress-Time: 1744306234805 Received: from pdx1-sub0-mail-a250.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.97.44.91 (trex/7.0.3); Thu, 10 Apr 2025 17:30:34 +0000 Received: from offworld (ip72-199-50-187.sd.sd.cox.net [72.199.50.187]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dave@stgolabs.net) by pdx1-sub0-mail-a250.dreamhost.com (Postfix) with ESMTPSA id 4ZYRfc28Cpz70; Thu, 10 Apr 2025 10:30:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stgolabs.net; s=dreamhost; t=1744306234; bh=t+oYNTEtBazT/u3SGm75P4mURykaPqZ2OKAXDYWbnK8=; h=Date:From:To:Cc:Subject:Content-Type; b=UUqUSk7OOKeKzELRdmJjZ9yqnpuWJsLNu6v90laLWXOp5BvYpMC6VcQ4GWYaKb3jF zCzM6DQE1ub8ulevbbp1qfkmZwwxqRdqNS9qjv03NIqKR6HYjWqagFxf+/vn44lRt5 3cexnIPpJk1MEp6dKBw0aNCGan80IBTcUoQ7j6hm7d5i2detXiOhK/16Dz0i4akzWu rcvVZ2bLoX1kJGryM4XYpO25ua1DxfHwmawajZJlbKE6OiuxdoBBWNIPbZjRJzYoqm qgsiLipPCi4Ia5/6BEqknekJkKhN2s0309gtG9Za80C1oyfi87VZenrsKCS9Jf8Qgv 73VD0kT3iJN/Q== Date: Thu, 10 Apr 2025 10:30:28 -0700 From: Davidlohr Bueso To: Jan Kara Cc: Luis Chamberlain , brauner@kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, riel@surriel.com, willy@infradead.org, hannes@cmpxchg.org, oliver.sang@intel.com, david@redhat.com, axboe@kernel.dk, hare@suse.de, david@fromorbit.com, djwong@kernel.org, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com Subject: Re: [PATCH v2 7/8] mm/migrate: enable noref migration for jbd2 Message-ID: <20250410173028.2ucbsnlut2bpupm3@offworld> Mail-Followup-To: Jan Kara , Luis Chamberlain , brauner@kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, riel@surriel.com, willy@infradead.org, hannes@cmpxchg.org, oliver.sang@intel.com, david@redhat.com, axboe@kernel.dk, hare@suse.de, david@fromorbit.com, djwong@kernel.org, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com References: <20250410014945.2140781-1-mcgrof@kernel.org> <20250410014945.2140781-8-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20220429 X-Stat-Signature: mtfy35ojewik84u1t1kb5gt95n8rejqk X-Rspam-User: X-Rspamd-Queue-Id: 9C6DB8000B X-Rspamd-Server: rspam08 X-HE-Tag: 1744306236-610279 X-HE-Meta: U2FsdGVkX1+zimJQcMaad7Dl6QAgorI+XG97ZfEGtjA/hUrI6Dl7Cnr8rDXiBMsZX+yFwx39IwNbQBETqCwRTOuQ3c0QQTFVBJbEi1BTjqXFCjUbKWdeGeqF1T/KgbfUWAGFM2FwnLsNJvNe9B2glpGdfUWecNb5tOH2h10O7uGIGnvvyncEC2wp2pBc/gbdvQHhyWmKkAZDG6XDCxVsG+k44CKn7i6mkrFaVufeytdmzPqHdJd93bo3ZF8JcoOK4Nqxsysdv/b0Ecee+N2FP/HO9+dvRoJs8UQN4eV7WnWWXUsVgaW13yZ2TOfuKoyXup93BSo6xugTDNrMFuJRJHURimh/CbfFdmH54JTPM0EKTsLM96p+Ts09c9xq6BEYklRz7ZxNkjVc+EpgLqB0UaZ564ibSC0g6Ag5w4Saavysi+uf6L/X0n18Zv43H6oNET2dWvruqJRuit6e/IgtlwDZQ/EJqy07lR7QPavCeyb3orRwVUcYB3ooknR0CiACSTlI8vK+7lW7GlGVVVL1zq82p4oJCjBijtGbrQWWN3SVeE84URg6+4rJt+xBifPOWFE206Q/kW2lyEUu7ZS0ksHk+fgRvf3uRTcIjoMN3Y8p4yuGfFdWlX/Cc5JPFUv07r+pm/RwokS3cOmpr2MBBjyt7QV1EvCHtv2+CwKj+xZukudAI9HlkR3xBdRzqp15zsqICAJYdqay1SE7cafUMomvXJvvQq3ufBHhkanCThuHV5zj8mvmTMHnd83GRFqxWClSpDFitPuMH6SQ93JKBz+Wr1vaJgBOO4AIPcMOQdNvoQVoBUnlE0OC+gJPZgKUtfl929d/flZqK5Jt4e6mHwJpoxIxyxE2cY9FwDSUMa+00bZQvAtcjcDUIXA2+5Tfq+71bk5BQM9SBfCuM1x2noEPBnvn1jjjMX+fQpU8pAvscctIJMcis+yADmqK/5IuVKGTdyUe3cP5RmNf03e LDpoeBdE ViHSm9wkSQEQDMJ0jNwIGee9Sm8M9tUvZnBnFSY37pPNC/R+St9JT+QGE5sm28EWYXTLcywDyqiWqqXBsVUMA0c7O0TTbDQPAr0IRsTfT2o4hVZfWweUPNPF1WKcFbZzFZchRZ8PKN/HucQ6TRtRzaeAFuFoe39GKV6yqAt35KQvgxiBr9Ktq7hF1xVRn4johl4aEIeN/N9yFYF9zFN2O0HgaEIQQ/FQOHCxnNKidVj0alhHc5LO5K+did3y1xBqNag3zrYtMnO17y7Oezq5uvoKREcoQPTkEfzmKH+Qw6KowpWAVsEsCIxhPJ2d9AEW4cD3jrVqDBcT5Pvhhav9GJBUGSCu05+vD/Bv1iRSBk32MJsg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 10 Apr 2025, Jan Kara wrote: >> @@ -851,6 +851,8 @@ static int __buffer_migrate_folio(struct address_space *mapping, >> bool busy; >> bool invalidated = false; >> >> + VM_WARN_ON_ONCE(test_and_set_bit_lock(BH_Migrate, >> + &head->b_state)); > >Careful here. This breaks the logic with !CONFIG_DEBUG_VM. Ok, I guess just a WARN_ON_ONCE() here then.