From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80420C369A2 for ; Thu, 10 Apr 2025 00:26:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 02C072800B6; Wed, 9 Apr 2025 20:26:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF5162800B5; Wed, 9 Apr 2025 20:26:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D96592800B6; Wed, 9 Apr 2025 20:26:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B80752800B5 for ; Wed, 9 Apr 2025 20:26:31 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 458D781580 for ; Thu, 10 Apr 2025 00:26:33 +0000 (UTC) X-FDA: 83316243066.30.56F20E3 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf28.hostedemail.com (Postfix) with ESMTP id B1C3EC0004 for ; Thu, 10 Apr 2025 00:26:31 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RK6L9TRi; spf=pass (imf28.hostedemail.com: domain of sj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744244791; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JYmPDG3EIHU176o7cPBLYSRv+KzaR5Dfp8s464/7fAk=; b=mQfMJkjTroakfBF7beTtw9B0K63mTcuXWJqfJBuCyhWP8gkZ8p4+81sGFLnTNA8AiAShWF kk005JAtaX3MVeQSXZva2CqIqwvfkYJ2NjXO8n4elAQLmuzbZdOzmqKC4QrnYfYsyaWRiD 0juBMHYQiqFJJQDQZYVeXzI8bAyQ6m8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744244791; a=rsa-sha256; cv=none; b=t2GdldltRlgw7qrT78hyu2ieNQnICZXgZLjUnis7r2CCoWxPmh74UWt5Pej+SM10et+Z0K so+VnimjNW39Y/MGLYc/6QnOJZdchT23YroI5V8A0mQjbEUccExqPOUFfNGDyxNQf9NDaM qukqseVomLqVT5sITOesUNoBUwOmPiM= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RK6L9TRi; spf=pass (imf28.hostedemail.com: domain of sj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 41AD16112C; Thu, 10 Apr 2025 00:26:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96EDFC4CEE2; Thu, 10 Apr 2025 00:26:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744244790; bh=mf7dlN6bui6TyvxORYOq971NbU/Gtl454K5wEcxrs8g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RK6L9TRiHWI9SoBGN5hSdYsUZIpTaeKPOS3pjP1T5sKtYW9vTr6W6v3OYAqa64FuZ NxSAi6dsKTLP43qcHKQFXzeMarFoDZXZVuQoxRFn2NbHIMui/FJLKZHKsOblrR+Zfa cYsNHc6gLiyiclUAcWWDSJhMz4CFl44fghjLjCM6HefQ1ViES83ms6IxJ11HkKk2cA 3dfA27Cl8BQLHdXxkHQpXAWFdZ6FF2qf9FpA1BHhhn1myLBYoYfWcTIMXsOOJmjI8v oA3cQn39p0dmw+b8DNEMsM0yzgdiRxRtvv7OgYeZuIsBxuBciqmU27jRh64aRCwkt3 lrshgQoro/hgw== From: SeongJae Park To: Baoquan He Cc: SeongJae Park , kernel test robot , Andrew Morton , Kemeng Shi , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Tim Chen Subject: Re: [linux-next:master 1753/1936] mm/swapfile.c:1517:20: warning: function 'swap_is_last_ref' is not needed and will not be emitted Date: Wed, 9 Apr 2025 17:26:27 -0700 Message-Id: <20250410002628.7927-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: n4mnbnga4gr6utzsnoamdr3oh7j9zzcf X-Rspam-User: X-Rspamd-Queue-Id: B1C3EC0004 X-Rspamd-Server: rspam08 X-HE-Tag: 1744244791-572734 X-HE-Meta: U2FsdGVkX1/+68iJy2MHgYLQ5QMSIbjaxqXmbTArDDSqIxZez5sdGFetfI6MKgOAfZd7j5BUNU72ZraBHNSYe4LrbtRpOAmFdgKoypLUmY7Fi3BNo1UBJ1piX7Gcu1Y5pjctSejDv5veUV5nnKiALOkSsYODBhobi6cfof5+O/NwyxIwNKdTQ3FFRucNA8+udcH0QpmLpes6dF9jDzO6SHlMcoBGrIi1mJWMKXZpRRSoErjxybASf77xAQrEMp17ScA/F+bDczVeddb150ToxNCs7o1SqPhY2T16D1ZgSeZBmq+rhmm2f+NNeFB2vKpF2GvU5rS53a2LjHLF8Iai25aqlU8HMBeEVUz9raES4Z9D7tYy/aOG15ZmiPaHdKBT6+yNh+5ufq6hsKxd1tc3qH9/b8vRcAytaCXfcnGMYV9KSiFx7B95ODX79kuTwoqYy4GxAiMw4RBRiJPKNkBROG4tJc7UQHHs7/O/p53JFjxxmI4dRfE6Dq/an2rLsMt6lnHSMxl0ZgB7HavZjxT+t8ruJLABTEqSa1ri6eU4Z2ng1rUvmn0U2KCJh979vcRvrdpuPrNxhIlsjb7oFyLThP3XwL3JIwSRO5XeMEgN4+NZYpehPXzYeP0NLBpHrhJqXrSZGpvjPT+2/wyQPZ/vMw4mUDc6IyD7V58rmgFV+aQ5qH5n460WuvI/izoUqcyV5gH58WMwyxc4umgPFLus4ab5hpg3MitXjog+rd7nkY0Mq9WanBcGalM90R+P80e66vyhaCClZVHiAVUflrc3gtkpgGoXYGSWJaLSBAIs0gVG9wo7goO6Ma6VrceKttC+m7SYXuF6HAPuYO3YyIKXsB+iEAUDFTMY+6HL0cZ8WKqYblKzOA6Vt6yu5BTP/3ipL7S9mX49Uqas6dt+X2xtj3gUcb/oqUWED+l67+ZhdPmmTqB12p9R8SWgas+JCaWhoknBUBZLsD8ro6LNR5L h2r6Ye4/ XHc0PlbNUzZNxSc9HgJ1smvB7KJy+7oitwyJe5Lnw40qxz3SfQJmDNzTdkk/O7bMeZthnf5LzQGcV2stLzXzH+vV0869MEuBzYuvGtpKosU29it2/ns/07Up0dibAK7TbCHWzHldz8PgMczqahhMA0wsuUISA2EyHYXEKkQxCe1D1ntsvdaX/PyavSUGXrBn0YkCnVrOMhk4gZdpoGfb19hqmAMojNjyU227Lbs5a2Qv2/aW5PY0QejBoMgkA9UhqmTIcJyQpjEHsso04aWGTsMu2HD5893/wmwx+njiBM22PilJAEhx48PgWAw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Baoquan, On Thu, 10 Apr 2025 06:45:45 +0800 Baoquan He wrote: [...] > diff --git a/mm/swapfile.c b/mm/swapfile.c > index 2887ed5d34cc..08b52346cc39 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -1539,7 +1539,7 @@ static bool swap_entries_put_map_nr(struct swap_info_struct *si, > * Drop the last ref(1, SWAP_HAS_CACHE or SWAP_MAP_SHMEM) of swap entries, > * caller have to ensure all entries belong to the same cgroup and cluster. > */ > -static inline bool swap_is_last_ref(unsigned char count) > +static inline bool __maybe_unused swap_is_last_ref(unsigned char count) > { > return (count == SWAP_HAS_CACHE) || (count == 1) || > (count == SWAP_MAP_SHMEM); I confirmed that this fixes my !CONFIG_DEBUG_VM case build failure on the latest mm-new. Thank you for quickly sharing your thought and this fix. Thanks, SJ