From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C642DC36002 for ; Wed, 9 Apr 2025 21:11:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A5E62800A8; Wed, 9 Apr 2025 17:11:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 454DE2800A6; Wed, 9 Apr 2025 17:11:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31B7C2800A8; Wed, 9 Apr 2025 17:11:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 13FF02800A6 for ; Wed, 9 Apr 2025 17:11:35 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7C6035A5AE for ; Wed, 9 Apr 2025 21:11:35 +0000 (UTC) X-FDA: 83315751750.28.38B0164 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf14.hostedemail.com (Postfix) with ESMTP id C8D9A100011 for ; Wed, 9 Apr 2025 21:11:33 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=EkpCov4T; dmarc=none; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744233093; a=rsa-sha256; cv=none; b=nxYg2vqWOka9sBdk1iYEtanTuIvdlIaS3+EwoplgK7nS0O9KG2Z3kjh1Vg5y5ctHc5OK83 QLSTKCcuNapfZprHnUYzY9EFmmPh3A8bQ9kN3uW3tsoYyNk4TA2ROsp12BEU2ToQJ2HxzJ GEE6qcZR9zv8Mqohw3HdR9Ekyx9F8ok= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=EkpCov4T; dmarc=none; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744233093; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hzCbSvALzNjGrQokU8NjYQz50IuTbYyLp9tYpujyCqA=; b=JKd+cyz55lkttbBac/RzX3d2w89eI0DznZLV+Uw11Y2o9OmeFlBrMYBBSjYJ4hadpJeHgD hD466PEfCMVaol1hK/WLaLM+LRSwzur0ocGHUWI7nE9GZB5citLa7ULbxbkw8w4JbBuowJ YB6u3anZ8XaLkQi/MeKDYZKJqClDxdA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 258F961127; Wed, 9 Apr 2025 21:11:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6031BC4CEE2; Wed, 9 Apr 2025 21:11:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1744233092; bh=wkDkk7Z7cHX0G/3db/Y8x874CyZ7qgRMDvsW3aX43Mw=; h=Date:From:To:Subject:In-Reply-To:References:From; b=EkpCov4TlqvKEMnRMX1IEGR3zgILgKvQFRsBgMWR54sJJEx66O/dYPxv0Xulirzrs vz6lff52oiMZjAnl6I9LDUCXOWCxOuNJ2rE+3w6WYAwW2dXV0fbn6JtSzENLvM7dKF wQs+1uZT0bs9HXm+1RBEc41UzwO2r+Sa9251Pc0I= Date: Wed, 9 Apr 2025 14:11:31 -0700 From: Andrew Morton To: "T.J. Mercier" , Suren Baghdasaryan , Kent Overstreet , Janghyuck Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] alloc_tag: Handle incomplete bulk allocations in vm_module_tags_populate Message-Id: <20250409141131.bd67f6b19ea7e770dce40ac7@linux-foundation.org> In-Reply-To: <20250409140848.da67768ac1f5e79d7296de4d@linux-foundation.org> References: <20250409195448.3697351-1-tjmercier@google.com> <20250409140848.da67768ac1f5e79d7296de4d@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C8D9A100011 X-Stat-Signature: 1uuqr16i17ei4h859k3e8f198n437tio X-Rspam-User: X-HE-Tag: 1744233093-259596 X-HE-Meta: U2FsdGVkX1993/qeLOs/bh/BoIwVndIoXymLA+d+1hJSlgvs3oSG2M1oZfxV3BU00UKimX7mkRzaFOr/HSCHIBOyj3DPL8JlJ4k/Tzl5vYhsySTI280NFprxf8OOFF4G1tdnz6hSQ2x4n7M1HWHJOxY3lxJdw/DL85KF6vomwXxeXeMVWTyp62rzdEpkHayfx/DLb2pajgG4sI2v1mtftmdxRtJ3u04JbwINGgQV1PUzx/N12AiCHGIMtRHrSHIVRcZmpIoPfQtlDNY+KhM29eWBs1rmA4/hACwJQcf5qYQf6opz8WwFMJH3hyucKRHFc3A0CAj2Co3eSpZgSE1yTMPJ06B12cpkL7IgAmXRfFgezIrx5E+6tW7X8J6m5tuASTjxIEj1jbY5AUqTvbzzX+Cue79Cu8XaQLQnyjYEDaRf7JCOcZ/SHI1YtoPi02kfJgo3v325Ughd4v+gTeIZNhFKdrwBfgUZhMPTo32njRHI3/Z+Jx2CGDIZoe7l82hmlXoIalfO8ZQZZxbzHpIftkm+maT2JtZHZDXT9WzcU8Wm6g5ndPPM6TrjUyIgrERf4EtwIkeyfII9ww7MB5pcj9NfCzjgDYmOyK3wKGmXmaABfWxinPAuinWkgYgD6BfRbyrMxI4AJWiVEoIVfjI1qdt4v8PvdGSUf4+yoZlQrXhEJjEldndWzX7AAlAfrVazK3rA5kV+ROEJCKgz2ZI/+NsNbUwagXzfb9iYlP2oSw2WnQE/kcqplYTtAF6uMtZYX64xDxKTYvv9y3ia7B5fAta+wFLRrCexZdNsEsw1uEnx4r0ZWCGGtWbCGoGYWECoCD/AqZA21Negj+JB15pLJndBhDDtbWZjibQmNq8whnK2NhycheIXUo0XTUPSMJHj/D0Qaex5uK6i+IMzVW0xAAFyT2QmnYdNnl4+z60/W3wY+ZdaWttBZjKbZ65Z2f8rY2VF7OovtWPXt8QM9c4 VBc1PYHP nL/nhLktr9Sv48Si+09rM1Moxr7HVySz4H1/F/QrTQw6uZiLTKkjFYWrlJvOxqaz3Vpk6wT1Bm1DQlM/iVV+KOyfqr+n2jXkhRHWLWogLOXbshuFcHzVinYB5hn6Z4dZWCsAUizm1Q23vKKJqBxRrEDxvzEwX4ObSnA2VWGmMmOP9P00aA941CkJq0yI6agzXQPFOKD6CsjwEuRtTalzKr1vqU9hWk77KcvHu+ZHtJ07dLyxw2rccE0vsAKnwB1/ASOP73M7qyzH5qnJyZmHr/AkGdEavBYPNsrifHkYg2uRl63zDls3otOYw2hYCEF+E3tqNYL/MKJ77kxKOeuz0YTOsg8c814awFS64+Uj31EBXZ60wZqtAuSLgTX4+MqtLW77j+dUUpjY6tP8JfkFYtkq+5w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 9 Apr 2025 14:08:48 -0700 Andrew Morton wrote: > On Wed, 9 Apr 2025 19:54:47 +0000 "T.J. Mercier" wrote: > > > alloc_pages_bulk_node may partially succeed and allocate fewer than the > > requested nr_pages. There are several conditions under which this can > > occur, but we have encountered the case where CONFIG_PAGE_OWNER is > > enabled causing all bulk allocations to always fallback to single page > > allocations due to commit 187ad460b841 ("mm/page_alloc: avoid page > > allocator recursion with pagesets.lock held"). > > > > Currently vm_module_tags_populate immediately fails when > > alloc_pages_bulk_node returns fewer than the requested number of pages. > > This patch causes vm_module_tags_populate to retry bulk allocations for > > the remaining memory instead. > > Please describe the userspace-visible runtime effects of this change. In a way > which permits a user who is experiencing some problem can recognize that this > patch will address that problem. > > ... > > Reported-by: Janghyuck Kim A Closes: link will presumably help with the above info. checkpatch now warns about the absence of a Closes: