From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A44F5C369A1 for ; Wed, 9 Apr 2025 14:03:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E3976B01A6; Wed, 9 Apr 2025 10:03:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 86DFD6B01A7; Wed, 9 Apr 2025 10:03:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70AFB6B01A8; Wed, 9 Apr 2025 10:03:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 526EF6B01A6 for ; Wed, 9 Apr 2025 10:03:13 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7E4BA120CAD for ; Wed, 9 Apr 2025 14:03:13 +0000 (UTC) X-FDA: 83314672266.06.B43A7FB Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf28.hostedemail.com (Postfix) with ESMTP id 2906CC000E for ; Wed, 9 Apr 2025 14:03:09 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=kmM8nGSt; dmarc=none; spf=none (imf28.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744207391; a=rsa-sha256; cv=none; b=ZgCXrfzGBjJCupq//ohkH7dFIhulXqdab67A+DBwFwYZ7AXF1/uArDXGhLy63LEZIZi9Kj bjnxKc6nGVXqeEaY50s+31FamnuE+5n0O1SjIdSpxyg4TcXXqKjmghKIHE23aZYmf4tp8Y JFx01+r3Syi5mElJpIGSALXS35ElyZc= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=kmM8nGSt; dmarc=none; spf=none (imf28.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744207391; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WgC7apt66Yz1l8rnuSd1IOWppntzQHHRtIGlSbwyHq8=; b=g8ox80UYOEa4bl9OYk+gkCwXpwgYPG+hz6dBGOMfxUbIAFtNcvYAwphkYBrEf+JFGOV+WS 1/Q93rwoQvwUasutjfVzcp1SwAeqIKg/VWUGUijd6sXJCOjaGa/U1qo5XzZ+qKVahBnpd8 OsQ0WSL9W9BdKC3HtKUsZAzO/Rcvkd4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WgC7apt66Yz1l8rnuSd1IOWppntzQHHRtIGlSbwyHq8=; b=kmM8nGStJ9MkFXEn48fe7anjfv o5bzu7sk4x3zNVkoEdfaP5wwaJzuSe7pVDGYcvESN1iiRNeoE7DgMaVjklAewf/NUK3Vv1P03aY0Q 4pZWyFgWqfdvOqMlDGPzPc0Nvl9wEl0Ng7Cc8xdWfjItC3THCk2nbmD/D8yiQ5E4bG9QbayqFkX2g nxKTJgwHfGUqgyC2SwjD5UxVAFKXMXZl0IKOtnYj/YaKHGftWvbmNROhvgRFchHCBahKosXchi38E 3SIdCzYJyBloHD7FHwG6BBfN/j30hmm5FFVDRebXjgaDRriFRoYQ2BzVkwWG9CNgYU4MZTwzrUbxX CkE/WBcg==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.98.1 #2 (Red Hat Linux)) id 1u2W19-00000008dDM-4B8r; Wed, 09 Apr 2025 14:03:04 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 4A764300288; Wed, 9 Apr 2025 16:03:03 +0200 (CEST) Date: Wed, 9 Apr 2025 16:03:03 +0200 From: Peter Zijlstra To: Gabriele Monaco Cc: linux-kernel@vger.kernel.org, Andrew Morton , Ingo Molnar , Mathieu Desnoyers , "Paul E. McKenney" , linux-mm@kvack.org, Ingo Molnar , Shuah Khan Subject: Re: [PATCH v12 2/3] sched: Move task_mm_cid_work to mm work_struct Message-ID: <20250409140303.GA9833@noisy.programming.kicks-ass.net> References: <20250311062849.72083-1-gmonaco@redhat.com> <20250311062849.72083-3-gmonaco@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250311062849.72083-3-gmonaco@redhat.com> X-Rspamd-Queue-Id: 2906CC000E X-Stat-Signature: 8gphj9yqiru75dfdocyqn4wkjjg5nnpq X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1744207389-455158 X-HE-Meta: U2FsdGVkX1/0+WjeGYyB9fZD4nCRx6x8kJ7bh9gi4OHkcdnNYllKNLSFv15v9C3Ad3Z5qErcSawHDCf5/sWD21kuCWb3/vovHY4LfE+0PuUzkuOsGXRvFsjgmy4yEhNHoHaT++jYS24wP7vwrrRq0WrQSs+LS4k1yZKsiDsMRm6Q6O5nRslb8ZESKtwm2HGADhCEANRqOO4M+njI5XjvWmB/MXbZ+jRfi3U78aO32pR4YGR0N6/uYCeH7GsRYCYXKdu0fpDbkn9rTRNP4Z8FIPdHsY+BO3DpjM89qBxRQNJZXOknhBd5uGw08woxd5rj9/gj9pPw75voBU/sOvRw/JVfsk1O9/uOptV3+G2bXhTGY8TzwQojjwTHL97/XhC23ZhWu2dK7UJ9UTteGeEOmVWHpQ7pU72QS6zi4+2ENyObxKI93pfnC55FFuylSEoVAP6dQKg25G4xoBQFmZN+vNNnKpUnz+rmcWiuTTepEhQcobJ+Fb8rQlUVCkWXSqmOrrk9zdTqD7/211zoCB+PHUV3hHbuG2Gkd/ccYnNMPUjnUwDSoQ0y2esPMa9tcSCUqSLevIV+voAIwUUXn71+nJyFVveAU9YOklV7ypAlaMNBJtS4OHT743F9gJ0Ihn1o+h8iheYm9WZQSDXyQElblD0F3XKfPEUYR2rplSU8XL3EPcHgekcEL3YxWJHp9tacdJuEP+pky3qMeg5DPXekrck5+uRukbqb4FMA2KOLiWwyf9a4B6mRgsTdBJXqGLs7imjnhCYNqtQydIAe0W2cInozxH62KR39Yn+pLOoDU3+IDNIXfc30wKIkX+H19x+ACd3pLJpMS7+urGyoge+tYkW3tYWPjsoi/mVvrFPyRVsIhPR6qkVTrBu6AK+BL7AC/lvZRxc7JxywHOOBmGAQca7zVN0LBx5nPm7TpPFnqIIb1HjcdAG86XE84R4KCXc0IV3COg4u79wwcAi36FF JqilN2EO 5ubVCtJB1f7TS2EUNgziZAAEjCw9JSLSo29be+WnBnrZfpXtMJh/tSbY5DFjy9t87YlbZMLLgULHz7TuIRd5aZbVILJE/WSYQbcL0vnO28qwaGK8zAaTMpxUQtbiS4x5933Scb6RVkaowyvftPZsi43soGR94tzBK2kC4X+NYUR3/LR6poazzTSKxH2oEfP577ge4UWApEvLurGuRVmFAw3rZLqYSWYvj5fg5/iu66UNFKNo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 11, 2025 at 07:28:45AM +0100, Gabriele Monaco wrote: > +static inline void rseq_preempt_from_tick(struct task_struct *t) > +{ > + u64 rtime = t->se.sum_exec_runtime - t->se.prev_sum_exec_runtime; > + > + if (rtime > RSEQ_UNPREEMPTED_THRESHOLD) > + rseq_preempt(t); > +} This confused me. The goal seems to be to tickle __rseq_handle_notify_resume() so it'll end up queueing that work thing. But why do we want to set PREEMPT_BIT here?