From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2996DC369A4 for ; Wed, 9 Apr 2025 14:00:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 620426B016D; Wed, 9 Apr 2025 10:00:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CF6C6B016F; Wed, 9 Apr 2025 10:00:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46E86280056; Wed, 9 Apr 2025 10:00:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2D96A6B016D for ; Wed, 9 Apr 2025 10:00:34 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CC1CD1601E6 for ; Wed, 9 Apr 2025 14:00:35 +0000 (UTC) X-FDA: 83314665630.12.DDA9A9F Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) by imf26.hostedemail.com (Postfix) with ESMTP id 5AF5A14002A for ; Wed, 9 Apr 2025 14:00:33 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=DPb+yM7B; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf26.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.170 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744207233; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lfO9/CEy4dgci6iz8QJ7UzHvpG+GvqY3wOSCyMzSDbM=; b=lB3biy0slfN92lvBWtsR7vC8mm/DsUMhVW/ndKI9BCqNN++y2rofV7PPrISuMBQvrF3xTB m/c60pQzt2VZ8oSyu3xgBCBx0LD6aRvEdRKHINagqnv+s6qckIh7ZIPPHHLqLNQ3ZW5prw wA4x5JrXF+EgLHwvhsrIWvYs0Jaw/us= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=DPb+yM7B; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf26.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.170 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744207233; a=rsa-sha256; cv=none; b=Oty0/NUjNexSeE5Dwa8nOhtaPLomQsE31igXqdyDdbfQkif/QbmPZE44cvNceVJSuhrpmO Z4fDfW4bYyaPZVT2z24dDTepDlGADvcgTrShBlv/BWapq27y9BmmxSdurmXP0onMCaQD3e nUmXotStECEuhraA5fsgHHhKf9CO7Ec= Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-7c081915cf3so879710585a.1 for ; Wed, 09 Apr 2025 07:00:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1744207232; x=1744812032; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lfO9/CEy4dgci6iz8QJ7UzHvpG+GvqY3wOSCyMzSDbM=; b=DPb+yM7BTl9ONKGg/aGQ2UgZ7ATcBgqDJ/zm5bAnagc4LMl5ApnWLkN92/tYjzBwVx Hqzq1WPExCaL6y2uOvexD/gL6NCr9629/7Up/AfaWf/T1veuYkT5mf4IZ5I+Q5qYnEZh U7PZVZMhBNzdsdgO0Anc0ExmeaL3AVCl79yoKr7Sd9jvCvjSPTpBnWUbDRdBX7T2EZue FWsinKr5qjGDcY7xD0uwYMOeMLYIMbt6mAz6xqpOfAaMSm1vD8pI/lWN2rTctny77Fy6 8d3oenJ65MnNZm67XWGWq/Is1FaXNrW8oR0nLIEnCwJwE+PP/kLmg15IoiDx0QrSd0kS 5pxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744207232; x=1744812032; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lfO9/CEy4dgci6iz8QJ7UzHvpG+GvqY3wOSCyMzSDbM=; b=AuWwy0T4Bj6mMMCWoMrU+2poJTEIVqhigy9lScbeoQM4C0ttx9YUADlb0+j5Vdk8ff H/3YH4faLxbLBjm2kBzyVcO0n6Bcmsiv4pqti7KHlpW+zPt76LdKUwyvcUTQEZGqTx4+ JD+Q6YZn4f99G0rAo74RXY9PScSJu0J1g4+vdyC+6+qvxcb6+z8BFmi6yDH0tTG9YAOV oYXYc+D6fthAbw3klR6U5rR48u9BwSgSRkie5bLFC85twGy+6feDpBjwR+z0Uvj1QgVS YLeEghMsOildhEJTbke+NRp8cXyeOveadVF3qOV9P2FdYI3fK9ZTszgAr4fsYpH5WOaY r2Zg== X-Forwarded-Encrypted: i=1; AJvYcCUEBYHrlk/IYXJWFtI87PgokKYgEguR4DAPdD2EE1JLdjIoGu6GulYQ0beWYcQ1KFVzHWMhSH7QPw==@kvack.org X-Gm-Message-State: AOJu0YxK0jnL4n3pukSXGfodM/b7w6hNUWjj9/tmzopiICwMxZ+GXpYo 9YGdywt2XMBAEZPAu1wuXOLDusLiEiJUiZYOHRnnsBylyCbWvriG0qXvzyojYZU= X-Gm-Gg: ASbGnctX2FW9U56k3xM1+LgLAspiGfc+zND15ubEXF+3ANpnJJpeHVoP9nzUrESDfOm mCbeIqTMNlZ+1RagFHy4aCTGkcnFWtdcrl5btgWTpkjq25AklGw1xWiFI2pp4NQg/5RNPtxFENj 9lOxTf9HHUOLvps6S+2BVy4DyB3RlBmytXeQv1uIoVnFI3Ka9LRU3/8jbyXgxOUfTPzSc4O/Ntk X6bqhXZh1ND3nAZ62c8dHRN0wxcsWLNRl+kTMCI+CYKNpuSTx/aXjegqUloPFPODPN8sa8q7Ot5 X99DXYOrMM8UaSAafM9PzcPcJ74WKU3V X-Google-Smtp-Source: AGHT+IGzpZNpd5bWmJIrglPrlH0pmCswaggSnMgMXggJtdtTARzTu3BIp4nxphDdER+S+PLR/Q6L3g== X-Received: by 2002:a05:620a:2614:b0:7c5:50dd:5079 with SMTP id af79cd13be357-7c79dd932c0mr375653685a.1.1744207232165; Wed, 09 Apr 2025 07:00:32 -0700 (PDT) Received: from localhost ([2620:10d:c091:600::1:8699]) by smtp.gmail.com with UTF8SMTPSA id af79cd13be357-7c7a10d3ba6sm76640685a.63.2025.04.09.07.00.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 07:00:31 -0700 (PDT) Date: Wed, 9 Apr 2025 10:00:23 -0400 From: Johannes Weiner To: Yunsheng Lin Cc: Andrew Morton , Vlastimil Babka , Brendan Jackman , Mel Gorman , Carlos Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel test robot , stable@vger.kernel.org Subject: Re: [PATCH 1/2] mm: page_alloc: speed up fallbacks in rmqueue_bulk() Message-ID: <20250409140023.GA2313@cmpxchg.org> References: <20250407180154.63348-1-hannes@cmpxchg.org> <38964e68-ac20-4595-b41d-8adc83ae6ba0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <38964e68-ac20-4595-b41d-8adc83ae6ba0@huawei.com> X-Rspamd-Server: rspam01 X-Stat-Signature: c6t5uggsrnsymkbi9pmmjsb6u7zmctr8 X-Rspam-User: X-Rspamd-Queue-Id: 5AF5A14002A X-HE-Tag: 1744207233-438871 X-HE-Meta: U2FsdGVkX19BdiY005UpxP+ecVKsekKjtCfCJ6mxdbxkHmM8YK2i0+0RzkYbWGwSA6/XwYlNlMWKn4963DRp7mzbCZoi/pbUOnlty2BSB9rlfsdPY1sURKBQFpgksD+5umU7a1PtrpjHvwHLbd2e7gFL5M4Uf4pA0T1sTkNRYC5VKDqwfdQn/FfipgPKTD0gJNeN0sh72+K+vHn15odNs7P9Hy7hETPMyitz615HVvRcTqKZ6UVWLesqV/Lc1CUkUlLQKumZamaYJiyqP7nsllMGyK4QUhyQBhbzcXwFRTB+WymDA1qHgs3uo9o8f+Y+/A8wiSKKEK8uwr7cBsOmt4OlPA9jfeMbcDmFvEU9frAlbvrS9RtkuUZP6PKYPmTcVYSayyE0PPQDnuEylgvSuBXgF/zmpMWQZBuRVx870dM04hbBWjX3mleDPOu60ZYQNj6FNsBMOkMMQp1/DlU08oRGoogLUUQuwW8uYrj3u546igsZ3qTi6LjUCxRmLHGR8+H65AaZA4VXq4hbAAQqUc32j6eg2+fo0XFTwox6GNFwJv1Gn2L5AuLBdKq1jUE5onMhjI0nVSfB3HhCXxeo8O8MvyqE0kJkrgkXj4jLn4pu4yLIOJyXBUigT6FzupGaOFKu3sGVZPEFd4/e+mPvyMP/yNSy2lDBvOMXG3AcmUaYxsubSa8cDAW7s+8CV5JAq0A3rjr7MX7KPrkHWzOEDdIvf0g8Qu/dWzaTuVONucKtS0wYUNONTzoZfaSoc3L7pE6FnGbAQeUMha6ELTJ1Eq62eqeM06XhXF1ApWHIwRgwEJyCI5mEr6V0FOVUUwZaXlOKUKsKuz0Jb3ye9qn+n2GaMe3N6gGFLFcQvYMG6EisA+rMqnIWLSqwiNj7MZHrjMfnEp2QPu4771OL2eMFxXc5qVdCvwPP+3tb/112yhSKNyNn7AkK2GFz13S0YPx7kU6knw737zH725zPqZw BRU8dXZY DP/e0E0pggkJyOMpWawlio42ra6BfhDcInNCl58AI/zXZZPLG6Ioax5q0FIawPqzRA+y4bGLNY0XlcBD8UVXi90tsTyOp7RV3pU6orqWVoy+6EK1J5DXmPWzKSCb74HyGLKrMEBXUotyUXve+EC+9e3cEjvr9aajTPKknfUEtcC/nJWMWPFe/eJzYOI985Y2cI0i920aXYpphdMCa9pa9xiGhpREY3LkJDRNOt2owWL5W+SfW9P7cmTA+KXekTIDBn2rc5VBt3qugJognsUiTCBibqlqjVANq/2519oGgC+SMroPMhz1wYAZWGhTJh3GCN4Qzrm9rN1BO3ORuwGZgt+QkkFIEYtJdLD6HPoz+HAjOWFmShskhBI0l8m8PBM3zOia+Vwk8Ogu6CxGM9PPoboKHQ1cAuNbbwKnjzblQg8Tfwa3wLTwzLxQReqRYAWilkMsMalSdN4Sx34v2gRwpjATeKo2XRxrzLPseCnwM2Yp9Re7y1K6koYuQTnE8Q3fnDVzM8IivNeTSQ5s880CbZFbTHgJI+jCTyV5z X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 09, 2025 at 04:02:39PM +0800, Yunsheng Lin wrote: > On 2025/4/8 2:01, Johannes Weiner wrote: > > @@ -2934,6 +2981,7 @@ struct page *rmqueue_buddy(struct zone *preferred_zone, struct zone *zone, > > { > > struct page *page; > > unsigned long flags; > > + enum rmqueue_mode rmqm = RMQUEUE_NORMAL; > > > > do { > > page = NULL; > > @@ -2945,7 +2993,7 @@ struct page *rmqueue_buddy(struct zone *preferred_zone, struct zone *zone, > > if (alloc_flags & ALLOC_HIGHATOMIC) > > page = __rmqueue_smallest(zone, order, MIGRATE_HIGHATOMIC); > > if (!page) { > > - page = __rmqueue(zone, order, migratetype, alloc_flags); > > + page = __rmqueue(zone, order, migratetype, alloc_flags, &rmqm); > > > > /* > > * If the allocation fails, allow OOM handling and > > It was not in the diff, but it seems the zone->lock is held inside the do..while loop, > doesn't it mean that the freelists are subject to outside changes and rmqm is stale? Yes. Note that it only loops when there is a bug/corrupted page, so it won't make much difference in practice. But it's still kind of weird. Thanks for your review, Yunsheng! Andrew, could you please fold the below fixlet? --- >From 71b1eea7ded41c1f674909f9755c23b9ee9bcb6a Mon Sep 17 00:00:00 2001 From: Johannes Weiner Date: Wed, 9 Apr 2025 09:56:52 -0400 Subject: [PATCH] mm: page_alloc: speed up fallbacks in rmqueue_bulk() fix reset rmqueue_mode in rmqueue_buddy() error loop, per Yunsheng Lin Signed-off-by: Johannes Weiner --- mm/page_alloc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index dfb2b3f508af..7ffeeb0f62d3 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -2983,7 +2983,6 @@ struct page *rmqueue_buddy(struct zone *preferred_zone, struct zone *zone, { struct page *page; unsigned long flags; - enum rmqueue_mode rmqm = RMQUEUE_NORMAL; do { page = NULL; @@ -2996,6 +2995,8 @@ struct page *rmqueue_buddy(struct zone *preferred_zone, struct zone *zone, if (alloc_flags & ALLOC_HIGHATOMIC) page = __rmqueue_smallest(zone, order, MIGRATE_HIGHATOMIC); if (!page) { + enum rmqueue_mode rmqm = RMQUEUE_NORMAL; + page = __rmqueue(zone, order, migratetype, alloc_flags, &rmqm); /* -- 2.49.0