From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFF19C36010 for ; Tue, 8 Apr 2025 21:04:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 45816280017; Tue, 8 Apr 2025 17:04:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4047E6B008A; Tue, 8 Apr 2025 17:04:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A696280017; Tue, 8 Apr 2025 17:04:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0856D6B0088 for ; Tue, 8 Apr 2025 17:04:00 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A59ADB9DD6 for ; Tue, 8 Apr 2025 21:04:00 +0000 (UTC) X-FDA: 83312103840.18.989DF88 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf23.hostedemail.com (Postfix) with ESMTP id 273D5140002 for ; Tue, 8 Apr 2025 21:03:59 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ll+LB5K4; dmarc=none; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744146239; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l+At1XZyI0WJ30pjXexaWxQiaoAeggmAsLHN6rpvu08=; b=TRjddivr6aOFFm9nHcIEdiJVRvPe57EstERLIQw5D7CQdSLYTMZH4YIggJ222uljkOLYLw NpMZxInGp3ziltxC/oP84vAImvuGgkWSr35svsNItB8z/vqzNAYhDtjV2EJNkIzDzS1qB1 asFPB4357rBHLXSnpzAhp1YHzTsxdzs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744146239; a=rsa-sha256; cv=none; b=GAipnIpqCvjhScJH+9OIxAlWjZhlRzptFvOrCZpB4ND6ugEvRsMinwKLEnJ+HyB2TsbBLC XJB74yN6uwbpMpyYMNaCE7ROUJXzDMYZ+fSI8O+73ol2aAcozQ6oTdpK1bmQZvmvvvlM6Y Iio7HCjpmt8ExaBalPm7vjOBTUSSBWI= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ll+LB5K4; dmarc=none; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 2E19F61166; Tue, 8 Apr 2025 21:03:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDBDEC4CEE5; Tue, 8 Apr 2025 21:03:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1744146238; bh=VrYkDSIeOHrewcKSwsx+ncRrL8vyTVuvY9kQe88VObE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ll+LB5K4zesSusjZg3vt8+iHhK+E6I0XDwOcUbAQTVkSMKAAyc1xmxKO3+ffCoKFS XwsqBhFyw9TkjkOP4NP2W75kt5K5nmv6vXMOUpO5FTC3/p0kgdg5sf5x3sTjtYKDpq DHtuLJaytRiRdDbPLG9Cbbs7nZNvLENoOyLbs3Mg= Date: Tue, 8 Apr 2025 14:03:57 -0700 From: Andrew Morton To: Frank van der Linden Cc: muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: Re: [PATCH v2] mm/cma: report base address of single range correctly Message-Id: <20250408140357.9a708f7547e48d2da1d2fc34@linux-foundation.org> In-Reply-To: <20250408164000.3215690-1-fvdl@google.com> References: <20250408164000.3215690-1-fvdl@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 273D5140002 X-Stat-Signature: pmjrpd9jf1ykpzcwdy53jm99nje41eoy X-Rspam-User: X-HE-Tag: 1744146239-8218 X-HE-Meta: U2FsdGVkX1+MeAvgMCHKfRY26DbTZTftYTPApi5raAUS8y4JtoQ90/w01SFOqE2igixek02Z+jaMqs4i7Yh5SbHc2KdNnEkN7Uvh7B812+brfowQgnJKblA6bK2Jmun06fbsmguFfE3JP0l6Sw2hH1Zbg7P23vtqA7RiQEaaRB5GaKHT+TF0b3dnzlRSS8B9O/CACazxwusfHjToMIBqzZQajyCyo44Gs5mRv2ICxXDtWylCfmjDvQm64DXwwCKr6AIT2Tw/RQxal9zYOlh1tyGM/BnQzOPsXMvGCBL0d5P1TzK0yHksPiRlqmJugQrmnGNN2qiSDRSdBqKUhtS+b4xSETSBUMnHv4ZbLqyxAfJnFhsWr7Uju47OmUIpty0XyEUywu73RJPjUwVETstwTMGW2/2AJvlisjN4aLS/nPpiKCWrhbss4/HB/uGve+TllrNCVsJp1ve4J6FKyOxrUc9loxg/OG/+XkD198NuosQ8lemN427MjhI1HqVtMPlCXiRQbVX5EsUhDRBipuiDPF7sET6bloASuS9uf+tfVrKw1+sdT6uF3JZ9lCzSjXLnZlff7Ucb/wx1AkqgPrQYKTUH0VoLE81DPWeWfn4kavI62Ow6YYsQqSXjepgJGkJoeRWGPC0cMrChJyKDiWaMwieweIMF0s1gwEh5JSj2kneompTr7wyVcGpEhn+bGFgJGO3tGsMPVL9chuKjsoHvcfPm0K6BFbZ6M82LY9knr6e+gIpeyucpvGYe7CbaxI7mbs9NkWYzYp0OKH9Cau2nd8rY8U+fFSDKL9pMR1KjtRk1F1L4YDX/c08/ukW0TT0CscDTJHIJ7X/RdaPdd0by8+Vy3cQdhT8sxr4il5DQIBY5olqzMk5m4TRZ0XClYwYZQyHqHOeLQW+F9F5Mm39PB97aQdT0Brc+QRSoFw/oBHA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 8 Apr 2025 16:40:00 +0000 Frank van der Linden wrote: > The cma_declare_contiguous_nid code was refactored by > commit c009da4258f9 ("mm, cma: support multiple contiguous > ranges, if requested"), so that it could use an internal > function to attempt a single range area first, and then > try a multi-range one. > > However, that meant that the actual base address used for > the !fixed case (base == 0) wasn't available one level up > to be printed in the informational message, and it would > always end up printing a base address of 0 in the boot > message. > > Make the internal function take a phys_addr_t pointer to > the base address, so that the value is available to the > caller. Changes from v1 are: --- a/mm/cma.c~mm-cma-report-base-address-of-single-range-correctly-v2 +++ a/mm/cma.c @@ -722,14 +722,15 @@ static int __init __cma_declare_contiguo } ret = cma_init_reserved_mem(base, size, order_per_bit, name, res_cma); - if (ret) + if (ret) { memblock_phys_free(base, size); - else { - (*res_cma)->nid = nid; - *basep = base; + return ret; } - return ret; + (*res_cma)->nid = nid; + *basep = base; + + return 0; } static void cma_debug_show_areas(struct cma *cma) _ Which appears to be just a little cleanup?