From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B0A4C36010 for ; Tue, 8 Apr 2025 19:13:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DE36280022; Tue, 8 Apr 2025 15:13:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 58DF7280020; Tue, 8 Apr 2025 15:13:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42AB3280022; Tue, 8 Apr 2025 15:13:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 236E8280020 for ; Tue, 8 Apr 2025 15:13:56 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 821411614B1 for ; Tue, 8 Apr 2025 19:13:57 +0000 (UTC) X-FDA: 83311826514.09.87F0D4D Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf17.hostedemail.com (Postfix) with ESMTP id DE8E04000E for ; Tue, 8 Apr 2025 19:13:55 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PAcmoqeY; spf=pass (imf17.hostedemail.com: domain of kuba@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744139636; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XfZEjyPA7JfR31W+71s1kgMvQ8qut7boMJMfA7WlNgY=; b=rbEgGvZXhLJUxLLAUs/qZWSYiwoqtNHMv7ac0k2KR+q30fq1b3eNZXm+Kd5H9BUN/GhSKU hY1BuvvinEEQffO0+16Sh0chCv1/R0nOLlQJ7r5Q16V+83i/+j+bDe3qmjX2u6E7wvKYus jvd4tcJGby/yHuWhN5JUUWZjNb5CYCg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744139636; a=rsa-sha256; cv=none; b=dHSxiwHL+76ZxOM37gIC+Nb4ssMH2Q3tFZtmFMLI8+kkJnRZ3vaOM0xla5losKJi410jn0 JqN0dWUvIdJKYhsgoUISzktwCAHq0exLWk2mYJTACgqcBuLegwaY3UHi9AabsM0G3O0qR2 a5mZNYlQnFpHCeJgKCJUGAw4zLz2YcM= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PAcmoqeY; spf=pass (imf17.hostedemail.com: domain of kuba@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id EA5DB44F09; Tue, 8 Apr 2025 19:13:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3B24C4CEE5; Tue, 8 Apr 2025 19:13:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744139634; bh=5DRa4EjABnqaxCONQi4w4JP1EalHC6671KkxCCi0Fzs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PAcmoqeY8NOC6IKQgd+rhVff/TQUVbjUrNGWcC0ybL9oWMD2ofAddjwCzbWSV4DZR yczqJ1wJG4E5G2ccTTI0C42i8suKrfvnMuUaiVR+BYcq/6WRJU2H1SFVnLQ5UMzIEa 0AoB/aYmwVXADDsbQPkY+vAn5vdA1ptyYcLTBHEVU3RGZy9habdt/P92X0IOZAgr8y ntONC5aNaghc2ld53zdmgU83hXdJPis9y91HR5rRlC9Y9XCgohvqNbO1hvYZiegR11 0huf6QJRE53jzWR3ZSer6Hjg0NSCn8vaUTQ3uf5GMcSPrT1s7nbSBNs5LaFTynaX3M vy6UAGYwlVZCw== Date: Tue, 8 Apr 2025 12:13:52 -0700 From: Jakub Kicinski To: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= Cc: "David S. Miller" , Jesper Dangaard Brouer , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , Eric Dumazet , Paolo Abeni , Ilias Apalodimas , Simon Horman , Andrew Morton , Mina Almasry , Yonglong Liu , Yunsheng Lin , Pavel Begunkov , Matthew Wilcox , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH net-next v8 1/2] page_pool: Move pp_magic check into helper functions Message-ID: <20250408121352.6a2349a9@kernel.org> In-Reply-To: <20250407-page-pool-track-dma-v8-1-da9500d4ba21@redhat.com> References: <20250407-page-pool-track-dma-v8-0-da9500d4ba21@redhat.com> <20250407-page-pool-track-dma-v8-1-da9500d4ba21@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: DE8E04000E X-Stat-Signature: rzm7k5rg93xew7zsscj668g5pp4wsoou X-HE-Tag: 1744139635-186800 X-HE-Meta: U2FsdGVkX18YnNkfZRolxOgCU0H+hh2fOyCne2BjjvOiHm2nbywTJTTVLY9q0CctAEoVYLuFA+NLvqCUdvCeYTgPZ/0S3DGeWqfDR6JVQcFZ7HWgQxPNbaB3oztp2yumYzNQaSdeP5wCnSBB9oTr5ZW8dTJ4Wo8qp6A4GmPB//OdVQDkE3PPgTzyzDRUvTT/fsD5Q47RkU0CHt4TsVQHaXLThZXoP+SQw+GjAjpq38sW64hnY8aHC9seiOHFsEXtVt6pmt+LhyfkInm8iMYnfbolk4BeBWDC91KYFDqglgH9p0PStl81Ln5+sbTIlUsj0jTLzPu3rCWvdQbQRw0h52OYqRgOotb3tvFv5xw2dFs32aGFjIzvcBzlXGNaV68UOJoFiyI+BdlMOsFND/TGCnecrZezZDxdXvj/GMSj8yDs5X9JqsFWFRS8Ph3VvM+61nB102utEFis9wEywzalfbn0L5WNg/az4jUNQiJ/uvxpT8GYfNDBNwaJBQuvDHEoLX1RJj70KPB8Ctg70qlSWOsF5XrQEFogdBC3n741qWxLXnRDTtox9/cwYBMDmledJgxQNEQ2SsHi5fSYsL78ZRY9t5371oXPQsKcWa307MhBE40AzfFziOMqlTbERu7UUc72+sszSzBTQXD+K2WDEqDTSsCUEGCuV+vGfoyaoZuCHReNI2r+WRBNdFifHjA5SAdT/3ras8xuIEGwojkWYCzc2ZjfQnEDgSCsSc/1EFGZ0stdsbcuGV+4Cm1P3Ar20ZKAbzW88/rSHJjkpVQAzyQOggmRlZE7wrT0aOnKaNvbbADmv2ftJEv0WSc3UR35306FV0bufEU2zsnwzyOW2jitnbdI4G2NcC0uitdiD6tT5paZnhLhB5rOxvElgYQDgQfr2uL3sj3BatA61AEfugIz7Mtua4FrUqfmDu9IhxfnDJuC3ER5a0Kc0X0bbsIxFdI0K1qoPcY1JesAhOg RkUgDTIX z/3HWvjgq93MOyS5RKAS5XV7s+8nHZ08Fo+QHUNyQqn0mEsKtDHPdo0mv3Xxr9NusVMnlKSMQtNQVDa4c+cRgqF06K/piuuoDL9XDj+YgWGieUvhe9b1h0508UXiUvuMyi8OVp4BJ2tHh7v97/OnnzWvgLePeeX+N01LUnTDhxQrG4qFEQgAruE5edL6SJ4WiyZ5JPMFKBZn8u6VyBN1KH984gifgeQloZJIWcyUYnxPwGTWD/P5u/AidJBXYdQK6o4VT97RnGtw0i+MmqvGHil3j6szmVYoZPn1GCw9BCzaMA3AhjL58EMtny1kmwvjlkwufy7tj6Rd1/1AvlZmm6VR3G/kftT81xmGWU/bB9FutzcwGG097Wsd60wuzAN/GR0OB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 07 Apr 2025 18:53:28 +0200 Toke H=C3=B8iland-J=C3=B8rgensen wrote: > diff --git a/include/linux/mm.h b/include/linux/mm.h > index b7f13f087954bdccfe1e263d39a59bfd1d738ab6..6f9ef1634f75701ae0be146ad= d1ea2c11beb6e48 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -4248,4 +4248,25 @@ int arch_lock_shadow_stack_status(struct task_stru= ct *t, unsigned long=20 > +static inline bool page_pool_page_is_pp(struct page *page) > +{ > + return false; > +} > +#endif > + > + extra empty line here > #endif /* _LINUX_MM_H */ > diff --git a/include/net/page_pool/types.h b/include/net/page_pool/types.h > index 36eb57d73abc6cfc601e700ca08be20fb8281055..31e6c5c6724b1cffbf5ad2535= b3eaee5dec54d9d 100644 > --- a/include/net/page_pool/types.h > +++ b/include/net/page_pool/types.h > @@ -264,6 +264,7 @@ void page_pool_destroy(struct page_pool *pool); > void page_pool_use_xdp_mem(struct page_pool *pool, void (*disconnect)(vo= id *), > const struct xdp_mem_info *mem); > void page_pool_put_netmem_bulk(netmem_ref *data, u32 count); > + and here > #else > static inline void page_pool_destroy(struct page_pool *pool) > { --=20 pw-bot: cr