From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85792C369A2 for ; Mon, 7 Apr 2025 23:14:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9EBD36B0008; Mon, 7 Apr 2025 19:14:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 975A96B000A; Mon, 7 Apr 2025 19:14:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DAFB6B000C; Mon, 7 Apr 2025 19:14:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 525AA6B0008 for ; Mon, 7 Apr 2025 19:14:23 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 97ED2120930 for ; Mon, 7 Apr 2025 23:14:24 +0000 (UTC) X-FDA: 83308803648.08.B7998D2 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by imf18.hostedemail.com (Postfix) with ESMTP id BD6911C0004 for ; Mon, 7 Apr 2025 23:14:22 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YQOHfr65; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744067662; a=rsa-sha256; cv=none; b=kcHjhk0cX4+534iwSPLhhk+QqVeDq9r8eehD0dTt3uFJGdjsnrcuEasqS6S40WLW4yh8nN 3aj4yth1WHcNY0rRRFNkFBE4C+VnQXN67RhVazHAlpoRBrzVhw6HdTLSw8yLbZgpZjVgWl +8A+0/EdEqQQ1RNbjOIsMLZKyr+bLw4= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YQOHfr65; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744067662; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references:dkim-signature; bh=RBLmvV7Q4wPiI+MEo68mMCleA6GCDfzaBhVQhk2842M=; b=qRtAGhiKiSUGb0yTxWjtOH/Ii6ZE5E0GbkeQLO2ytua+eguqEgKp9oPaJECEp3Yx8/XFhL Z+mBM8lb6JuqSKuDpPjUBf17sxJk0sAtTu0kefMCGBtUtX0pywk2N8s8TGYWO69PiKNm6u iDNyNvskuByNCsQqV+ee1L8YPKm26/M= Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5e5e22e6ed2so7212908a12.3 for ; Mon, 07 Apr 2025 16:14:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744067661; x=1744672461; darn=kvack.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=RBLmvV7Q4wPiI+MEo68mMCleA6GCDfzaBhVQhk2842M=; b=YQOHfr65E6r0Jic2xLKdkj7pZCRl+aqUekimbNRwD9Xl9U/ndpbUNONzJ2ikdi+gUT Rgd8uFNK5jTmz9GqcJunAY8OTrlbadgO6f//8DQr8heYDJajvaGsGBOOunLKqvBDwEGN D42/Xhsb13unEvKk29Qgl2oE07Wk9VzeRCHnMxcnr3hlq/t+phQbRrml4+0VoJZUg2fJ C/Ai/TlKFrsgbBQf/fMsqUjPkEeAaRxbKCD9KV+RQP7ai9XgG6lxm3sEDppMhq+wpZWY hzaPaPCx73k4wNCNg1G2fvvAmMpmHphvlDbgadCFjgrSvCYgmEfHsVTOyjQve07Nl0qH W8kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744067661; x=1744672461; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RBLmvV7Q4wPiI+MEo68mMCleA6GCDfzaBhVQhk2842M=; b=sekwBAQiixaooRx0SV2nNljVf1D/sj9zFRelPWOgw3UEIz1qBSQn25sEx5aZMQas0G LN1ZXptKHbDK4OjHJgJaMGoWPa3MhqDRAvuRin1j5FSfTfTx/xQr1eoNpW4yETlAjRax HBLsR3tcwhm3UUg7j8t7hSKY4fsyeuE7SrjfpmbfaNnNVLSlqx9Waayj81l36P7PwOh9 qTnsaL0QcjMCmZisr3ESFoCfMJWO3W/PeWEst18y+k23F+wEh+UOUO3CORvmNw1JGh3/ Ms6pH0cqNEm6DmoVBrhKEVSKCEsoGsKIdqn0aQw5k0AvBsaU2dgGcK9GNL8DCjsJxLhT 1qNg== X-Forwarded-Encrypted: i=1; AJvYcCU2GIjCwbi0L7NU2kikFkC2PwM1YoQEvbf94A2M6n+yOPmCtQSl8jG9FBpzy2rMNKifEAL38wuzog==@kvack.org X-Gm-Message-State: AOJu0YwqjnYxEkDp7G2L30zLc8gTM2HiL8/TeDw1RlUeXsOpOGzdZsFI IgG2xcCXqvQMaXoLvElpDTzlvE8VvVTcnEu+vWrmmkehM1b4Tx2z X-Gm-Gg: ASbGnctcBq7LGIDFGgMwvfa6o5/5O10RTKsiUtH+W9rWAk2xDQlV8cK+a2ZyPehPum1 ZRF2jPf0xG1qwzU0YmjJoBHPDDDoqH27UJ0EaXeOVYL9M3KGSdLGEGa8IA+vIwti1V9tPF4ILno 0pclZewip7LvumvLiJ472WTjViFZIwbllGI4J+pU22jF3RDCoE+CYtkeqAJjfKE4szd53V2rLf3 ipd40HBx44OVybPvE04kX+/PYg8l5A3+JPhnujlhQrH5qCdEcLsBKcf3+U6aHvQ25ospIam2scN sYa2H/waSfeXiVDoYWCvh7zlTvlbwNZPbUV6J/fZKO3f X-Google-Smtp-Source: AGHT+IFw0VJuD/5dW/5qXBXj2E60I8Vo/rjRMNFLtTW24KhKoP0N3NY3gh2Db5uU52nsRPD05z706A== X-Received: by 2002:a17:907:72c3:b0:ac7:9acf:4ef with SMTP id a640c23a62f3a-ac7d6e9fe06mr1202449766b.56.1744067661141; Mon, 07 Apr 2025 16:14:21 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac7c0184d0dsm807259066b.130.2025.04.07.16.14.20 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 07 Apr 2025 16:14:20 -0700 (PDT) From: Wei Yang To: Liam.Howlett@oracle.com, akpm@linux-foundation.org, willy@infradead.org Cc: linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, Wei Yang , "Liam R . Howlett" , stable@vger.kernel.org Subject: [RESEND Patch v2 2/3] maple_tree: restart walk on correct status Date: Mon, 7 Apr 2025 23:13:53 +0000 Message-Id: <20250407231354.11771-3-richard.weiyang@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20250407231354.11771-1-richard.weiyang@gmail.com> References: <20250407231354.11771-1-richard.weiyang@gmail.com> X-Rspamd-Queue-Id: BD6911C0004 X-Stat-Signature: 6hjrwpge71nrga9kk4tus6nh8ajnq41p X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1744067662-485756 X-HE-Meta: U2FsdGVkX19nTK+zLHGqSOZSn1dPVNvJOcyIktLXliUzTZP0A7qa2S0j8PfwE8U6Jy5uRNgIVQUBhmroBDSjRHR4bvXgOXs+jxS/+r6gdDNIHGu1/EG+J/CBGz8c+fa/4xo7AvMlKS6lhQdXLKxrogUDrIBlSVgA1om1J8Szb256Ue4idv9nlA4OHncIjjDXjKBb3wh2r93h0e62IqZghoLWkRfsFR1VNMIoezQtESXiDZgQI2cuhKHhN2/uawkDx2NHB43DOhumDMPlGftUnvfK4tGJkd64vwwkTs5nZQKW2q7n2Nczrsvc8qOx66T3SoDr1V8Rwxkilx1ByPpkyvPN9DUcW3zetyrVzoFLPbRnxMawnFeVWDkVveKeMsM0j96MxDg8gurZDko0zUNnFvCvHBNxwZd+oNrFfWwZTirHlhS0h0Y839IbO5RCL0IpLdzJuuPjDFnEY6S998pfdbB04SYyWPPbIReudQJmVMNQcni6CCh4eR5e94L00IGIU+kHjBSh5HynXLtWp8Z4w9d4wEQ5ZldPdcPIrkfz/EqVJE3JpSme7xZvBGsj2MgTh8KjjYrZysny/kDCR8hsaeH90ESijzGtSa6fNou4+5Or+RQ+8eDHd0MKzVgkLnYn9YZmUL73xP589UjV+mNA1ZCqICwdJ+KZWwfgYwwUEHILMhIflMZA/P6fFtYv4xAhEIF0KKvFXNjmPVpVPZIGZQ8jCMqU+8GjJHxv3h5na1L8LfOlcKJ1DNUjg2Rjq6i18XD0DHiLH7yK9+stD5+8IExwg8H3z0GIK4mkM7T+C5Ih2vE19HL3I0K1oVvXtFQLITIUaodv3bTx4qlfftMmAiKiNAv7fooF8+x8/LIjaMmV7Ec/DCFdtwnKo0tWR+tygl8Z12ZcCyTow022rDiYf5aRKq1XMy46QKu/NO9JUhRj3ci4SEDp97OS+q420xc8VMlK7vpSZNux3mfdjnF 7XRsKnSO ZgbRZs3fgrRt21PLtcWKqeUkTxgwKLLC3O0aFhOo0AWhmPY/AhfYQNYz4zTVyO2qAJTtJQX3Z20U5Sjz67/bA1A+GhDiDysLcMbUDA4aEwz/OYEwr67qjEJ7Q4hlMCeyPilX51zM49PnB1fJHv8HJG1x1/Fq/0ZPCP+KtLDQ7JTl9jpc02vycNEeczdvg4EbLQn+W0QQVEYuLNw08vnoKZxUd5xjfBQ9nCdzHQaFoQS7TO5aUy6CC+Cc7p7KH2duNULDCtDdw7ngZG4CxmgKq29DX/3RFmlklM6UhFnXD4BQnUm3IWnzRP0j+mEK0reghECRejavzWBVYrskVLa6iWr8f/pt13M+8s8frJ+BwZssuteekNwiItebThI79oitBpOWLXi1H5+PzQSK/pAQJbokUfXNHkzscwe257vd4wiyNw7PbDbj7j0QARY2ZPXWE29O12qftKrbpOP5agYidB0LOyHfHMXOBn8/5bykkvUv9X91Wr5eepICCmhcJwZpPDR+DHXBYt21x92IKrMO0MdnO846ilOD5ICwVSVAvr1E1CSMNEvS+unfoJcGqyVMAD3JDEX80XNmqxkM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Commit a8091f039c1e ("maple_tree: add MAS_UNDERFLOW and MAS_OVERFLOW states") adds more status during maple tree walk. But it introduce a typo on the status check during walk. It expects to mean neither active nor start, we would restart the walk, while current code means we would always restart the walk. Fixes: a8091f039c1e ("maple_tree: add MAS_UNDERFLOW and MAS_OVERFLOW states") Signed-off-by: Wei Yang CC: Liam R. Howlett CC: Reviewed-by: Liam R. Howlett --- lib/maple_tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/maple_tree.c b/lib/maple_tree.c index 0696e8d1c4e9..81970b3a6af7 100644 --- a/lib/maple_tree.c +++ b/lib/maple_tree.c @@ -4895,7 +4895,7 @@ void *mas_walk(struct ma_state *mas) { void *entry; - if (!mas_is_active(mas) || !mas_is_start(mas)) + if (!mas_is_active(mas) && !mas_is_start(mas)) mas->status = ma_start; retry: entry = mas_state_walk(mas); -- 2.34.1