From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AD8EC3601E for ; Mon, 7 Apr 2025 16:23:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93EA86B0007; Mon, 7 Apr 2025 12:23:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C6E66B0008; Mon, 7 Apr 2025 12:23:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7413A6B000A; Mon, 7 Apr 2025 12:23:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 55D7B6B0007 for ; Mon, 7 Apr 2025 12:23:32 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E7303C1398 for ; Mon, 7 Apr 2025 16:23:32 +0000 (UTC) X-FDA: 83307768264.09.C1B1A36 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 0D0AF40007 for ; Mon, 7 Apr 2025 16:23:30 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Z9J0fhCp; spf=pass (imf07.hostedemail.com: domain of longman@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=longman@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744043011; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=sHkVYaexMET2kVqCTXNoyYGk6gyC8HQIAaeFmdUzouU=; b=6ttcJMTg1uZv+siASmDPawLMgfOCZat0mjJSQuJv9h6DGRufDkGmZ82NYBkxpkG24zINt7 uzMsSwLHQK2E6CYGJzNhqTDxbZ8DN+cwsFwx2XHA6aaZZdvulGRTdPZst+gDgzLI9DmCn7 cFUkOoJnPSbDNzU+HB8mEpzfU9NFk6w= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Z9J0fhCp; spf=pass (imf07.hostedemail.com: domain of longman@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=longman@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744043011; a=rsa-sha256; cv=none; b=EbITTsMapWBQO6SSpF7SWU2wl4SnkVuZt6tGxS3Ve/rLMbcsDDrQzhUhB+3GAMXQfFK0Wt vJ8pMFR9UfugE0utjMPs5T4fBYn0EGD2qJd17c6dovyVbakhoH6z6U4FG5Mg7plG8hn36a AA73ooN4i54tuuNwiKCOqXD+DkURs/I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744043010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=sHkVYaexMET2kVqCTXNoyYGk6gyC8HQIAaeFmdUzouU=; b=Z9J0fhCpVun6+vYiEFE/0woSeR0Ya+5OQ8NwcYMrgfQ4kcjmFGTYriLPrwq+Kahrv1tAnU 9QRcEDnbOO/kwtc+VggqXSHPz3jZSn6YSTwYJYk7PuwGk+gmnFSqA7DwslJ/VrQSbC7b6r rijUeWrXxEsEvtI6GTy1UqegJ6hO1UA= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-558-nAIU25_JPsS9A9dM_bD6Cw-1; Mon, 07 Apr 2025 12:23:27 -0400 X-MC-Unique: nAIU25_JPsS9A9dM_bD6Cw-1 X-Mimecast-MFC-AGG-ID: nAIU25_JPsS9A9dM_bD6Cw_1744043005 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BC02C19560B8; Mon, 7 Apr 2025 16:23:24 +0000 (UTC) Received: from llong-thinkpadp16vgen1.westford.csb (unknown [10.22.90.98]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6A6F7180175B; Mon, 7 Apr 2025 16:23:21 +0000 (UTC) From: Waiman Long To: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Tejun Heo , =?UTF-8?q?Michal=20Koutn=C3=BD?= , Shuah Khan Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Waiman Long Subject: [PATCH v5 0/2] memcg: Fix test_memcg_min/low test failures Date: Mon, 7 Apr 2025 12:23:14 -0400 Message-ID: <20250407162316.1434714-1-longman@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Rspamd-Queue-Id: 0D0AF40007 X-Stat-Signature: fcb6497jypaysez5mf6y1k8h9z5zguez X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1744043010-424556 X-HE-Meta: U2FsdGVkX1/JTLf2Wr5zpk+QWK8CtfboKhDHqFUqZdWU2x+AcUtpAOxppDTN2HGCpId8j+DdPeCbTogQuzCg/49a6nA4NVIXY5ZjM1jcXPeTJpEKD6QKFkgGwpzBJSmNRrCKAI9D1nyhjzOhgOVyDcc28ap3RbyUgxFopQUtffbeLFXOKlJa7IZUOqPF0an4jBsLjeX/h+4D7SuOs890UMF6DRNj8jlmfshWxOKGwV6B4A2x6A4xE5NenMvBgHPctMjM4toi12bQcwrEmUpIr6fvUv+F5HvleIbUabqMSwsyhUvEvRwDkFP3o3NYvxqi20G1bYlRNkHDSc7faZpxdfezFqGFWtvs6F+45v5mi+pNRFlLNpe6JbQanL92JByCdxp4yXmuypz/sM+zOKJtu8VoD78zS0To+VgDw81AVYRKKYh9DjYliewF6mkaCAfOA+8sp0aVx4Z85PCjc/mWWcVzESlStv+kSqYdT9EdkIOSWTpN1dNX1LGBGl1ltU66+g+4tBY+nlHqhCtiJD8IshJYeDtxaWVD5nmH/yWKw2gkH3YbElV9yue8peOAUd+qC93mVUfoQcVlUr4iO1+OHucHmbNc3rlJgIl56GLEBtTirBcaUUVTWW8Q7aujlRDNSwTp1k8cQi1UIkUmlGx/WB4il2Vv+blzikdTSF2ze2CxZjDoSsIgL3yeovsGH+6yN41c6goT34HtYQBnCm/Mn8yOxXBuwPz3OsHUg7rpZ40METT9RODKTXLrcTmoa32fS1KnIeD+6y3N3bqVOscsTw6TT7nn349jnDFdN+kDDOLSul9EuFNMuhQyLEajdwxEjshsweZNyZrjQW7tOfbQWtP/ebtYW3spIeM+wxi4pWfqxJiLL5wWl3GuFB5S4JVmtyU0IEp1ymVvXqsrvlLs1SRiH2aryJ8ywntIcKbUgFmlxDIj/IutynSmhw6PtQtW5eIE3K8Rrg9n096a64x shI1xSHE RMUn9i9fNN+dtBecV/Cj9bjYHv03UbJP/C9o1tXF71YKPxPELuqN53Oq9dXbf4XhytVAbLfXNvVHP5K6kgdQGISpQbzmmn2dnhq5JQSjhLaaxdeVDhbpFViGKUVwmSguMQvFkxGCOOTChR2HBozPuDgPko6LrTjDyOpwhConGH0HxWkwGdX8cdmRkPemzrT/LCvHSlRweVFInGyCtYD9Rq645+4Xt2sLIXwO9ySw4okrpvsk10vP0E1VESto0fo7Nl2kMb6nAiSWOMS3Di+U3d6arICtamRlDVwDXmDp1HL98ARtF7jJXcq4FU5WQPkkl86sGM8UKn+Fra6rOr1UC5qa87RbI1gG27E+/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: v5: - Use mem_cgroup_usage() as originally suggested by Johannes. v4: - Add "#ifdef CONFIG_MEMCG" directives around shrink_node_memcgs() to avoid compilation problem with !CONFIG_MEMCG configs. The test_memcontrol selftest consistently fails its test_memcg_low sub-test and sporadically fails its test_memcg_min sub-test. This patchset fixes the test_memcg_min and test_memcg_low failures by skipping the !usage case in shrink_node_memcgs() and adjust the test_memcontrol selftest to fix other causes of the test failures. Waiman Long (2): mm/vmscan: Skip memcg with !usage in shrink_node_memcgs() selftests: memcg: Increase error tolerance of child memory.current check in test_memcg_protection() mm/internal.h | 9 +++++++++ mm/memcontrol-v1.h | 2 -- mm/vmscan.c | 4 ++++ tools/testing/selftests/cgroup/test_memcontrol.c | 11 ++++++++--- 4 files changed, 21 insertions(+), 5 deletions(-) -- 2.48.1