From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87ABCC36002 for ; Mon, 7 Apr 2025 01:40:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F1C596B0005; Sun, 6 Apr 2025 21:40:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ECAF06B0007; Sun, 6 Apr 2025 21:40:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D921C6B0008; Sun, 6 Apr 2025 21:40:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BA3646B0005 for ; Sun, 6 Apr 2025 21:40:39 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7AF2DC08CE for ; Mon, 7 Apr 2025 01:40:40 +0000 (UTC) X-FDA: 83305543440.23.B8CBFE1 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf17.hostedemail.com (Postfix) with ESMTP id CC96240006 for ; Mon, 7 Apr 2025 01:40:38 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=N170TU05; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of mhiramat@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=mhiramat@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743990038; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G9kslMiAjcIOxIfbwor+UkTQhn6rV09dMAKpArDdNyI=; b=mEtqbjpk8zVP9hsPXyf9gevA4NQtjwKk08qGnZnxThmG0jIkn2GfPiwhC9zCM9V9wPstkL MpLc8Rx2aXpyhFzsshzgEdPA5d96IlrNKUtpEa9NLQyaXwercQjOCjaxZA1RuyS433uKk6 pch7Fdnc5pVE2KJnHinBinJv/2E32G4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743990038; a=rsa-sha256; cv=none; b=HA52zxTj9KnLwPdZ4VH9sfg8JFzo1O6X+n2HFmjEObDcNDy3eVzlpYFm/shou1yEkvdbsI cW2cPif8P3/UU9+n3SbnCuodletU3yBvTKs+6yNmobv7mlcBoHiGPNnOTpbR8F9jRP3eyb +cCMP2y2YFTWLxYPqShD89sN174xMfM= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=N170TU05; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of mhiramat@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=mhiramat@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id A955060010; Mon, 7 Apr 2025 01:40:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47B3AC4CEE9; Mon, 7 Apr 2025 01:40:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743990037; bh=Okrp/iU8s6vx/iSN7wKtk1uNblTS/UT+9eq+ZTcQgRM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=N170TU05rFjJdB/HBNmWwg/z2F0XYYkqY3cPK/MtzcCOjJ+8KUi2KSicxFKj5ehjX uuJ7tEaWnOKzotfF0U//ksEQkSNP3lTaIrAwEiYqTeXqfrb0u1ogba9kQuC2v6qF5I ZAULcNMzdLVfXer4yssF5hWk6/1lCN0vt1n5fdui5Xunx5UewUqJQrF4o3gSV2HLWx uEXdejAaLsckmYuwa2lOUKi/XrLhmA9SARJgH54Cl3kNf0toxo2cOMGPI60g3kqUT4 s+qMHRXh2WjVeQ4p0+zn12l4q1sCte6EsIe2+3Yz8FcW6ZNMg6jEYOYJzS0GYagYw1 RGMT3BOMoDRgQ== Date: Mon, 7 Apr 2025 10:40:32 +0900 From: Masami Hiramatsu (Google) To: Masami Hiramatsu (Google) Cc: Wei Yang , Steven Rostedt , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Mathieu Desnoyers , Andrew Morton , Mike Rapoport , linux-mm@kvack.org Subject: Re: [PATCH v4 1/2] mm/memblock: Add reserved memory release function Message-Id: <20250407104032.162f1d10e9ab885c72bfac8c@kernel.org> In-Reply-To: <20250407093351.5514960330bebbe07b707431@kernel.org> References: <173989132750.230693.15749600013776132201.stgit@devnote2> <173989133862.230693.14094993331347437600.stgit@devnote2> <20250405023018.g2ae52nrz2757b3n@master> <20250407093351.5514960330bebbe07b707431@kernel.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: CC96240006 X-Stat-Signature: 4zidw95dop3ppf91gwgqr8jns8n4gf8g X-Rspam-User: X-HE-Tag: 1743990038-207486 X-HE-Meta: U2FsdGVkX19QF5+NisFCgTfhsKlU0bJNm1pvtdqKx7A5b0KVlWpn86ed0alVse/Cg7T47yr4436eX/MRD23U5ZN7n5pc+K5nYT+RA3PgXHyqSFcfoPxKeryynknnLFEBERSj/ki/oPe24G9rv39fCJzTGwJhImHFHDHfjZLJJYdPoy10AiPpMuMfQnsp6gkbtDwJ+OusXs6WZFzJr2OszSckpROivEU0ABcJ60Ei0O+vglrPO6KnVAfijH5Y6faoRb1aUsQv8wa4LH995XO6M6OapnBqUKoFJxRPelxwJUSHuDoBbZI20r/ZCeSVv6K24Gv3za4H2eTsxpNMce9V1N0pZovPWMGu1bMhOLLSzEfJExa4KTlMolLV63dVK5WI1hnFcmrZ3zL+c64OeHZCywkZ3QG3X9suv6MtQveONbOdjJwBcXyxvOHGgU0TtHPdIFLnQjoNOptP6Ro/3ZF9kodIYtdXFDomMPeimvQ3Cfirtg+Jg7DLZr1lgbwMETXwKbteGCraqJg6asGnYjjyf73v9xtwpse/t4yu0PpXITaUiEG3WMxjtGxp4iPmwlRitAPgRg95Ct41HkzG0oOW8Y57KTFWD6zkQ8hmirz2TnKSyMDiBd2wNriLVyhfRvhCWKofdJl6HYZ7r0qaJUu/RxuRhubG8SV6mf45hVJRl8AK7VmBSjIxSbFVT78i2dHzUsmf4beTD0lQ7CDHXsjoU/6n7mzGbKOySnlJ8sSjr2YoibMvshAkz/fUrrYkEA309MDkW4fxJW+OtNF9SddtVu5VktPzr2mPXqcI8/GP2cYzztBWUUEQ0NvFtWIhtczZI/Ck4Dxug2DLwUoiZgivsucapyRbB4rXaBGgIVeb+ulHqmybvH26JL51xV5i+8BB3jmsiDo4eJFl5XN1hkHrt/xhtsu2JS3XMMNYXhrLCTbNpKio3fXGXELRlpXomSpz7lg6cWeKVv48vTkcQym 8gKErhSg wo9tvqze2dH1u0Cr+cwmViRLbzLrIfULrgX4mj68cTKkG43PvmKTzpN83BvsASoa8o9el44kiXXZar+RQVJl7xFYN/6+oCkPSUdFIF8tJQryZ1ydee1+IAdCQ78XLeq5/YYByKQ2gHfCxQMiQypER10qHX2Z/9N0E16a4uJYkRRSpzQ3pcYG84CPnBJpbd6LROwTUvkGujE0CGfT2OHhF+CECTfxf9UdQWyrpwEEUxOpmINZdhDta4K4SYH5Vz3dLoqFfXl0Z4flIgdI0TIGV2Yco/hnP+auK98W5Z66gdOi3gNsoNKYLqCdm2CbIggrpa/FgUP+qoy0OPgy2uRvL7yYmUQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 7 Apr 2025 09:33:51 +0900 Masami Hiramatsu (Google) wrote: > But this is fragile by design. As I did for lib/bootconfig and > tools/bootconfig, you should use __KERNEL__ and makes it not depending on > the kernel header files because it does not expected to be used in user > space. > Even if I added mutex.h, it stopped with another reason. > > test -L linux/memblock.h || ln -s ../../../../include/linux/memblock.h linux/memblock.h > test -L asm/asm.h || ln -s ../../../arch/x86/include/asm/asm.h asm/asm.h > test -L asm/cmpxchg.h || ln -s ../../../arch/x86/include/asm/cmpxchg.h asm/cmpxchg.h > cc -I. -I../../include -Wall -O2 -fsanitize=address -fsanitize=undefined -D CONFIG_PHYS_ADDR_T_64BIT -c -o main.o main.c > test -L memblock.c || ln -s ../../../mm/memblock.c memblock.c > cc -I. -I../../include -Wall -O2 -fsanitize=address -fsanitize=undefined -D CONFIG_PHYS_ADDR_T_64BIT -c -o memblock.o memblock.c > memblock.c: In function 'memblock_add_range.isra': > memblock.c:685:17: warning: 'end_rgn' may be used uninitialized [-Wmaybe-uninitialized] > 685 | memblock_merge_regions(type, start_rgn, end_rgn); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > memblock.c:591:42: note: 'end_rgn' was declared here > 591 | int idx, nr_new, start_rgn = -1, end_rgn; > | ^~~~~~~ > cc -I. -I../../include -Wall -O2 -fsanitize=address -fsanitize=undefined -D CONFIG_PHYS_ADDR_T_64BIT -c -o lib/slab.o lib/slab.c > cc -I. -I../../include -Wall -O2 -fsanitize=address -fsanitize=undefined -D CONFIG_PHYS_ADDR_T_64BIT -c -o mmzone.o mmzone.c > cc -I. -I../../include -Wall -O2 -fsanitize=address -fsanitize=undefined -D CONFIG_PHYS_ADDR_T_64BIT -c -o slab.o ../../lib/slab.c > ../../lib/slab.c:6:10: fatal error: urcu/uatomic.h: No such file or directory > 6 | #include > | ^~~~~~~~~~~~~~~~ > compilation terminated. > make: *** [: slab.o] Error 1 Ah, sorry. This is from liburcu. I installed the package and fixes the issue. Let me send the patch. Thank you, -- Masami Hiramatsu (Google)