From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25703C36010 for ; Mon, 7 Apr 2025 09:37:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E962B6B0008; Mon, 7 Apr 2025 05:37:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E45206B000A; Mon, 7 Apr 2025 05:37:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0E446B000C; Mon, 7 Apr 2025 05:37:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B571A6B0008 for ; Mon, 7 Apr 2025 05:37:48 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DB64AAEFFE for ; Mon, 7 Apr 2025 09:37:48 +0000 (UTC) X-FDA: 83306745816.08.9B43D9A Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf27.hostedemail.com (Postfix) with ESMTP id 9D29640009 for ; Mon, 7 Apr 2025 09:37:46 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of rakie.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=rakie.kim@sk.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744018667; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zv7+jyDzvTFzdENcVgaz/HXbnE/eGIBfp9bbB3LDxrY=; b=BceSs0wva7ya+zxGxLtyvKGjUKj8CVjqjMjh/EQxJ+p9AJ9865qbLevOVJkWB0aQjBbVUa 5vOK6Wg4//W7olM5VoRb4RowhhSQ7oMdcmxUEz+eVrH45j28JLLYugVwqFrTnnMGkSrcMb iXLUcsZ1gGa3+xUlVFMSIuVNdG/I9eU= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of rakie.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=rakie.kim@sk.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744018667; a=rsa-sha256; cv=none; b=5R1QyjmuXS8J4gmzXMaXGDxXX6ipqIO9I+3NNf3zeBRPF7uIGWOEJzbLxgOP+9cX0G3DD3 0pK5GjtfZEf1GmjFr7WCB9gro7hIGaj6eR4bpSwMXVkckaOZ+u/YYZx55hMgq1X1USGgRi Um/p17R8aWZJKTf7uQXZM8/6YsGB2cQ= X-AuditID: a67dfc5b-669ff7000002311f-75-67f39ce63774 From: Rakie Kim To: Oscar Salvador Cc: akpm@linux-foundation.org, gourry@gourry.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, joshua.hahnjy@gmail.com, dan.j.williams@intel.com, ying.huang@linux.alibaba.com, david@redhat.com, Jonathan.Cameron@huawei.com, kernel_team@skhynix.com, honggyu.kim@sk.com, yunjeong.mun@sk.com, Rakie Kim Subject: Re: [PATCH v6 3/3] mm/mempolicy: Support memory hotplug in weighted interleave Date: Mon, 7 Apr 2025 18:37:32 +0900 Message-ID: <20250407093738.406-1-rakie.kim@sk.com> X-Mailer: git-send-email 2.48.1.windows.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOLMWRmVeSWpSXmKPExsXC9ZZnoe6zOZ/TDc60iVjMWb+GzWL61AuM Fl/X/2K2+Hn3OLvFqoXX2CyOb53HbnF+1ikWi8u75rBZ3Fvzn9XizLQii9VrMhy4PXbOusvu 0d12md2j5chbVo/Fe14yeWz6NInd48SM3yweOx9aerzfd5XNY/Ppao/Pm+QCuKK4bFJSczLL Uov07RK4Mi7tnsZS8EOw4sOLDqYGxh18XYycHBICJhLfp7UzdzFygNkf/zuBmGwCShLH9saA VIgIqElMe9XI3sXIxcEs8J1JovnMNHaQhLBAuMT3+09YQOpZBFQlPpxKBwnzChhLbHr5jxFi uqZEw6V7TCA2p4CpxITPU1hAbCEBHolXG/YzQtQLSpyc+QQsziwgL9G8dTYzyC4Jge9sEnv7 fzJDDJKUOLjiBssERv5ZSHpmIelZwMi0ilEoM68sNzEzx0QvozIvs0IvOT93EyMw+JfV/one wfjpQvAhRgEORiUe3h1un9OFWBPLiitzDzFKcDArifBanvqULsSbklhZlVqUH19UmpNafIhR moNFSZzX6Ft5ipBAemJJanZqakFqEUyWiYNTqoHR++bmjQ+nPDZVD7gY6sRf6WobxWio7fyp 3VmEO6dOvzF1+f7rjEkTz63w2bhy/pYOmbd3c8wfOF/2edjezFlQUPGZVXqG3tkL162tpi9d qGlytbk1sJlLz4PlmcFy9qRfr4/V29Q+fTAhSu7b+eTmk+I706fcun5g3WHxs3NK4zYdfmae pPFGiaU4I9FQi7moOBEA02HKlXoCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrILMWRmVeSWpSXmKPExsXCNUNNS/fZnM/pBmc+cFjMWb+GzWL61AuM Fl/X/2K2+Hn3OLvF52evmS1WLbzGZnF86zx2i8NzT7JanJ91isXi8q45bBb31vxntTgzrcji 0LXnrBar12RY/N62gs2B32PnrLvsHt1tl9k9Wo68ZfVYvOclk8emT5PYPU7M+M3isfOhpcf7 fVfZPL7d9vBY/OIDk8fm09UenzfJBfBEcdmkpOZklqUW6dslcGVc2j2NpeCHYMWHFx1MDYw7 +LoYOTgkBEwkPv53AjHZBJQkju2N6WLk5BARUJOY9qqRvYuRi4NZ4DuTRPOZaewgCWGBcInv 95+wgNSzCKhKfDiVDhLmFTCW2PTyHyOILSGgKdFw6R4TiM0pYCox4fMUFhBbSIBH4tWG/YwQ 9YISJ2c+AYszC8hLNG+dzTyBkWcWktQsJKkFjEyrGEUy88pyEzNzTPWKszMq8zIr9JLzczcx AgN+We2fiTsYv1x2P8QowMGoxMN7o/FTuhBrYllxZe4hRgkOZiURXstTQCHelMTKqtSi/Pii 0pzU4kOM0hwsSuK8XuGpCUIC6YklqdmpqQWpRTBZJg5OqQbGkN3a+hEH6zmZUq+oVdWWHF4c p7EoXDFonuK+CRNds5Jmde9dlrVW8ZhC7DO7OOWT6n6Lfi839Lj1lcFQJeuQ/r792heOcDiE 79Ls5LxoraxV9mA7U5dp7a97ydHSP5+nTri14Rrvvenf7xu9FJrWuKnrcNxfh87rMQ/+CWv/ NZluN+P1hPxYJZbijERDLeai4kQAkX4dnnQCAAA= X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 9D29640009 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: kkiq7kdmfh9d6t1t79izf5kpf4148598 X-HE-Tag: 1744018666-228113 X-HE-Meta: U2FsdGVkX19hrS0IYb7hnMpDeALl2fmPPKNgw6Km9yHhv/wzd9x+QMWLTSfKSa5QE0ktYqfpBmAW0id4Dvmea/vPlqIWblHWB27o0t6HSZ7vwTRIyuIuAs5PqXoKIRAZm0FNWFe9cFO7KRNkHtVNAolqvpM+pwRAh727CQSEny3oBZ5dul+abPG1GNhesYQI8qkUX3x/7Su7Tq3qAt84L8ULR9MrUo+B66CI+v+wf69Tm9gK80F1oEcfoKiybQ6i92kR2fDNuDRE4BJG3nP3RxBcoUtWX6+E/CZT4D7gAcoWPzWpTuI+JtcmwmY70jJRZ3dzikdyEPu8O+nfU7RF1jyAvj6dGldFBHGbxjN68XfN/4jeUCC2TnFdfJa6xZzWquuc4HUH07aXRewZ4dNjKi+SmvGXt+qkrisyG3FIKbqvluEYFOG4tKusn3DsvIEFBvy7yLcLCXM5Cr2z42YtaNCw0AwebU10p1eYs9Py2JnIWQ267kmYY0VDgPP11PNsbk66pH3EpwISbmCz1LHU2Ir/5N2RS/TYIy81dJh+SU8063sdhLm6AcaryxOR2dXciuYjaE8eECaFwK24Dfzozx8PSR0Md0OJTq2mh29MlDf5x6g7XuaIaPAH1p0U6iXKlsPzj8ry3tl/c7eN7IDIU7m+CehcwyZgm/je2a71Ewd6wGXA6QCbUxc/2hMoO47u+INezTPxtRSF8K0FFPT8RnOUPCjgrswQkNFu0Q/6lCyfLww1QcccwG29B+BKio+6xWWsT/qPnBz8WvXUrj+lCjTWeJa91asBaG19vwcvjWjnsZeC4Km1DC3vFOMEu8/d X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 4 Apr 2025 10:43:18 +0200 Oscar Salvador wrote: > On Fri, Apr 04, 2025 at 04:46:21PM +0900, Rakie Kim wrote: > > The weighted interleave policy distributes page allocations across multiple > > NUMA nodes based on their performance weight, thereby improving memory > > bandwidth utilization. The weight values for each node are configured > > through sysfs. > > > > Previously, sysfs entries for configuring weighted interleave were created > > for all possible nodes (N_POSSIBLE) at initialization, including nodes that > > might not have memory. However, not all nodes in N_POSSIBLE are usable at > > runtime, as some may remain memoryless or offline. > > This led to sysfs entries being created for unusable nodes, causing > > potential misconfiguration issues. > > > > To address this issue, this patch modifies the sysfs creation logic to: > > 1) Limit sysfs entries to nodes that are online and have memory, avoiding > > the creation of sysfs entries for nodes that cannot be used. > > 2) Support memory hotplug by dynamically adding and removing sysfs entries > > based on whether a node transitions into or out of the N_MEMORY state. > > > > Additionally, the patch ensures that sysfs attributes are properly managed > > when nodes go offline, preventing stale or redundant entries from persisting > > in the system. > > > > By making these changes, the weighted interleave policy now manages its > > sysfs entries more efficiently, ensuring that only relevant nodes are > > considered for interleaving, and dynamically adapting to memory hotplug > > events. > > > > Signed-off-by: Rakie Kim > > Signed-off-by: Honggyu Kim > > Signed-off-by: Yunjeong Mun > > For the memory-hotplug bits: Reviewed-by: Oscar Salvador > > Just one thing that caught my eye: > > Cannot add_weighted_interleave_group be __init? AFAICS, it only gets > called at boot time? > > > -- > Oscar Salvador > SUSE Labs Thank you for your response regarding this patch. I agree that `add_weighted_interleave_group` can be marked with __init, as it is only called during system boot. I will make this change in the next revision. Rakie