From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91D51C36002 for ; Mon, 7 Apr 2025 00:34:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A7476B0005; Sun, 6 Apr 2025 20:34:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0586C6B0007; Sun, 6 Apr 2025 20:34:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E5FC46B0008; Sun, 6 Apr 2025 20:34:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C69106B0005 for ; Sun, 6 Apr 2025 20:34:13 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1D3711407C4 for ; Mon, 7 Apr 2025 00:34:00 +0000 (UTC) X-FDA: 83305375440.29.8DB7900 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id 557DC40003 for ; Mon, 7 Apr 2025 00:33:58 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OYQrUKzQ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of mhiramat@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mhiramat@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743986038; a=rsa-sha256; cv=none; b=jlGLeZFdRI0hjhJmiw11UPkrr9ocW6EEKgj5fnruGEs+5ReD1uzmvXuRvsm4fn8/pT+fAC II2LG63lvzHhaaTGTo7L/ww1XBs9fa7HqDApeInnl5MuK5PpBAWAFORCZ9e6/rEtEtkw/g B7H0JBG5r9h5g85KZHdcluWtE/xxRRg= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OYQrUKzQ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of mhiramat@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mhiramat@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743986038; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EhiYqk2gUVD2fjOAQ5EamFM9mGWLrHgB9fT2lnKSPrM=; b=MNVMt4ziUIBlYRqcOZdEgKADg7TnpxYvlG1eN4p2kO7FAEYbEoZT2hCQhCqBHQtAkJ2C9N 9EJex0iRktKXzuKxnlXFvYDVZn3P6jme1S+8Zsoh2ppavcaJkjDnQ4SCJWNPZYf/VcJYLc bIkIugptHQHat7HlElrXkaMma0HtRLc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id EA5FD5C58EE; Mon, 7 Apr 2025 00:31:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 598DBC4CEE3; Mon, 7 Apr 2025 00:33:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743986036; bh=YKkc3sQ/4L552d8qUaKPTIAMhzZq6WvaxTu60Lnsawk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OYQrUKzQ1RIBYp/uDc2apiy5EEbvGf8ejCwVwXpy0lr6cA13cR4nK4rVkLQfLKTKQ XCqo9jz1X1Jyy92KOKhXzgJC/3y2TtiwHjs9J0Y5WsaE5IOqUruvTWMclkjvQdTosc PuhHMf6jvSRnot9F7jrLqU4DapR4p4IrR+y3dX9OARPURYIlFmUrXlXAW3ms0fG922 WOt4OulUbHbzstkCSSYQl19bmgTDufPn6ebwFbPTF39oXrVS+s4/yJOaOGHn8jfqOE /GBUyMjkzg9ww7hjXmQfpTi+bhoqzzaLpIXNmjlmKUsPAjbTDW3FnjqbEyb5vAlT6j bI63r8JrhAwDQ== Date: Mon, 7 Apr 2025 09:33:51 +0900 From: Masami Hiramatsu (Google) To: Wei Yang Cc: Steven Rostedt , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Mathieu Desnoyers , Andrew Morton , Mike Rapoport , linux-mm@kvack.org Subject: Re: [PATCH v4 1/2] mm/memblock: Add reserved memory release function Message-Id: <20250407093351.5514960330bebbe07b707431@kernel.org> In-Reply-To: <20250405023018.g2ae52nrz2757b3n@master> References: <173989132750.230693.15749600013776132201.stgit@devnote2> <173989133862.230693.14094993331347437600.stgit@devnote2> <20250405023018.g2ae52nrz2757b3n@master> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 557DC40003 X-Stat-Signature: g3mgurb5znufuiyjdouk89unypkijxa9 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1743986038-53242 X-HE-Meta: U2FsdGVkX1+jgfuOujkfUEFk1mGa6aualrXMmdU1Vg+5t3fkYPwnO9yfgNIj53GylgzmM0LUffYcZIfwFXUlLzkT6/Qw8fpKdQJpMDmUYVdsVM9PBKiRD827LZSB2cnOAp6i85kKpW0wSmKdoRnI7ZSYd6JwawlyC9hETyM3jBxaLZkjErYuyUJCRmL6HMGZjMw10MXt5UYMJA8cx8M08BW6fOU/5oDxZXGExqzIUmeB0WHDnKBGbZnau2Mxt9gj6Ic5cuWEq5Ec6AGOqfGc0FJctHaD8upERbxFTKLKJ2jbI4WDfMbhn+1gmZnQGZHAcbk1fGqcmSdx8IWsCgFqq19oz1VtY5qEz+i98GIK+3HvIDQNbdebvwNQE/dHTE1z3T0Lfw4+ClLhVkPH+hJ8yCtRAe2pXkkHwXunXRZIRdg2CQ+ZJ6/GtAz7a9/E13sFuIjeYVOtmODdmXLBjNXaeXzAKWfHNXwdhxRhosAkewh8dkrKN63sSWLl9jOPuATYC4ULqCUJ27MnlrfVShvyg8htxvd89P0sbsytSabd776ZNQrXIsERnixn6fUTzkDvO8Dtc6goFfMME+Q79MJc1vGimjj7+OKHSy/6GURv5FJdWhBI25TrgsoUThz1nJ/2GHOybqQrtSzH0JsYoyfsBl64hfLLkfmlsvNUfno0fp/fdS/C0aU3Tc2+LlA7vVtSVBk2sbLRVVfWbbmwg0vg3bTg1ODNSed1DjPTlf1C6Un5FV1VFR6ljarSP961w5TXsaCh5NyGWHsaerpkqS//IQc4YQgfmR41pJXkfFUCsODOslDaDHi1UdXymP2bO9byxVhmNyJBpkoKxhnSY8bjWiEODbbmJSxJIJg/bdsgt93YcDkELc3d2vSpJeQH5CM6EFc073iewxON433Q+OXwTIrJOV+aqUoQrpeomx6OtkhQWmfjlGVd5XGvAqVDlaCz0eHauAPQfli2n0/Uogh vR/xVrbR +2Z1ZoadK+d3em7KcnEwwZwMfYfBrVK/3RD5G08TQjm8EBEt5uJN0v3Tdwbp7OQZs+v84CmZhdHLvuSZWH4nXUivILpXpILbiuatTfQdGiUKf2E8Q/6ZqOGPsUaBaG8p+S0cwq9pqKaMieeRE4tI8yXjQca5IcES62F6k4BG9yXYzj8oY8bH5leQ7zFAueIn66/kDaMLVkBuod94sAm3eVbJ7lJ1PGZYvJqJXsPXN1Sv8C1YU/6p9tqKqXBJ0bif32qqNf73uSQJxoR4OBFciqgdCRqX2J4nWm3xya2PLiwVFOAIDR+GtrEmLh3d3/RS05GPgUYZC+cQv0j+t/ZbqwxvQDt9WvAel5rhdrhAmOk1re+F7rTN9OB3wG/6UuNABail/+hc3bssEZPFgHhxCrO99liH4b80EbDeD8yhyR8jbSXfSdAxO0RA4SGQeXYfakYUiNq7ddj4g2j4YrMDGNW4Z9QcBgsl0sObx4eNVZDKMWTsNNl+p0satlRqNTBhSB70C X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 5 Apr 2025 02:30:18 +0000 Wei Yang wrote: > On Wed, Feb 19, 2025 at 12:08:58AM +0900, Masami Hiramatsu (Google) wrote: > >From: Masami Hiramatsu (Google) > > > >Add reserve_mem_release_by_name() to release a reserved memory region > >with a given name. This allows us to release reserved memory which is > >defined by kernel cmdline, after boot. > > > >Signed-off-by: Masami Hiramatsu (Google) > >Acked-by: Mike Rapoport (Microsoft) > >Cc: Andrew Morton > >Cc: linux-mm@kvack.org > >--- > > Changes in v4: > > - Use free_reserved_area() according to Mike's comment. > > Changes in v2: > > - Rename reserved_mem_* to reserve_mem_*. > >--- > > include/linux/mm.h | 1 + > > mm/memblock.c | 66 +++++++++++++++++++++++++++++++++++++++++++--------- > > 2 files changed, 55 insertions(+), 12 deletions(-) > > > >diff --git a/include/linux/mm.h b/include/linux/mm.h > >index 7b1068ddcbb7..1ee9e7447485 100644 > >--- a/include/linux/mm.h > >+++ b/include/linux/mm.h > >@@ -4123,6 +4123,7 @@ void vma_pgtable_walk_begin(struct vm_area_struct *vma); > > void vma_pgtable_walk_end(struct vm_area_struct *vma); > > > > int reserve_mem_find_by_name(const char *name, phys_addr_t *start, phys_addr_t *size); > >+int reserve_mem_release_by_name(const char *name); > > > > #ifdef CONFIG_64BIT > > int do_mseal(unsigned long start, size_t len_in, unsigned long flags); > >diff --git a/mm/memblock.c b/mm/memblock.c > >index 95af35fd1389..8cd95f60015d 100644 > >--- a/mm/memblock.c > >+++ b/mm/memblock.c > >@@ -16,6 +16,7 @@ > > #include > > #include > > #include > >+#include > > > > #include > > #include > >@@ -2283,6 +2284,7 @@ struct reserve_mem_table { > > }; > > static struct reserve_mem_table reserved_mem_table[RESERVE_MEM_MAX_ENTRIES]; > > static int reserved_mem_count; > >+static DEFINE_MUTEX(reserve_mem_lock); > > > > This looks break the memblock tests in tools/testing/memblock. > > memblock.c:2289:8: warning: type defaults to ‘int’ in declaration of ‘DEFINE_MUTEX’ [-Wimplicit-int] > 2289 | static DEFINE_MUTEX(reserve_mem_lock); > | ^~~~~~~~~~~~ > memblock.c:2289:1: warning: parameter names (without types) in function declaration > 2289 | static DEFINE_MUTEX(reserve_mem_lock); > | ^~~~~~ > memblock.c: In function ‘reserve_mem_find_by_name’: > memblock.c:2332:9: warning: implicit declaration of function ‘guard’ [-Wimplicit-function-declaration] > 2332 | guard(mutex)(&reserve_mem_lock); > | ^~~~~ Hmm, this means the memblock test builds the kernel source code in user space. I think we need to add linux/mutex.h under tools/testing/memblock. But this is fragile by design. As I did for lib/bootconfig and tools/bootconfig, you should use __KERNEL__ and makes it not depending on the kernel header files because it does not expected to be used in user space. Even if I added mutex.h, it stopped with another reason. test -L linux/memblock.h || ln -s ../../../../include/linux/memblock.h linux/memblock.h test -L asm/asm.h || ln -s ../../../arch/x86/include/asm/asm.h asm/asm.h test -L asm/cmpxchg.h || ln -s ../../../arch/x86/include/asm/cmpxchg.h asm/cmpxchg.h cc -I. -I../../include -Wall -O2 -fsanitize=address -fsanitize=undefined -D CONFIG_PHYS_ADDR_T_64BIT -c -o main.o main.c test -L memblock.c || ln -s ../../../mm/memblock.c memblock.c cc -I. -I../../include -Wall -O2 -fsanitize=address -fsanitize=undefined -D CONFIG_PHYS_ADDR_T_64BIT -c -o memblock.o memblock.c memblock.c: In function 'memblock_add_range.isra': memblock.c:685:17: warning: 'end_rgn' may be used uninitialized [-Wmaybe-uninitialized] 685 | memblock_merge_regions(type, start_rgn, end_rgn); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ memblock.c:591:42: note: 'end_rgn' was declared here 591 | int idx, nr_new, start_rgn = -1, end_rgn; | ^~~~~~~ cc -I. -I../../include -Wall -O2 -fsanitize=address -fsanitize=undefined -D CONFIG_PHYS_ADDR_T_64BIT -c -o lib/slab.o lib/slab.c cc -I. -I../../include -Wall -O2 -fsanitize=address -fsanitize=undefined -D CONFIG_PHYS_ADDR_T_64BIT -c -o mmzone.o mmzone.c cc -I. -I../../include -Wall -O2 -fsanitize=address -fsanitize=undefined -D CONFIG_PHYS_ADDR_T_64BIT -c -o slab.o ../../lib/slab.c ../../lib/slab.c:6:10: fatal error: urcu/uatomic.h: No such file or directory 6 | #include | ^~~~~~~~~~~~~~~~ compilation terminated. make: *** [: slab.o] Error 1 Thank you, -- Masami Hiramatsu (Google)