From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD731C36002 for ; Mon, 7 Apr 2025 02:58:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9FF3E6B000C; Sun, 6 Apr 2025 22:58:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9856D6B000D; Sun, 6 Apr 2025 22:58:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 827F16B000E; Sun, 6 Apr 2025 22:58:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 648316B000C for ; Sun, 6 Apr 2025 22:58:52 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8A646C0A0C for ; Mon, 7 Apr 2025 02:58:52 +0000 (UTC) X-FDA: 83305740504.19.7296B17 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf21.hostedemail.com (Postfix) with ESMTP id 802881C0004 for ; Mon, 7 Apr 2025 02:58:50 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="Nm//pY+T"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743994730; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WpAXmQFfrth9inTHfwe4gzaFOrCIBg7xJ7/0e8gazqI=; b=RaWEjA/NtIgC1fCFjXpEeWTFNrXQB+tLviNkV5v2L5mbBMRGwaEU1lWuK9/6X34bEzCPy6 2bsJv+7iK/+23U90VvEyfQrRLk5SpSzDGMFKp/NCX/7IFfoT/OmqgFB4N8n4MRFLdWzsu8 h5CxRWipIBl8SmIuu7PDYusRHibYIls= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="Nm//pY+T"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743994730; a=rsa-sha256; cv=none; b=REcFOWxbc02cVKOltGg6d79Kewjxg9ufVxzSr3RWZ5qD5Cg0sl+0snBzYm2uE8yttLxDU3 ONE8pgdcsSlu2pDYLdclcER88J+pvIygiSA4NOXxuwK1EqdB3KzWnRfdYb4mv1Udwu9z6U cHOmbjvbJN6W5ntg6nHk3bL3VWIgr2Q= Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-ac2c663a3daso741884366b.2 for ; Sun, 06 Apr 2025 19:58:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743994729; x=1744599529; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=WpAXmQFfrth9inTHfwe4gzaFOrCIBg7xJ7/0e8gazqI=; b=Nm//pY+TJtVIXAhdwx01jIE8fstz46q2NIzwN6mEWKzChsOAmArCrgSif6apAj1BLk WJajTrWjYhHwKx6bP4tu35/98ip2bUWPmlYe33NFBKe0GkNrw4XMCUgU33FAydnYeF7d q5pTF9hf5USVtpCHIOKVv2rOGLFxSmm8SURd1S6xpUmh210DQIEh5PEMPWsiX0yINwDk nPEC37dnmgxqGxZ+RMD34iVVr/KWOqLmbjoMPQHdr6JFEXgNO0Ij91wlzjpMPYOY4XN1 w3yOAt/7muHiVfeLrBZEQuC8XSdKAN9o22o8vTfnIKRUxUzJI1Loix96mpK8bEQHu8FS ycAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743994729; x=1744599529; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WpAXmQFfrth9inTHfwe4gzaFOrCIBg7xJ7/0e8gazqI=; b=fubRwNICE7OqTFBgalVljTtWnUSTgb7nHrAuz1pCEqMKEZV3nrzxlnRMKHqVfsAjzs 7IDXDhvMTpx5o3qViEM8rkgvBLjPpV9HqsAZgT1EV/grnEkhgKzYCkFHQxIeDgeCBIYz xb1PoKZr1ZWsQWFTIGY+FhriJGDTOI4kXr3KBCSl7OkGhsrs/f3ykIUe/MN3ofY+pgJM CDlLdUaUOKw2/iTWxOOPSE2q/uDCBn80C1crrbCcfeYz2YFvRECHLNMyFgbaCsb/h+Oj tnnMepTavesLQjSuLfFVS41ut/E+JTj8s5GdZTgk1d9F7cuHujytAXiWDjZAcyGgprRF MVIg== X-Forwarded-Encrypted: i=1; AJvYcCU0Y/jOL7AAjVWohm/NTpquRNIg7u6F2ZkyBf3S42r465SsagZgm/xvrklCBQFf2NqS2pVJ/9nj/g==@kvack.org X-Gm-Message-State: AOJu0Yx3KKrc637c7gv7dOsWpFpRCEmUJ063TfaKvfs6xsB9IxeJ7tmi lMgqmyepe+7Sp5n8b/n1grDEJGYwYj01PvYZp5gpFRTs/FlsPuGz X-Gm-Gg: ASbGncurKc7fG8J7Y0XwMBkKm0a0kAzeXs9sb6APyQzlO69Peg+RdbAlNSxZhWkkyCw 1DAu7NAB1xe5ExV56XYOBYQDUdsbpfSTkgNU7vuZNVClsoF5RjFDkDCw3Top2BO+w86vNQ6CPO1 ub98wTkh+nwKsRP41QQ/jf90EZsoOSeKAf4Q5JVv1HQaXrFU58OjpE1dMCmcM+VCJc8iKO8pNH2 QTGdrYUMI6V4Z+VDWZp7ua/caQuGKpK4HD9zJZN/NrgXpme3kJ4GS4KUOEU1yh/fmzuKKoC7/hI Bx2O0Qlh/lmp17J5iMxZvfyZZEPRpIsVHlW4Ql2Sibbn X-Google-Smtp-Source: AGHT+IE7bML/E71NZfYgfT5QezMVMN5iV1eS9oVYrdiFA5PfO8SsJRMQc4dbsuwpt6YdWwFWh8ZUwg== X-Received: by 2002:a17:907:970b:b0:ac3:cab6:719e with SMTP id a640c23a62f3a-ac7d1854ad4mr843637666b.11.1743994728819; Sun, 06 Apr 2025 19:58:48 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac7bfea16aesm667639566b.70.2025.04.06.19.58.48 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 06 Apr 2025 19:58:48 -0700 (PDT) Date: Mon, 7 Apr 2025 02:58:48 +0000 From: Wei Yang To: Wei Yang Cc: rppt@kernel.org, akpm@linux-foundation.org, yajun.deng@linux.dev, linux-mm@kvack.org Subject: Re: [Patch v2 0/3] memblock: some fix for memmap_init_reserved_pages() Message-ID: <20250407025848.5fw74w4dqasjbh6k@master> Reply-To: Wei Yang References: <20250318071948.23854-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250318071948.23854-1-richard.weiyang@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam01 X-Stat-Signature: hcicrgskwrn9m55rrq7qeghdj5ixh4im X-Rspam-User: X-Rspamd-Queue-Id: 802881C0004 X-HE-Tag: 1743994730-180002 X-HE-Meta: U2FsdGVkX194J9xyvynXwpMNgQ1sTYmK0uCRseIkBe3RLXvNZxfir0KaBg58T0ZnNKwd/2HLy9VmlzO1DAa0NydtpHHwrQD8d+vgWzuT1zS2Kz/u9I/b7Ss2boUyedqzWNFn1UJx8AtfYv72FDu74yGhT+TjPmnyE2HxInrvrl7WlKJ6rzgWNUzgHggrq0qSo/Ch+W4zFw65PNXZeRSmVTwYlFrRWhosSv4N6nB+T/ELUKu+b/ywj19yZn/JmoAsFKSdCLxpzPBXjxltAFCc2Crhu4/IIJcluArTtV9lYXG+EUFqxtCNUB+W04rqYGOueaW4orfFqXPzke6CWDb5kP6C56DueROQVriCf51yGqWlpcql6Lm5Tyt2rNhI7/jL7mPuB7d+4PTxHmvYCsyoLMCvLMt1y8ZgI5TfKtCYOL0YpSII2Ju+vY0otIeSftbA/Zo7Ai+EVSDZUwB4NmRfesieZlssSTPBnWWuQwBeImWEfc0yuXKkdv7z6zlLR30JpKQdrn13T517+EuiRnp8ygv7/o0oW7kdfh4aeS2BWFdDTJKxAJ6bST/GhOVX8ojnPtGVOR15vrO9a56zHDE9vT0I0xGawQ51PyD+ge5UBv+JVBVpa2bX4XSBCdUSTqNflXdDePEL2KUjL28y/3batlF5JSb0RgzN+9KOGkL2y5rowh1jjBtCh2SqqQTm9XzjmwAHOJDjJPizxY/0UV6BuqqnxUAUTkSiL3QKCLD5Q0kv8wpMt/Hd0CJ6Bwv5W404ko+sGdtLiCGQaOfRktfJtboWigCCvIUyYLb0HzCjNyET8ZIX42kyojc9/iCFZSRsa5ad9rlUhWe428zXu8BiBLDs9lkShyXA9E5W0SAs+OGrdnVvD46Xj+5eKZxmhrQxmTUunGagmN2B7XabLOMCrfudvGmZjSyZOlVkgNZ8WSaFgF0vtHeL359v101EzzGL8y6BJP5nTaZYU4s5GRf wp/z57Bi oXaRJoR7hTqk2e+FApl0gXJflmvX7gEKgp+nb2ei0mwtKTigZ4dh4CpUkJUEiHp+5pBcZEyi04KdX5IP4gy/d216TiaVp7Ja/yxMYghoS3I3HDJef0okda8I6SHjeD5pkOXy7zvjW3REM+7CC2FGzf7h2JfqmQF+ZOf/9ZABvA1aiN01S3Bzbtyu6ubmn6eCIbo63iXfDXsQUqXqULCzmJfzOIFuxmAknGerNZu1VlWgw5ACLltYRG7uNn6BKEHh7KrEOAx5RN5cvgEEltu6gTdo0h/Qhjt1AktOTV3+4ClOQAzsr4rPMMy3kj3woz+NMQ74S4pl4NGZFxkGxfh/XQ9wchPiycCt6ivBE7DHIQfq5pEJq/qGgGPxyUNRnz6zEOpsSYIh3mVGf18uaL9QGVU9zn/Or1bQ60T8Q6fNw58oo/+izp/ag3PgpKmpF74HJ+dyLvBnA/MQ79PmuwvS7Fm+yHMSBoFDyZXiVG9SVNNFsEpQRsBv6qLnZruO1t6a8TWiHVST3OAs9a9eQ3YEo9KmrXRkV3qq1Ggn0IdyWs3ciigrr6emmGVZbAvCUAz5F+6Txl5RAyrRW5D+k85p24hQUTQtQKQk82t3ynIRqocYFJ5gylREfwkUoywwwc4xys3v/1xDsokrB9SETW+IPlE3Vk7nYp3czS95HH5VfHAHkLdb965csqlgE9VV61CYFwcwct3glf+tSVOhqXL0y9wDdtVTI1otjoJ5myZ+3Z9/6kug= X-Bogosity: Ham, tests=bogofilter, spamicity=0.007712, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Ping? On Tue, Mar 18, 2025 at 07:19:45AM +0000, Wei Yang wrote: >During code review, I found we may leave some reserved region with invalid nid >when memblock_set_node() double the array. The patch set propose a fix and >test case. > >Also I found memblock_set_node() accept size instead of end as second >parameter. Currently it is misused. > >Patch 1: fix the second argument passed to memblock_set_node() >Patch 2: fix the invalid node id we may have in memmap_init_reserved_pages() >Patch 3: add a test case to verify it > >v2: move check out side of the loop > >Wei Yang (3): > mm/memblock: pass size instead of end to memblock_set_node() > mm/memblock: repeat setting reserved region nid if array is doubled > memblock tests: add test for memblock_set_node > > mm/memblock.c | 12 ++- > tools/testing/memblock/tests/basic_api.c | 102 +++++++++++++++++++++++ > 2 files changed, 113 insertions(+), 1 deletion(-) > >-- >2.34.1 -- Wei Yang Help you, Help me