From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C77EC3600C for ; Sun, 6 Apr 2025 09:31:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3CA786B0006; Sun, 6 Apr 2025 05:31:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 352AF6B0008; Sun, 6 Apr 2025 05:31:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F3906B000A; Sun, 6 Apr 2025 05:31:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F3CD46B0006 for ; Sun, 6 Apr 2025 05:31:09 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 48022B08A2 for ; Sun, 6 Apr 2025 09:31:10 +0000 (UTC) X-FDA: 83303100300.30.BCE1F47 Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) by imf12.hostedemail.com (Postfix) with ESMTP id 6C6B54000C for ; Sun, 6 Apr 2025 09:31:08 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nQaNqmPb; spf=pass (imf12.hostedemail.com: domain of andrewjballance@gmail.com designates 209.85.167.181 as permitted sender) smtp.mailfrom=andrewjballance@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743931868; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fHmP/Qg/EJyJa26FRzbLoPkPrFVf0HVFbniEqKsAmzY=; b=xfh5t0f6Wcstd+r9xQZSA088djBaaOBdjv4RWa9LoO4pgMcW6pVM6kW6IBL3gfJaHeffNj 70kI4ee3AqDVBL/wbrOZmqNB+SOswJPTcT53O9ELlFKnigoNLZPnBr+TiAQSZwVpLDqaDk AjnQLzKm8WSdOY00oDuILhP5jcXI9dU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743931868; a=rsa-sha256; cv=none; b=TVkeLDugqQQ9OOx12sXTSsSm88mOUuN+0ZeXF526LwbdyjfhzDHOHHhkKMmaK5hjuaGJp2 ovKqaiSBVvE8wZI3Sex7V5JPCwFGRoE/nFEwOL2hlO6gBptIiolVYgeyGCggaEaf35Rv1l ysrXHo6cBIkxqD5l3utrw2jXX7X0gVc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nQaNqmPb; spf=pass (imf12.hostedemail.com: domain of andrewjballance@gmail.com designates 209.85.167.181 as permitted sender) smtp.mailfrom=andrewjballance@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-oi1-f181.google.com with SMTP id 5614622812f47-3f8df49e75fso966287b6e.1 for ; Sun, 06 Apr 2025 02:31:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743931867; x=1744536667; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fHmP/Qg/EJyJa26FRzbLoPkPrFVf0HVFbniEqKsAmzY=; b=nQaNqmPbAqMXbl1uwZCk0Lu95GiBaageDFrrZ/d+qHdvB1ZtK1Y732zu18ZEGOOAye HPs5S+NW8FY170AJc6ceMfKY/yPoBbzsFeQy81KtRyK8XMDta+qQuGxHjIvrwX19KoIt 7Rl4/73faMLz826WokmQQq1CuVQmbUaGEmYc1foWd5XdO2IF8cUFgJT7MLbTrfVTWsLy fXm3EKb4ZCSDyoaViwRagVfhgaxGwNU3ExJce73SnxNcxISV5dBmAwCKuyuLA+RK3+sM 9/dj6mKFRlHI6MDne9gN9+n1qal/LhbbpCmneURuu4/HBMSFG47wPM5nSndqM0FXQwyj CU5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743931867; x=1744536667; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fHmP/Qg/EJyJa26FRzbLoPkPrFVf0HVFbniEqKsAmzY=; b=ER1MgxY/bf2UcZpyH5k1f7duCmVSpRE/P1uqlk6lZ47834bXnufMz+XzU2hGgG4bj+ EzLr6r6DTsBnIGdIRv2ivIlNIl16dNvvABw3ORKmaJSkYknwjfTExGeN/iDwyF10xI5C xQve+py8A2y++hSGW129CAwNaMqV/Ge6/Hiy4x5sGI3ymc9IwAdHyPZ/UCcQ3HXKcdd5 R4C3wpljn0FR+Km3xc6zDsRMZglUrJh8Tc/t+wsjFb4I5clRx4EKGw40vLEul1N9k2hR 34yS3cpJC1JuMMca8Q+J367t4lzEuw/xoozZgpDxJzokx5t85PASlA8nuSEt2ArEGESo xsbg== X-Forwarded-Encrypted: i=1; AJvYcCVUBNTW15pSrB88TAgfVpBzBeHw4GUKtmrUc6bwnVRReh/LScwwdmn5ZR/HDdsdx/iGW6/c4yaehA==@kvack.org X-Gm-Message-State: AOJu0Yw1V9jaDx4hfu90us3xGsaFUK9gkkUXrFMHDjyIfGnzTldGCC9O fTF2w9Vi4nZD7Pxd5kolmDaqRhbmhxlSlcdk7yiH+gHHw+k8BPYI X-Gm-Gg: ASbGncuVoAjuU/iVXggqlgrBWZh3cJlK3TpaHs9yuAdP9btgwpEJW5qrT7JMFn1Bx/7 IAnCHLNJhveBPSyLq1tpoCLOiP4z0m3W7dDJyw2RhdFMsf+ijVSElwsEk5T13nHOysMn/32pR/U 7Y5z/wvwohmS/VIv4BuaetWc3o3JKDXmEDOH0mMWSYbKmMfg1d0G91ZxlkE0TTFt0Qu8F/ChmAK 9Vmjj2vPYGcfq0XWpG0oAoDqFK465//7odA1RE6zO/BO6VR29/3sLLY7ksvu0eHMHgT0Iw86K58 ox+hNMXaIhMJusILokUT7Ey+D39BOVuoE4pGUhGfoAzd/95hmW5jfYR6t6zutaofZR0b0SfYqrb ySEAGI5LGKBTx9VXt X-Google-Smtp-Source: AGHT+IH3FJ5kGG0Wg/P7+DauHff2Q8I3DdhxiyMON9kl/B34ns20VCHv08p5xFw8uDaJF9ytGCKjqA== X-Received: by 2002:a05:6808:309c:b0:3f8:b73b:682f with SMTP id 5614622812f47-40045578aafmr4837432b6e.1.1743931867307; Sun, 06 Apr 2025 02:31:07 -0700 (PDT) Received: from my-computer.lan (c-73-76-29-249.hsd1.tx.comcast.net. [73.76.29.249]) by smtp.googlemail.com with ESMTPSA id 5614622812f47-400400809e9sm1344818b6e.36.2025.04.06.02.31.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Apr 2025 02:31:06 -0700 (PDT) From: Andrew Ballance To: willy@infradead.org Cc: Liam.Howlett@oracle.com, a.hindborg@kernel.org, akpm@linux-foundation.org, alex.gaynor@gmail.com, aliceryhl@google.com, andrewjballance@gmail.com, benno.lossin@proton.me, bjorn3_gh@protonmail.com, boqun.feng@gmail.com, brauner@kernel.org, dakr@kernel.org, dingxiangfei2009@gmail.com, gary@garyguo.net, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, maple-tree@lists.infradead.org, ojeda@kernel.org, rust-for-linux@vger.kernel.org, tmgross@umich.edu, wedsonaf@gmail.com Subject: Re: [RFC PATCH 1/2] maple_tree: add __mtree_insert_range function Date: Sun, 6 Apr 2025 04:30:08 -0500 Message-ID: <20250406093008.1655905-1-andrewjballance@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 6C6B54000C X-Stat-Signature: gi8n9tfmy3pxq9pp4b9yjodec85mg37m X-HE-Tag: 1743931868-535933 X-HE-Meta: U2FsdGVkX19LAqhBLRi1l+nuFNHQfP7vJqcB3DcyccAN7Ojt4Um5hAY3L5fOC+TUSi41H5Dw4zLVfn3Rya6zsJ5DxS8z9MPt+Jnqwhokitm0Gdgsnj88QioiN+cdOzrODKDWtFLJwet4unuSr9bBOyYXWUTU+IR58/dj1YxB9cOsqfZURmhbk47qWn93lMpoQm2E9p5dfDmuLkgtzQ5l6S9zqVPCq6CVCLd6NU4xbbxYPSgDGHoA18IEi6LHOor0eWWwESaOMPhYiSJXP4+J7AW6UDSImfSNCY6zatRRL27pIAx1z7l/MYsRhOgBq/fk4QOcqEjUEKro+7ug6f2ApHHF5pxYH/wSh2XmTDZqo1vndqmKiFLfAlJSL7rp2IvPOHRfBbK2s3CiNz4W1otVB+lcLlbiF0SqKqPD+bmqHQu3YmYF6qO1rICjQIahwqNlJydw+fqR+YbTkdJOVEUI/+rxsu1areJVAxBy2jXm9rfI6Z+sf6vTHpWDXLeWUGioFqvGw/zbcn81vPXPxMNBEyMxI+wvuMyMQ8ZwxxjIwFsrXSxNgxW2+YvSzKNL9WrvrisyYB0/foPTPMcuzf5txGhIb5G/kwW5f5TXq9amOXIQiLiSWlMIGoQyC8eRxvmONP93lXVfUYAdkfhL3rCqVNPh38RB8nZUkfKo1Hkh4nio4Y6YMDpSEqxDI8U8NTEkz9kGOLWePxseT40SoxQTFJdKOll8jM3X3xAouJzKgrfOzUt9tYv1hdCww/q2pI4vpWSoX7hGT8ec9uGh/xwzvKzTjRdu1oH8fkvdfQtUMDKsOmzSFPDO/s4yXU8g3jHkbe70ghms5Nw7yWZW2YMzS9ISnSL+T1/XxMJAoSFsWvNNgMSDyg9O8OmMFqtqUaC2ywueoby7UKBOHDgqILCto1VBrJic/XNfFSyw9T4kEALfUxeYN/fiK4p1hsoCzUD/VZmmwiUZFOdC8uiWAgS lxToduVh knx5L8s0jbC1FXSkmH4cpuZFuwWp9jcWCjB64NToP5iJoEdT3jdLlf6qZLSq73u7m9DxjDykkn/uOT842Vn2excO8oSsn7GxN9m4Rdpm30lLiHkabRDY53Bba3GkoNjCdoaZMcYiBX7la6zpHtxMpRgwlDqTr2w4h+kyKkZDslYECVg6eySR9gdZo+dC4aee7E7nSgwja3vpMqFK2Y/w8uLWXM6FTcX/zs4G1dUVDZDufIJkoAwEXgoPFBCp3+zmIyBwvMs1gpr8H30q5+8AaWruhYgmlSHEqtxQQRk5XZgamT4e09t/wg/fgQRt9P2ZqIb/q/ynR/QZiKdGPgUoolOmrp89StQqVQ+YbhkIpyS9r9pLEnVmHuLImMkyH7vqchCrOxcySYCFF+tbTFlhuCdff+CSoZ7Q1uLIYyyyWY+gRoHwPrRw+FKyVVA== X-Bogosity: Unsure, tests=bogofilter, spamicity=0.499102, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Apr 05, 2025 at 04:22:34PM +0100, Matthew Wilcox wrote: > On Sat, Apr 05, 2025 at 01:01:53AM -0500, Andrew Ballance wrote: > > adds the __mtree_insert_range which is identical to mtree_insert_range > > but does not aquire ma_lock. > > This function is needed for the rust bindings for maple trees because > > the locking is handled on the rust side. > > No. > > The support for external locking is a TEMPORARY HACK. I've talked > before about why this is and don't feel like explaining it again. this does use the maple_tree's internal ma_lock. the locking is done on the rust side using bindings to mtree_lock(). it is done this way so that rust can track the lifetimes of any values from mtree_load. the easiest way to do this was to add code to the c side. for the v2 I can make changes so that this does not touch the c side.