From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC316C36010 for ; Sat, 5 Apr 2025 02:30:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 927E46B0007; Fri, 4 Apr 2025 22:30:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D74D6B0008; Fri, 4 Apr 2025 22:30:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79F306B000A; Fri, 4 Apr 2025 22:30:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5CEAA6B0007 for ; Fri, 4 Apr 2025 22:30:23 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 378E7AC429 for ; Sat, 5 Apr 2025 02:30:24 +0000 (UTC) X-FDA: 83298411168.07.ABD91D7 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf21.hostedemail.com (Postfix) with ESMTP id 32D511C0004 for ; Sat, 5 Apr 2025 02:30:21 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bScCd9OA; spf=pass (imf21.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743820222; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IS15rDDOUaZvubbeDN/CRQmwSnCO8pmZhHDJU2CSssA=; b=vEhPtzo13JD9axxpalohqtdMVgAVkW8ew3shD6UDx7haaRyJ/MEFRoi9MrWvNNoql8754u Su/h3P8zYdyF+RB8U5Pz3GkVmdidkexXe2sBtGEjzdkLqT8u3uFJNAOpv4luA3dDdS1LPC 02OsS+XcKGx9yYvMIDP+gBEV0lfUrow= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bScCd9OA; spf=pass (imf21.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743820222; a=rsa-sha256; cv=none; b=b8sDNE7m59DRCN1rCYdRyj0ObAKK9EEhtcGCBcspHcrp5EefunixC8CFc/CS6B1zRYyooP kProKNPs4EUqImE9OtJhDDxoODHdpnt+IUjZtLtVrb3sAPwtb+7M+YTgG55t/3JHnKESVZ Ec6Wsgf6UjIasH09W+mpXJKd4ogd3EE= Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5ed43460d6bso4349777a12.0 for ; Fri, 04 Apr 2025 19:30:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743820220; x=1744425020; darn=kvack.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IS15rDDOUaZvubbeDN/CRQmwSnCO8pmZhHDJU2CSssA=; b=bScCd9OAd6c3U9WzipiIx7iX4lYBd7AMyIuCmjzpiJ+/Z4hiNzbEn3ENwCGFw1ypqB gMsykfb1D1tQ8RYfJH9+l1bCMLS34SF0EgLfiNPCKxiz0oeYH6Ifljm9e82NNUG3Oi/K zShqNhVq5vmCZmsh0ASdF3GjaU0GB52rxbaTsi5/s1LZZFJUCbvL9IH/5OVPftmidTjt Ih69xPJaJHXtAmnqfwf4s5RHKj6OZdq14SvmFKYAn31R8kVL2qxwuMkTnEjKD/btoWZX T4sFlr0Y+YDcq4M77bkQbceANIdb87+Ae/ph7qgJU+vH7YIZgZKndxPoeNt1otK3FtSV SXhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743820220; x=1744425020; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IS15rDDOUaZvubbeDN/CRQmwSnCO8pmZhHDJU2CSssA=; b=GqTxD/G6VSKOsGK3v8nkNyItDe1sIMfC5+q1DhwZlBOQFv5JYrLO2RqMlUD24knMJN W889u659AnQ0D2wOeDGsHpCs5w1DGUi0bHpZmeBMMmG6g7FJoezBSgdSVIcSShFRhdbu K+6YQIlguq/dAyeMdpTgqUfikKPGOXN2dZ925yw1KILNiFzvdhdwxQV6+glSJa4sWOjG YbxjYR20qH9wNk2pMCoxShem4ysZqygIvuGhPUh7xlI3/ONFHqWnxZ3sm2YFfldq0aQI vQ5McQy4++4zd5+AJD/FaRfSH+I61fiKBQir97kpMgvdjxNo4rrIlbTY5ZCtyc61eByD 9cvg== X-Forwarded-Encrypted: i=1; AJvYcCVJ67EjL/P2PAPM2Fp1ySC1ayNd59uMMzXCBoqLzJyY8Zoy9nCTk92/lek/ZQ7yP2NA+P9z1KSxPw==@kvack.org X-Gm-Message-State: AOJu0YzGIc0Rod4jfvVs9Lx2ztSL5dtoYmcFnIXANbTSAEUgykzl9N9s d52ba24fdnmG6K5P94sSDf3f00MK90ij7mi17HieDkWsa6unFKIBHDgHadyu X-Gm-Gg: ASbGnctUAlq+3uimq9KtQ30SULcGbwyN8NGnROsLugGfjDhd1KC3BDWDBYBX6/xNBOW sI3+u2n8fn698ngBoLK52Dld8b7ZfWuhOw6fymvpmVOxTu9yS57z91vKTCqZnkFkCVuha7jn2Bc CjIoAUJScS02YNNfnPK3esNuIuhL7qyxnyKIWQ7fofJy10xvucv7Lx46zZ+/+d7V0KECmFACU/b PWqtWJjy/0x+Zq3ShE1CNhZDCso33gS0PbK2MJtUYkOXR31KhnlYFh2YCSI3TTGVnV/++DmoeFy I5VdaE4BocqqF9v4//gsZ8lLtbeR4dMCEbjRA573a69H X-Google-Smtp-Source: AGHT+IE7wFn6ERJrBkfR1Q7/KnqdJjGKd1nUQ/1w3C9FdGeL3AF2csZF/cfRhKp8Z4EAaS7twttq5A== X-Received: by 2002:a05:6402:90e:b0:5e6:1996:7902 with SMTP id 4fb4d7f45d1cf-5f0b6631b4bmr4006673a12.32.1743820220359; Fri, 04 Apr 2025 19:30:20 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5f087ed1f40sm3097531a12.26.2025.04.04.19.30.19 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 04 Apr 2025 19:30:19 -0700 (PDT) Date: Sat, 5 Apr 2025 02:30:18 +0000 From: Wei Yang To: "Masami Hiramatsu (Google)" Cc: Steven Rostedt , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Mathieu Desnoyers , Andrew Morton , Mike Rapoport , linux-mm@kvack.org Subject: Re: [PATCH v4 1/2] mm/memblock: Add reserved memory release function Message-ID: <20250405023018.g2ae52nrz2757b3n@master> Reply-To: Wei Yang References: <173989132750.230693.15749600013776132201.stgit@devnote2> <173989133862.230693.14094993331347437600.stgit@devnote2> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <173989133862.230693.14094993331347437600.stgit@devnote2> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 32D511C0004 X-Stat-Signature: ocbehaj3i61a9u51o6zrqh6hr53e46b5 X-HE-Tag: 1743820221-110370 X-HE-Meta: U2FsdGVkX1/0Qx2eUWZWh6I55Ha5Uv17XOAVtEuHNQ+flO/d6OWbxk+Sz1Vs0IQx8v1GX1xJYMww7+uHmpZfoxW2p8u8Wpu/XHV35zDIpqVhUsncRxY5wm8i7k2Yg7Cc/A+uLmy2LddHnwwtFqydssZiqYHMtTH2W4Qt0jwD0hrkURA9bnJGeyoInWeK6bLWt0+0zmmFZrsFSUg833+IyaMNA2yd5wNDk78i+5fT/XIP5aohTJMEamKR/aV5wjQ1X6vtqpzWsEMViTzj8rp5mfkBh6w6ERKlNvKLU/zi5caqeZkiE4vq01fvW+Zasv8a25kExVejfzWOZ525k85tFy3SsZlVlyV6BuoGj9iY2XImlaU0DrFmMItoR3Zped27ys1qmreaUJOR4fukKa2ih9JMncT4b3CTObmUtwug6RB6whsNWGyDy2ZXZpAUqXajPpENH135Mm4joWKou/5LLCL+jMnauSrPDoitMaEh+IU1I5ypPxZwme3C4E2qu3t62wRf/BokeTP3e8qo1K1a6plyKzkyRX+RhVkDdyBnsDnLY8EYTimU1CS1fSiNWe4IRDmszxgELtY8R5W2yk51olE8A2G/2aIgDILWBKS/Q/GUB9fJWHiQuyZ1WzAp8fVx/pPeXl1uvLtoqC2CuwRo4Rx999Yuoh848k/f2AJ9ULkA/VSm4JFVMB7BPsxy4engqCv+b3/D7krOBI1OFvD3q5T/fXQPB+jzJVpESE+a+P15inlcNEV8gSyCjZHPvuwy80yoE++X25l1Itkei7CwavUKKo58ZPgPUH/GbVJ8bODCOcChkmPTfmuh56bvDqbus5Eb+pTNviz4TAMmnfe73YOgzGQtwqIuLf5hduisUE0U0y0h4ILj7RtDScCEUpbLbTFd49nbI9omzCb395c013DXoFlQcfz0XVY60vQ0wsWf9IejXOuiDHT3GlyPfwvEO3Hd+d5uNP+oVmhlTPj BDH7YQXF LcwsdJ/UONTwbaAFwt0Gi2KMRd4Or9jPkFlfl/drGijhJg5SoyN+dnprLxgA5/zyleWfC6inJ760l2eP+c5Xtuz3eMDiUamZfom95JyAuLIP7wPqM35MMLNEwt+gCrEkiA9m5kEhLXNikQrPn6T3ynm8dkpPN889zjGks45g38K4AgQzbaGeyuetylEtnj5RP5M9KTQB/Nu5Ov9SJgryj89p0pstrriY23L+/DgRsjPMb16R8xSA2o1wUvfCUVmEGfeG49ozmYqLICo+RvD3Qoy94fwNO1BbipcaNaNU0xOguSVAUG4jBQliBNT5dfvEz0IpuEanjAlrRYBMHTQmhVTgxccU3/2mW/Ir3lWJovMnSe90+lF19tCPXXVUrT4gb5Wb4pGSwKxa4GybWpUbqIOOzBHGRGXlyKk/dn3wZwNP9H9nH5UYqYCcgaP8ARCozBtp300Wchf0H4FlyosTNgApg2G0mwFYlE6oOS2kTlClMDqPBitxunLE7O4xy89Kvn3Z0C0ZXia3BxKaoPznds7CkpKYt1vnaeIx/syTIq4EtEin8+FX69FOQO1XnZ+dnbJVXpHYwI8ftknuKNh3TDaG99T64dOCXnEzy4xKb/W58o8wd4gjbNi4yn5Pmt+/hPPMGaC5xTUuwABSWkDVggKExjCRfWOkVJClLAv8ri6DsugsC6FDHU6vlvelpA2X18B1Cw9XKMpHdTQPAY+zDmpd8a80ofRFhkElj8vivfPt+zooHsrqDXYqI4UafAlxbcSKf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 19, 2025 at 12:08:58AM +0900, Masami Hiramatsu (Google) wrote: >From: Masami Hiramatsu (Google) > >Add reserve_mem_release_by_name() to release a reserved memory region >with a given name. This allows us to release reserved memory which is >defined by kernel cmdline, after boot. > >Signed-off-by: Masami Hiramatsu (Google) >Acked-by: Mike Rapoport (Microsoft) >Cc: Andrew Morton >Cc: linux-mm@kvack.org >--- > Changes in v4: > - Use free_reserved_area() according to Mike's comment. > Changes in v2: > - Rename reserved_mem_* to reserve_mem_*. >--- > include/linux/mm.h | 1 + > mm/memblock.c | 66 +++++++++++++++++++++++++++++++++++++++++++--------- > 2 files changed, 55 insertions(+), 12 deletions(-) > >diff --git a/include/linux/mm.h b/include/linux/mm.h >index 7b1068ddcbb7..1ee9e7447485 100644 >--- a/include/linux/mm.h >+++ b/include/linux/mm.h >@@ -4123,6 +4123,7 @@ void vma_pgtable_walk_begin(struct vm_area_struct *vma); > void vma_pgtable_walk_end(struct vm_area_struct *vma); > > int reserve_mem_find_by_name(const char *name, phys_addr_t *start, phys_addr_t *size); >+int reserve_mem_release_by_name(const char *name); > > #ifdef CONFIG_64BIT > int do_mseal(unsigned long start, size_t len_in, unsigned long flags); >diff --git a/mm/memblock.c b/mm/memblock.c >index 95af35fd1389..8cd95f60015d 100644 >--- a/mm/memblock.c >+++ b/mm/memblock.c >@@ -16,6 +16,7 @@ > #include > #include > #include >+#include > > #include > #include >@@ -2283,6 +2284,7 @@ struct reserve_mem_table { > }; > static struct reserve_mem_table reserved_mem_table[RESERVE_MEM_MAX_ENTRIES]; > static int reserved_mem_count; >+static DEFINE_MUTEX(reserve_mem_lock); > This looks break the memblock tests in tools/testing/memblock. memblock.c:2289:8: warning: type defaults to ‘int’ in declaration of ‘DEFINE_MUTEX’ [-Wimplicit-int] 2289 | static DEFINE_MUTEX(reserve_mem_lock); | ^~~~~~~~~~~~ memblock.c:2289:1: warning: parameter names (without types) in function declaration 2289 | static DEFINE_MUTEX(reserve_mem_lock); | ^~~~~~ memblock.c: In function ‘reserve_mem_find_by_name’: memblock.c:2332:9: warning: implicit declaration of function ‘guard’ [-Wimplicit-function-declaration] 2332 | guard(mutex)(&reserve_mem_lock); | ^~~~~