From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07247C36010 for ; Fri, 4 Apr 2025 17:24:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B76346B0011; Fri, 4 Apr 2025 13:24:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B22716B0012; Fri, 4 Apr 2025 13:24:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3A756B0022; Fri, 4 Apr 2025 13:24:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 84CEE6B0011 for ; Fri, 4 Apr 2025 13:24:43 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 834C514065C for ; Fri, 4 Apr 2025 17:24:44 +0000 (UTC) X-FDA: 83297036088.16.6E1C389 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf26.hostedemail.com (Postfix) with ESMTP id CF1A8140008 for ; Fri, 4 Apr 2025 17:24:42 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jlXchcGY; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of kees@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743787483; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=myGRcHSruwKnAipQHedHJPEkpEodxXSC7qUBX2m9qe8=; b=3s0ojPi9bd7nklJsQYjgHTkwJZsXuR3/R66wjKyDKC4rEll4K+HR5jDe76dmEc6TxaLQUP RHsfHYMQJNOxQ5UrJ9WcoCFNiKW1b6rnjQ90s1uCL+TOtPCg+7Jgk7CTd/0KxQd2nn5jPT LZeI2di5XSA0FkRp8thXUxOt45scYhg= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jlXchcGY; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of kees@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743787483; a=rsa-sha256; cv=none; b=qYCMDJOZV7me9QYSNPiFRg0VmimBUV9EoHEDQh/oyVsW47exx73d8YD0/QT8rlYXKiIcz4 5HELwHyyuOd7x/MTIS2tpys1O/x+85ZfnSkxfenngqj9o+p8njJVhIdlN7RLQRYVsQ4lKW gYEb1HMKA42oRfbyNY0kJGvh0uWN7Zg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id F14ED44255; Fri, 4 Apr 2025 17:24:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E8E1C4CEDD; Fri, 4 Apr 2025 17:24:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743787481; bh=likuG5BOuOReaswjoND3u+xsF3i14STI5Fea/gpcC5I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jlXchcGYRc/LjxHDDVnmqx+0pinPANAoiXsH7QW3d8AnFaphuO+kMOZ/nPKdLl5D1 2Cdb8SqSNYg1B49ux57Ok0RbA3bZcAsIKCH0I3mNJtBLbICleWhem9exV1x402tJhn er5S+GhcXGVzdzC4EEeh9kfPAoSQ3acWzax6jS8tHluVmOSYrSeWGf6Fa6PnE7bQwM 7r2f9nVL6qnQ4X1m3lWbNC3PXbCEALUnK2LvdYfnDHztkq+uDomrUEp25vkoEGGKVN cc2VUD5sI27C2W6bX0LWyjz0wuRBThrCEYrsQxyoFdBQHIAZCTzSDega5vsKpRs5gM ed2ckaivBzB1w== Date: Fri, 4 Apr 2025 10:24:38 -0700 From: Kees Cook To: Bhupesh Sharma Cc: Bhupesh , akpm@linux-foundation.org, kernel-dev@igalia.com, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, oliver.sang@intel.com, lkp@intel.com, laoar.shao@gmail.com, pmladek@suse.com, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, arnaldo.melo@gmail.com, alexei.starovoitov@gmail.com, andrii.nakryiko@gmail.com, mirq-linux@rere.qmqm.pl, peterz@infradead.org, willy@infradead.org, david@redhat.com, viro@zeniv.linux.org.uk, ebiederm@xmission.com, brauner@kernel.org, jack@suse.cz, mingo@redhat.com, juri.lelli@redhat.com, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com Subject: Re: [PATCH v2 1/3] exec: Dynamically allocate memory to store task's full name Message-ID: <202504041023.A21FA17DDC@keescook> References: <20250331121820.455916-1-bhupesh@igalia.com> <20250331121820.455916-2-bhupesh@igalia.com> <202504030924.50896AD12@keescook> <3202d24e-b155-ab0a-86cd-0a3204ec52dd@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3202d24e-b155-ab0a-86cd-0a3204ec52dd@igalia.com> X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: CF1A8140008 X-Stat-Signature: zdt49zcdpu1cc1xg1tycew1sqbbuj6ou X-Rspam-User: X-HE-Tag: 1743787482-584186 X-HE-Meta: U2FsdGVkX19b2ExWJZQKnvq7WWf+O3tXQBKNDB0IsYgjLl7FpDNyJoCjwoO57xJnzs7kYnCtBW2TVcDUQR9bdjyOQ0gTalwl77NjDmVXfh/wnH0tuDNcVPCw8twSbeqay8Zblo8UXa1oyOrFTHZKKg6OqfAzVbVS7NLtfv4GlD7FA+gkfCYAyMyj8Qjgemnqq8m2tdMI3L0RzdvUecR2KSODY93wAh8nR37/+B3TGBBZkCACfMW93Njq1ysqK6jVsMW6O+AsgfHnWH0ghLoEmuovY7caGkuchMJGymKXHur3G+0x2xt7Jm8g1jpXT/V9m4WqT7ypshPykUYvEqKnotfIGEqVzyievwTjtHXFFdrJtUtwn+gljk9de99iVm1Jz7ZAJlb3Ymiel2gXKFIdF8sN+MoU3LBRejVo/OysNnZ7y3yKAAkg40s1ovLLIZE+7rweDzpUq2AST+Xhpw3/RszKNC/FCN43z7RT6dWpC1Djo2hnFCjIb19U4zi752LSSTew3iJIP7DmLJYD0b6zh/NUVHUli+WzfcwT9SrbRvX2IxXXTx+x4Mnd52mr6kV694Je4b+2+in6jgYLmpK3u69nHk0H6tEQDVoVe4i9RkUKdY0t1gxHhv2MgIoe/Hu9FgatRlkS2xuNUaNcV5QG2O/fkzHWYVV8kXqIwoY3FQVN8Nc3UPiwH1+4o7dXEhoAYVZVjz8s2atL5wUY/Zgv2//8QBdCkoGgNZy0asRcMaVm4W3QVfl/ua7pz/jKzLEBPTlF94ecEE7OWTe5L9wpzkNsdB3HVb+OENRPtm08m8k/kXeJ2V3QAjElGrelOXX5RTgxpZRPi+0JuRPZS77fAhriLuFIgVbMDxitAIPu+LgvhlmgD6Btzg4RB1OhaDggp3DJFjilnG/KU4Ttl3Spo8IphK2Kg/H1sTrHv2DoIFWXym325lShZbWlsLQ6ypKn4y34IhP3nk06/YzT0S+ 9W+/3UM2 HcAN1KKtbaTW+FemmbjblOLx4tlr20rFGWEdylQ1SjKU079Wz5SSurjI6UEiZqt374qVsg0BVz7penCiACRHfDF9nYGi7VrwtIFJvpknt8ZAdX+vzqmzOlyw4AfjT5wiNo7T0BndTINfYUMr58QXUtsAHzwyjlATQbAsGIREZoJz7i7euBcSe5h3DVNincCWjtpBjP1YE6LpzuQMeDDZP5WU/dCiAxhOvFc2TNXKXbA+ArdqQwjHqfBSEfLt6+bm4LsCR4XR6sjZuY/6q3p+XoOr7jLj+M+RAEffKJdgUuq8U8V1XgTDZIio/CSq53K3HPN9I X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 04, 2025 at 12:18:56PM +0530, Bhupesh Sharma wrote: > In another review for this series, Yafang mentioned the following cleanup + > approach suggested by Linus (see [0]). > Also I have summarized my understanding on the basis of the suggestions > Linus shared and the accompanying background threads (please see [1]). > > Kindly share your views on the same, so that I can change the implementation > in v3 series accordingly. In thinking about this a little more I think we can't universally change all the APIs to use the new full_name since it is a pointer, which may be getting changed out from under readers if a setter changes it. So this may need some careful redesign, likely with RCU. hmm. -- Kees Cook