From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF880C3600C for ; Fri, 4 Apr 2025 03:23:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 747C7280005; Thu, 3 Apr 2025 23:23:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F6F8280004; Thu, 3 Apr 2025 23:23:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 597C2280005; Thu, 3 Apr 2025 23:23:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3C57E280004 for ; Thu, 3 Apr 2025 23:23:00 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7B7FBBB5E9 for ; Fri, 4 Apr 2025 03:23:00 +0000 (UTC) X-FDA: 83294914920.24.CBAEA2F Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf01.hostedemail.com (Postfix) with ESMTP id 5637F40008 for ; Fri, 4 Apr 2025 03:22:58 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=NOZ3PWdA; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf01.hostedemail.com: domain of anthony.yznaga@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=anthony.yznaga@oracle.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743736978; a=rsa-sha256; cv=none; b=fJrIGb4S1OH9ZUnXw6nj+y8Fa5Pv7Ez6PmYYcZSumfRxdJDmYloUQngFXG/svn1JLmYnYg PxYfeQmS1S6nFG2cRxQEJHcwztYKkJr11sLhVM151cTdqHapa0olUWjSIpPygT16uvLleD rg3c6y6gjSjUpO896HwnVUkpd2nYaUQ= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=NOZ3PWdA; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf01.hostedemail.com: domain of anthony.yznaga@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=anthony.yznaga@oracle.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743736978; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u/Ka24LgFH1mEp9+dOJpjfauIGm/1R9CiLlxElDfEpA=; b=181KkLw63enQHHXgvXxf6VzSpfx7cszK5DZ8uHPLpv+ZeRAK1Ha860Il2wTXR1zBjoriSw Hk6OPWt85aLHAaAG+r4pr7cR4bJLw756pm7o2Z1Q8nIVzurvlYeuucMvKpd6jr5WcO8jzc 9pHnFrYGbVe16634waHIHSweqd+oteM= Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5341O27B030347; Fri, 4 Apr 2025 02:19:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2023-11-20; bh=u/Ka2 4LgFH1mEp9+dOJpjfauIGm/1R9CiLlxElDfEpA=; b=NOZ3PWdAMVOTQS0+7aDuR skwtgjrkJZAUfqyztFxUQRUHMd8XrW5jez6ggYlpafDPnj5vl+3tvAdIkeitH8/F 4fTizL12uMMCvYenkY3Aj/JpSFHtwJ6jmz1nJMRFlozv7NNy16r38P90LrM/nljX oCUF+mdsc0PQfkuUDhn7rNFtFwnhj5/YAKU30n/vVuFAQ932dqXyyrEI5OPL/s1T uJn+E2JG/YbS5G//Z30/xPl77vfDswZNL0WeohxrTgsPiBlm+cXEEBbWblivWGtw CQZtcF8wb7Ure94mM1gATTmdMCQMSa47x4XxKnu5rNx20OgD+8uyIcuLrSK2BCm5 g== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 45p7f0p1nn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 04 Apr 2025 02:19:15 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5340fY7x017359; Fri, 4 Apr 2025 02:19:14 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 45t2pspj9u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 04 Apr 2025 02:19:14 +0000 Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 5342H8gg030074; Fri, 4 Apr 2025 02:19:13 GMT Received: from localhost.localdomain (ca-dev60.us.oracle.com [10.129.136.27]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 45t2pspj73-4; Fri, 04 Apr 2025 02:19:13 +0000 From: Anthony Yznaga To: akpm@linux-foundation.org, willy@infradead.org, markhemm@googlemail.com, viro@zeniv.linux.org.uk, david@redhat.com, khalid@kernel.org Cc: anthony.yznaga@oracle.com, andreyknvl@gmail.com, dave.hansen@intel.com, luto@kernel.org, brauner@kernel.org, arnd@arndb.de, ebiederm@xmission.com, catalin.marinas@arm.com, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhiramat@kernel.org, rostedt@goodmis.org, vasily.averin@linux.dev, xhao@linux.alibaba.com, pcc@google.com, neilb@suse.de, maz@kernel.org Subject: [PATCH v2 03/20] mm/mshare: make msharefs writable and support directories Date: Thu, 3 Apr 2025 19:18:45 -0700 Message-ID: <20250404021902.48863-4-anthony.yznaga@oracle.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20250404021902.48863-1-anthony.yznaga@oracle.com> References: <20250404021902.48863-1-anthony.yznaga@oracle.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-04_01,2025-04-03_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 mlxscore=0 spamscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2502280000 definitions=main-2504040014 X-Proofpoint-ORIG-GUID: uxvsTgFDon66oivjCAXUe9tYMbY1XvCl X-Proofpoint-GUID: uxvsTgFDon66oivjCAXUe9tYMbY1XvCl X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 5637F40008 X-Stat-Signature: g9ceopywd1euk61ydsmft5b48najzhuc X-HE-Tag: 1743736978-106133 X-HE-Meta: U2FsdGVkX19CvrAYWmCaSmCWRPOLmxibYBlR4yESR8ttaYUq+6n3EUK8313n6fhE7g6+T4TanWagDyuA6aMbgeIYzBL8kCQdAQRH4aVVSzWW7e8y+hOUmf0dxoxuJnOJVPXPHSsHRAfQkiIdHHCEkyv+F+8vxIC0qceGPlP+TkY8MU6lvwyTEEK4DSd1aPbuML3BGjeAM4cWa7CG18g3GmoQzN67K8wvBk81F6wzDV8C1ioI1HTCxb2JquBUB0kG6XsuimuivWVgn3MOZL623QHOy4i+TcMJFq0vgevx/OFi0v9gLW5SZkx8tQ5vqvdrLYxJ7igRmFmx4iiCVOeqsd8F2GQ0A4ezdrlXhnIhw2M5mnHzhmqxUGLX1M4/qeUNrSOWF1a5MVmy9ULD13Og1BBi5s8uhPd30BTDeZMj4Isd+eqeS0UjxQvYfu4HVhfLjBSzgP1I/+qf/UGt5N3B1+TN/2MXJoUWfJOtPLB5Ilv1cLZkZanLMs7GDR+ajHx+fYmofjcTBSHSXhOcYZ1+Tji3rKmcPyVx/SseCN6AtzvnxrGX8UGffWi8j5AtEJ3Ig1s6sR2hzTGipKtWQ2RmaM3LCgKI1zUPZjedXB1owMjs5gPVXWJvayqX7EaYQXmApXemDkKZWzNTDWzVwixh1Ln94JbgRys7elWI2uz4J/y+GaPCYq2giQ5xpSUYG7I5LCqtS3MxjXR+7GpmD8ByG75HdmucZ8PSdIQcTPS5Z1DdMiWhNyypye6RYTCCK8QHAcUbGXvRTpiJD9NcAr8vMFAQShtjd/HOTgEgItrmB9lO5XyfwL/CdGGq2czi+Pokso9sTDN59Hzckb2fG/mLtLfDjvyAgYxaJgnLC/ImoPftaSaBPJzsW5Hmdg0nawNK6asMc4ZKgGfy0yFkuBGPj/EhiNU3HRyFW+E5J/ndx4BarA3Zj8jrYfNq4oXjT7GmP6Z092aZYlnNMryWml0 vKeHGKV+ N3tm4nS4J7cBfgKBV619zXbqJSoCvbMiEiVL2sYoJvyRC+vyZzFUKXYbt/UAkqzyJzxkajqFjTtqeykTUWKOSXzfm6jdnJSnAGsT+2FgS+v5Fj7Q4SpyYPK637/h5aA73aXv+4bniLavYdWMw6b2O30sAmm5lwbi2uhB9HGjNbQXJUioFlm2HxTsycC9hmdX1u0BjtUKLRZr7Mty8N68fbuV0OrS3TxNj5gV/AHSXQFSKNp5DuRepsnKZ4rviVdNsVKRmBVdsCAyolBM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Khalid Aziz Make msharefs filesystem writable and allow creating directories to support better access control to mshare'd regions defined in msharefs. Signed-off-by: Khalid Aziz Signed-off-by: Anthony Yznaga --- mm/mshare.c | 116 +++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 115 insertions(+), 1 deletion(-) diff --git a/mm/mshare.c b/mm/mshare.c index d666471bc94b..5d9e25da0244 100644 --- a/mm/mshare.c +++ b/mm/mshare.c @@ -19,14 +19,128 @@ const unsigned long mshare_align = P4D_SIZE; +static const struct inode_operations msharefs_dir_inode_ops; +static const struct inode_operations msharefs_file_inode_ops; + static const struct file_operations msharefs_file_operations = { .open = simple_open, }; +static struct inode +*msharefs_get_inode(struct mnt_idmap *idmap, struct super_block *sb, + const struct inode *dir, umode_t mode) +{ + struct inode *inode = new_inode(sb); + + if (!inode) + return ERR_PTR(-ENOMEM); + + inode->i_ino = get_next_ino(); + inode_init_owner(&nop_mnt_idmap, inode, dir, mode); + simple_inode_init_ts(inode); + + switch (mode & S_IFMT) { + case S_IFREG: + inode->i_op = &msharefs_file_inode_ops; + inode->i_fop = &msharefs_file_operations; + break; + case S_IFDIR: + inode->i_op = &msharefs_dir_inode_ops; + inode->i_fop = &simple_dir_operations; + inc_nlink(inode); + break; + default: + discard_new_inode(inode); + return ERR_PTR(-EINVAL); + } + + return inode; +} + +static int +msharefs_mknod(struct mnt_idmap *idmap, struct inode *dir, + struct dentry *dentry, umode_t mode) +{ + struct inode *inode; + + inode = msharefs_get_inode(idmap, dir->i_sb, dir, mode); + if (IS_ERR(inode)) + return PTR_ERR(inode); + + d_instantiate(dentry, inode); + dget(dentry); + inode_set_mtime_to_ts(dir, inode_set_ctime_current(dir)); + + return 0; +} + +static int +msharefs_create(struct mnt_idmap *idmap, struct inode *dir, + struct dentry *dentry, umode_t mode, bool excl) +{ + return msharefs_mknod(idmap, dir, dentry, mode | S_IFREG); +} + +static struct dentry * +msharefs_mkdir(struct mnt_idmap *idmap, struct inode *dir, + struct dentry *dentry, umode_t mode) +{ + int ret = msharefs_mknod(idmap, dir, dentry, mode | S_IFDIR); + + if (!ret) + inc_nlink(dir); + return ERR_PTR(ret); +} + struct msharefs_info { struct dentry *info_dentry; }; +static inline bool +is_msharefs_info_file(const struct dentry *dentry) +{ + struct msharefs_info *info = dentry->d_sb->s_fs_info; + + return info->info_dentry == dentry; +} + +static int +msharefs_rename(struct mnt_idmap *idmap, + struct inode *old_dir, struct dentry *old_dentry, + struct inode *new_dir, struct dentry *new_dentry, + unsigned int flags) +{ + if (is_msharefs_info_file(old_dentry) || + is_msharefs_info_file(new_dentry)) + return -EPERM; + + return simple_rename(idmap, old_dir, old_dentry, new_dir, + new_dentry, flags); +} + +static int +msharefs_unlink(struct inode *dir, struct dentry *dentry) +{ + if (is_msharefs_info_file(dentry)) + return -EPERM; + + return simple_unlink(dir, dentry); +} + +static const struct inode_operations msharefs_file_inode_ops = { + .setattr = simple_setattr, +}; + +static const struct inode_operations msharefs_dir_inode_ops = { + .create = msharefs_create, + .lookup = simple_lookup, + .link = simple_link, + .unlink = msharefs_unlink, + .mkdir = msharefs_mkdir, + .rmdir = simple_rmdir, + .rename = msharefs_rename, +}; + static ssize_t mshare_info_read(struct file *file, char __user *buf, size_t nbytes, loff_t *ppos) @@ -106,7 +220,7 @@ msharefs_fill_super(struct super_block *sb, struct fs_context *fc) inode->i_ino = 1; inode->i_mode = S_IFDIR | 0777; simple_inode_init_ts(inode); - inode->i_op = &simple_dir_inode_operations; + inode->i_op = &msharefs_dir_inode_ops; inode->i_fop = &simple_dir_operations; set_nlink(inode, 2); -- 2.43.5