From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8403DC3600C for ; Thu, 3 Apr 2025 22:31:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 840BA280004; Thu, 3 Apr 2025 18:31:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7EF12280001; Thu, 3 Apr 2025 18:31:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B820280004; Thu, 3 Apr 2025 18:31:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4A8C8280001 for ; Thu, 3 Apr 2025 18:31:33 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 592F9AC9C8 for ; Thu, 3 Apr 2025 22:31:34 +0000 (UTC) X-FDA: 83294180508.11.02CB57B Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf03.hostedemail.com (Postfix) with ESMTP id 9C20120004 for ; Thu, 3 Apr 2025 22:31:32 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Htf1EKTi; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of kuba@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743719492; a=rsa-sha256; cv=none; b=etwzfaYVS8Wcp68L0FpRp8+5J0GG6GVGKpaY9HZEMZeh9ZzYthXBCTzXSHOhD78hhj5F+z 3RcVSgt6i555WXmsVEABGRHAySLaa22L4Y8wLMK6CKBevfIbbRQZmnahHAdzSFqR3NeFNM 9/v9wtTtKhr9tZ/GfmCp6T/leZqUUJ8= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Htf1EKTi; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of kuba@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743719492; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RNmWB0wo22TyNEr/v3/HpE/WYiTwAHSJ9ltdedtdOkc=; b=fvnlFr5ZIEzh5KmVKq+bVIiNaWQhFS492UXbWGr/CgS27d7ybJYTFpyeHqR1ovjDS+jgrE Pi20R1lAJJp1lpmb9xnRT6Fuw900V/niC507eYlqduOezKadXISutmktO50hNKNqI5Q8ML Hd5ckWwedXo0dXEolQCIArRwdIJLeow= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id C1EE744E7E; Thu, 3 Apr 2025 22:31:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A635C4CEE3; Thu, 3 Apr 2025 22:31:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743719491; bh=q7aT1Vc9FCJL3FCej7Qo+diDR5o13VyLs2ps027u9VQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Htf1EKTiwevBUPUymLkFuUGQbfKsvyB4rrmwSzMbJK8Y/m0/v0q6tpcET1MnXN4No s+7bbLHyQGG8IzECdarQuPoOBHhuoFrdFHRIj/UD/8Wq5NTGnOT1W5BpFwN/Oh9wec Gk21QN/coOp4Da8BO1qw+o8tUURfcZJ4AiyPFO4Kc7avSRMH0ybdosuxga7Tg7V22a LHKUDGTZmmN3Mb00N3PM0d9jtHHHUzooslffkmBUccQVJnTNHMJXnGgu38hPZ9jHO8 CKMBaRVDJSPqwdt9GdbqbE635vMX6nDVo8UFwIqrHaTSMHdG8B9PTKFqR/SYWm4Z3B 81/zCJ2RElWcA== Date: Thu, 3 Apr 2025 15:31:29 -0700 From: Jakub Kicinski To: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= Cc: "David S. Miller" , Jesper Dangaard Brouer , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , Eric Dumazet , Paolo Abeni , Ilias Apalodimas , Simon Horman , Andrew Morton , Mina Almasry , Yonglong Liu , Yunsheng Lin , Pavel Begunkov , Matthew Wilcox , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org, Qiuling Ren , Yuying Ma Subject: Re: [PATCH net-next v6 2/2] page_pool: Track DMA-mapped pages and unmap them when destroying the pool Message-ID: <20250403153129.013a7bdd@kernel.org> In-Reply-To: <20250401-page-pool-track-dma-v6-2-8b83474870d4@redhat.com> References: <20250401-page-pool-track-dma-v6-0-8b83474870d4@redhat.com> <20250401-page-pool-track-dma-v6-2-8b83474870d4@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9C20120004 X-Stat-Signature: icc6djzdy5gjixwfsmb37roby5a1y6tm X-Rspam-User: X-HE-Tag: 1743719492-453137 X-HE-Meta: U2FsdGVkX1/Ew9P2oS2P1P52dPbuE+vlxT+8hWXDPVlzNIyExsY74FvGFXfx42GvdSFCFTcFdqcaV+xSxKupCcx94ecOvHG8w7RO4puNl839hBFz+dunbsTN4f9OLM6CDlcWwkJtD11/ZjvbDcyNewwxfJ7HfAzwFxdIl1cEpbFHMumEoP/xgweZfI1FmBACmcwXHhL5H+51IuvuKV/Dzgxs5580vO6mmAMxp5pzowWdbAVLPDdNDOApS2U4MVh24Xo0bUc1clBTrg5Pq0OokDsJcmqDPP21YDdJTjn/L2xExzUF0FY12XOBfNCSqRfpaUmWDI7+rZ2q20GAZQzl1RXEpOrOjdSX37WyBAjg/Y/IMmvZ2+M454XXYya/vc4dTE+6gL/okFXRNVnLNdFNtiG4cn32bXxzx80Yl+IGEvyh0FqpIEb+u+KYwOxJYTfFSnSOKagJwW5pxlYpAo0qeQlKybhnfMORCTiCnvn5//tOwgm/wUFVzgg2n0uq1NIQH/zaEIsHVVgTFf3iQC75DLpkqY6j+I/RTLcQ2GXwYPBodAFWFGyONGJnsVQABcy9tdggTLOTF7FYl4GZ/j+PKOj9IcoYS3lTwK+OvNqM5xq8QjyfWgNEIj/n8kF6vIJ1zFhnRrE7H6qpnwofDk1xJcjcBFGIkyfWcDEcaE/JyjGBr5e8ucpAhnmt8d3k6MwqlRwpxj+wi8quZ0h23BfEWu6X6/lbyThUCKaPxJW8jmRSW5oIMsT/MlUjjCERo5zN3qd0F9yEB+Y8uSuEO0irB/44nr0xwmt5/HIFzqT+Ygcji7aShxeg9OboVVM8gQTpq+y/0TeBz/rhHpjDgrOAEm75ePlpZp+trKG8OcMgWJrc0VG823rZI9qUqYJD1v8ECcIORf6Y9uTJpsXEj1eHx0vt9KBIkfkQ+kNn5TzIkx4VLKoiNr7zykFZ7XC9QZlxs0IzgpAXLmY8V0iR6IL QtVlZUT/ gVkX2P9I7D449cpaRwTvb19t6PtETQBu/VH/U/ypZypSOMWh0zmVu1dnwobJNJwWret8yIiSgLf+JNd6mwJ9Fdj0+8NmZf3NBzLkzCznsEzm2PZCvG/jK5otkTtYXLKW/+7ny+GL2SHdT23+NJfFv/eP2OPRDn0RMa6hGOoCKgqPMNz256O/qJg7mQ1/oQv2SBXwab1QedZBREQ9nFE5/uFxy10mgBYsV6p6n2HfomQMxKiS5rufNKTy2fMq4QeS1Fayck/HYKD/7dRKfgOUfILf9XRZoqHym9V9hU1tSCDeJsaql81tRZH54tzXpcGYhvlTJOInO9KPtikcARgqaIpz+hjZIF/ixNbSUVm+O0U9lp+I68Mfvz6RdjnPqz3KzLIvN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 01 Apr 2025 11:27:19 +0200 Toke H=C3=B8iland-J=C3=B8rgensen wrote: > + if (err) { > + WARN_ONCE(1, "couldn't track DMA mapping, please report to netdev@"); > goto unmap_failed; FWIW I second Pavel's concern about the warning being too drastic. I have the feeling Meta's fleet will hit this. How about WARN_ONCE(err !=3D -ENOMEM, ... ? I presume you care mostly about the array filling up so -EBUSY > + } > =20 > + if (page_pool_set_dma_addr_netmem(netmem, dma)) { > + WARN_ONCE(1, "unexpected DMA address, please report to netdev@"); > + goto unmap_failed; > + } I think this is ever so slightly leaking the id, if it ever happens?