From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E57DC3600C for ; Thu, 3 Apr 2025 05:45:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22F34280003; Thu, 3 Apr 2025 01:45:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DCCB280001; Thu, 3 Apr 2025 01:45:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A4E1280003; Thu, 3 Apr 2025 01:45:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E0B2F280001 for ; Thu, 3 Apr 2025 01:45:45 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 12DC8816DA for ; Thu, 3 Apr 2025 05:45:47 +0000 (UTC) X-FDA: 83291645934.18.3ECDA0C Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf17.hostedemail.com (Postfix) with ESMTP id 8424440006 for ; Thu, 3 Apr 2025 05:45:44 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf17.hostedemail.com: domain of rakie.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=rakie.kim@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743659145; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pW/BebcfWBTAIWNxWc4JOkH9eatvl2huqNtsVX0JDJM=; b=A3JjGytZQ1x/dDzD0gIvkxSvGW5EES0eSj8FW7neLWKBXUQ9K81sDswPfj0YbR/sKqMxUl DSM4AsuPGuPeFnCVzZENihLYJo5E1N2MQeH/ZIjG9HnZixDkwywKks12GSfLA9a+3jXIiM kIHdFrGk+V3rElV1O3edIwiWbuBQGqo= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf17.hostedemail.com: domain of rakie.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=rakie.kim@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743659145; a=rsa-sha256; cv=none; b=EHhac5z7gqC4Hx2k/hrwaIjB/ugSZHU7sh1w6JEjCEA0/gikhFwo6dmdhZa82Y8NnCKxlf jElwL++cPf5NzbUtrdRpB1inEXgm/dFUHTsSorKZxRC02OIYlqAL8kD1K/8SNqSiyHSyfO W/H963hxHq4TVIFhxZX5mkxwzH2C9Yg= X-AuditID: a67dfc5b-681ff7000002311f-b0-67ee20867fcf From: Rakie Kim To: akpm@linux-foundation.org Cc: Rakie Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, joshua.hahnjy@gmail.com, dan.j.williams@intel.com, ying.huang@linux.alibaba.com, david@redhat.com, Jonathan.Cameron@huawei.com, kernel_team@skhynix.com, honggyu.kim@sk.com, yunjeong.mun@sk.com, Oscar Salvador , Gregory Price Subject: Re: [PATCH v5 3/3] mm/mempolicy: Support memory hotplug in weighted interleave Date: Thu, 3 Apr 2025 14:45:28 +0900 Message-ID: <20250403054536.1138-1-rakie.kim@sk.com> X-Mailer: git-send-email 2.48.1.windows.1 In-Reply-To: <20250403042638.1127-1-rakie.kim@sk.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJLMWRmVeSWpSXmKPExsXC9ZZnoW6bwrt0g1cnpCzmrF/DZjF96gVG i6/rfzFb/Lx7nN1i1cJrbBbHt85jtzg/6xSLxeVdc9gs7q35z2pxZlqRxeo1GQ7cHjtn3WX3 6G67zO7RcuQtq8fiPS+ZPDZ9msTucWLGbxaPnQ8tPd7vu8rmsfl0tcfnTXIBXFFcNimpOZll qUX6dglcGZNX3mIp2CRW8fLzVtYGxs1CXYycHBICJhKHH/9hh7FnvD3I0sXIwcEmoCRxbG8M SFhEQFZi6t/zQGEuDmaBCcwSZ9YeZQJJCAuES1zo38oMYrMIqEpMvvGPFcTmBZrz+MZtNoiZ mhINl+6B1XMKmErcaVoFVi8kwCPxasN+Roh6QYmTM5+wgNjMAvISzVtnM4MskxD4zCYx9cJ6 qEGSEgdX3GCZwMg/C0nPLCQ9CxiZVjEKZeaV5SZm5pjoZVTmZVboJefnbmIERsCy2j/ROxg/ XQg+xCjAwajEw9tx7W26EGtiWXFl7iFGCQ5mJRHeQi2gEG9KYmVValF+fFFpTmrxIUZpDhYl cV6jb+UpQgLpiSWp2ampBalFMFkmDk6pBkblSd0TeKz5DfbWCk48/azT6It0tR/rUoVliceK Tpvp8b/WOiR6x+LJ/7ol4Qbbt7C6+8TH3ZfieMs9+5zBorK0o/er+lbMb+Fcc2DVV9OvU/80 X2OZcmsfs3HGauHN7w1MmPxvuj4Q1r4RnPhWZ8tDdh+Zhucf/XdWLFkfw3Xg+vuAPk9nSVcl luKMREMt5qLiRADw65lDfAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMLMWRmVeSWpSXmKPExsXCNUNNS7dN4V26wdkzPBZz1q9hs5g+9QKj xdf1v5gtft49zm7x+dlrZotVC6+xWRzfOo/d4vDck6wW52edYrG4vGsOm8W9Nf9ZLc5MK7I4 dO05q8XqNRkWv7etYHPg99g56y67R3fbZXaPliNvWT0W73nJ5LHp0yR2jxMzfrN47Hxo6fF+ 31U2j2+3PTwWv/jA5LH5dLXH501yATxRXDYpqTmZZalF+nYJXBmTV95iKdgkVvHy81bWBsbN Ql2MnBwSAiYSM94eZOli5OBgE1CSOLY3BiQsIiArMfXveaAwFwezwARmiTNrjzKBJIQFwiUu 9G9lBrFZBFQlJt/4xwpi8wLNeXzjNhvETE2Jhkv3wOo5BUwl7jStAqsXEuCReLVhPyNEvaDE yZlPWEBsZgF5ieats5knMPLMQpKahSS1gJFpFaNIZl5ZbmJmjqlecXZGZV5mhV5yfu4mRmDQ L6v9M3EH45fL7ocYBTgYlXh4L5i8TRdiTSwrrsw9xCjBwawkwluoBRTiTUmsrEotyo8vKs1J LT7EKM3BoiTO6xWemiAkkJ5YkpqdmlqQWgSTZeLglGpglBaYPOnu4xn2Vz2zjGxPWG3tzGWS +LF5NYfy68A0C/uj0xRiDDRXMt3Xe9DjJRP4a0JQ8aJ1b6YEJnc9dP3JLM6+lvNv0zJtt8of VqHLy259Ddv/rzqatWsrw/UgnqbHE7aprODpETzf8+YIa6LzxftNDDNmC6jw8rZdfdUze+qF FwvXSob2KrEUZyQaajEXFScCAORpqBh2AgAA X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 8424440006 X-Rspamd-Server: rspam05 X-Rspam-User: X-Stat-Signature: 9yrfixsm9mz5c7wa49o7iugbnzyghwd9 X-HE-Tag: 1743659144-139760 X-HE-Meta: U2FsdGVkX19VJslBhTYd9EeowCz9mPOxlC5PLveN6GoQX4uBy9s7aBVnNOe1yuETIG4VBkUj+u7aiM9UmTZK/Jeykjz7M3SJV6tTrL/alwFaKV2xBGYRkzTtXSrOdIqcqqha/ABGvB3HOJGq4+4iEJM1gzomxh3K0s0KPpaTIP2KDcnuEeqFmH+yH7BjbY72o+kLR5jprsVTEK6sqQX3YbLCQ31soc/VLuwLaoXC+G2xkcDvek3XJvU4wWZyMJuvkWK7HMwyU4POSq1NXVeRycyp6D9sO5wxMC5RFiZKTOPdllGskj6HreRJiEnIg/HtF2UHv836GuDjSi7/LuSCJFY+WxiXWp3s6fHFvqq2ZCZG9xY4Hm+ao+JaTnyC7Zhltc21zhzzV2iZyvUrQb4xwrX0u7WWn7L2ZH1inOOtVtWc0mud8mpnzkhHxdHFklo753fH+16Y3CTvmpjzwXsngG8MwIzQnIDsLfuq/xrvmznDZrl1AJoj3Jn9B3hEJFWkWDFuOFyWuxkYD+5qydcbMJ4e6ivIPYogYMcY5S32p0fbafSRW2VjbNua4Hj7iMjJW6pbzxlRNvYP3NOfygKYU8Tzz1GhEGR7P1kRiXkApXOq7Y55HOcv9uY7/zbZHcpDaRe+/UbVqrD6b3Apnr5WDpzw++lCDCs0sY2ugvpfLkHiOPAE0asgQrus1rc269T1iQ7KGTpRxBP2Gnl2TUz9MTrCCiu9zcQv9mX3Qg2iHuKC6RgiQKJ+OWdDd1uMg5S5Fky6f6UcqULfOpNcQrxdCla33hDDTzL9w7KEMuVSs3yKm2umNd6CfNRuWNRZgxuR0P4BUDTpthuMqO6+phTwtWiykUh8FasR7NqbKhedJ6Bk5/MxWjAZhLEWLhk5L139PH0+gkGYqbGaymDWit+pLhD+i92+wdpRmRV8+nN25ADKT8WNLVtgQul7A+7kKdIl5M8BW4U7utHF0S973lt KJ1n6U1m B5wjNgjdOFTl6s5E5GpVVXWVBFAXWsIjwnsu+CIQtfV0Vge2eB7gc5JhuxoBuW6bQjEVBb/7OAqs0xvSar88WKf4TC11VgTBXg7em4XDRM2q/DM+wN/s0q/UrKuR1gE4SRuXVgpTIzqhsEypmBwyjKlD98wm9GTtwdq/Xe+YQVZUZdLCItdParxsnd5FFIqIBUpFzplPogFWJDGU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 3 Apr 2025 13:26:14 +0900 Rakie Kim wrote: > On Wed, 2 Apr 2025 12:36:24 -0400 Gregory Price wrote: > > On Wed, Apr 02, 2025 at 05:41:57PM +0200, Oscar Salvador wrote: > > > > > > Yes, this callback will be called whenever {online,offline}_pages succeeds, but > > > status_change_nid will be != NUMA_NO_NODE IFF the node state changes. > > > And you already have the check > > > > > > if (nid < 0) > > > goto out > > > > > > at the beginning, which means that all {offline,online}_pages operation that > > > do not carry a numa node state change will be filtered out there. > > > > > > Makes sense, or am I missing something? > > > > > > > Ah, you're quite right. That was difficult to see on the surface, so > > the check in fact superfluous. No need for an extra version, can just > > add a patch to squash and drop it. > > > > ~Gregory > > To Gregory and Oscar > > As Oscar correctly pointed out, the check for > 'if (!node_state(nid, N_MEMORY))' is unnecessary and should be removed. > > Additionally, there are other suggestions from Dan Williams that should > be applied as well: > Link: https://lore.kernel.org/lkml/67ed66ef7c070_9dac294e0@dwillia2-xfh.jf.intel.com.notmuch/ > > I will incorporate all of these improvements and submit a new version (v6). > > Rakie To Andrew I sincerely apologize for the inconvenience. It appears that this commit still requires additional corrections. I would appreciate it if you could drop the changes you merged into -mm, mm-new branch yesterday. <1> The patch titled Subject: mm/mempolicy: fix memory leaks in weighted interleave sysfs has been added to the -mm mm-new branch. Its filename is mm-mempolicy-fix-memory-leaks-in-weighted-interleave-sysfs.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-mempolicy-fix-memory-leaks-in-weighted-interleave-sysfs.patch <2> The patch titled Subject: mm/mempolicy: support dynamic sysfs updates for weighted interleave has been added to the -mm mm-new branch. Its filename is mm-mempolicy-support-dynamic-sysfs-updates-for-weighted-interleave.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-mempolicy-support-dynamic-sysfs-updates-for-weighted-interleave.patch <3> The patch titled Subject: mm/mempolicy: support memory hotplug in weighted interleave has been added to the -mm mm-new branch. Its filename is mm-mempolicy-support-memory-hotplug-in-weighted-interleave.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-mempolicy-support-memory-hotplug-in-weighted-interleave.patch Rakie