Re: [PATCH v5 3/3] mm/mempolicy: Support memory hotplug in weighted interleave

[Rakie Kim <rakie.kim@sk.com>]

On Thu,  3 Apr 2025 13:26:14 +0900 Rakie Kim <rakie.kim@sk.com> wrote:
> On Wed, 2 Apr 2025 12:36:24 -0400 Gregory Price <gourry@gourry.net> wrote:
> > On Wed, Apr 02, 2025 at 05:41:57PM +0200, Oscar Salvador wrote:
> > > 
> > > Yes, this callback will be called whenever {online,offline}_pages succeeds, but
> > > status_change_nid will be != NUMA_NO_NODE IFF the node state changes.
> > > And you already have the check
> > > 
> > >  if (nid < 0)
> > >     goto out
> > > 
> > > at the beginning, which means that all {offline,online}_pages operation that
> > > do not carry a numa node state change will be filtered out there.
> > > 
> > > Makes sense, or am I missing something?
> > >
> > 
> > Ah, you're quite right.  That was difficult to see on the surface, so
> > the check in fact superfluous.  No need for an extra version, can just
> > add a patch to squash and drop it.
> > 
> > ~Gregory
> 
> To Gregory and Oscar
> 
> As Oscar correctly pointed out, the check for
> 'if (!node_state(nid, N_MEMORY))' is unnecessary and should be removed.
> 
> Additionally, there are other suggestions from Dan Williams that should
> be applied as well:
> Link: https://lore.kernel.org/lkml/67ed66ef7c070_9dac294e0@dwillia2-xfh.jf.intel.com.notmuch/
> 
> I will incorporate all of these improvements and submit a new version (v6).
> 
> Rakie

To Andrew

I sincerely apologize for the inconvenience. It appears that this commit
still requires additional corrections. I would appreciate it if you could
drop the changes you merged into -mm, mm-new branch yesterday.

<1>
The patch titled
     Subject: mm/mempolicy: fix memory leaks in weighted interleave sysfs has been added to the -mm mm-new branch.  Its filename is
     mm-mempolicy-fix-memory-leaks-in-weighted-interleave-sysfs.patch
This patch will shortly appear at
     https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-mempolicy-fix-memory-leaks-in-weighted-interleave-sysfs.patch
<2>
The patch titled
     Subject: mm/mempolicy: support dynamic sysfs updates for weighted interleave has been added to the -mm mm-new branch.  Its filename is
     mm-mempolicy-support-dynamic-sysfs-updates-for-weighted-interleave.patch
This patch will shortly appear at
     https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-mempolicy-support-dynamic-sysfs-updates-for-weighted-interleave.patch
<3>
The patch titled
     Subject: mm/mempolicy: support memory hotplug in weighted interleave has been added to the -mm mm-new branch.  Its filename is
     mm-mempolicy-support-memory-hotplug-in-weighted-interleave.patch
This patch will shortly appear at
     https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-mempolicy-support-memory-hotplug-in-weighted-interleave.patch

Rakie