From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88F94C3600C for ; Thu, 3 Apr 2025 04:26:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5BCDF280003; Thu, 3 Apr 2025 00:26:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 54310280001; Thu, 3 Apr 2025 00:26:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 395BF280003; Thu, 3 Apr 2025 00:26:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1BDE1280001 for ; Thu, 3 Apr 2025 00:26:44 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 98A4F567CF for ; Thu, 3 Apr 2025 04:26:45 +0000 (UTC) X-FDA: 83291446770.09.A5A9AF5 Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf08.hostedemail.com (Postfix) with ESMTP id 9E43916000C for ; Thu, 3 Apr 2025 04:26:43 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf08.hostedemail.com: domain of rakie.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=rakie.kim@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743654404; a=rsa-sha256; cv=none; b=BuvwqbLueJP8yHf5YUpqderrOifb+m0t9cwRYFPC+aDVwXvxpLJAqoT0p3QN0NeuT8Fihf 3s2VPrYL2uttI97aFLIyB7dWMwSQR7B6X58rNjPhVtzVuJgnIOvICI44Fia5lEK6gUsez/ x5F7aBZ/pxFeTB5UyfRuF+xSnQSLI5M= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf08.hostedemail.com: domain of rakie.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=rakie.kim@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743654404; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eigOh4VqaAEMPwslQxDJn1UbGbIzyjnnb8aRCMzRk7k=; b=FqW0Mb8eP85siuYjQggE7R4pOQvrMJeM8LX9GdLfIP6XD+Mw3Z5hERn5ym70LZApMhpmiK 4F0mo1cEqzzpEOEox8jbOjZ+Tvswmnea9f9CB6HsdZNu9kZjfOT3fxGJvuHC5PlTOFISPw kye+iQK0K4u0j6WFfzVkbWHY85L3lfw= X-AuditID: a67dfc5b-669ff7000002311f-7d-67ee0e028556 From: Rakie Kim To: Gregory Price Cc: Rakie Kim , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, joshua.hahnjy@gmail.com, dan.j.williams@intel.com, ying.huang@linux.alibaba.com, david@redhat.com, Jonathan.Cameron@huawei.com, kernel_team@skhynix.com, honggyu.kim@sk.com, yunjeong.mun@sk.com, Oscar Salvador Subject: Re: [PATCH v5 3/3] mm/mempolicy: Support memory hotplug in weighted interleave Date: Thu, 3 Apr 2025 13:26:14 +0900 Message-ID: <20250403042638.1127-1-rakie.kim@sk.com> X-Mailer: git-send-email 2.48.1.windows.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBLMWRmVeSWpSXmKPExsXC9ZZnkS4T37t0g3MXxS3mrF/DZjF96gVG i6/rfzFb/Lx7nN1i1cJrbBbHt85jtzg/6xSLxeVdc9gs7q35z2pxZlqRxeo1GQ7cHjtn3WX3 6G67zO7RcuQtq8fiPS+ZPDZ9msTucWLGbxaPnQ8tPd7vu8rmsfl0tcfnTXIBXFFcNimpOZll qUX6dglcGYta2xkLLnJWvLvxir2B8RJ7FyMnh4SAicSpGY9ZYOy16/+xdTFycLAJKEkc2xsD YooIqEq0XXHvYuTiYBboYJb4eWgxE0i5sEC4xIX+rcwgNgtQzd8NV8DG8AKN+fm7mQlipKZE w6V7YDangJnE4infwNYKCfBIvNqwnxGiXlDi5MwnYL3MAvISzVtnM4MskxB4zyaxY90XqDsl JQ6uuMEygZF/FpKeWUh6FjAyrWIUyswry03MzDHRy6jMy6zQS87P3cQIDP9ltX+idzB+uhB8 iFGAg1GJh7fj2tt0IdbEsuLK3EOMEhzMSiK8hVpAId6UxMqq1KL8+KLSnNTiQ4zSHCxK4rxG 38pThATSE0tSs1NTC1KLYLJMHJxSDYyMDy5Y/ntvyXaV94fqWs6HTr1al47a1aWnHjY6E8Fi +rHEM06nL2/C8ii3J3Zep4X2GvoITt7vJ3JKQbRo3cK3BgpKaerSQX8tbPYLNve0hRiulww2 CVPYey50g+y1K99YJhWePGpYdDwtPtKPIfsQ64PeOUbTm2WzpzPM+PDwmtv02RlnhZVYijMS DbWYi4oTAV9zNXh7AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrELMWRmVeSWpSXmKPExsXCNUNNS5eJ7126Qd8BNos569ewWUyfeoHR 4uv6X8wWP+8eZ7f4/Ow1s8WqhdfYLI5vncducXjuSVaL87NOsVhc3jWHzeLemv+sFmemFVkc uvac1WL1mgyL39tWsDnwe+ycdZfdo7vtMrtHy5G3rB6L97xk8tj0aRK7x4kZv1k8dj609Hi/ 7yqbx7fbHh6LX3xg8th8utrj8ya5AJ4oLpuU1JzMstQifbsEroxFre2MBRc5K97deMXewHiJ vYuRk0NCwERi7fp/bF2MHBxsAkoSx/bGgJgiAqoSbVfcuxi5OJgFOpglfh5azARSLiwQLnGh fysziM0CVPN3wxUWEJsXaMzP381MECM1JRou3QOzOQXMJBZP+Qa2SkiAR+LVhv2MEPWCEidn PgHrZRaQl2jeOpt5AiPPLCSpWUhSCxiZVjGKZOaV5SZm5pjqFWdnVOZlVugl5+duYgSG/LLa PxN3MH657H6IUYCDUYmH94LJ23Qh1sSy4srcQ4wSHMxKIryFWkAh3pTEyqrUovz4otKc1OJD jNIcLErivF7hqQlCAumJJanZqakFqUUwWSYOTqkGRtf1ptxHWX/+281+mUtxtuhnz85LXC8M m3pnvpj55zuXm9Kmy388GsT2y3yPsJzJe6P6rtkdg5WLuc0t55j9jhE0L7CUOFD0qDHw30XJ zsemImdqzBeX6DKIryq+zmrWO/9V04486zTte2rzPbdst9j9TPvF9uplGve3uUmyVp42frVG KU/fWomlOCPRUIu5qDgRAJ5mFhZ1AgAA X-CFilter-Loop: Reflected X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9E43916000C X-Stat-Signature: tgsjnjkkzpwpa98fsbw7a4fpbpco1gkq X-Rspam-User: X-HE-Tag: 1743654403-400579 X-HE-Meta: U2FsdGVkX1+tjL9uuO+MkJt6fo7B1NmZQ2hAu/pzuKnT/K8ZYne1eY+3MTukLw2kZaxlBDcxXp6VRfHQaOpH5AsM1MY3TNG4FW9mIrpSKep6TCA0jzpKF01ZJL+b1jergWKThE6vHfOlw77qkXGkqxwsnNE35aABWk2gOLyndm94DZxEpcOP3xcqF2PeBi75U4vsVmBTeBdMwbyoIXfJhnvzeNcavKPC0aoucmuIxBu4ym+IQK99EMLpelkYLontUxHrJZLpiWlCarPqLuG1Tw0U2zyh/y7smCmj1+qfcNlnSbQ8ZkS7zmJpUFHHaiMu0TDa9KdPlu+naqhrWFUCywKMIXMoWIA21uSez4xfleRUACHdeOjUPPmdoYf2GpPv8yQmm9920gqr6lESn6KJuaRlrluDSBysOFHY02XBlO0N5pSjDF5hYFprWF0MWaUUu6NslOX+bVFckMuC/Tu0TZN6t8ahxr7QVryUfsh2Xl94ov4dPuD6OiJrQor8eOcmZ0k/b1YDqNT7l0KqSWdhyAZwSpLicspZ0zmgwRZZonC3bHwbIdGTce5tPuiZqdbQ5rr7cHPsTyC0ARiUWMiYgXVV0SzLHKwr7kWlMYBnB7A1KVFS6lwKGXITyU7iYe6Vqe2Vxe7jQRqAZD5oXalftcfSBnwouyb/E82Ol3HIR85Pr8iTyE7wlf9vLHtcwk5Kbk0PMSaKL3XZOYZ33e2y4J9olDR5G2N+icauihJ7QIbNOJ74j7kpLBPS+TTaqmFunTZ9Edq2Pi5/oPpZy1RlftCSmzo4tqIeF8yI6de9nVL7zY3y0qioNjE49N2XMIccb21kqzEcnzhCz/LAyW5XjyV2e5IhPPfo/HipZQOJnD2VTnvJQP1tzPvIPUD8qcS2frqGJocB/VBDUX1PhXIx20BCFJgDhxu4xe22Vobhicmo+C8hICdAzq3jdzXeamL0jHWMzE6IP869w++rUos N3PfRMzQ lOrrGYb0OZiacuB526A6zZvpdXA8NLoiNzImnGJu09VdNO/45onxy/7t0NT9LzdSjn+qmt/m4Ns+iOHhLwJJ3lETgbFqM3z5X9sgRKnjdDScGH3Ll5Oc8L30TMYuLGDjUVbbK6O6mYq6fRbcekFqANGBDHA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 2 Apr 2025 12:36:24 -0400 Gregory Price wrote: > On Wed, Apr 02, 2025 at 05:41:57PM +0200, Oscar Salvador wrote: > > > > Yes, this callback will be called whenever {online,offline}_pages succeeds, but > > status_change_nid will be != NUMA_NO_NODE IFF the node state changes. > > And you already have the check > > > > if (nid < 0) > > goto out > > > > at the beginning, which means that all {offline,online}_pages operation that > > do not carry a numa node state change will be filtered out there. > > > > Makes sense, or am I missing something? > > > > Ah, you're quite right. That was difficult to see on the surface, so > the check in fact superfluous. No need for an extra version, can just > add a patch to squash and drop it. > > ~Gregory To Gregory and Oscar As Oscar correctly pointed out, the check for 'if (!node_state(nid, N_MEMORY))' is unnecessary and should be removed. Additionally, there are other suggestions from Dan Williams that should be applied as well: Link: https://lore.kernel.org/lkml/67ed66ef7c070_9dac294e0@dwillia2-xfh.jf.intel.com.notmuch/ I will incorporate all of these improvements and submit a new version (v6). Rakie