From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52F83C3600C for ; Thu, 3 Apr 2025 04:26:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F384A280003; Thu, 3 Apr 2025 00:26:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE705280001; Thu, 3 Apr 2025 00:26:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD7AD280003; Thu, 3 Apr 2025 00:26:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C1EAC280001 for ; Thu, 3 Apr 2025 00:26:00 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 165341A147B for ; Thu, 3 Apr 2025 04:26:02 +0000 (UTC) X-FDA: 83291444964.25.395560D Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf24.hostedemail.com (Postfix) with ESMTP id 84E68180005 for ; Thu, 3 Apr 2025 04:25:59 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of rakie.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=rakie.kim@sk.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743654360; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fzZNjeYfZnquqZPzODz65QmgUgsWCbGwhYvj1DLwtQg=; b=bDS5zYB83uf00RQsltNHf+gFo8UvXUFmD9jSCtnyO3GM+6kZ9TQi7aUFMmCe26aMXrJM9I bCrbglCLgv7pyku4crIEByNRAHJ5ZniMedN0vf7vv7lLsHjRuHY4IUImXHo+V9yN6ScS26 Ltj8Of764tAivE2fJkighBBM3mmvk+A= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of rakie.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=rakie.kim@sk.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743654360; a=rsa-sha256; cv=none; b=XHb8o9V7EihsrTil6oKOfBrTowsGEgU2drWCzf+3maPf8ym6ldpG2y2ZIJepJayg748XYb jZC7EMMco+OvndsyDAFFbR3+YuuR0HtR1KnOMEQMYUueGEMUmV2DHCeCcEw34yvYWhcROY 2m+zMR0oN3h6IovDOz52wsEwhZZ8bPw= X-AuditID: a67dfc5b-669ff7000002311f-c2-67ee0dd482b0 From: Rakie Kim To: Dan Williams Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, joshua.hahnjy@gmail.com, ying.huang@linux.alibaba.com, david@redhat.com, Jonathan.Cameron@huawei.com, kernel_team@skhynix.com, honggyu.kim@sk.com, yunjeong.mun@sk.com, rakie.kim@sk.com, gourry@gourry.net Subject: Re: [PATCH v3 2/3] mm/mempolicy: Support dynamic sysfs updates for weighted interleave Date: Thu, 3 Apr 2025 13:25:42 +0900 Message-ID: <20250403042552.1116-1-rakie.kim@sk.com> X-Mailer: git-send-email 2.48.1.windows.1 In-Reply-To: <67ed66ef7c070_9dac294e0@dwillia2-xfh.jf.intel.com.notmuch> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrILMWRmVeSWpSXmKPExsXC9ZZnoe5V3nfpBvtaGC3mrF/DZjF96gVG i6/rfzFb/Lx7nN1i1cJrbBbHt85jtzg/6xSLxeVdc9gs7q35z2qxek2GA5fHzll32T262y6z e7QcecvqsXjPSyaPTZ8msXucmPGbxWPnQ0uP9/uusnl83iQXwBnFZZOSmpNZllqkb5fAlXGl czVbQT9/Ref/P0wNjGt4uhg5OSQETCT6ftxihbG7761n7mLk4GATUJI4tjcGJCwioC0xcc5B oDAXB7PAeSaJF91z2EESwgLxEm+uXGcEsVkEVCV+z+kDi/MCzdl2ooMZYqamRMOle0wgNqeA h8SlB89YQGwhAR6JVxv2M0LUC0qcnPkELM4sIC/RvHU22DIJgddsEktuL2GCGCQpcXDFDZYJ jPyzkPTMQtKzgJFpFaNQZl5ZbmJmjoleRmVeZoVecn7uJkZgwC+r/RO9g/HTheBDjAIcjEo8 vB3X3qYLsSaWFVfmHmKU4GBWEuEt1AIK8aYkVlalFuXHF5XmpBYfYpTmYFES5zX6Vp4iJJCe WJKanZpakFoEk2Xi4JRqYPSsMu2PkV7SPJNptbBNR+ETpcq07QdDNlU6vX0yvSlP6P7UxbOS +SZ579jJLvhz4Z15XccWvXutInH35E790p3aX3ym+PLUsUwon6BUGT3NS223pMF7VhnNVU92 JVQ8/ZTzbXnt6xM+i5xnnH6S11X3zPay5+u2io5Ct06p+px5l6/wR+p/01ZiKc5INNRiLipO BAB4KEFKdAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrNLMWRmVeSWpSXmKPExsXCNUNNS/cK77t0gwcTzSzmrF/DZjF96gVG i6/rfzFb/Lx7nN3i87PXzBarFl5jszi+dR67xeG5J1ktzs86xWJxedccNot7a/6zWhy69pzV YvWaDIvf21awOfB57Jx1l92ju+0yu0fLkbesHov3vGTy2PRpErvHiRm/WTx2PrT0eL/vKpvH t9seHotffGDy+LxJLoA7issmJTUnsyy1SN8ugSvjSudqtoJ+/orO/3+YGhjX8HQxcnJICJhI dN9bz9zFyMHBJqAkcWxvDEhYREBbYuKcg0BhLg5mgfNMEi+657CDJIQF4iXeXLnOCGKzCKhK /J7TBxbnBZqz7UQHM8RMTYmGS/eYQGxOAQ+JSw+esYDYQgI8Eq827GeEqBeUODnzCVicWUBe onnrbOYJjDyzkKRmIUktYGRaxSiSmVeWm5iZY6pXnJ1RmZdZoZecn7uJERjky2r/TNzB+OWy +yFGAQ5GJR7eCyZv04VYE8uKK3MPMUpwMCuJ8BZqAYV4UxIrq1KL8uOLSnNSiw8xSnOwKInz eoWnJggJpCeWpGanphakFsFkmTg4pRoYtf7P3yHsbG+2eaL5uyfFBvdeHZ4RFMst1Xn2w9LO HpO9Avs5Vx48sqEg9LX2KrmTE3f5bfkv+O1FmGVQBpNt4SaHbTv+fak3O74u+vtn+Q9iKb8/ vn9e8myF1++TB40llm5tSV579wB7Xr9ui+rPbV5m92ZKmcrISlx9mdm0VneRTO7bo8cdfiux FGckGmoxFxUnAgCVq797bgIAAA== X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 84E68180005 X-Stat-Signature: ius9gwd8wdrf3fs5bgku9jjnahzszha1 X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1743654359-625441 X-HE-Meta: U2FsdGVkX184PSL0KSrrgszHu4FeJEBnRPB5DyX1lxx0hIo6qLJ5OGcBsnw0g7texjohcMOlaLEaRh2RTGDNI4PY2bBodmhfqMeSwje9Rg5D6hCZ/J1ZMU1aATOgmwhb7LcS+7s/GZ7VsRDatF5/y/DGiAWiouxdSkzKfm54cjWeEOoD9mmbf5FSseV8V/HG82GXmHuJglcJfLxhV4K0fVKK+E7qXEnbnugdMSZgoSGLEQ3szHAEfur7r7FZd6Gin/MwNYf9s+NPSw4T+Ln2wmd5ayRf6pOTdWtYlQKem0W18gm9rwy8PwzDy28XydgUeJXmcYQFyx+O1pMwmvR1sj5ibee6U+BcezJ8DcCiBRZ6strT3Wtzc3Md4eXzGEKl/ekr1a90zH/Euoss4z2anNGQuJSdXG0BlT21WWGfSsisn8wqdPyjoIlUrVIgDrs6l90NtgWHGnkJI/4JT77iGlArCqfqjYJ5kHkDHS/bRyU33Oc7/KYtJVfgpZmmVcjCovsuDavqz6DlZp06KXpzLO1ij+0fOMnMN/iNSn6+bo8UGw3BXNWaj8tK9ffwx6OlLleHDqXlmb1zhiQfGueCoh2Bc6TebtWbxAX0xm3HX9FFuLCAni107nHBBDy6IcyDUS93SvSSkcoG1T6aoNWsdbH3pY5f7LFzE0GvVOF6fbrjBMT/KbBIr+puHeJvbnCtOiRq9A01hp7GoX9T40BVrdiwNhU/uhzKAzdeZ+b+h0MJXsIgMrbAw8TKzEFa/4pGneDuUAZcXuscCz4MGWTxEJ4ZqvKhR5bhbYoQvV9YMlJA3xBlVyIqNuMnM8jaScLyFM8/432Xx37Hvo5tdJE1gofJUvxo26J9hy+QzrDLZ1Pj8eWLsAKLNKXRG/kLb1Mv312AauZ08SdJghXnfJUV709S8oY7259fhD2V8t/wQYEmVWFtDEHLQCtdwyI2y6kVdztCIDRUYHW2Djr252p CiZN1ZPE UsMTPkfHZQi8nsHeGUd6F+mqEwag+c1ykBnuvNn8AWTBsntYDP8I1llwLgycu+Pp5ZccVqgsDBDXvWi0ubBZIll5juTbExmZNNxIpojNEOVoUEKm8dEfOWdq+Y/rb4+3tl8dBHnQrCRMXtaKIRYr0G+4AeA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 2 Apr 2025 09:33:51 -0700 Dan Williams wrote: > Rakie Kim wrote: > > Previously, the weighted interleave sysfs structure was statically > > managed, preventing dynamic updates when nodes were added or removed. > > > > This patch restructures the weighted interleave sysfs to support > > dynamic insertion and deletion. The sysfs that was part of > > the 'weighted_interleave_group' is now globally accessible, > > allowing external access to that sysfs. > > > > With this change, sysfs management for weighted interleave is > > more flexible, supporting hotplug events and runtime updates > > more effectively. > > I understand the urge to try to make a general case for a patch, but it > is better to state the explicit reason especially when someone is later > reading the history and may not realize that this is part of a series. > > So instead of making claims like "this is more flexible / more effective > for runtime updates", state that motivation explicitly. Something like: > > "In preparation for enabling weighted-interleave sysfs attributes to > react to node-online/offline events, introduce sysfs_wi_node_add() and > sysfs_wi_node_delete() helpers to dynamically manage the > weighted-interleave attributes. > > A follow-on patch registers a memory-hotplug notifier to use these > helpers, for now just refactor the current "publish all possible node" > approach to use sysfs_wi_node_{add,delete}()." > Hi Dan Williams, Thank you for your response regarding this patch. First, I would like to mention that this version is v3, and the latest version is v5: https://lore.kernel.org/lkml/20250402014906.1086-1-rakie.kim@sk.com/ However, I believe that all of your suggestions should also apply to v5, and I completely agree with your feedback. I will incorporate the improvements you proposed and prepare v6 accordingly. Rakie